<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205690] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205690">205690</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-09-08 20:31:58 -0700 (Thu, 08 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>HTMLObjectElement.codebase attribute should reflect as a URL
https://bugs.webkit.org/show_bug.cgi?id=161768
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline existing test now that more checks are passing.
* web-platform-tests/html/dom/reflection-embedded-expected.txt:
Source/WebCore:
HTMLObjectElement.codebase attribute should reflect as a URL:
- https://html.spec.whatwg.org/#dom-applet-codebase
Chrome and Firefox agree with the specification.
No new test, rebaselined existing test.
* html/HTMLObjectElement.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomelementattributejsnullexpectedtxt">trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomelementattributejsnullhtml">trunk/LayoutTests/fast/dom/element-attribute-js-null.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectionembeddedexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorimportedw3cwebplatformtestshtmldomreflectionembeddedexpectedtxt">trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLObjectElementcpp">trunk/Source/WebCore/html/HTMLObjectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLObjectElementidl">trunk/Source/WebCore/html/HTMLObjectElement.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsfastdomelementattributejsnullexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt (205689 => 205690)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt 2016-09-09 03:31:58 UTC (rev 205690)
</span><span class="lines">@@ -148,7 +148,6 @@
</span><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.align]
</span><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.archive]
</span><span class="cx"> TEST SUCCEEDED: The value was the empty string. [tested HTMLObjectElement.border]
</span><del>-TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.codeBase]
</del><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.codeType]
</span><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.height]
</span><span class="cx"> TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.name]
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomelementattributejsnullhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null.html (205689 => 205690)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/element-attribute-js-null.html 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null.html 2016-09-09 03:31:58 UTC (rev 205690)
</span><span class="lines">@@ -384,7 +384,6 @@
</span><span class="cx"> {name: 'align', expectedNull: 'null'},
</span><span class="cx"> {name: 'archive', expectedNull: 'null'},
</span><span class="cx"> {name: 'border', expectedNull: ''},
</span><del>- {name: 'codeBase', expectedNull: 'null'},
</del><span class="cx"> {name: 'codeType', expectedNull: 'null'},
</span><span class="cx"> {name: 'height', expectedNull: 'null'},
</span><span class="cx"> {name: 'name', expectedNull: 'null'},
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (205689 => 205690)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-09 03:31:58 UTC (rev 205690)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-09-08 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ HTMLObjectElement.codebase attribute should reflect as a URL
+ https://bugs.webkit.org/show_bug.cgi?id=161768
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline existing test now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-embedded-expected.txt:
+
+2016-09-08 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> ol.start may return incorrect value for reversed lists when not explicitly set
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=161713
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectionembeddedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (205689 => 205690)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-09 03:31:58 UTC (rev 205690)
</span><span class="lines">@@ -6337,95 +6337,95 @@
</span><span class="cx"> PASS object.codeBase: typeof IDL attribute
</span><span class="cx"> PASS object.codeBase: IDL get with DOM attribute unset
</span><span class="cx"> PASS object.codeBase: setAttribute() to "" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to "" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got ""
</del><ins>+PASS object.codeBase: setAttribute() to "" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to " foo " followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to " foo " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/foo" but got " foo "
</del><ins>+PASS object.codeBase: setAttribute() to " foo " followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to "http://site.example/" followed by getAttribute()
</span><span class="cx"> PASS object.codeBase: setAttribute() to "http://site.example/" followed by IDL get
</span><span class="cx"> PASS object.codeBase: setAttribute() to "//site.example/path???@#l" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to "//site.example/path???@#l" followed by IDL get assert_equals: expected "http://site.example/path???@#l" but got "//site.example/path???@#l"
</del><ins>+PASS object.codeBase: setAttribute() to "//site.example/path???@#l" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f "
</del><ins>+PASS object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to undefined followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to undefined followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/undefined" but got "undefined"
</del><ins>+PASS object.codeBase: setAttribute() to undefined followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to 7 followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to 7 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/7" but got "7"
</del><ins>+PASS object.codeBase: setAttribute() to 7 followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to 1.5 followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to 1.5 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/1.5" but got "1.5"
</del><ins>+PASS object.codeBase: setAttribute() to 1.5 followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to true followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to true followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/true" but got "true"
</del><ins>+PASS object.codeBase: setAttribute() to true followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to false followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to false followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/false" but got "false"
</del><ins>+PASS object.codeBase: setAttribute() to false followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to object "[object Object]" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to object "[object Object]" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/[object%20Object]" but got "[object Object]"
</del><ins>+PASS object.codeBase: setAttribute() to object "[object Object]" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to NaN followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to NaN followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/NaN" but got "NaN"
</del><ins>+PASS object.codeBase: setAttribute() to NaN followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to Infinity followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/Infinity" but got "Infinity"
</del><ins>+PASS object.codeBase: setAttribute() to Infinity followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to -Infinity followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to -Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/-Infinity" but got "-Infinity"
</del><ins>+PASS object.codeBase: setAttribute() to -Infinity followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to "\0" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to "\0" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0"
</del><ins>+PASS object.codeBase: setAttribute() to "\0" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to null followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to null followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/null" but got "null"
</del><ins>+PASS object.codeBase: setAttribute() to null followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to object "test-toString" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to object "test-toString" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-toString" but got "test-toString"
</del><ins>+PASS object.codeBase: setAttribute() to object "test-toString" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to object "test-valueOf" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to object "test-valueOf" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-valueOf" but got "test-valueOf"
</del><ins>+PASS object.codeBase: setAttribute() to object "test-valueOf" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to "" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to "" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got ""
</del><ins>+PASS object.codeBase: IDL set to "" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to " foo " should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to " foo " followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to " foo " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/foo" but got " foo "
</del><ins>+PASS object.codeBase: IDL set to " foo " followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to "http://site.example/" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "http://site.example/" followed by getAttribute()
</span><span class="cx"> PASS object.codeBase: IDL set to "http://site.example/" followed by IDL get
</span><span class="cx"> PASS object.codeBase: IDL set to "//site.example/path???@#l" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "//site.example/path???@#l" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to "//site.example/path???@#l" followed by IDL get assert_equals: expected "http://site.example/path???@#l" but got "//site.example/path???@#l"
</del><ins>+PASS object.codeBase: IDL set to "//site.example/path???@#l" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f "
</del><ins>+PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to undefined should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to undefined followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to undefined followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/undefined" but got "undefined"
</del><ins>+PASS object.codeBase: IDL set to undefined followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to 7 should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to 7 followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to 7 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/7" but got "7"
</del><ins>+PASS object.codeBase: IDL set to 7 followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to 1.5 should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to 1.5 followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to 1.5 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/1.5" but got "1.5"
</del><ins>+PASS object.codeBase: IDL set to 1.5 followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to true should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to true followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to true followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/true" but got "true"
</del><ins>+PASS object.codeBase: IDL set to true followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to false should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to false followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to false followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/false" but got "false"
</del><ins>+PASS object.codeBase: IDL set to false followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to object "[object Object]" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to object "[object Object]" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to object "[object Object]" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/[object%20Object]" but got "[object Object]"
</del><ins>+PASS object.codeBase: IDL set to object "[object Object]" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to NaN should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to NaN followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to NaN followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/NaN" but got "NaN"
</del><ins>+PASS object.codeBase: IDL set to NaN followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to Infinity should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to Infinity followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/Infinity" but got "Infinity"
</del><ins>+PASS object.codeBase: IDL set to Infinity followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to -Infinity should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to -Infinity followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to -Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/-Infinity" but got "-Infinity"
</del><ins>+PASS object.codeBase: IDL set to -Infinity followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to "\0" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "\0" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to "\0" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0"
</del><ins>+PASS object.codeBase: IDL set to "\0" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to null should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to null followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to null followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/null" but got "null"
</del><ins>+PASS object.codeBase: IDL set to null followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to object "test-toString" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to object "test-toString" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to object "test-toString" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-toString" but got "test-toString"
</del><ins>+PASS object.codeBase: IDL set to object "test-toString" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to object "test-valueOf" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to object "test-valueOf" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to object "test-valueOf" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-valueOf" but got "test-valueOf"
</del><ins>+PASS object.codeBase: IDL set to object "test-valueOf" followed by IDL get
</ins><span class="cx"> PASS object.codeType: typeof IDL attribute
</span><span class="cx"> PASS object.codeType: IDL get with DOM attribute unset
</span><span class="cx"> PASS object.codeType: setAttribute() to "" followed by getAttribute()
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorimportedw3cwebplatformtestshtmldomreflectionembeddedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (205689 => 205690)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-09 03:31:58 UTC (rev 205690)
</span><span class="lines">@@ -6337,95 +6337,95 @@
</span><span class="cx"> PASS object.codeBase: typeof IDL attribute
</span><span class="cx"> PASS object.codeBase: IDL get with DOM attribute unset
</span><span class="cx"> PASS object.codeBase: setAttribute() to "" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to "" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got ""
</del><ins>+PASS object.codeBase: setAttribute() to "" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to " foo " followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to " foo " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/foo" but got " foo "
</del><ins>+PASS object.codeBase: setAttribute() to " foo " followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to "http://site.example/" followed by getAttribute()
</span><span class="cx"> PASS object.codeBase: setAttribute() to "http://site.example/" followed by IDL get
</span><span class="cx"> PASS object.codeBase: setAttribute() to "//site.example/path???@#l" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to "//site.example/path???@#l" followed by IDL get assert_equals: expected "http://site.example/path???@#l" but got "//site.example/path???@#l"
</del><ins>+PASS object.codeBase: setAttribute() to "//site.example/path???@#l" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f "
</del><ins>+PASS object.codeBase: setAttribute() to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to undefined followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to undefined followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/undefined" but got "undefined"
</del><ins>+PASS object.codeBase: setAttribute() to undefined followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to 7 followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to 7 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/7" but got "7"
</del><ins>+PASS object.codeBase: setAttribute() to 7 followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to 1.5 followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to 1.5 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/1.5" but got "1.5"
</del><ins>+PASS object.codeBase: setAttribute() to 1.5 followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to true followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to true followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/true" but got "true"
</del><ins>+PASS object.codeBase: setAttribute() to true followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to false followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to false followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/false" but got "false"
</del><ins>+PASS object.codeBase: setAttribute() to false followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to object "[object Object]" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to object "[object Object]" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/[object%20Object]" but got "[object Object]"
</del><ins>+PASS object.codeBase: setAttribute() to object "[object Object]" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to NaN followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to NaN followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/NaN" but got "NaN"
</del><ins>+PASS object.codeBase: setAttribute() to NaN followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to Infinity followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/Infinity" but got "Infinity"
</del><ins>+PASS object.codeBase: setAttribute() to Infinity followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to -Infinity followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to -Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/-Infinity" but got "-Infinity"
</del><ins>+PASS object.codeBase: setAttribute() to -Infinity followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to "\0" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to "\0" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0"
</del><ins>+PASS object.codeBase: setAttribute() to "\0" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to null followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to null followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/null" but got "null"
</del><ins>+PASS object.codeBase: setAttribute() to null followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to object "test-toString" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to object "test-toString" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-toString" but got "test-toString"
</del><ins>+PASS object.codeBase: setAttribute() to object "test-toString" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: setAttribute() to object "test-valueOf" followed by getAttribute()
</span><del>-FAIL object.codeBase: setAttribute() to object "test-valueOf" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-valueOf" but got "test-valueOf"
</del><ins>+PASS object.codeBase: setAttribute() to object "test-valueOf" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to "" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to "" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got ""
</del><ins>+PASS object.codeBase: IDL set to "" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to " foo " should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to " foo " followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to " foo " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/foo" but got " foo "
</del><ins>+PASS object.codeBase: IDL set to " foo " followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to "http://site.example/" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "http://site.example/" followed by getAttribute()
</span><span class="cx"> PASS object.codeBase: IDL set to "http://site.example/" followed by IDL get
</span><span class="cx"> PASS object.codeBase: IDL set to "//site.example/path???@#l" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "//site.example/path???@#l" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to "//site.example/path???@#l" followed by IDL get assert_equals: expected "http://site.example/path???@#l" but got "//site.example/path???@#l"
</del><ins>+PASS object.codeBase: IDL set to "//site.example/path???@#l" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f "
</del><ins>+PASS object.codeBase: IDL set to "\0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f " followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to undefined should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to undefined followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to undefined followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/undefined" but got "undefined"
</del><ins>+PASS object.codeBase: IDL set to undefined followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to 7 should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to 7 followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to 7 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/7" but got "7"
</del><ins>+PASS object.codeBase: IDL set to 7 followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to 1.5 should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to 1.5 followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to 1.5 followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/1.5" but got "1.5"
</del><ins>+PASS object.codeBase: IDL set to 1.5 followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to true should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to true followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to true followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/true" but got "true"
</del><ins>+PASS object.codeBase: IDL set to true followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to false should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to false followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to false followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/false" but got "false"
</del><ins>+PASS object.codeBase: IDL set to false followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to object "[object Object]" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to object "[object Object]" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to object "[object Object]" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/[object%20Object]" but got "[object Object]"
</del><ins>+PASS object.codeBase: IDL set to object "[object Object]" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to NaN should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to NaN followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to NaN followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/NaN" but got "NaN"
</del><ins>+PASS object.codeBase: IDL set to NaN followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to Infinity should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to Infinity followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/Infinity" but got "Infinity"
</del><ins>+PASS object.codeBase: IDL set to Infinity followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to -Infinity should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to -Infinity followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to -Infinity followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/-Infinity" but got "-Infinity"
</del><ins>+PASS object.codeBase: IDL set to -Infinity followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to "\0" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to "\0" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to "\0" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/reflection-embedded.html" but got "\0"
</del><ins>+PASS object.codeBase: IDL set to "\0" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to null should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to null followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to null followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/null" but got "null"
</del><ins>+PASS object.codeBase: IDL set to null followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to object "test-toString" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to object "test-toString" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to object "test-toString" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-toString" but got "test-toString"
</del><ins>+PASS object.codeBase: IDL set to object "test-toString" followed by IDL get
</ins><span class="cx"> PASS object.codeBase: IDL set to object "test-valueOf" should not throw
</span><span class="cx"> PASS object.codeBase: IDL set to object "test-valueOf" followed by getAttribute()
</span><del>-FAIL object.codeBase: IDL set to object "test-valueOf" followed by IDL get assert_equals: expected "http://localhost:8800/html/dom/test-valueOf" but got "test-valueOf"
</del><ins>+PASS object.codeBase: IDL set to object "test-valueOf" followed by IDL get
</ins><span class="cx"> PASS object.codeType: typeof IDL attribute
</span><span class="cx"> PASS object.codeType: IDL get with DOM attribute unset
</span><span class="cx"> PASS object.codeType: setAttribute() to "" followed by getAttribute()
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (205689 => 205690)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/Source/WebCore/ChangeLog 2016-09-09 03:31:58 UTC (rev 205690)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2016-09-08 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ HTMLObjectElement.codebase attribute should reflect as a URL
+ https://bugs.webkit.org/show_bug.cgi?id=161768
+
+ Reviewed by Alex Christensen.
+
+ HTMLObjectElement.codebase attribute should reflect as a URL:
+ - https://html.spec.whatwg.org/#dom-applet-codebase
+
+ Chrome and Firefox agree with the specification.
+
+ No new test, rebaselined existing test.
+
+ * html/HTMLObjectElement.idl:
+
+2016-09-08 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> ol.start may return incorrect value for reversed lists when not explicitly set
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=161713
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLObjectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLObjectElement.cpp (205689 => 205690)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLObjectElement.cpp 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/Source/WebCore/html/HTMLObjectElement.cpp 2016-09-09 03:31:58 UTC (rev 205690)
</span><span class="lines">@@ -362,7 +362,7 @@
</span><span class="cx">
</span><span class="cx"> bool HTMLObjectElement::isURLAttribute(const Attribute& attribute) const
</span><span class="cx"> {
</span><del>- return attribute.name() == dataAttr || (attribute.name() == usemapAttr && attribute.value().string()[0] != '#') || HTMLPlugInImageElement::isURLAttribute(attribute);
</del><ins>+ return attribute.name() == dataAttr || attribute.name() == codebaseAttr || (attribute.name() == usemapAttr && attribute.value().string()[0] != '#') || HTMLPlugInImageElement::isURLAttribute(attribute);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const AtomicString& HTMLObjectElement::imageSourceURL() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLObjectElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLObjectElement.idl (205689 => 205690)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLObjectElement.idl 2016-09-09 03:31:21 UTC (rev 205689)
+++ trunk/Source/WebCore/html/HTMLObjectElement.idl 2016-09-09 03:31:58 UTC (rev 205690)
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx"> [Reflect] attribute DOMString align;
</span><span class="cx"> [Reflect] attribute DOMString archive;
</span><span class="cx"> [Reflect, TreatNullAs=EmptyString] attribute DOMString border;
</span><del>- [Reflect] attribute DOMString codeBase;
</del><ins>+ [Reflect, URL] attribute USVString codeBase;
</ins><span class="cx"> [Reflect] attribute DOMString codeType;
</span><span class="cx"> [Reflect, URL] attribute USVString data;
</span><span class="cx"> [Reflect] attribute boolean declare;
</span></span></pre>
</div>
</div>
</body>
</html>