<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205627] releases/WebKitGTK/webkit-2.14</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205627">205627</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-09-08 05:02:30 -0700 (Thu, 08 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/205321">r205321</a> - GetByIdWithThis/GetByValWithThis should have ValueProfiles so that they can predict their result types
https://bugs.webkit.org/show_bug.cgi?id=160922
Patch by JF Bastien <jfbastien@apple.com> on 2016-09-01
Reviewed by Keith Miller.
JSTests:
Benchmark GetBy{Id,Val}WithThis in monomorphic and polymorphic uses.
The value profile is used by the calc functions, which do some mild math with the result.
These benchmarks get ~4% faster with value profiling.
* microbenchmarks/super-get-by-id-with-this-monomorphic.js: Added.
(A):
(A.prototype.set value):
(A.prototype.get value):
(B.prototype.set value):
(B.prototype.get value):
(B):
(const.bench):
* microbenchmarks/super-get-by-id-with-this-polymorphic.js: Added.
(A):
(A.prototype.set value):
(A.prototype.get value):
(B.prototype.set value):
(B.prototype.get value):
(B):
(const.bench):
* microbenchmarks/super-get-by-val-with-this-monomorphic.js: Added.
(value):
(A):
(A.prototype.set v):
(A.prototype.get v):
(B.prototype.set v):
(B.prototype.get v):
(B):
(const.bench):
* microbenchmarks/super-get-by-val-with-this-polymorphic.js: Added.
(value):
(A):
(A.prototype.set v):
(A.prototype.get v):
(B.prototype.set v):
(B.prototype.get v):
(B):
(const.bench):
Source/JavaScriptCore:
Add value profiling to GetBy{Id,Val}WithThis.
* bytecode/BytecodeList.json:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitGetByVal):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGPredictionPropagationPhase.cpp:
* llint/LowLevelInterpreter.asm:
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit214JSTestsChangeLog">releases/WebKitGTK/webkit-2.14/JSTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceJavaScriptCoreChangeLog">releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceJavaScriptCorebytecodeBytecodeListjson">releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecode/BytecodeList.json</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceJavaScriptCorebytecodeCodeBlockcpp">releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecode/CodeBlock.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceJavaScriptCorebytecompilerBytecodeGeneratorcpp">releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceJavaScriptCoredfgDFGByteCodeParsercpp">releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceJavaScriptCoredfgDFGNodeh">releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGNode.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceJavaScriptCoredfgDFGPredictionPropagationPhasecpp">releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceJavaScriptCorellintLowLevelInterpreterasm">releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/llint/LowLevelInterpreter.asm</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceJavaScriptCoreruntimeCommonSlowPathscpp">releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit214JSTestsmicrobenchmarkssupergetbyidwiththismonomorphicjs">releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-id-with-this-monomorphic.js</a></li>
<li><a href="#releasesWebKitGTKwebkit214JSTestsmicrobenchmarkssupergetbyidwiththispolymorphicjs">releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-id-with-this-polymorphic.js</a></li>
<li><a href="#releasesWebKitGTKwebkit214JSTestsmicrobenchmarkssupergetbyvalwiththismonomorphicjs">releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-val-with-this-monomorphic.js</a></li>
<li><a href="#releasesWebKitGTKwebkit214JSTestsmicrobenchmarkssupergetbyvalwiththispolymorphicjs">releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-val-with-this-polymorphic.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit214JSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/JSTests/ChangeLog (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/JSTests/ChangeLog 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/JSTests/ChangeLog 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -1,3 +1,49 @@
</span><ins>+2016-09-01 JF Bastien <jfbastien@apple.com>
+
+ GetByIdWithThis/GetByValWithThis should have ValueProfiles so that they can predict their result types
+ https://bugs.webkit.org/show_bug.cgi?id=160922
+
+ Reviewed by Keith Miller.
+
+ Benchmark GetBy{Id,Val}WithThis in monomorphic and polymorphic uses.
+ The value profile is used by the calc functions, which do some mild math with the result.
+ These benchmarks get ~4% faster with value profiling.
+
+ * microbenchmarks/super-get-by-id-with-this-monomorphic.js: Added.
+ (A):
+ (A.prototype.set value):
+ (A.prototype.get value):
+ (B.prototype.set value):
+ (B.prototype.get value):
+ (B):
+ (const.bench):
+ * microbenchmarks/super-get-by-id-with-this-polymorphic.js: Added.
+ (A):
+ (A.prototype.set value):
+ (A.prototype.get value):
+ (B.prototype.set value):
+ (B.prototype.get value):
+ (B):
+ (const.bench):
+ * microbenchmarks/super-get-by-val-with-this-monomorphic.js: Added.
+ (value):
+ (A):
+ (A.prototype.set v):
+ (A.prototype.get v):
+ (B.prototype.set v):
+ (B.prototype.get v):
+ (B):
+ (const.bench):
+ * microbenchmarks/super-get-by-val-with-this-polymorphic.js: Added.
+ (value):
+ (A):
+ (A.prototype.set v):
+ (A.prototype.get v):
+ (B.prototype.set v):
+ (B.prototype.get v):
+ (B):
+ (const.bench):
+
</ins><span class="cx"> 2016-09-01 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> ObjectAllocationSinkingPhase::insertOSRHintsForUpdate() fails to emit updated hints in some cases
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214JSTestsmicrobenchmarkssupergetbyidwiththismonomorphicjs"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-id-with-this-monomorphic.js (0 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-id-with-this-monomorphic.js (rev 0)
+++ releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-id-with-this-monomorphic.js 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+const run = new Function("init", "num", `
+const calc = val => {
+ let c = 0;
+ for (let v = val; v; v >>>= 1) c += v & 1;
+ return val * 2 + val / 2 + c;
+}
+
+class A {
+ constructor(x) { this._value = x; }
+ set value(x) { this._value = x; }
+ get value() { return this._value; }
+}
+class B extends A {
+ set value(x) { super.value = x; }
+ get value() { return calc(super.value); }
+}
+
+const bench = (init, num) => {
+ let arr = [];
+ for (let i = 0; i != num; ++i) arr.push(new B(init));
+ for (let i = 0; i != num; ++i) arr[i].value += i;
+ let sum = 0;
+ for (let i = 0; i != num; ++i) sum += arr[i].value;
+};
+
+bench(init, num);
+`);
+
+run(2, 10000);
+run(1 << 30, 10000);
+run(42.2, 10000);
+run(42.5e10, 10000);
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit214JSTestsmicrobenchmarkssupergetbyidwiththispolymorphicjs"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-id-with-this-polymorphic.js (0 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-id-with-this-polymorphic.js (rev 0)
+++ releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-id-with-this-polymorphic.js 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+const calc = val => {
+ let c = 0;
+ for (let v = val; v; v >>>= 1) c += v & 1;
+ return val * 2 + val / 2 + c;
+}
+
+class A {
+ constructor(x) { this._value = x; }
+ set value(x) { this._value = x; }
+ get value() { return this._value; }
+}
+class B extends A {
+ set value(x) { super.value = x; }
+ get value() { return calc(super.value); }
+}
+
+const bench = (init, num) => {
+ let arr = [];
+ for (let i = 0; i != num; ++i) arr.push(new B(init));
+ for (let i = 0; i != num; ++i) arr[i].value += i;
+ let sum = 0;
+ for (let i = 0; i != num; ++i) sum += arr[i].value;
+};
+
+bench(2, 10000);
+bench(1 << 30, 10000);
+bench(42.2, 10000);
+bench(42.5e10, 10000);
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit214JSTestsmicrobenchmarkssupergetbyvalwiththismonomorphicjs"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-val-with-this-monomorphic.js (0 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-val-with-this-monomorphic.js (rev 0)
+++ releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-val-with-this-monomorphic.js 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -0,0 +1,36 @@
</span><ins>+const run = new Function("init", "num", `
+
+function value() { return 'v'; }
+noInline(value);
+
+const calc = val => {
+ let c = 0;
+ for (let v = val; v; v >>>= 1) c += v & 1;
+ return val * 2 + val / 2 + c;
+}
+
+class A {
+ constructor(x) { this._v = x; }
+ set v(x) { this._v = x; }
+ get v() { return this._v; }
+}
+class B extends A {
+ set v(x) { super[value()] = x; }
+ get v() { return calc(super[value()]); }
+}
+
+const bench = (init, num) => {
+ let arr = [];
+ for (let i = 0; i != num; ++i) arr.push(new B(init));
+ for (let i = 0; i != num; ++i) arr[i].v += i;
+ let sum = 0;
+ for (let i = 0; i != num; ++i) sum += arr[i].v;
+};
+
+bench(init, num);
+`);
+
+run(2, 10000);
+run(1 << 30, 10000);
+run(42.2, 10000);
+run(42.5e10, 10000);
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit214JSTestsmicrobenchmarkssupergetbyvalwiththispolymorphicjs"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-val-with-this-polymorphic.js (0 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-val-with-this-polymorphic.js (rev 0)
+++ releases/WebKitGTK/webkit-2.14/JSTests/microbenchmarks/super-get-by-val-with-this-polymorphic.js 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+function value() { return 'v'; }
+noInline(value);
+
+const calc = val => {
+ let c = 0;
+ for (let v = val; v; v >>>= 1) c += v & 1;
+ return val * 2 + val / 2 + c;
+}
+
+class A {
+ constructor(x) { this._v = x; }
+ set v(x) { this._v = x; }
+ get v() { return this._v; }
+}
+class B extends A {
+ set v(x) { super[value()] = x; }
+ get v() { return calc(super[value()]); }
+}
+
+const bench = (init, num) => {
+ let arr = [];
+ for (let i = 0; i != num; ++i) arr.push(new B(init));
+ for (let i = 0; i != num; ++i) arr[i].v += i;
+ let sum = 0;
+ for (let i = 0; i != num; ++i) sum += arr[i].v;
+};
+
+bench(2, 10000);
+bench(1 << 30, 10000);
+bench(42.2, 10000);
+bench(42.5e10, 10000);
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/ChangeLog (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/ChangeLog 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/ChangeLog 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2016-09-01 JF Bastien <jfbastien@apple.com>
+
+ GetByIdWithThis/GetByValWithThis should have ValueProfiles so that they can predict their result types
+ https://bugs.webkit.org/show_bug.cgi?id=160922
+
+ Reviewed by Keith Miller.
+
+ Add value profiling to GetBy{Id,Val}WithThis.
+
+ * bytecode/BytecodeList.json:
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::dumpBytecode):
+ (JSC::CodeBlock::finishCreation):
+ * bytecompiler/BytecodeGenerator.cpp:
+ (JSC::BytecodeGenerator::emitGetById):
+ (JSC::BytecodeGenerator::emitGetByVal):
+ * dfg/DFGByteCodeParser.cpp:
+ (JSC::DFG::ByteCodeParser::parseBlock):
+ * dfg/DFGNode.h:
+ (JSC::DFG::Node::hasHeapPrediction):
+ * dfg/DFGPredictionPropagationPhase.cpp:
+ * llint/LowLevelInterpreter.asm:
+ * runtime/CommonSlowPaths.cpp:
+ (JSC::SLOW_PATH_DECL):
+
</ins><span class="cx"> 2016-09-01 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><span class="cx"> Rename WASM classes dropping the WASM prefix
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceJavaScriptCorebytecodeBytecodeListjson"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecode/BytecodeList.json (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecode/BytecodeList.json 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecode/BytecodeList.json 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -65,8 +65,8 @@
</span><span class="cx"> { "name" : "op_get_by_id", "length" : 9 },
</span><span class="cx"> { "name" : "op_get_by_id_proto_load", "length" : 9 },
</span><span class="cx"> { "name" : "op_get_by_id_unset", "length" : 9 },
</span><del>- { "name" : "op_get_by_id_with_this", "length" : 5 },
- { "name" : "op_get_by_val_with_this", "length" : 5 },
</del><ins>+ { "name" : "op_get_by_id_with_this", "length" : 6 },
+ { "name" : "op_get_by_val_with_this", "length" : 6 },
</ins><span class="cx"> { "name" : "op_try_get_by_id", "length" : 5 },
</span><span class="cx"> { "name" : "op_put_by_id", "length" : 9 },
</span><span class="cx"> { "name" : "op_put_by_id_with_this", "length" : 5 },
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceJavaScriptCorebytecodeCodeBlockcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecode/CodeBlock.cpp (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecode/CodeBlock.cpp 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecode/CodeBlock.cpp 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -1149,6 +1149,7 @@
</span><span class="cx"> int r2 = (++it)->u.operand;
</span><span class="cx"> int id0 = (++it)->u.operand;
</span><span class="cx"> out.printf("%s, %s, %s, %s", registerName(r0).data(), registerName(r1).data(), registerName(r2).data(), idName(id0, identifier(id0)).data());
</span><ins>+ dumpValueProfiling(out, it, hasPrintedProfiling);
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> case op_get_by_val_with_this: {
</span><span class="lines">@@ -1158,6 +1159,7 @@
</span><span class="cx"> int r3 = (++it)->u.operand;
</span><span class="cx"> printLocationAndOp(out, exec, location, it, "get_by_val_with_this");
</span><span class="cx"> out.printf("%s, %s, %s, %s", registerName(r0).data(), registerName(r1).data(), registerName(r2).data(), registerName(r3).data());
</span><ins>+ dumpValueProfiling(out, it, hasPrintedProfiling);
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> case op_put_by_id: {
</span><span class="lines">@@ -2076,7 +2078,9 @@
</span><span class="cx"> }
</span><span class="cx"> case op_get_direct_pname:
</span><span class="cx"> case op_get_by_id:
</span><ins>+ case op_get_by_id_with_this:
</ins><span class="cx"> case op_try_get_by_id:
</span><ins>+ case op_get_by_val_with_this:
</ins><span class="cx"> case op_get_from_arguments:
</span><span class="cx"> case op_to_number: {
</span><span class="cx"> linkValueProfile(i, opLength);
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceJavaScriptCorebytecompilerBytecodeGeneratorcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -2492,11 +2492,12 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT_WITH_MESSAGE(!parseIndex(property), "Indexed properties should be handled with get_by_val.");
</span><span class="cx">
</span><del>- emitOpcode(op_get_by_id_with_this);
</del><ins>+ UnlinkedValueProfile profile = emitProfiledOpcode(op_get_by_id_with_this);
</ins><span class="cx"> instructions().append(kill(dst));
</span><span class="cx"> instructions().append(base->index());
</span><span class="cx"> instructions().append(thisVal->index());
</span><span class="cx"> instructions().append(addConstant(property));
</span><ins>+ instructions().append(profile);
</ins><span class="cx"> return dst;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2664,11 +2665,12 @@
</span><span class="cx">
</span><span class="cx"> RegisterID* BytecodeGenerator::emitGetByVal(RegisterID* dst, RegisterID* base, RegisterID* thisValue, RegisterID* property)
</span><span class="cx"> {
</span><del>- emitOpcode(op_get_by_val_with_this);
</del><ins>+ UnlinkedValueProfile profile = emitProfiledOpcode(op_get_by_val_with_this);
</ins><span class="cx"> instructions().append(kill(dst));
</span><span class="cx"> instructions().append(base->index());
</span><span class="cx"> instructions().append(thisValue->index());
</span><span class="cx"> instructions().append(property->index());
</span><ins>+ instructions().append(profile);
</ins><span class="cx"> return dst;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceJavaScriptCoredfgDFGByteCodeParsercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -4129,10 +4129,12 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> case op_get_by_val_with_this: {
</span><ins>+ SpeculatedType prediction = getPrediction();
+
</ins><span class="cx"> Node* base = get(VirtualRegister(currentInstruction[2].u.operand));
</span><span class="cx"> Node* thisValue = get(VirtualRegister(currentInstruction[3].u.operand));
</span><span class="cx"> Node* property = get(VirtualRegister(currentInstruction[4].u.operand));
</span><del>- Node* getByValWithThis = addToGraph(GetByValWithThis, base, thisValue, property);
</del><ins>+ Node* getByValWithThis = addToGraph(GetByValWithThis, OpInfo(prediction), base, thisValue, property);
</ins><span class="cx"> set(VirtualRegister(currentInstruction[1].u.operand), getByValWithThis);
</span><span class="cx">
</span><span class="cx"> NEXT_OPCODE(op_get_by_val_with_this);
</span><span class="lines">@@ -4226,12 +4228,14 @@
</span><span class="cx"> NEXT_OPCODE(op_get_by_id);
</span><span class="cx"> }
</span><span class="cx"> case op_get_by_id_with_this: {
</span><ins>+ SpeculatedType prediction = getPrediction();
+
</ins><span class="cx"> Node* base = get(VirtualRegister(currentInstruction[2].u.operand));
</span><span class="cx"> Node* thisValue = get(VirtualRegister(currentInstruction[3].u.operand));
</span><span class="cx"> unsigned identifierNumber = m_inlineStackTop->m_identifierRemap[currentInstruction[4].u.operand];
</span><span class="cx">
</span><span class="cx"> set(VirtualRegister(currentInstruction[1].u.operand),
</span><del>- addToGraph(GetByIdWithThis, OpInfo(identifierNumber), base, thisValue));
</del><ins>+ addToGraph(GetByIdWithThis, OpInfo(identifierNumber), OpInfo(prediction), base, thisValue));
</ins><span class="cx">
</span><span class="cx"> NEXT_OPCODE(op_get_by_id_with_this);
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceJavaScriptCoredfgDFGNodeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGNode.h (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGNode.h 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGNode.h 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -1395,8 +1395,10 @@
</span><span class="cx"> case GetDirectPname:
</span><span class="cx"> case GetById:
</span><span class="cx"> case GetByIdFlush:
</span><ins>+ case GetByIdWithThis:
</ins><span class="cx"> case TryGetById:
</span><span class="cx"> case GetByVal:
</span><ins>+ case GetByValWithThis:
</ins><span class="cx"> case Call:
</span><span class="cx"> case TailCallInlinedCaller:
</span><span class="cx"> case Construct:
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceJavaScriptCoredfgDFGPredictionPropagationPhasecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -680,11 +680,6 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- case GetByValWithThis:
- case GetByIdWithThis: {
- setPrediction(SpecBytecodeTop);
- break;
- }
</del><span class="cx"> case ArrayPop:
</span><span class="cx"> case ArrayPush:
</span><span class="cx"> case RegExpExec:
</span><span class="lines">@@ -693,7 +688,9 @@
</span><span class="cx"> case StringReplaceRegExp:
</span><span class="cx"> case GetById:
</span><span class="cx"> case GetByIdFlush:
</span><ins>+ case GetByIdWithThis:
</ins><span class="cx"> case TryGetById:
</span><ins>+ case GetByValWithThis:
</ins><span class="cx"> case GetByOffset:
</span><span class="cx"> case MultiGetByOffset:
</span><span class="cx"> case GetDirectPname:
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceJavaScriptCorellintLowLevelInterpreterasm"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/llint/LowLevelInterpreter.asm (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/llint/LowLevelInterpreter.asm 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/llint/LowLevelInterpreter.asm 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -1806,12 +1806,12 @@
</span><span class="cx"> _llint_op_get_by_id_with_this:
</span><span class="cx"> traceExecution()
</span><span class="cx"> callOpcodeSlowPath(_slow_path_get_by_id_with_this)
</span><del>- dispatch(5)
</del><ins>+ dispatch(6)
</ins><span class="cx">
</span><span class="cx"> _llint_op_get_by_val_with_this:
</span><span class="cx"> traceExecution()
</span><span class="cx"> callOpcodeSlowPath(_slow_path_get_by_val_with_this)
</span><del>- dispatch(5)
</del><ins>+ dispatch(6)
</ins><span class="cx">
</span><span class="cx"> _llint_op_put_by_id_with_this:
</span><span class="cx"> traceExecution()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceJavaScriptCoreruntimeCommonSlowPathscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp (205626 => 205627)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp 2016-09-08 11:22:59 UTC (rev 205626)
+++ releases/WebKitGTK/webkit-2.14/Source/JavaScriptCore/runtime/CommonSlowPaths.cpp 2016-09-08 12:02:30 UTC (rev 205627)
</span><span class="lines">@@ -828,7 +828,7 @@
</span><span class="cx"> JSValue thisVal = OP_C(3).jsValue();
</span><span class="cx"> PropertySlot slot(thisVal, PropertySlot::PropertySlot::InternalMethodType::Get);
</span><span class="cx"> JSValue result = baseValue.get(exec, ident, slot);
</span><del>- RETURN(result);
</del><ins>+ RETURN_PROFILED(op_get_by_id_with_this, result);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> SLOW_PATH_DECL(slow_path_get_by_val_with_this)
</span><span class="lines">@@ -845,7 +845,7 @@
</span><span class="cx"> if (JSCell::canUseFastGetOwnProperty(structure)) {
</span><span class="cx"> if (RefPtr<AtomicStringImpl> existingAtomicString = asString(subscript)->toExistingAtomicString(exec)) {
</span><span class="cx"> if (JSValue result = baseValue.asCell()->fastGetOwnProperty(vm, structure, existingAtomicString.get()))
</span><del>- RETURN(result);
</del><ins>+ RETURN_PROFILED(op_get_by_val_with_this, result);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -854,9 +854,9 @@
</span><span class="cx"> if (subscript.isUInt32()) {
</span><span class="cx"> uint32_t i = subscript.asUInt32();
</span><span class="cx"> if (isJSString(baseValue) && asString(baseValue)->canGetIndex(i))
</span><del>- RETURN(asString(baseValue)->getIndex(exec, i));
</del><ins>+ RETURN_PROFILED(op_get_by_val_with_this, asString(baseValue)->getIndex(exec, i));
</ins><span class="cx">
</span><del>- RETURN(baseValue.get(exec, i, slot));
</del><ins>+ RETURN_PROFILED(op_get_by_val_with_this, baseValue.get(exec, i, slot));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> baseValue.requireObjectCoercible(exec);
</span><span class="lines">@@ -863,7 +863,7 @@
</span><span class="cx"> CHECK_EXCEPTION();
</span><span class="cx"> auto property = subscript.toPropertyKey(exec);
</span><span class="cx"> CHECK_EXCEPTION();
</span><del>- RETURN(baseValue.get(exec, property, slot));
</del><ins>+ RETURN_PROFILED(op_get_by_val_with_this, baseValue.get(exec, property, slot));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> SLOW_PATH_DECL(slow_path_put_by_id_with_this)
</span></span></pre>
</div>
</div>
</body>
</html>