<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205598] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205598">205598</a></dd>
<dt>Author</dt> <dd>pvollan@apple.com</dd>
<dt>Date</dt> <dd>2016-09-08 00:45:27 -0700 (Thu, 08 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Win] Exception fuzz tests fail
https://bugs.webkit.org/show_bug.cgi?id=140928
Reviewed by Mark Lam.
JSTests:
Unskip tests.
* exceptionFuzz.yaml:
Source/JavaScriptCore:
Flush stdout when throwing the exception to make sure the output comes before output in the exception handler.
The tests depend on the output to stdout being written in the correct order.
* runtime/ExceptionFuzz.cpp:
(JSC::doExceptionFuzzing):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkJSTestsexceptionFuzzyaml">trunk/JSTests/exceptionFuzz.yaml</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeExceptionFuzzcpp">trunk/Source/JavaScriptCore/runtime/ExceptionFuzz.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (205597 => 205598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog 2016-09-08 07:44:57 UTC (rev 205597)
+++ trunk/JSTests/ChangeLog 2016-09-08 07:45:27 UTC (rev 205598)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-09-08 Per Arne Vollan <pvollan@apple.com>
+
+ [Win] Exception fuzz tests fail
+ https://bugs.webkit.org/show_bug.cgi?id=140928
+
+ Reviewed by Mark Lam.
+
+ Unskip tests.
+
+ * exceptionFuzz.yaml:
+
</ins><span class="cx"> 2016-09-06 Saam Barati <sbarati@apple.com>
</span><span class="cx">
</span><span class="cx"> ProxyObject's structure should not have ObjectPrototype as its prototype and it should not have special behavior for intercepting "__proto__"
</span></span></pre></div>
<a id="trunkJSTestsexceptionFuzzyaml"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/exceptionFuzz.yaml (205597 => 205598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/exceptionFuzz.yaml 2016-09-08 07:44:57 UTC (rev 205597)
+++ trunk/JSTests/exceptionFuzz.yaml 2016-09-08 07:45:27 UTC (rev 205598)
</span><span class="lines">@@ -22,9 +22,4 @@
</span><span class="cx"> # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">
</span><span class="cx"> - path: exceptionFuzz
</span><del>- cmd: |
- if ($hostOS == "windows")
- skip
- else
- runExceptionFuzz
- end
</del><ins>+ cmd: runExceptionFuzz
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (205597 => 205598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-09-08 07:44:57 UTC (rev 205597)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-09-08 07:45:27 UTC (rev 205598)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-09-08 Per Arne Vollan <pvollan@apple.com>
+
+ [Win] Exception fuzz tests fail
+ https://bugs.webkit.org/show_bug.cgi?id=140928
+
+ Reviewed by Mark Lam.
+
+ Flush stdout when throwing the exception to make sure the output comes before output in the exception handler.
+ The tests depend on the output to stdout being written in the correct order.
+
+ * runtime/ExceptionFuzz.cpp:
+ (JSC::doExceptionFuzzing):
+
</ins><span class="cx"> 2016-09-07 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Enable the <meter> element on iOS
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeExceptionFuzzcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ExceptionFuzz.cpp (205597 => 205598)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ExceptionFuzz.cpp 2016-09-08 07:44:57 UTC (rev 205597)
+++ trunk/Source/JavaScriptCore/runtime/ExceptionFuzz.cpp 2016-09-08 07:45:27 UTC (rev 205598)
</span><span class="lines">@@ -49,6 +49,7 @@
</span><span class="cx"> unsigned fireTarget = Options::fireExceptionFuzzAt();
</span><span class="cx"> if (fireTarget == s_numberOfExceptionFuzzChecks) {
</span><span class="cx"> printf("JSC EXCEPTION FUZZ: Throwing fuzz exception with call frame %p, seen in %s and return address %p.\n", exec, where, returnPC);
</span><ins>+ fflush(stdout);
</ins><span class="cx"> throwException(exec, scope, createError(exec, ASCIILiteral("Exception Fuzz")));
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>