<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205676] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205676">205676</a></dd>
<dt>Author</dt> <dd>mattbaker@apple.com</dd>
<dt>Date</dt> <dd>2016-09-08 16:21:27 -0700 (Thu, 08 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: TimelineDataGridNode should refresh when graph column is resized
https://bugs.webkit.org/show_bug.cgi?id=161765
<rdar://problem/28215674>
Reviewed by Brian Burg.
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.resizerDragging):
Call `DataGridNode.didResizeColumn` for all visible nodes in the columns
to the left and right of the column resizer.
* UserInterface/Views/DataGridNode.js:
(WebInspector.DataGridNode.prototype.didResizeColumn):
Add protected base class method for subclasses to override.
* UserInterface/Views/TimelineDataGridNode.js:
(WebInspector.TimelineDataGridNode.prototype.didResizeColumn):
Refresh the node's graph when the "graph" column is resized.
Renamed `left/rightCellIndex` -> `left/rightColumnIndex`.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDataGridjs">trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDataGridNodejs">trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineDataGridNodejs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (205675 => 205676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-09-08 23:19:38 UTC (rev 205675)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-09-08 23:21:27 UTC (rev 205676)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-09-08 Matt Baker <mattbaker@apple.com>
+
+ Web Inspector: TimelineDataGridNode should refresh when graph column is resized
+ https://bugs.webkit.org/show_bug.cgi?id=161765
+ <rdar://problem/28215674>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGrid.prototype.resizerDragging):
+ Call `DataGridNode.didResizeColumn` for all visible nodes in the columns
+ to the left and right of the column resizer.
+
+ * UserInterface/Views/DataGridNode.js:
+ (WebInspector.DataGridNode.prototype.didResizeColumn):
+ Add protected base class method for subclasses to override.
+
+ * UserInterface/Views/TimelineDataGridNode.js:
+ (WebInspector.TimelineDataGridNode.prototype.didResizeColumn):
+ Refresh the node's graph when the "graph" column is resized.
+ Renamed `left/rightCellIndex` -> `left/rightColumnIndex`.
+
</ins><span class="cx"> 2016-09-08 Nikita Vasilyev <nvasilyev@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Add a button to navigation bar to toggle Control Flow Profiler
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDataGridjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (205675 => 205676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-09-08 23:19:38 UTC (rev 205675)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-09-08 23:21:27 UTC (rev 205676)
</span><span class="lines">@@ -1783,22 +1783,22 @@
</span><span class="cx"> var dragPoint = (resizer.initialPosition - positionDelta) - this.element.totalOffsetLeft;
</span><span class="cx"> // Constrain the dragpoint to be within the space made up by the
</span><span class="cx"> // column directly to the left and the column directly to the right.
</span><del>- var leftCellIndex = resizer[WebInspector.DataGrid.PreviousColumnOrdinalSymbol];
- var rightCellIndex = resizer[WebInspector.DataGrid.NextColumnOrdinalSymbol];
</del><ins>+ var leftColumnIndex = resizer[WebInspector.DataGrid.PreviousColumnOrdinalSymbol];
+ var rightColumnIndex = resizer[WebInspector.DataGrid.NextColumnOrdinalSymbol];
</ins><span class="cx"> var firstRowCells = this._headerTableBodyElement.rows[0].cells;
</span><span class="cx"> var leftEdgeOfPreviousColumn = 0;
</span><del>- for (var i = 0; i < leftCellIndex; i++)
</del><ins>+ for (var i = 0; i < leftColumnIndex; i++)
</ins><span class="cx"> leftEdgeOfPreviousColumn += firstRowCells[i].offsetWidth;
</span><span class="cx">
</span><span class="cx"> // Differences for other resize methods
</span><span class="cx"> if (this.resizeMethod === WebInspector.DataGrid.ResizeMethod.Last) {
</span><del>- rightCellIndex = this.resizers.length;
</del><ins>+ rightColumnIndex = this.resizers.length;
</ins><span class="cx"> } else if (this.resizeMethod === WebInspector.DataGrid.ResizeMethod.First) {
</span><del>- leftEdgeOfPreviousColumn += firstRowCells[leftCellIndex].offsetWidth - firstRowCells[0].offsetWidth;
- leftCellIndex = 0;
</del><ins>+ leftEdgeOfPreviousColumn += firstRowCells[leftColumnIndex].offsetWidth - firstRowCells[0].offsetWidth;
+ leftColumnIndex = 0;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- var rightEdgeOfNextColumn = leftEdgeOfPreviousColumn + firstRowCells[leftCellIndex].offsetWidth + firstRowCells[rightCellIndex].offsetWidth;
</del><ins>+ var rightEdgeOfNextColumn = leftEdgeOfPreviousColumn + firstRowCells[leftColumnIndex].offsetWidth + firstRowCells[rightColumnIndex].offsetWidth;
</ins><span class="cx">
</span><span class="cx"> // Give each column some padding so that they don't disappear.
</span><span class="cx"> var leftMinimum = leftEdgeOfPreviousColumn + this.ColumnResizePadding;
</span><span class="lines">@@ -1809,15 +1809,29 @@
</span><span class="cx"> resizer.element.style.left = (dragPoint - this.CenterResizerOverBorderAdjustment) + "px";
</span><span class="cx">
</span><span class="cx"> var percentLeftColumn = (((dragPoint - leftEdgeOfPreviousColumn) / this._dataTableElement.offsetWidth) * 100) + "%";
</span><del>- this._headerTableColumnGroupElement.children[leftCellIndex].style.width = percentLeftColumn;
- this._dataTableColumnGroupElement.children[leftCellIndex].style.width = percentLeftColumn;
</del><ins>+ this._headerTableColumnGroupElement.children[leftColumnIndex].style.width = percentLeftColumn;
+ this._dataTableColumnGroupElement.children[leftColumnIndex].style.width = percentLeftColumn;
</ins><span class="cx">
</span><span class="cx"> var percentRightColumn = (((rightEdgeOfNextColumn - dragPoint) / this._dataTableElement.offsetWidth) * 100) + "%";
</span><del>- this._headerTableColumnGroupElement.children[rightCellIndex].style.width = percentRightColumn;
- this._dataTableColumnGroupElement.children[rightCellIndex].style.width = percentRightColumn;
</del><ins>+ this._headerTableColumnGroupElement.children[rightColumnIndex].style.width = percentRightColumn;
+ this._dataTableColumnGroupElement.children[rightColumnIndex].style.width = percentRightColumn;
</ins><span class="cx">
</span><span class="cx"> this._positionResizerElements();
</span><span class="cx"> this._positionHeaderViews();
</span><ins>+
+ const skipHidden = true;
+ const dontPopulate = true;
+
+ let leftColumnIdentifier = this.orderedColumns[leftColumnIndex];
+ let rightColumnIdentifier = this.orderedColumns[rightColumnIndex];
+ let child = this.children[0];
+
+ while (child) {
+ child.didResizeColumn(leftColumnIdentifier);
+ child.didResizeColumn(rightColumnIdentifier);
+ child = child.traverseNextNode(skipHidden, this, dontPopulate);
+ }
+
</ins><span class="cx"> event.preventDefault();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDataGridNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js (205675 => 205676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js 2016-09-08 23:19:38 UTC (rev 205675)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js 2016-09-08 23:21:27 UTC (rev 205676)
</span><span class="lines">@@ -732,6 +732,11 @@
</span><span class="cx"> let value = this.data[columnIdentifier];
</span><span class="cx"> return typeof value === "string" ? value : null;
</span><span class="cx"> }
</span><ins>+
+ didResizeColumn(columnIdentifier)
+ {
+ // Override by subclasses.
+ }
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // Used to create a new table row when entering new data by editing cells.
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineDataGridNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js (205675 => 205676)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js 2016-09-08 23:19:38 UTC (rev 205675)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js 2016-09-08 23:21:27 UTC (rev 205676)
</span><span class="lines">@@ -389,4 +389,12 @@
</span><span class="cx"> {
</span><span class="cx"> // Implemented by subclasses.
</span><span class="cx"> }
</span><ins>+
+ didResizeColumn(columnIdentifier)
+ {
+ if (columnIdentifier !== "graph")
+ return;
+
+ this.needsGraphRefresh();
+ }
</ins><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>