<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205604] releases/WebKitGTK/webkit-2.14/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205604">205604</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-09-08 01:19:12 -0700 (Thu, 08 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/205249">r205249</a> - DOM event handling should pass Event around by reference.
<https://webkit.org/b/161398>
Reviewed by Chris Dumez.
Source/WebCore:
Start with making Node::defaultEventHandler() take an Event& instead of an Event*,
and then spread out from there, propagating the referenceness.
* dom/Element.cpp:
(WebCore::Element::isKeyboardFocusable):
* dom/Element.h:
* dom/EventDispatcher.cpp:
(WebCore::callDefaultEventHandlersInTheBubblingOrder):
* dom/Node.cpp:
(WebCore::Node::dispatchDOMActivateEvent):
(WebCore::Node::defaultEventHandler):
* dom/Node.h:
* editing/Editor.cpp:
(WebCore::Editor::handleKeyboardEvent):
(WebCore::Editor::handleInputMethodKeydown):
(WebCore::Editor::handleTextEvent):
* editing/Editor.h:
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::handleKeydownEvent):
(WebCore::BaseCheckableInputType::handleKeypressEvent):
* html/BaseCheckableInputType.h:
* html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeydownEvent):
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeypressEvent):
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeyupEvent):
* html/BaseChooserOnlyDateAndTimeInputType.h:
* html/BaseClickableWithKeyInputType.cpp:
(WebCore::BaseClickableWithKeyInputType::handleKeydownEvent):
(WebCore::BaseClickableWithKeyInputType::handleKeypressEvent):
(WebCore::BaseClickableWithKeyInputType::handleKeyupEvent):
* html/BaseClickableWithKeyInputType.h:
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::isKeyboardFocusable):
* html/BaseDateAndTimeInputType.h:
* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::handleKeyupEvent):
* html/CheckboxInputType.h:
* html/ColorInputType.cpp:
(WebCore::ColorInputType::handleDOMActivateEvent):
* html/ColorInputType.h:
* html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
* html/FileInputType.h:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isKeyboardFocusable):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::handleClick):
(WebCore::HTMLAnchorElement::eventType):
(WebCore::isEnterKeyKeydownEvent):
* html/HTMLAnchorElement.h:
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::isKeyboardFocusable):
* html/HTMLAreaElement.h:
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::defaultEventHandler):
* html/HTMLButtonElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isKeyboardFocusable):
* html/HTMLFormControlElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::submitElementFromEvent):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::prepareForSubmission):
* html/HTMLFormElement.h:
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::isKeyboardFocusable):
* html/HTMLFrameOwnerElement.h:
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::defaultEventHandler):
* html/HTMLFrameSetElement.h:
* html/HTMLIFrameElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isKeyboardFocusable):
(WebCore::HTMLInputElement::isTextFormControlKeyboardFocusable):
(WebCore::HTMLInputElement::willDispatchEvent):
(WebCore::HTMLInputElement::defaultEventHandler):
* html/HTMLInputElement.h:
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler):
* html/HTMLLabelElement.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::defaultEventHandler):
* html/HTMLLinkElement.h:
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
(WebCore::HTMLPlugInElement::isKeyboardFocusable):
* html/HTMLPlugInElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::defaultEventHandler):
* html/HTMLPlugInImageElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::isKeyboardFocusable):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):
* html/HTMLSelectElement.h:
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::defaultEventHandler):
* html/HTMLSummaryElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::isKeyboardFocusable):
(WebCore::HTMLTextAreaElement::defaultEventHandler):
(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
* html/HTMLTextAreaElement.h:
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::forwardEvent):
* html/HTMLTextFormControlElement.h:
* html/ImageInputType.cpp:
(WebCore::ImageInputType::handleDOMActivateEvent):
* html/ImageInputType.h:
* html/InputType.cpp:
(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleMouseDownEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):
(WebCore::InputType::handleKeypressEvent):
(WebCore::InputType::handleKeyupEvent):
(WebCore::InputType::handleBeforeTextInsertedEvent):
(WebCore::InputType::handleTouchEvent):
(WebCore::InputType::forwardEvent):
(WebCore::InputType::shouldSubmitImplicitly):
(WebCore::InputType::dispatchSimulatedClickIfActive):
(WebCore::InputType::isKeyboardFocusable):
* html/InputType.h:
* html/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
* html/MediaDocument.h:
* html/NumberInputType.cpp:
(WebCore::NumberInputType::handleKeydownEvent):
* html/NumberInputType.h:
* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleClickEvent):
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):
(WebCore::RadioInputType::isKeyboardFocusable):
* html/RadioInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::handleTouchEvent):
(WebCore::RangeInputType::handleKeydownEvent):
* html/RangeInputType.h:
* html/ResetInputType.cpp:
(WebCore::ResetInputType::handleDOMActivateEvent):
* html/ResetInputType.h:
* html/SearchInputType.cpp:
(WebCore::SearchInputType::handleKeydownEvent):
* html/SearchInputType.h:
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::handleDOMActivateEvent):
* html/SubmitInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::isKeyboardFocusable):
(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton):
(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::shouldSubmitImplicitly):
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
* html/TextFieldInputType.h:
* html/shadow/AutoFillButtonElement.cpp:
(WebCore::AutoFillButtonElement::defaultEventHandler):
* html/shadow/AutoFillButtonElement.h:
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlMuteButtonElement::defaultEventHandler):
(WebCore::MediaControlSeekButtonElement::defaultEventHandler):
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
* html/shadow/MediaControlElementTypes.h:
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::defaultEventHandler):
(WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler):
(WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler):
(WebCore::MediaControlPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlOverlayPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
(WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler):
(WebCore::MediaControlTimelineElement::defaultEventHandler):
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler):
* html/shadow/MediaControlElements.h:
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::defaultEventHandler):
(WebCore::MediaControls::containsRelatedTarget):
* html/shadow/MediaControls.h:
* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::defaultEventHandler):
(WebCore::MediaControlsApple::handleClickEvent):
(WebCore::MediaControlsAppleEventListener::handleEvent):
* html/shadow/MediaControlsApple.h:
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::handleTouchStart):
(WebCore::SliderThumbElement::handleTouchMove):
(WebCore::SliderThumbElement::handleTouchEndAndCancel):
(WebCore::SliderThumbElement::handleTouchEvent):
* html/shadow/SliderThumbElement.h:
* html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::forwardEvent):
* html/shadow/SpinButtonElement.h:
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::defaultEventHandler):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
* html/shadow/TextControlInnerElements.h:
* html/shadow/mac/ImageControlsButtonElementMac.cpp:
(WebCore::ImageControlsButtonElementMac::defaultEventHandler):
* html/shadow/mac/ImageControlsButtonElementMac.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchBeforeUnloadEvent):
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::defaultEventHandler):
(WebCore::MathMLElement::isKeyboardFocusable):
* mathml/MathMLElement.h:
* mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::defaultEventHandler):
* mathml/MathMLSelectElement.h:
* page/EventHandler.cpp:
(WebCore::didScrollInScrollableArea):
(WebCore::handleWheelEventInAppropriateEnclosingBox):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::keyEvent):
(WebCore::handleKeyboardSelectionMovement):
(WebCore::EventHandler::handleKeyboardSelectionMovementForAccessibility):
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::defaultTextInputEventHandler):
(WebCore::EventHandler::defaultSpaceEventHandler):
(WebCore::EventHandler::defaultBackspaceEventHandler):
(WebCore::EventHandler::defaultArrowEventHandler):
(WebCore::EventHandler::defaultTabEventHandler):
* page/EventHandler.h:
* page/FocusController.cpp:
(WebCore::isFocusableElementOrScopeOwner):
(WebCore::isNonFocusableScopeOwner):
(WebCore::isFocusableScopeOwner):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusCandidateInContainer):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::userResize):
* rendering/RenderFrameSet.h:
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
(WebCore::SVGAElement::isKeyboardFocusable):
* svg/SVGAElement.h:
Source/WebKit2:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performNonEditingBehaviorForSelector):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoredomElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoredomElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Element.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoredomEventDispatchercpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/EventDispatcher.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoredomNodecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Node.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoredomNodeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Node.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoreeditingEditorcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/editing/Editor.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoreeditingEditorh">releases/WebKitGTK/webkit-2.14/Source/WebCore/editing/Editor.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlBaseCheckableInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseCheckableInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlBaseCheckableInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseCheckableInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlBaseChooserOnlyDateAndTimeInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlBaseChooserOnlyDateAndTimeInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlBaseClickableWithKeyInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseClickableWithKeyInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlBaseClickableWithKeyInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseClickableWithKeyInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlBaseDateAndTimeInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseDateAndTimeInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlBaseDateAndTimeInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseDateAndTimeInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlCheckboxInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/CheckboxInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlCheckboxInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/CheckboxInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlColorInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ColorInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlColorInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ColorInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlFileInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/FileInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlFileInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/FileInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLAnchorElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAnchorElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLAnchorElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAnchorElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLAreaElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAreaElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLAreaElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAreaElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLButtonElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLButtonElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLButtonElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLButtonElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFormControlElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormControlElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFormControlElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormControlElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFormElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFormElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFrameOwnerElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameOwnerElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFrameOwnerElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameOwnerElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFrameSetElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameSetElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFrameSetElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameSetElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLIFrameElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLIFrameElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLInputElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLInputElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLInputElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLInputElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLLabelElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLabelElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLLabelElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLabelElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLLinkElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLinkElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLLinkElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLinkElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLPlugInElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLPlugInElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLPlugInImageElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInImageElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLPlugInImageElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInImageElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLSelectElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLSelectElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSelectElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLSummaryElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSummaryElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLSummaryElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSummaryElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLTextAreaElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextAreaElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLTextAreaElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextAreaElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLTextFormControlElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextFormControlElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLTextFormControlElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextFormControlElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlImageInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ImageInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlImageInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ImageInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/InputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/InputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlMediaDocumentcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/MediaDocument.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlMediaDocumenth">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/MediaDocument.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlNumberInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/NumberInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlNumberInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/NumberInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlRadioInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RadioInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlRadioInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RadioInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlRangeInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RangeInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlRangeInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RangeInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlResetInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ResetInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlResetInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ResetInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlSearchInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SearchInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlSearchInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SearchInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlSubmitInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SubmitInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlSubmitInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SubmitInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlTextFieldInputTypecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/TextFieldInputType.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlTextFieldInputTypeh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/TextFieldInputType.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowAutoFillButtonElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/AutoFillButtonElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowAutoFillButtonElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/AutoFillButtonElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlElementTypescpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElementTypes.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlElementTypesh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElementTypes.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlElementscpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElements.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlElementsh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElements.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlscpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControls.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlsh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControls.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlsApplecpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlsApple.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlsAppleh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlsApple.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowSliderThumbElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SliderThumbElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowSliderThumbElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SliderThumbElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowSpinButtonElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SpinButtonElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowSpinButtonElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SpinButtonElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowTextControlInnerElementscpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/TextControlInnerElements.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowTextControlInnerElementsh">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/TextControlInnerElements.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowmacImageControlsButtonElementMaccpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorehtmlshadowmacImageControlsButtonElementMach">releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoreloaderFrameLoadercpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/loader/FrameLoader.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoremathmlMathMLElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoremathmlMathMLElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoremathmlMathMLSelectElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLSelectElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoremathmlMathMLSelectElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLSelectElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorepageEventHandlercpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/page/EventHandler.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorepageEventHandlerh">releases/WebKitGTK/webkit-2.14/Source/WebCore/page/EventHandler.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorepageFocusControllercpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/page/FocusController.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorerenderingRenderFrameSetcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/rendering/RenderFrameSet.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCorerenderingRenderFrameSeth">releases/WebKitGTK/webkit-2.14/Source/WebCore/rendering/RenderFrameSet.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoresvgSVGAElementcpp">releases/WebKitGTK/webkit-2.14/Source/WebCore/svg/SVGAElement.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebCoresvgSVGAElementh">releases/WebKitGTK/webkit-2.14/Source/WebCore/svg/SVGAElement.h</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebKit2ChangeLog">releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit214SourceWebKit2WebProcessWebPagemacWebPageMacmm">releases/WebKitGTK/webkit-2.14/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit214SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -1,3 +1,258 @@
</span><ins>+2016-08-31 Andreas Kling <akling@apple.com>
+
+ DOM event handling should pass Event around by reference.
+ <https://webkit.org/b/161398>
+
+ Reviewed by Chris Dumez.
+
+ Start with making Node::defaultEventHandler() take an Event& instead of an Event*,
+ and then spread out from there, propagating the referenceness.
+
+ * dom/Element.cpp:
+ (WebCore::Element::isKeyboardFocusable):
+ * dom/Element.h:
+ * dom/EventDispatcher.cpp:
+ (WebCore::callDefaultEventHandlersInTheBubblingOrder):
+ * dom/Node.cpp:
+ (WebCore::Node::dispatchDOMActivateEvent):
+ (WebCore::Node::defaultEventHandler):
+ * dom/Node.h:
+ * editing/Editor.cpp:
+ (WebCore::Editor::handleKeyboardEvent):
+ (WebCore::Editor::handleInputMethodKeydown):
+ (WebCore::Editor::handleTextEvent):
+ * editing/Editor.h:
+ * html/BaseCheckableInputType.cpp:
+ (WebCore::BaseCheckableInputType::handleKeydownEvent):
+ (WebCore::BaseCheckableInputType::handleKeypressEvent):
+ * html/BaseCheckableInputType.h:
+ * html/BaseChooserOnlyDateAndTimeInputType.cpp:
+ (WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
+ (WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeydownEvent):
+ (WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeypressEvent):
+ (WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeyupEvent):
+ * html/BaseChooserOnlyDateAndTimeInputType.h:
+ * html/BaseClickableWithKeyInputType.cpp:
+ (WebCore::BaseClickableWithKeyInputType::handleKeydownEvent):
+ (WebCore::BaseClickableWithKeyInputType::handleKeypressEvent):
+ (WebCore::BaseClickableWithKeyInputType::handleKeyupEvent):
+ * html/BaseClickableWithKeyInputType.h:
+ * html/BaseDateAndTimeInputType.cpp:
+ (WebCore::BaseDateAndTimeInputType::isKeyboardFocusable):
+ * html/BaseDateAndTimeInputType.h:
+ * html/CheckboxInputType.cpp:
+ (WebCore::CheckboxInputType::handleKeyupEvent):
+ * html/CheckboxInputType.h:
+ * html/ColorInputType.cpp:
+ (WebCore::ColorInputType::handleDOMActivateEvent):
+ * html/ColorInputType.h:
+ * html/FileInputType.cpp:
+ (WebCore::FileInputType::handleDOMActivateEvent):
+ * html/FileInputType.h:
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::isKeyboardFocusable):
+ (WebCore::HTMLAnchorElement::defaultEventHandler):
+ (WebCore::HTMLAnchorElement::handleClick):
+ (WebCore::HTMLAnchorElement::eventType):
+ (WebCore::isEnterKeyKeydownEvent):
+ * html/HTMLAnchorElement.h:
+ * html/HTMLAreaElement.cpp:
+ (WebCore::HTMLAreaElement::isKeyboardFocusable):
+ * html/HTMLAreaElement.h:
+ * html/HTMLButtonElement.cpp:
+ (WebCore::HTMLButtonElement::defaultEventHandler):
+ * html/HTMLButtonElement.h:
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::isKeyboardFocusable):
+ * html/HTMLFormControlElement.h:
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::submitImplicitly):
+ (WebCore::submitElementFromEvent):
+ (WebCore::HTMLFormElement::validateInteractively):
+ (WebCore::HTMLFormElement::prepareForSubmission):
+ * html/HTMLFormElement.h:
+ * html/HTMLFrameOwnerElement.cpp:
+ (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable):
+ * html/HTMLFrameOwnerElement.h:
+ * html/HTMLFrameSetElement.cpp:
+ (WebCore::HTMLFrameSetElement::defaultEventHandler):
+ * html/HTMLFrameSetElement.h:
+ * html/HTMLIFrameElement.h:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::isKeyboardFocusable):
+ (WebCore::HTMLInputElement::isTextFormControlKeyboardFocusable):
+ (WebCore::HTMLInputElement::willDispatchEvent):
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ * html/HTMLInputElement.h:
+ * html/HTMLLabelElement.cpp:
+ (WebCore::HTMLLabelElement::defaultEventHandler):
+ * html/HTMLLabelElement.h:
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::defaultEventHandler):
+ * html/HTMLLinkElement.h:
+ * html/HTMLPlugInElement.cpp:
+ (WebCore::HTMLPlugInElement::defaultEventHandler):
+ (WebCore::HTMLPlugInElement::isKeyboardFocusable):
+ * html/HTMLPlugInElement.h:
+ * html/HTMLPlugInImageElement.cpp:
+ (WebCore::HTMLPlugInImageElement::defaultEventHandler):
+ * html/HTMLPlugInImageElement.h:
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::isKeyboardFocusable):
+ (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
+ (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
+ (WebCore::HTMLSelectElement::defaultEventHandler):
+ * html/HTMLSelectElement.h:
+ * html/HTMLSummaryElement.cpp:
+ (WebCore::HTMLSummaryElement::defaultEventHandler):
+ * html/HTMLSummaryElement.h:
+ * html/HTMLTextAreaElement.cpp:
+ (WebCore::HTMLTextAreaElement::isKeyboardFocusable):
+ (WebCore::HTMLTextAreaElement::defaultEventHandler):
+ (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
+ * html/HTMLTextAreaElement.h:
+ * html/HTMLTextFormControlElement.cpp:
+ (WebCore::HTMLTextFormControlElement::forwardEvent):
+ * html/HTMLTextFormControlElement.h:
+ * html/ImageInputType.cpp:
+ (WebCore::ImageInputType::handleDOMActivateEvent):
+ * html/ImageInputType.h:
+ * html/InputType.cpp:
+ (WebCore::InputType::handleClickEvent):
+ (WebCore::InputType::handleMouseDownEvent):
+ (WebCore::InputType::handleDOMActivateEvent):
+ (WebCore::InputType::handleKeydownEvent):
+ (WebCore::InputType::handleKeypressEvent):
+ (WebCore::InputType::handleKeyupEvent):
+ (WebCore::InputType::handleBeforeTextInsertedEvent):
+ (WebCore::InputType::handleTouchEvent):
+ (WebCore::InputType::forwardEvent):
+ (WebCore::InputType::shouldSubmitImplicitly):
+ (WebCore::InputType::dispatchSimulatedClickIfActive):
+ (WebCore::InputType::isKeyboardFocusable):
+ * html/InputType.h:
+ * html/MediaDocument.cpp:
+ (WebCore::MediaDocument::defaultEventHandler):
+ * html/MediaDocument.h:
+ * html/NumberInputType.cpp:
+ (WebCore::NumberInputType::handleKeydownEvent):
+ * html/NumberInputType.h:
+ * html/RadioInputType.cpp:
+ (WebCore::RadioInputType::handleClickEvent):
+ (WebCore::RadioInputType::handleKeydownEvent):
+ (WebCore::RadioInputType::handleKeyupEvent):
+ (WebCore::RadioInputType::isKeyboardFocusable):
+ * html/RadioInputType.h:
+ * html/RangeInputType.cpp:
+ (WebCore::RangeInputType::handleMouseDownEvent):
+ (WebCore::RangeInputType::handleTouchEvent):
+ (WebCore::RangeInputType::handleKeydownEvent):
+ * html/RangeInputType.h:
+ * html/ResetInputType.cpp:
+ (WebCore::ResetInputType::handleDOMActivateEvent):
+ * html/ResetInputType.h:
+ * html/SearchInputType.cpp:
+ (WebCore::SearchInputType::handleKeydownEvent):
+ * html/SearchInputType.h:
+ * html/SubmitInputType.cpp:
+ (WebCore::SubmitInputType::handleDOMActivateEvent):
+ * html/SubmitInputType.h:
+ * html/TextFieldInputType.cpp:
+ (WebCore::TextFieldInputType::isKeyboardFocusable):
+ (WebCore::TextFieldInputType::handleKeydownEvent):
+ (WebCore::TextFieldInputType::handleKeydownEventForSpinButton):
+ (WebCore::TextFieldInputType::forwardEvent):
+ (WebCore::TextFieldInputType::shouldSubmitImplicitly):
+ (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
+ * html/TextFieldInputType.h:
+ * html/shadow/AutoFillButtonElement.cpp:
+ (WebCore::AutoFillButtonElement::defaultEventHandler):
+ * html/shadow/AutoFillButtonElement.h:
+ * html/shadow/MediaControlElementTypes.cpp:
+ (WebCore::MediaControlMuteButtonElement::defaultEventHandler):
+ (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
+ (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
+ * html/shadow/MediaControlElementTypes.h:
+ * html/shadow/MediaControlElements.cpp:
+ (WebCore::MediaControlPanelElement::defaultEventHandler):
+ (WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler):
+ (WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler):
+ (WebCore::MediaControlPlayButtonElement::defaultEventHandler):
+ (WebCore::MediaControlOverlayPlayButtonElement::defaultEventHandler):
+ (WebCore::MediaControlRewindButtonElement::defaultEventHandler):
+ (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler):
+ (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
+ (WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler):
+ (WebCore::MediaControlTimelineElement::defaultEventHandler):
+ (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
+ (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler):
+ (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler):
+ * html/shadow/MediaControlElements.h:
+ * html/shadow/MediaControls.cpp:
+ (WebCore::MediaControls::defaultEventHandler):
+ (WebCore::MediaControls::containsRelatedTarget):
+ * html/shadow/MediaControls.h:
+ * html/shadow/MediaControlsApple.cpp:
+ (WebCore::MediaControlsApple::defaultEventHandler):
+ (WebCore::MediaControlsApple::handleClickEvent):
+ (WebCore::MediaControlsAppleEventListener::handleEvent):
+ * html/shadow/MediaControlsApple.h:
+ * html/shadow/SliderThumbElement.cpp:
+ (WebCore::SliderThumbElement::defaultEventHandler):
+ (WebCore::SliderThumbElement::handleTouchStart):
+ (WebCore::SliderThumbElement::handleTouchMove):
+ (WebCore::SliderThumbElement::handleTouchEndAndCancel):
+ (WebCore::SliderThumbElement::handleTouchEvent):
+ * html/shadow/SliderThumbElement.h:
+ * html/shadow/SpinButtonElement.cpp:
+ (WebCore::SpinButtonElement::defaultEventHandler):
+ (WebCore::SpinButtonElement::forwardEvent):
+ * html/shadow/SpinButtonElement.h:
+ * html/shadow/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerTextElement::defaultEventHandler):
+ (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
+ (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
+ * html/shadow/TextControlInnerElements.h:
+ * html/shadow/mac/ImageControlsButtonElementMac.cpp:
+ (WebCore::ImageControlsButtonElementMac::defaultEventHandler):
+ * html/shadow/mac/ImageControlsButtonElementMac.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::dispatchBeforeUnloadEvent):
+ * mathml/MathMLElement.cpp:
+ (WebCore::MathMLElement::defaultEventHandler):
+ (WebCore::MathMLElement::isKeyboardFocusable):
+ * mathml/MathMLElement.h:
+ * mathml/MathMLSelectElement.cpp:
+ (WebCore::MathMLSelectElement::defaultEventHandler):
+ * mathml/MathMLSelectElement.h:
+ * page/EventHandler.cpp:
+ (WebCore::didScrollInScrollableArea):
+ (WebCore::handleWheelEventInAppropriateEnclosingBox):
+ (WebCore::EventHandler::defaultWheelEventHandler):
+ (WebCore::EventHandler::keyEvent):
+ (WebCore::handleKeyboardSelectionMovement):
+ (WebCore::EventHandler::handleKeyboardSelectionMovementForAccessibility):
+ (WebCore::EventHandler::defaultKeyboardEventHandler):
+ (WebCore::EventHandler::defaultTextInputEventHandler):
+ (WebCore::EventHandler::defaultSpaceEventHandler):
+ (WebCore::EventHandler::defaultBackspaceEventHandler):
+ (WebCore::EventHandler::defaultArrowEventHandler):
+ (WebCore::EventHandler::defaultTabEventHandler):
+ * page/EventHandler.h:
+ * page/FocusController.cpp:
+ (WebCore::isFocusableElementOrScopeOwner):
+ (WebCore::isNonFocusableScopeOwner):
+ (WebCore::isFocusableScopeOwner):
+ (WebCore::FocusController::advanceFocusInDocumentOrder):
+ (WebCore::FocusController::findFocusCandidateInContainer):
+ * rendering/RenderFrameSet.cpp:
+ (WebCore::RenderFrameSet::userResize):
+ * rendering/RenderFrameSet.h:
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::defaultEventHandler):
+ (WebCore::SVGAElement::isKeyboardFocusable):
+ * svg/SVGAElement.h:
+
</ins><span class="cx"> 2016-08-31 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r201701): Unable to copy from CodeMirror editor version used in Jenkins install website
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Element.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Element.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Element.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -249,7 +249,7 @@
</span><span class="cx"> setIntegralAttribute(tabindexAttr, value);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool Element::isKeyboardFocusable(KeyboardEvent*) const
</del><ins>+bool Element::isKeyboardFocusable(KeyboardEvent&) const
</ins><span class="cx"> {
</span><span class="cx"> return isFocusable() && tabIndex() >= 0;
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Element.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Element.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Element.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -295,7 +295,7 @@
</span><span class="cx"> bool tabIndexSetExplicitly() const;
</span><span class="cx"> virtual bool supportsFocus() const;
</span><span class="cx"> virtual bool isFocusable() const;
</span><del>- virtual bool isKeyboardFocusable(KeyboardEvent*) const;
</del><ins>+ virtual bool isKeyboardFocusable(KeyboardEvent&) const;
</ins><span class="cx"> virtual bool isMouseFocusable() const;
</span><span class="cx">
</span><span class="cx"> virtual bool shouldUseInputMethod();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoredomEventDispatchercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/EventDispatcher.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/EventDispatcher.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/EventDispatcher.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // Non-bubbling events call only one default event handler, the one for the target.
</span><del>- path.contextAt(0).node()->defaultEventHandler(&event);
</del><ins>+ path.contextAt(0).node()->defaultEventHandler(event);
</ins><span class="cx"> ASSERT(!event.defaultPrevented());
</span><span class="cx">
</span><span class="cx"> if (event.defaultHandled() || !event.bubbles())
</span><span class="lines">@@ -95,7 +95,7 @@
</span><span class="cx">
</span><span class="cx"> size_t size = path.size();
</span><span class="cx"> for (size_t i = 1; i < size; ++i) {
</span><del>- path.contextAt(i).node()->defaultEventHandler(&event);
</del><ins>+ path.contextAt(i).node()->defaultEventHandler(event);
</ins><span class="cx"> ASSERT(!event.defaultPrevented());
</span><span class="cx"> if (event.defaultHandled())
</span><span class="cx"> return;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Node.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Node.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Node.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -2156,11 +2156,11 @@
</span><span class="cx"> dispatchScopedEvent(MutationEvent::create(subtreeModifiedEventName, true));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool Node::dispatchDOMActivateEvent(int detail, PassRefPtr<Event> underlyingEvent)
</del><ins>+bool Node::dispatchDOMActivateEvent(int detail, Event& underlyingEvent)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT_WITH_SECURITY_IMPLICATION(!NoEventDispatchAssertion::isEventDispatchForbidden());
</span><span class="cx"> Ref<UIEvent> event = UIEvent::create(eventNames().DOMActivateEvent, true, true, document().defaultView(), detail);
</span><del>- event->setUnderlyingEvent(underlyingEvent.get());
</del><ins>+ event->setUnderlyingEvent(&underlyingEvent);
</ins><span class="cx"> dispatchScopedEvent(event);
</span><span class="cx"> return event->defaultHandled();
</span><span class="cx"> }
</span><span class="lines">@@ -2196,34 +2196,34 @@
</span><span class="cx"> dispatchScopedEvent(Event::create(eventNames().inputEvent, true, false));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Node::defaultEventHandler(Event* event)
</del><ins>+void Node::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->target() != this)
</del><ins>+ if (event.target() != this)
</ins><span class="cx"> return;
</span><del>- const AtomicString& eventType = event->type();
</del><ins>+ const AtomicString& eventType = event.type();
</ins><span class="cx"> if (eventType == eventNames().keydownEvent || eventType == eventNames().keypressEvent) {
</span><del>- if (is<KeyboardEvent>(*event)) {
</del><ins>+ if (is<KeyboardEvent>(event)) {
</ins><span class="cx"> if (Frame* frame = document().frame())
</span><span class="cx"> frame->eventHandler().defaultKeyboardEventHandler(downcast<KeyboardEvent>(event));
</span><span class="cx"> }
</span><span class="cx"> } else if (eventType == eventNames().clickEvent) {
</span><del>- int detail = is<UIEvent>(*event) ? downcast<UIEvent>(*event).detail() : 0;
</del><ins>+ int detail = is<UIEvent>(event) ? downcast<UIEvent>(event).detail() : 0;
</ins><span class="cx"> if (dispatchDOMActivateEvent(detail, event))
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> #if ENABLE(CONTEXT_MENUS)
</span><span class="cx"> } else if (eventType == eventNames().contextmenuEvent) {
</span><span class="cx"> if (Frame* frame = document().frame())
</span><span class="cx"> if (Page* page = frame->page())
</span><del>- page->contextMenuController().handleContextMenuEvent(event);
</del><ins>+ page->contextMenuController().handleContextMenuEvent(&event);
</ins><span class="cx"> #endif
</span><span class="cx"> } else if (eventType == eventNames().textInputEvent) {
</span><del>- if (is<TextEvent>(*event)) {
</del><ins>+ if (is<TextEvent>(event)) {
</ins><span class="cx"> if (Frame* frame = document().frame())
</span><span class="cx"> frame->eventHandler().defaultTextInputEventHandler(downcast<TextEvent>(event));
</span><span class="cx"> }
</span><span class="cx"> #if ENABLE(PAN_SCROLLING)
</span><del>- } else if (eventType == eventNames().mousedownEvent && is<MouseEvent>(*event)) {
- if (downcast<MouseEvent>(*event).button() == MiddleButton) {
</del><ins>+ } else if (eventType == eventNames().mousedownEvent && is<MouseEvent>(event)) {
+ if (downcast<MouseEvent>(event).button() == MiddleButton) {
</ins><span class="cx"> if (enclosingLinkEventParentOrSelf())
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -2237,7 +2237,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><del>- } else if (eventNames().isWheelEventType(eventType) && is<WheelEvent>(*event)) {
</del><ins>+ } else if (eventNames().isWheelEventType(eventType) && is<WheelEvent>(event)) {
</ins><span class="cx"> // If we don't have a renderer, send the wheel event to the first node we find with a renderer.
</span><span class="cx"> // This is needed for <option> and <optgroup> elements so that <select>s get a wheel scroll.
</span><span class="cx"> Node* startNode = this;
</span><span class="lines">@@ -2248,7 +2248,7 @@
</span><span class="cx"> if (Frame* frame = document().frame())
</span><span class="cx"> frame->eventHandler().defaultWheelEventHandler(startNode, downcast<WheelEvent>(event));
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS)
</span><del>- } else if (is<TouchEvent>(*event) && eventNames().isTouchEventType(eventType)) {
</del><ins>+ } else if (is<TouchEvent>(event) && eventNames().isTouchEventType(eventType)) {
</ins><span class="cx"> RenderObject* renderer = this->renderer();
</span><span class="cx"> while (renderer && (!is<RenderBox>(*renderer) || !downcast<RenderBox>(*renderer).canBeScrolledAndHasScrollableArea()))
</span><span class="cx"> renderer = renderer->parent();
</span><span class="lines">@@ -2255,10 +2255,10 @@
</span><span class="cx">
</span><span class="cx"> if (renderer && renderer->node()) {
</span><span class="cx"> if (Frame* frame = document().frame())
</span><del>- frame->eventHandler().defaultTouchEventHandler(renderer->node(), downcast<TouchEvent>(event));
</del><ins>+ frame->eventHandler().defaultTouchEventHandler(renderer->node(), &downcast<TouchEvent>(event));
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><del>- } else if (event->type() == eventNames().webkitEditableContentChangedEvent) {
</del><ins>+ } else if (event.type() == eventNames().webkitEditableContentChangedEvent) {
</ins><span class="cx"> dispatchInputEvent();
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoredomNodeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Node.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Node.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/dom/Node.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -508,7 +508,7 @@
</span><span class="cx"> virtual void handleLocalEvents(Event&);
</span><span class="cx">
</span><span class="cx"> void dispatchSubtreeModifiedEvent();
</span><del>- bool dispatchDOMActivateEvent(int detail, PassRefPtr<Event> underlyingEvent);
</del><ins>+ bool dispatchDOMActivateEvent(int detail, Event& underlyingEvent);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><span class="cx"> virtual bool allowsDoubleTapGesture() const { return true; }
</span><span class="lines">@@ -526,7 +526,7 @@
</span><span class="cx"> virtual void dispatchInputEvent();
</span><span class="cx">
</span><span class="cx"> // Perform the default action for an event.
</span><del>- virtual void defaultEventHandler(Event*);
</del><ins>+ virtual void defaultEventHandler(Event&);
</ins><span class="cx">
</span><span class="cx"> void ref();
</span><span class="cx"> void deref();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoreeditingEditorcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/editing/Editor.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/editing/Editor.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/editing/Editor.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -184,51 +184,51 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Editor::handleKeyboardEvent(KeyboardEvent* event)
</del><ins>+void Editor::handleKeyboardEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> if (EditorClient* c = client())
</span><del>- c->handleKeyboardEvent(event);
</del><ins>+ c->handleKeyboardEvent(&event);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void Editor::handleInputMethodKeydown(KeyboardEvent* event)
</del><ins>+void Editor::handleInputMethodKeydown(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> if (EditorClient* c = client())
</span><del>- c->handleInputMethodKeydown(event);
</del><ins>+ c->handleInputMethodKeydown(&event);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-bool Editor::handleTextEvent(TextEvent* event)
</del><ins>+bool Editor::handleTextEvent(TextEvent& event)
</ins><span class="cx"> {
</span><del>- LOG(Editing, "Editor %p handleTextEvent (data %s)", this, event->data().utf8().data());
</del><ins>+ LOG(Editing, "Editor %p handleTextEvent (data %s)", this, event.data().utf8().data());
</ins><span class="cx">
</span><span class="cx"> // Default event handling for Drag and Drop will be handled by DragController
</span><span class="cx"> // so we leave the event for it.
</span><del>- if (event->isDrop())
</del><ins>+ if (event.isDrop())
</ins><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (event->isPaste()) {
- if (event->pastingFragment())
</del><ins>+ if (event.isPaste()) {
+ if (event.pastingFragment())
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> {
</span><del>- if (client()->performsTwoStepPaste(event->pastingFragment()))
</del><ins>+ if (client()->performsTwoStepPaste(event.pastingFragment()))
</ins><span class="cx"> return true;
</span><span class="cx"> #endif
</span><del>- replaceSelectionWithFragment(event->pastingFragment(), false, event->shouldSmartReplace(), event->shouldMatchStyle(), EditActionPaste, event->mailBlockquoteHandling());
</del><ins>+ replaceSelectionWithFragment(event.pastingFragment(), false, event.shouldSmartReplace(), event.shouldMatchStyle(), EditActionPaste, event.mailBlockquoteHandling());
</ins><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx"> else
</span><del>- replaceSelectionWithText(event->data(), false, event->shouldSmartReplace(), EditActionPaste);
</del><ins>+ replaceSelectionWithText(event.data(), false, event.shouldSmartReplace(), EditActionPaste);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- String data = event->data();
</del><ins>+ String data = event.data();
</ins><span class="cx"> if (data == "\n") {
</span><del>- if (event->isLineBreak())
</del><ins>+ if (event.isLineBreak())
</ins><span class="cx"> return insertLineBreak();
</span><span class="cx"> return insertParagraphSeparator();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return insertTextWithoutSendingTextEvent(data, false, event);
</del><ins>+ return insertTextWithoutSendingTextEvent(data, false, &event);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool Editor::canEdit() const
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoreeditingEditorh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/editing/Editor.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/editing/Editor.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/editing/Editor.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -114,9 +114,9 @@
</span><span class="cx">
</span><span class="cx"> CompositeEditCommand* lastEditCommand() { return m_lastEditCommand.get(); }
</span><span class="cx">
</span><del>- void handleKeyboardEvent(KeyboardEvent*);
- void handleInputMethodKeydown(KeyboardEvent*);
- bool handleTextEvent(TextEvent*);
</del><ins>+ void handleKeyboardEvent(KeyboardEvent&);
+ void handleInputMethodKeydown(KeyboardEvent&);
+ bool handleTextEvent(TextEvent&);
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT bool canEdit() const;
</span><span class="cx"> WEBCORE_EXPORT bool canEditRichly() const;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlBaseCheckableInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseCheckableInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseCheckableInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseCheckableInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -60,9 +60,9 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseCheckableInputType::handleKeydownEvent(KeyboardEvent* event)
</del><ins>+void BaseCheckableInputType::handleKeydownEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- const String& key = event->keyIdentifier();
</del><ins>+ const String& key = event.keyIdentifier();
</ins><span class="cx"> if (key == "U+0020") {
</span><span class="cx"> element().setActive(true, true);
</span><span class="cx"> // No setDefaultHandled(), because IE dispatches a keypress in this case
</span><span class="lines">@@ -70,11 +70,11 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseCheckableInputType::handleKeypressEvent(KeyboardEvent* event)
</del><ins>+void BaseCheckableInputType::handleKeypressEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- if (event->charCode() == ' ') {
</del><ins>+ if (event.charCode() == ' ') {
</ins><span class="cx"> // Prevent scrolling down the page.
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlBaseCheckableInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseCheckableInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseCheckableInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseCheckableInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -39,13 +39,13 @@
</span><span class="cx"> class BaseCheckableInputType : public InputType {
</span><span class="cx"> protected:
</span><span class="cx"> explicit BaseCheckableInputType(HTMLInputElement& element) : InputType(element) { }
</span><del>- void handleKeydownEvent(KeyboardEvent*) override;
</del><ins>+ void handleKeydownEvent(KeyboardEvent&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> FormControlState saveFormControlState() const override;
</span><span class="cx"> void restoreFormControlState(const FormControlState&) override;
</span><span class="cx"> bool appendFormData(FormDataList&, bool) const override;
</span><del>- void handleKeypressEvent(KeyboardEvent*) override;
</del><ins>+ void handleKeypressEvent(KeyboardEvent&) override;
</ins><span class="cx"> bool canSetStringValue() const override;
</span><span class="cx"> void accessKeyAction(bool sendMouseEvents) override;
</span><span class="cx"> String fallbackValue() const override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlBaseChooserOnlyDateAndTimeInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> closeDateTimeChooser();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent(Event*)
</del><ins>+void BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent(Event&)
</ins><span class="cx"> {
</span><span class="cx"> if (element().isDisabledOrReadOnly() || !element().renderer() || !ScriptController::processingUserGesture())
</span><span class="cx"> return;
</span><span class="lines">@@ -108,17 +108,17 @@
</span><span class="cx"> m_dateTimeChooser->endChooser();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseChooserOnlyDateAndTimeInputType::handleKeydownEvent(KeyboardEvent* event)
</del><ins>+void BaseChooserOnlyDateAndTimeInputType::handleKeydownEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> BaseClickableWithKeyInputType::handleKeydownEvent(element(), event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseChooserOnlyDateAndTimeInputType::handleKeypressEvent(KeyboardEvent* event)
</del><ins>+void BaseChooserOnlyDateAndTimeInputType::handleKeypressEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> BaseClickableWithKeyInputType::handleKeypressEvent(element(), event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseChooserOnlyDateAndTimeInputType::handleKeyupEvent(KeyboardEvent* event)
</del><ins>+void BaseChooserOnlyDateAndTimeInputType::handleKeyupEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> BaseClickableWithKeyInputType::handleKeyupEvent(*this, event);
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlBaseChooserOnlyDateAndTimeInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -47,10 +47,10 @@
</span><span class="cx"> void createShadowSubtree() override;
</span><span class="cx"> void detach() override;
</span><span class="cx"> void setValue(const String&, bool valueChanged, TextFieldEventBehavior) override;
</span><del>- void handleDOMActivateEvent(Event*) override;
- void handleKeydownEvent(KeyboardEvent*) override;
- void handleKeypressEvent(KeyboardEvent*) override;
- void handleKeyupEvent(KeyboardEvent*) override;
</del><ins>+ void handleDOMActivateEvent(Event&) override;
+ void handleKeydownEvent(KeyboardEvent&) override;
+ void handleKeypressEvent(KeyboardEvent&) override;
+ void handleKeyupEvent(KeyboardEvent&) override;
</ins><span class="cx"> void accessKeyAction(bool sendMouseEvents) override;
</span><span class="cx"> bool isMouseFocusable() const override;
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlBaseClickableWithKeyInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseClickableWithKeyInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseClickableWithKeyInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseClickableWithKeyInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -39,9 +39,9 @@
</span><span class="cx">
</span><span class="cx"> using namespace HTMLNames;
</span><span class="cx">
</span><del>-void BaseClickableWithKeyInputType::handleKeydownEvent(HTMLInputElement& element, KeyboardEvent* event)
</del><ins>+void BaseClickableWithKeyInputType::handleKeydownEvent(HTMLInputElement& element, KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- const String& key = event->keyIdentifier();
</del><ins>+ const String& key = event.keyIdentifier();
</ins><span class="cx"> if (key == "U+0020") {
</span><span class="cx"> element.setActive(true, true);
</span><span class="cx"> // No setDefaultHandled(), because IE dispatches a keypress in this case
</span><span class="lines">@@ -49,23 +49,23 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseClickableWithKeyInputType::handleKeypressEvent(HTMLInputElement& element, KeyboardEvent* event)
</del><ins>+void BaseClickableWithKeyInputType::handleKeypressEvent(HTMLInputElement& element, KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- int charCode = event->charCode();
</del><ins>+ int charCode = event.charCode();
</ins><span class="cx"> if (charCode == '\r') {
</span><del>- element.dispatchSimulatedClick(event);
- event->setDefaultHandled();
</del><ins>+ element.dispatchSimulatedClick(&event);
+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> if (charCode == ' ') {
</span><span class="cx"> // Prevent scrolling down the page.
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseClickableWithKeyInputType::handleKeyupEvent(InputType& inputType, KeyboardEvent* event)
</del><ins>+void BaseClickableWithKeyInputType::handleKeyupEvent(InputType& inputType, KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- const String& key = event->keyIdentifier();
</del><ins>+ const String& key = event.keyIdentifier();
</ins><span class="cx"> if (key != "U+0020")
</span><span class="cx"> return;
</span><span class="cx"> // Simulate mouse click for spacebar for button types.
</span><span class="lines">@@ -78,17 +78,17 @@
</span><span class="cx"> element.dispatchSimulatedClick(0, sendMouseEvents ? SendMouseUpDownEvents : SendNoEvents);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseClickableWithKeyInputType::handleKeydownEvent(KeyboardEvent* event)
</del><ins>+void BaseClickableWithKeyInputType::handleKeydownEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> handleKeydownEvent(element(), event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseClickableWithKeyInputType::handleKeypressEvent(KeyboardEvent* event)
</del><ins>+void BaseClickableWithKeyInputType::handleKeypressEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> handleKeypressEvent(element(), event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void BaseClickableWithKeyInputType::handleKeyupEvent(KeyboardEvent* event)
</del><ins>+void BaseClickableWithKeyInputType::handleKeyupEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> handleKeyupEvent(*this, event);
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlBaseClickableWithKeyInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseClickableWithKeyInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseClickableWithKeyInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseClickableWithKeyInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -38,9 +38,9 @@
</span><span class="cx"> // Base of input types that dispatches a simulated click on space/return key.
</span><span class="cx"> class BaseClickableWithKeyInputType : public InputType {
</span><span class="cx"> public:
</span><del>- static void handleKeydownEvent(HTMLInputElement&, KeyboardEvent*);
- static void handleKeypressEvent(HTMLInputElement&, KeyboardEvent*);
- static void handleKeyupEvent(InputType&, KeyboardEvent*);
</del><ins>+ static void handleKeydownEvent(HTMLInputElement&, KeyboardEvent&);
+ static void handleKeypressEvent(HTMLInputElement&, KeyboardEvent&);
+ static void handleKeyupEvent(InputType&, KeyboardEvent&);
</ins><span class="cx"> static void accessKeyAction(HTMLInputElement&, bool sendMouseEvents);
</span><span class="cx">
</span><span class="cx"> protected:
</span><span class="lines">@@ -47,9 +47,9 @@
</span><span class="cx"> explicit BaseClickableWithKeyInputType(HTMLInputElement& element) : InputType(element) { }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- void handleKeydownEvent(KeyboardEvent*) override;
- void handleKeypressEvent(KeyboardEvent*) override;
- void handleKeyupEvent(KeyboardEvent*) override;
</del><ins>+ void handleKeydownEvent(KeyboardEvent&) override;
+ void handleKeypressEvent(KeyboardEvent&) override;
+ void handleKeyupEvent(KeyboardEvent&) override;
</ins><span class="cx"> void accessKeyAction(bool sendMouseEvents) override;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlBaseDateAndTimeInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseDateAndTimeInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseDateAndTimeInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseDateAndTimeInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -181,7 +181,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>-bool BaseDateAndTimeInputType::isKeyboardFocusable(KeyboardEvent*) const
</del><ins>+bool BaseDateAndTimeInputType::isKeyboardFocusable(KeyboardEvent&) const
</ins><span class="cx"> {
</span><span class="cx"> return !element().isReadOnly() && element().isTextFormControlFocusable();
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlBaseDateAndTimeInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseDateAndTimeInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseDateAndTimeInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/BaseDateAndTimeInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> virtual bool setMillisecondToDateComponents(double, DateComponents*) const = 0;
</span><span class="cx"> String visibleValue() const override;
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const override;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const override;
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlCheckboxInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/CheckboxInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/CheckboxInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/CheckboxInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -54,9 +54,9 @@
</span><span class="cx"> return validationMessageValueMissingForCheckboxText();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void CheckboxInputType::handleKeyupEvent(KeyboardEvent* event)
</del><ins>+void CheckboxInputType::handleKeyupEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- const String& key = event->keyIdentifier();
</del><ins>+ const String& key = event.keyIdentifier();
</ins><span class="cx"> if (key != "U+0020")
</span><span class="cx"> return;
</span><span class="cx"> dispatchSimulatedClickIfActive(event);
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlCheckboxInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/CheckboxInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/CheckboxInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/CheckboxInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> const AtomicString& formControlType() const override;
</span><span class="cx"> bool valueMissing(const String&) const override;
</span><span class="cx"> String valueMissingText() const override;
</span><del>- void handleKeyupEvent(KeyboardEvent*) override;
</del><ins>+ void handleKeyupEvent(KeyboardEvent&) override;
</ins><span class="cx"> void willDispatchClick(InputElementClickState&) override;
</span><span class="cx"> void didDispatchClick(Event*, const InputElementClickState&) override;
</span><span class="cx"> bool isCheckbox() const override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlColorInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ColorInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ColorInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ColorInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -133,7 +133,7 @@
</span><span class="cx"> m_chooser->setSelectedColor(valueAsColor());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ColorInputType::handleDOMActivateEvent(Event* event)
</del><ins>+void ColorInputType::handleDOMActivateEvent(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> if (element().isDisabledOrReadOnly() || !element().renderer())
</span><span class="cx"> return;
</span><span class="lines">@@ -148,7 +148,7 @@
</span><span class="cx"> m_chooser->reattachColorChooser(valueAsColor());
</span><span class="cx"> }
</span><span class="cx">
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ColorInputType::detach()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlColorInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ColorInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ColorInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ColorInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> String sanitizeValue(const String&) const override;
</span><span class="cx"> void createShadowSubtree() override;
</span><span class="cx"> void setValue(const String&, bool valueChanged, TextFieldEventBehavior) override;
</span><del>- void handleDOMActivateEvent(Event*) override;
</del><ins>+ void handleDOMActivateEvent(Event&) override;
</ins><span class="cx"> void detach() override;
</span><span class="cx"> bool shouldRespectListAttribute() override;
</span><span class="cx"> bool typeMismatchFor(const String&) const override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlFileInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/FileInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/FileInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/FileInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -169,7 +169,7 @@
</span><span class="cx"> return element().multiple() ? validationMessageValueMissingForMultipleFileText() : validationMessageValueMissingForFileText();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void FileInputType::handleDOMActivateEvent(Event* event)
</del><ins>+void FileInputType::handleDOMActivateEvent(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> if (element().isDisabledFormControl())
</span><span class="cx"> return;
</span><span class="lines">@@ -192,7 +192,7 @@
</span><span class="cx"> chrome->runOpenPanel(input.document().frame(), m_fileChooser);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RenderPtr<RenderElement> FileInputType::createInputRenderer(RenderStyle&& style)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlFileInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/FileInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/FileInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/FileInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx"> bool appendFormData(FormDataList&, bool) const override;
</span><span class="cx"> bool valueMissing(const String&) const override;
</span><span class="cx"> String valueMissingText() const override;
</span><del>- void handleDOMActivateEvent(Event*) override;
</del><ins>+ void handleDOMActivateEvent(Event&) override;
</ins><span class="cx"> RenderPtr<RenderElement> createInputRenderer(RenderStyle&&) override;
</span><span class="cx"> bool canSetStringValue() const override;
</span><span class="cx"> bool canChangeFromAnotherType() const override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLAnchorElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAnchorElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAnchorElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAnchorElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -118,7 +118,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLAnchorElement::isKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool HTMLAnchorElement::isKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> if (!isLink())
</span><span class="cx"> return HTMLElement::isKeyboardFocusable(event);
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx"> if (!document().frame())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (!document().frame()->eventHandler().tabsToLinks(event))
</del><ins>+ if (!document().frame()->eventHandler().tabsToLinks(&event))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> if (!renderer() && ancestorsOfType<HTMLCanvasElement>(*this).first())
</span><span class="lines">@@ -166,16 +166,16 @@
</span><span class="cx"> url.appendNumber(std::lround(absolutePosition.y()));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLAnchorElement::defaultEventHandler(Event* event)
</del><ins>+void HTMLAnchorElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> if (isLink()) {
</span><span class="cx"> if (focused() && isEnterKeyKeydownEvent(event) && treatLinkAsLiveForEventType(NonMouseEvent)) {
</span><del>- event->setDefaultHandled();
- dispatchSimulatedClick(event);
</del><ins>+ event.setDefaultHandled();
+ dispatchSimulatedClick(&event);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (MouseEvent::canTriggerActivationBehavior(*event) && treatLinkAsLiveForEventType(eventType(event))) {
</del><ins>+ if (MouseEvent::canTriggerActivationBehavior(event) && treatLinkAsLiveForEventType(eventType(event))) {
</ins><span class="cx"> handleClick(event);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -183,10 +183,10 @@
</span><span class="cx"> if (hasEditableStyle()) {
</span><span class="cx"> // This keeps track of the editable block that the selection was in (if it was in one) just before the link was clicked
</span><span class="cx"> // for the LiveWhenNotFocused editable link behavior
</span><del>- if (event->type() == eventNames().mousedownEvent && is<MouseEvent>(*event) && downcast<MouseEvent>(*event).button() != RightButton && document().frame()) {
</del><ins>+ if (event.type() == eventNames().mousedownEvent && is<MouseEvent>(event) && downcast<MouseEvent>(event).button() != RightButton && document().frame()) {
</ins><span class="cx"> setRootEditableElementForSelectionOnMouseDown(document().frame()->selection().selection().rootEditableElement());
</span><del>- m_wasShiftKeyDownOnMouseDown = downcast<MouseEvent>(*event).shiftKey();
- } else if (event->type() == eventNames().mouseoverEvent) {
</del><ins>+ m_wasShiftKeyDownOnMouseDown = downcast<MouseEvent>(event).shiftKey();
+ } else if (event.type() == eventNames().mouseoverEvent) {
</ins><span class="cx"> // These are cleared on mouseover and not mouseout because their values are needed for drag events,
</span><span class="cx"> // but drag events happen after mouse out events.
</span><span class="cx"> clearRootEditableElementForSelectionOnMouseDown();
</span><span class="lines">@@ -352,9 +352,9 @@
</span><span class="cx"> PingLoader::sendPing(*document().frame(), document().completeURL(pingURLs[i]), destinationURL);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLAnchorElement::handleClick(Event* event)
</del><ins>+void HTMLAnchorElement::handleClick(Event& event)
</ins><span class="cx"> {
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx">
</span><span class="cx"> Frame* frame = document().frame();
</span><span class="cx"> if (!frame)
</span><span class="lines">@@ -362,7 +362,7 @@
</span><span class="cx">
</span><span class="cx"> StringBuilder url;
</span><span class="cx"> url.append(stripLeadingAndTrailingHTMLSpaces(attributeWithoutSynchronization(hrefAttr)));
</span><del>- appendServerMapMousePosition(url, *event);
</del><ins>+ appendServerMapMousePosition(url, event);
</ins><span class="cx"> URL kurl = document().completeURL(url.toString());
</span><span class="cx">
</span><span class="cx"> auto downloadAttribute = nullAtom;
</span><span class="lines">@@ -371,17 +371,16 @@
</span><span class="cx"> downloadAttribute = attributeWithoutSynchronization(downloadAttr);
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- frame->loader().urlSelected(kurl, target(), event, LockHistory::No, LockBackForwardList::No, hasRel(RelationNoReferrer) ? NeverSendReferrer : MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate(), downloadAttribute);
</del><ins>+ frame->loader().urlSelected(kurl, target(), &event, LockHistory::No, LockBackForwardList::No, hasRel(RelationNoReferrer) ? NeverSendReferrer : MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate(), downloadAttribute);
</ins><span class="cx">
</span><span class="cx"> sendPings(kurl);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-HTMLAnchorElement::EventType HTMLAnchorElement::eventType(Event* event)
</del><ins>+HTMLAnchorElement::EventType HTMLAnchorElement::eventType(Event& event)
</ins><span class="cx"> {
</span><del>- ASSERT(event);
- if (!is<MouseEvent>(*event))
</del><ins>+ if (!is<MouseEvent>(event))
</ins><span class="cx"> return NonMouseEvent;
</span><del>- return downcast<MouseEvent>(*event).shiftKey() ? MouseEventWithShiftKey : MouseEventWithoutShiftKey;
</del><ins>+ return downcast<MouseEvent>(event).shiftKey() ? MouseEventWithShiftKey : MouseEventWithoutShiftKey;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool HTMLAnchorElement::treatLinkAsLiveForEventType(EventType eventType) const
</span><span class="lines">@@ -414,9 +413,9 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool isEnterKeyKeydownEvent(Event* event)
</del><ins>+bool isEnterKeyKeydownEvent(Event& event)
</ins><span class="cx"> {
</span><del>- return event->type() == eventNames().keydownEvent && is<KeyboardEvent>(*event) && downcast<KeyboardEvent>(*event).keyIdentifier() == "Enter";
</del><ins>+ return event.type() == eventNames().keydownEvent && is<KeyboardEvent>(event) && downcast<KeyboardEvent>(event).keyIdentifier() == "Enter";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool shouldProhibitLinks(Element* element)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLAnchorElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAnchorElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAnchorElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAnchorElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -91,8 +91,8 @@
</span><span class="cx"> private:
</span><span class="cx"> bool supportsFocus() const override;
</span><span class="cx"> bool isMouseFocusable() const override;
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const override;
- void defaultEventHandler(Event*) final;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const override;
+ void defaultEventHandler(Event&) final;
</ins><span class="cx"> void setActive(bool active = true, bool pause = false) final;
</span><span class="cx"> void accessKeyAction(bool sendMouseEvents) final;
</span><span class="cx"> bool isURLAttribute(const Attribute&) const final;
</span><span class="lines">@@ -103,7 +103,7 @@
</span><span class="cx">
</span><span class="cx"> void sendPings(const URL& destinationURL);
</span><span class="cx">
</span><del>- void handleClick(Event*);
</del><ins>+ void handleClick(Event&);
</ins><span class="cx">
</span><span class="cx"> enum EventType {
</span><span class="cx"> MouseEventWithoutShiftKey,
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> MouseEventWithShiftKey,
</span><span class="cx"> NonMouseEvent,
</span><span class="cx"> };
</span><del>- static EventType eventType(Event*);
</del><ins>+ static EventType eventType(Event&);
</ins><span class="cx"> bool treatLinkAsLiveForEventType(EventType) const;
</span><span class="cx">
</span><span class="cx"> Element* rootEditableElementForSelectionOnMouseDown() const;
</span><span class="lines">@@ -134,7 +134,7 @@
</span><span class="cx">
</span><span class="cx"> // Functions shared with the other anchor elements (i.e., SVG).
</span><span class="cx">
</span><del>-bool isEnterKeyKeydownEvent(Event*);
</del><ins>+bool isEnterKeyKeydownEvent(Event&);
</ins><span class="cx"> bool shouldProhibitLinks(Element*);
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLAreaElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAreaElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAreaElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAreaElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -191,7 +191,7 @@
</span><span class="cx"> return downcast<HTMLMapElement>(*mapElement).imageElement();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLAreaElement::isKeyboardFocusable(KeyboardEvent*) const
</del><ins>+bool HTMLAreaElement::isKeyboardFocusable(KeyboardEvent&) const
</ins><span class="cx"> {
</span><span class="cx"> return isFocusable();
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLAreaElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAreaElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAreaElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLAreaElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> void parseAttribute(const QualifiedName&, const AtomicString&) final;
</span><span class="cx"> bool supportsFocus() const final;
</span><span class="cx"> String target() const final;
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const final;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const final;
</ins><span class="cx"> bool isMouseFocusable() const final;
</span><span class="cx"> bool isFocusable() const final;
</span><span class="cx"> void updateFocusAppearance(SelectionRestorationMode, SelectionRevealMode) final;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLButtonElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLButtonElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLButtonElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLButtonElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -112,23 +112,23 @@
</span><span class="cx"> HTMLFormControlElement::parseAttribute(name, value);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLButtonElement::defaultEventHandler(Event* event)
</del><ins>+void HTMLButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().DOMActivateEvent && !isDisabledFormControl()) {
</del><ins>+ if (event.type() == eventNames().DOMActivateEvent && !isDisabledFormControl()) {
</ins><span class="cx"> if (form() && m_type == SUBMIT) {
</span><span class="cx"> m_isActivatedSubmit = true;
</span><span class="cx"> form()->prepareForSubmission(event);
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> m_isActivatedSubmit = false; // Do this in case submission was canceled.
</span><span class="cx"> }
</span><span class="cx"> if (form() && m_type == RESET) {
</span><span class="cx"> form()->reset();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (is<KeyboardEvent>(*event)) {
- KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(*event);
</del><ins>+ if (is<KeyboardEvent>(event)) {
+ KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(event);
</ins><span class="cx"> if (keyboardEvent.type() == eventNames().keydownEvent && keyboardEvent.keyIdentifier() == "U+0020") {
</span><span class="cx"> setActive(true, true);
</span><span class="cx"> // No setDefaultHandled() - IE dispatches a keypress in this case.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLButtonElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLButtonElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLButtonElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLButtonElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx">
</span><span class="cx"> void parseAttribute(const QualifiedName&, const AtomicString&) final;
</span><span class="cx"> bool isPresentationAttribute(const QualifiedName&) const final;
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx">
</span><span class="cx"> bool appendFormData(FormDataList&, bool) final;
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFormControlElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormControlElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormControlElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormControlElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -368,11 +368,11 @@
</span><span class="cx"> return HTMLElement::isFocusable();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLFormControlElement::isKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool HTMLFormControlElement::isKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> if (isFocusable())
</span><span class="cx"> if (document().frame())
</span><del>- return document().frame()->eventHandler().tabsToAllFormControls(event);
</del><ins>+ return document().frame()->eventHandler().tabsToAllFormControls(&event);
</ins><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFormControlElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormControlElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormControlElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormControlElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -143,7 +143,7 @@
</span><span class="cx"> void didMoveToNewDocument(Document* oldDocument) override;
</span><span class="cx">
</span><span class="cx"> bool supportsFocus() const override;
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const override;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const override;
</ins><span class="cx"> bool isMouseFocusable() const override;
</span><span class="cx">
</span><span class="cx"> void didRecalcStyle(Style::Change) override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFormElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -180,7 +180,7 @@
</span><span class="cx"> return elements()->item(index);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLFormElement::submitImplicitly(Event* event, bool fromImplicitSubmissionTrigger)
</del><ins>+void HTMLFormElement::submitImplicitly(Event& event, bool fromImplicitSubmissionTrigger)
</ins><span class="cx"> {
</span><span class="cx"> unsigned submissionTriggerCount = 0;
</span><span class="cx"> for (auto& formAssociatedElement : m_associatedElements) {
</span><span class="lines">@@ -189,7 +189,7 @@
</span><span class="cx"> HTMLFormControlElement& formElement = downcast<HTMLFormControlElement>(*formAssociatedElement);
</span><span class="cx"> if (formElement.isSuccessfulSubmitButton()) {
</span><span class="cx"> if (formElement.renderer()) {
</span><del>- formElement.dispatchSimulatedClick(event);
</del><ins>+ formElement.dispatchSimulatedClick(&event);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> } else if (formElement.canTriggerImplicitSubmission())
</span><span class="lines">@@ -205,9 +205,9 @@
</span><span class="cx"> prepareForSubmission(event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline HTMLFormControlElement* submitElementFromEvent(const Event* event)
</del><ins>+static inline HTMLFormControlElement* submitElementFromEvent(const Event& event)
</ins><span class="cx"> {
</span><del>- for (Node* node = event->target()->toNode(); node; node = node->parentNode()) {
</del><ins>+ for (Node* node = event.target()->toNode(); node; node = node->parentNode()) {
</ins><span class="cx"> if (is<HTMLFormControlElement>(*node))
</span><span class="cx"> return downcast<HTMLFormControlElement>(node);
</span><span class="cx"> }
</span><span class="lines">@@ -214,9 +214,8 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLFormElement::validateInteractively(Event* event)
</del><ins>+bool HTMLFormElement::validateInteractively(Event& event)
</ins><span class="cx"> {
</span><del>- ASSERT(event);
</del><span class="cx"> if (!document().page() || !document().page()->settings().interactiveFormValidationEnabled() || noValidate())
</span><span class="cx"> return true;
</span><span class="cx">
</span><span class="lines">@@ -268,7 +267,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLFormElement::prepareForSubmission(Event* event)
</del><ins>+void HTMLFormElement::prepareForSubmission(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> Frame* frame = document().frame();
</span><span class="cx"> if (m_isSubmittingOrPreparingForSubmission || !frame)
</span><span class="lines">@@ -296,7 +295,7 @@
</span><span class="cx"> m_isSubmittingOrPreparingForSubmission = false;
</span><span class="cx">
</span><span class="cx"> if (m_shouldSubmit)
</span><del>- submit(event, true, true, NotSubmittedByJavaScript);
</del><ins>+ submit(&event, true, true, NotSubmittedByJavaScript);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLFormElement::submit()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFormElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFormElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> void registerImgElement(HTMLImageElement*);
</span><span class="cx"> void removeImgElement(HTMLImageElement*);
</span><span class="cx">
</span><del>- void prepareForSubmission(Event*); // FIXME: This function doesn't only prepare, it sometimes calls submit() itself.
</del><ins>+ void prepareForSubmission(Event&); // FIXME: This function doesn't only prepare, it sometimes calls submit() itself.
</ins><span class="cx"> WEBCORE_EXPORT void submit();
</span><span class="cx"> void submitFromJavaScript();
</span><span class="cx"> WEBCORE_EXPORT void reset();
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx">
</span><span class="cx"> void setDemoted(bool demoted) { m_wasDemoted = demoted; }
</span><span class="cx">
</span><del>- void submitImplicitly(Event*, bool fromImplicitSubmissionTrigger);
</del><ins>+ void submitImplicitly(Event&, bool fromImplicitSubmissionTrigger);
</ins><span class="cx"> bool formWouldHaveSecureSubmission(const String& url);
</span><span class="cx">
</span><span class="cx"> String name() const;
</span><span class="lines">@@ -162,7 +162,7 @@
</span><span class="cx"> unsigned formElementIndex(FormAssociatedElement*);
</span><span class="cx">
</span><span class="cx"> // Returns true if the submission should proceed.
</span><del>- bool validateInteractively(Event*);
</del><ins>+ bool validateInteractively(Event&);
</ins><span class="cx">
</span><span class="cx"> // Validates each of the controls, and stores controls of which 'invalid'
</span><span class="cx"> // event was not canceled to the specified vector. Returns true if there
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFrameOwnerElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameOwnerElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameOwnerElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameOwnerElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx"> m_sandboxFlags = flags;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLFrameOwnerElement::isKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool HTMLFrameOwnerElement::isKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> return m_contentFrame && HTMLElement::isKeyboardFocusable(event);
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFrameOwnerElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameOwnerElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameOwnerElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameOwnerElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> void setSandboxFlags(SandboxFlags);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const override;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const override;
</ins><span class="cx"> bool isFrameOwnerElement() const final { return true; }
</span><span class="cx">
</span><span class="cx"> Frame* m_contentFrame;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFrameSetElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameSetElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameSetElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameSetElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -189,12 +189,11 @@
</span><span class="cx"> m_noresize = containingFrameSet->noResize();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLFrameSetElement::defaultEventHandler(Event* event)
</del><ins>+void HTMLFrameSetElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- ASSERT(event);
- if (is<MouseEvent>(*event) && !m_noresize && is<RenderFrameSet>(renderer())) {
</del><ins>+ if (is<MouseEvent>(event) && !m_noresize && is<RenderFrameSet>(renderer())) {
</ins><span class="cx"> if (downcast<RenderFrameSet>(*renderer()).userResize(downcast<MouseEvent>(event))) {
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLFrameSetElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameSetElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameSetElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLFrameSetElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> bool rendererIsNeeded(const RenderStyle&) final;
</span><span class="cx"> RenderPtr<RenderElement> createElementRenderer(RenderStyle&&, const RenderTreePosition&) final;
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx">
</span><span class="cx"> bool willRecalcStyle(Style::Change) final;
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLIFrameElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLIFrameElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLIFrameElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLIFrameElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> HTMLIFrameElement(const QualifiedName&, Document&);
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const final { return false; }
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const final { return false; }
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> void parseAttribute(const QualifiedName&, const AtomicString&) final;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLInputElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLInputElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLInputElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLInputElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -372,7 +372,7 @@
</span><span class="cx"> return m_inputType->hasCustomFocusLogic();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLInputElement::isKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool HTMLInputElement::isKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> return m_inputType->isKeyboardFocusable(event);
</span><span class="cx"> }
</span><span class="lines">@@ -387,7 +387,7 @@
</span><span class="cx"> return HTMLTextFormControlElement::isFocusable();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLInputElement::isTextFormControlKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool HTMLInputElement::isTextFormControlKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> return HTMLTextFormControlElement::isKeyboardFocusable(event);
</span><span class="cx"> }
</span><span class="lines">@@ -1083,7 +1083,7 @@
</span><span class="cx">
</span><span class="cx"> void HTMLInputElement::willDispatchEvent(Event& event, InputElementClickState& state)
</span><span class="cx"> {
</span><del>- if (event.type() == eventNames().textInputEvent && m_inputType->shouldSubmitImplicitly(&event))
</del><ins>+ if (event.type() == eventNames().textInputEvent && m_inputType->shouldSubmitImplicitly(event))
</ins><span class="cx"> event.stopPropagation();
</span><span class="cx"> if (event.type() == eventNames().clickEvent && is<MouseEvent>(event) && downcast<MouseEvent>(event).button() == LeftButton) {
</span><span class="cx"> m_inputType->willDispatchClick(state);
</span><span class="lines">@@ -1096,35 +1096,34 @@
</span><span class="cx"> m_inputType->didDispatchClick(&event, state);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLInputElement::defaultEventHandler(Event* evt)
</del><ins>+void HTMLInputElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- ASSERT(evt);
- if (is<MouseEvent>(*evt) && evt->type() == eventNames().clickEvent && downcast<MouseEvent>(*evt).button() == LeftButton) {
- m_inputType->handleClickEvent(downcast<MouseEvent>(evt));
- if (evt->defaultHandled())
</del><ins>+ if (is<MouseEvent>(event) && event.type() == eventNames().clickEvent && downcast<MouseEvent>(event).button() == LeftButton) {
+ m_inputType->handleClickEvent(downcast<MouseEvent>(event));
+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><del>- if (is<TouchEvent>(*evt)) {
- m_inputType->handleTouchEvent(downcast<TouchEvent>(evt));
- if (evt->defaultHandled())
</del><ins>+ if (is<TouchEvent>(event)) {
+ m_inputType->handleTouchEvent(downcast<TouchEvent>(event));
+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- if (is<KeyboardEvent>(*evt) && evt->type() == eventNames().keydownEvent) {
- m_inputType->handleKeydownEvent(downcast<KeyboardEvent>(evt));
- if (evt->defaultHandled())
</del><ins>+ if (is<KeyboardEvent>(event) && event.type() == eventNames().keydownEvent) {
+ m_inputType->handleKeydownEvent(downcast<KeyboardEvent>(event));
+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Call the base event handler before any of our own event handling for almost all events in text fields.
</span><span class="cx"> // Makes editing keyboard handling take precedence over the keydown and keypress handling in this function.
</span><del>- bool callBaseClassEarly = isTextField() && (evt->type() == eventNames().keydownEvent || evt->type() == eventNames().keypressEvent);
</del><ins>+ bool callBaseClassEarly = isTextField() && (event.type() == eventNames().keydownEvent || event.type() == eventNames().keypressEvent);
</ins><span class="cx"> if (callBaseClassEarly) {
</span><del>- HTMLTextFormControlElement::defaultEventHandler(evt);
- if (evt->defaultHandled())
</del><ins>+ HTMLTextFormControlElement::defaultEventHandler(event);
+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1132,28 +1131,28 @@
</span><span class="cx"> // actually submitting the form. For reset inputs, the form is reset. These events are sent when the user clicks
</span><span class="cx"> // on the element, or presses enter while it is the active element. JavaScript code wishing to activate the element
</span><span class="cx"> // must dispatch a DOMActivate event - a click event will not do the job.
</span><del>- if (evt->type() == eventNames().DOMActivateEvent) {
- m_inputType->handleDOMActivateEvent(evt);
- if (evt->defaultHandled())
</del><ins>+ if (event.type() == eventNames().DOMActivateEvent) {
+ m_inputType->handleDOMActivateEvent(event);
+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Use key press event here since sending simulated mouse events
</span><span class="cx"> // on key down blocks the proper sending of the key press event.
</span><del>- if (is<KeyboardEvent>(*evt)) {
- KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(*evt);
</del><ins>+ if (is<KeyboardEvent>(event)) {
+ KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(event);
</ins><span class="cx"> if (keyboardEvent.type() == eventNames().keypressEvent) {
</span><del>- m_inputType->handleKeypressEvent(&keyboardEvent);
</del><ins>+ m_inputType->handleKeypressEvent(keyboardEvent);
</ins><span class="cx"> if (keyboardEvent.defaultHandled())
</span><span class="cx"> return;
</span><span class="cx"> } else if (keyboardEvent.type() == eventNames().keyupEvent) {
</span><del>- m_inputType->handleKeyupEvent(&keyboardEvent);
</del><ins>+ m_inputType->handleKeyupEvent(keyboardEvent);
</ins><span class="cx"> if (keyboardEvent.defaultHandled())
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (m_inputType->shouldSubmitImplicitly(evt)) {
</del><ins>+ if (m_inputType->shouldSubmitImplicitly(event)) {
</ins><span class="cx"> if (isSearchField()) {
</span><span class="cx"> addSearchResult();
</span><span class="cx"> onSearch();
</span><span class="lines">@@ -1166,25 +1165,25 @@
</span><span class="cx"> RefPtr<HTMLFormElement> formForSubmission = m_inputType->formForSubmission();
</span><span class="cx"> // Form may never have been present, or may have been destroyed by code responding to the change event.
</span><span class="cx"> if (formForSubmission)
</span><del>- formForSubmission->submitImplicitly(evt, canTriggerImplicitSubmission());
</del><ins>+ formForSubmission->submitImplicitly(event, canTriggerImplicitSubmission());
</ins><span class="cx">
</span><del>- evt->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (is<BeforeTextInsertedEvent>(*evt))
- m_inputType->handleBeforeTextInsertedEvent(downcast<BeforeTextInsertedEvent>(evt));
</del><ins>+ if (is<BeforeTextInsertedEvent>(event))
+ m_inputType->handleBeforeTextInsertedEvent(downcast<BeforeTextInsertedEvent>(event));
</ins><span class="cx">
</span><del>- if (is<MouseEvent>(*evt) && evt->type() == eventNames().mousedownEvent) {
- m_inputType->handleMouseDownEvent(downcast<MouseEvent>(evt));
- if (evt->defaultHandled())
</del><ins>+ if (is<MouseEvent>(event) && event.type() == eventNames().mousedownEvent) {
+ m_inputType->handleMouseDownEvent(downcast<MouseEvent>(event));
+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- m_inputType->forwardEvent(evt);
</del><ins>+ m_inputType->forwardEvent(event);
</ins><span class="cx">
</span><del>- if (!callBaseClassEarly && !evt->defaultHandled())
- HTMLTextFormControlElement::defaultEventHandler(evt);
</del><ins>+ if (!callBaseClassEarly && !event.defaultHandled())
+ HTMLTextFormControlElement::defaultEventHandler(event);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool HTMLInputElement::willRespondToMouseClickEvents()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLInputElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLInputElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLInputElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLInputElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -284,7 +284,7 @@
</span><span class="cx"> // Functions for InputType classes.
</span><span class="cx"> void setValueInternal(const String&, TextFieldEventBehavior);
</span><span class="cx"> bool isTextFormControlFocusable() const;
</span><del>- bool isTextFormControlKeyboardFocusable(KeyboardEvent*) const;
</del><ins>+ bool isTextFormControlKeyboardFocusable(KeyboardEvent&) const;
</ins><span class="cx"> bool isTextFormControlMouseFocusable() const;
</span><span class="cx"> bool valueAttributeWasUpdatedAfterParsing() const { return m_valueAttributeWasUpdatedAfterParsing; }
</span><span class="cx">
</span><span class="lines">@@ -335,7 +335,7 @@
</span><span class="cx"> protected:
</span><span class="cx"> HTMLInputElement(const QualifiedName&, Document&, HTMLFormElement*, bool createdByParser);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> enum AutoCompleteSetting { Uninitialized, On, Off };
</span><span class="lines">@@ -350,7 +350,7 @@
</span><span class="cx"> void didMoveToNewDocument(Document* oldDocument) final;
</span><span class="cx">
</span><span class="cx"> bool hasCustomFocusLogic() const final;
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const final;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const final;
</ins><span class="cx"> bool isMouseFocusable() const final;
</span><span class="cx"> bool isEnumeratable() const final;
</span><span class="cx"> bool supportLabels() const final;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLLabelElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLabelElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLabelElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLabelElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -110,22 +110,22 @@
</span><span class="cx"> element->setHovered(over);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLLabelElement::defaultEventHandler(Event* evt)
</del><ins>+void HTMLLabelElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> static bool processingClick = false;
</span><span class="cx">
</span><del>- if (evt->type() == eventNames().clickEvent && !processingClick) {
</del><ins>+ if (event.type() == eventNames().clickEvent && !processingClick) {
</ins><span class="cx"> RefPtr<LabelableElement> element = control();
</span><span class="cx">
</span><span class="cx"> // If we can't find a control or if the control received the click
</span><span class="cx"> // event, then there's no need for us to do anything.
</span><del>- if (!element || (evt->target() && element->containsIncludingShadowDOM(evt->target()->toNode())))
</del><ins>+ if (!element || (event.target() && element->containsIncludingShadowDOM(event.target()->toNode())))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> processingClick = true;
</span><span class="cx">
</span><span class="cx"> // Click the corresponding control.
</span><del>- element->dispatchSimulatedClick(evt);
</del><ins>+ element->dispatchSimulatedClick(&event);
</ins><span class="cx">
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx"> if (element->isMouseFocusable())
</span><span class="lines">@@ -133,10 +133,10 @@
</span><span class="cx">
</span><span class="cx"> processingClick = false;
</span><span class="cx">
</span><del>- evt->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- HTMLElement::defaultEventHandler(evt);
</del><ins>+ HTMLElement::defaultEventHandler(event);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool HTMLLabelElement::willRespondToMouseClickEvents()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLLabelElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLabelElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLabelElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLabelElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> void setHovered(bool = true) final;
</span><span class="cx">
</span><span class="cx"> // Overridden to either click() or focus() the corresponding control.
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx">
</span><span class="cx"> void focus(bool restorePreviousSelection, FocusDirection) final;
</span><span class="cx"> };
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLLinkElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLinkElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLinkElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLinkElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -454,11 +454,10 @@
</span><span class="cx"> return attribute.name().localName() == hrefAttr || HTMLElement::isURLAttribute(attribute);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLLinkElement::defaultEventHandler(Event* event)
</del><ins>+void HTMLLinkElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- ASSERT(event);
- if (MouseEvent::canTriggerActivationBehavior(*event)) {
- handleClick(*event);
</del><ins>+ if (MouseEvent::canTriggerActivationBehavior(event)) {
+ handleClick(event);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> HTMLElement::defaultEventHandler(event);
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLLinkElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLinkElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLinkElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLLinkElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -97,7 +97,7 @@
</span><span class="cx">
</span><span class="cx"> bool isURLAttribute(const Attribute&) const final;
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx"> void handleClick(Event&);
</span><span class="cx">
</span><span class="cx"> HTMLLinkElement(const QualifiedName&, Document&, bool createdByParser);
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLPlugInElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -180,7 +180,7 @@
</span><span class="cx"> HTMLFrameOwnerElement::collectStyleForPresentationAttribute(name, value, style);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLPlugInElement::defaultEventHandler(Event* event)
</del><ins>+void HTMLPlugInElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> // Firefox seems to use a fake event listener to dispatch events to plug-in (tested with mouse events only).
</span><span class="cx"> // This is observable via different order of events - in Firefox, event listeners specified in HTML attributes fires first, then an event
</span><span class="lines">@@ -194,12 +194,12 @@
</span><span class="cx">
</span><span class="cx"> if (is<RenderEmbeddedObject>(*renderer)) {
</span><span class="cx"> if (downcast<RenderEmbeddedObject>(*renderer).isPluginUnavailable()) {
</span><del>- downcast<RenderEmbeddedObject>(*renderer).handleUnavailablePluginIndicatorEvent(event);
</del><ins>+ downcast<RenderEmbeddedObject>(*renderer).handleUnavailablePluginIndicatorEvent(&event);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (is<RenderSnapshottedPlugIn>(*renderer) && displayState() < Restarting) {
</span><del>- downcast<RenderSnapshottedPlugIn>(*renderer).handleEvent(event);
</del><ins>+ downcast<RenderSnapshottedPlugIn>(*renderer).handleEvent(&event);
</ins><span class="cx"> HTMLFrameOwnerElement::defaultEventHandler(event);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -213,14 +213,14 @@
</span><span class="cx"> RefPtr<Widget> widget = downcast<RenderWidget>(*renderer).widget();
</span><span class="cx"> if (!widget)
</span><span class="cx"> return;
</span><del>- widget->handleEvent(event);
- if (event->defaultHandled())
</del><ins>+ widget->handleEvent(&event);
+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> HTMLFrameOwnerElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLPlugInElement::isKeyboardFocusable(KeyboardEvent*) const
</del><ins>+bool HTMLPlugInElement::isKeyboardFocusable(KeyboardEvent&) const
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: Why is this check needed?
</span><span class="cx"> if (!document().page())
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLPlugInElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx">
</span><span class="cx"> virtual bool useFallbackContent() const { return false; }
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> virtual bool requestObject(const String& url, const String& mimeType, const Vector<String>& paramNames, const Vector<String>& paramValues);
</span><span class="cx"> RenderPtr<RenderElement> createElementRenderer(RenderStyle&&, const RenderTreePosition&) override;
</span><span class="lines">@@ -114,7 +114,7 @@
</span><span class="cx">
</span><span class="cx"> bool supportsFocus() const override;
</span><span class="cx">
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const override;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const override;
</ins><span class="cx"> bool isPluginElement() const final;
</span><span class="cx">
</span><span class="cx"> RefPtr<JSC::Bindings::Instance> m_instance;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLPlugInImageElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInImageElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInImageElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInImageElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -755,12 +755,12 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLPlugInImageElement::defaultEventHandler(Event* event)
</del><ins>+void HTMLPlugInImageElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> RenderElement* r = renderer();
</span><span class="cx"> if (r && r->isEmbeddedObject()) {
</span><del>- if (displayState() == WaitingForSnapshot && is<MouseEvent>(*event) && event->type() == eventNames().clickEvent) {
- MouseEvent& mouseEvent = downcast<MouseEvent>(*event);
</del><ins>+ if (displayState() == WaitingForSnapshot && is<MouseEvent>(event) && event.type() == eventNames().clickEvent) {
+ MouseEvent& mouseEvent = downcast<MouseEvent>(event);
</ins><span class="cx"> if (mouseEvent.button() == LeftButton) {
</span><span class="cx"> userDidClickSnapshot(&mouseEvent, true);
</span><span class="cx"> mouseEvent.setDefaultHandled();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLPlugInImageElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInImageElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInImageElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLPlugInImageElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -125,7 +125,7 @@
</span><span class="cx"> void prepareForDocumentSuspension() final;
</span><span class="cx"> void resumeFromDocumentSuspension() final;
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx"> void dispatchPendingMouseClick() final;
</span><span class="cx">
</span><span class="cx"> void updateSnapshot(PassRefPtr<Image>) final;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSelectElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSelectElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSelectElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -316,7 +316,7 @@
</span><span class="cx"> HTMLFormControlElementWithState::parseAttribute(name, value);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLSelectElement::isKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool HTMLSelectElement::isKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> if (renderer())
</span><span class="cx"> return isFocusable();
</span><span class="lines">@@ -1113,7 +1113,7 @@
</span><span class="cx">
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void HTMLSelectElement::menuListDefaultEventHandler(Event* event)
</del><ins>+void HTMLSelectElement::menuListDefaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(renderer());
</span><span class="cx"> ASSERT(renderer()->isMenuList());
</span><span class="lines">@@ -1121,11 +1121,11 @@
</span><span class="cx"> const Page* page = document().page();
</span><span class="cx"> RefPtr<RenderTheme> renderTheme = page ? &page->theme() : RenderTheme::defaultTheme();
</span><span class="cx">
</span><del>- if (event->type() == eventNames().keydownEvent) {
- if (!is<KeyboardEvent>(*event))
</del><ins>+ if (event.type() == eventNames().keydownEvent) {
+ if (!is<KeyboardEvent>(event))
</ins><span class="cx"> return;
</span><span class="cx">
</span><del>- KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(*event);
</del><ins>+ KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(event);
</ins><span class="cx"> if (platformHandleKeydownEvent(&keyboardEvent))
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -1174,11 +1174,11 @@
</span><span class="cx">
</span><span class="cx"> // Use key press event here since sending simulated mouse events
</span><span class="cx"> // on key down blocks the proper sending of the key press event.
</span><del>- if (event->type() == eventNames().keypressEvent) {
- if (!is<KeyboardEvent>(*event))
</del><ins>+ if (event.type() == eventNames().keypressEvent) {
+ if (!is<KeyboardEvent>(event))
</ins><span class="cx"> return;
</span><span class="cx">
</span><del>- KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(*event);
</del><ins>+ KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(event);
</ins><span class="cx"> int keyCode = keyboardEvent.keyCode();
</span><span class="cx"> bool handled = false;
</span><span class="cx">
</span><span class="lines">@@ -1224,7 +1224,7 @@
</span><span class="cx"> handled = true;
</span><span class="cx"> } else if (keyCode == '\r') {
</span><span class="cx"> if (form())
</span><del>- form()->submitImplicitly(&keyboardEvent, false);
</del><ins>+ form()->submitImplicitly(keyboardEvent, false);
</ins><span class="cx"> dispatchChangeEventForMenuList();
</span><span class="cx"> handled = true;
</span><span class="cx"> }
</span><span class="lines">@@ -1234,7 +1234,7 @@
</span><span class="cx"> keyboardEvent.setDefaultHandled();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mousedownEvent && is<MouseEvent>(*event) && downcast<MouseEvent>(*event).button() == LeftButton) {
</del><ins>+ if (event.type() == eventNames().mousedownEvent && is<MouseEvent>(event) && downcast<MouseEvent>(event).button() == LeftButton) {
</ins><span class="cx"> focus();
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> auto* renderer = this->renderer();
</span><span class="lines">@@ -1250,11 +1250,11 @@
</span><span class="cx"> menuList.showPopup();
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if !PLATFORM(IOS)
</span><del>- if (event->type() == eventNames().blurEvent && !focused()) {
</del><ins>+ if (event.type() == eventNames().blurEvent && !focused()) {
</ins><span class="cx"> auto& menuList = downcast<RenderMenuList>(*renderer());
</span><span class="cx"> if (menuList.popupIsVisible())
</span><span class="cx"> menuList.hidePopup();
</span><span class="lines">@@ -1314,11 +1314,11 @@
</span><span class="cx"> updateListBoxSelection(!multiSelect);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLSelectElement::listBoxDefaultEventHandler(Event* event)
</del><ins>+void HTMLSelectElement::listBoxDefaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> auto& listItems = this->listItems();
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mousedownEvent && is<MouseEvent>(*event) && downcast<MouseEvent>(*event).button() == LeftButton) {
</del><ins>+ if (event.type() == eventNames().mousedownEvent && is<MouseEvent>(event) && downcast<MouseEvent>(event).button() == LeftButton) {
</ins><span class="cx"> focus();
</span><span class="cx">
</span><span class="cx"> // Calling focus() may remove or change our renderer, in which case we don't want to handle the event further.
</span><span class="lines">@@ -1328,7 +1328,7 @@
</span><span class="cx"> auto& renderListBox = downcast<RenderListBox>(*renderer);
</span><span class="cx">
</span><span class="cx"> // Convert to coords relative to the list box if needed.
</span><del>- MouseEvent& mouseEvent = downcast<MouseEvent>(*event);
</del><ins>+ MouseEvent& mouseEvent = downcast<MouseEvent>(event);
</ins><span class="cx"> IntPoint localOffset = roundedIntPoint(renderListBox.absoluteToLocal(mouseEvent.absoluteLocation(), UseTransforms));
</span><span class="cx"> int listIndex = renderListBox.listIndexAtOffset(toIntSize(localOffset));
</span><span class="cx"> if (listIndex >= 0) {
</span><span class="lines">@@ -1344,8 +1344,8 @@
</span><span class="cx">
</span><span class="cx"> mouseEvent.setDefaultHandled();
</span><span class="cx"> }
</span><del>- } else if (event->type() == eventNames().mousemoveEvent && is<MouseEvent>(*event) && !downcast<RenderListBox>(*renderer()).canBeScrolledAndHasScrollableArea()) {
- MouseEvent& mouseEvent = downcast<MouseEvent>(*event);
</del><ins>+ } else if (event.type() == eventNames().mousemoveEvent && is<MouseEvent>(event) && !downcast<RenderListBox>(*renderer()).canBeScrolledAndHasScrollableArea()) {
+ MouseEvent& mouseEvent = downcast<MouseEvent>(event);
</ins><span class="cx"> if (mouseEvent.button() != LeftButton || !mouseEvent.buttonDown())
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -1369,7 +1369,7 @@
</span><span class="cx"> }
</span><span class="cx"> mouseEvent.setDefaultHandled();
</span><span class="cx"> }
</span><del>- } else if (event->type() == eventNames().mouseupEvent && is<MouseEvent>(*event) && downcast<MouseEvent>(*event).button() == LeftButton && document().frame()->eventHandler().autoscrollRenderer() != renderer()) {
</del><ins>+ } else if (event.type() == eventNames().mouseupEvent && is<MouseEvent>(event) && downcast<MouseEvent>(event).button() == LeftButton && document().frame()->eventHandler().autoscrollRenderer() != renderer()) {
</ins><span class="cx"> // This click or drag event was not over any of the options.
</span><span class="cx"> if (m_lastOnChangeSelection.isEmpty())
</span><span class="cx"> return;
</span><span class="lines">@@ -1377,11 +1377,11 @@
</span><span class="cx"> // click. For drag selection, onChange will fire when the autoscroll
</span><span class="cx"> // timer stops.
</span><span class="cx"> listBoxOnChange();
</span><del>- } else if (event->type() == eventNames().keydownEvent) {
- if (!is<KeyboardEvent>(*event))
</del><ins>+ } else if (event.type() == eventNames().keydownEvent) {
+ if (!is<KeyboardEvent>(event))
</ins><span class="cx"> return;
</span><span class="cx">
</span><del>- KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(*event);
</del><ins>+ KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(event);
</ins><span class="cx"> const String& keyIdentifier = keyboardEvent.keyIdentifier();
</span><span class="cx">
</span><span class="cx"> bool handled = false;
</span><span class="lines">@@ -1468,15 +1468,15 @@
</span><span class="cx">
</span><span class="cx"> keyboardEvent.setDefaultHandled();
</span><span class="cx"> }
</span><del>- } else if (event->type() == eventNames().keypressEvent) {
- if (!is<KeyboardEvent>(*event))
</del><ins>+ } else if (event.type() == eventNames().keypressEvent) {
+ if (!is<KeyboardEvent>(event))
</ins><span class="cx"> return;
</span><del>- KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(*event);
</del><ins>+ KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(event);
</ins><span class="cx"> int keyCode = keyboardEvent.keyCode();
</span><span class="cx">
</span><span class="cx"> if (keyCode == '\r') {
</span><span class="cx"> if (form())
</span><del>- form()->submitImplicitly(&keyboardEvent, false);
</del><ins>+ form()->submitImplicitly(keyboardEvent, false);
</ins><span class="cx"> keyboardEvent.setDefaultHandled();
</span><span class="cx"> } else if (m_multiple && keyCode == ' ' && m_allowsNonContiguousSelection) {
</span><span class="cx"> // Use space to toggle selection change.
</span><span class="lines">@@ -1491,7 +1491,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLSelectElement::defaultEventHandler(Event* event)
</del><ins>+void HTMLSelectElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> auto* renderer = this->renderer();
</span><span class="cx"> if (!renderer)
</span><span class="lines">@@ -1510,14 +1510,14 @@
</span><span class="cx"> #else
</span><span class="cx"> menuListDefaultEventHandler(event);
</span><span class="cx"> #endif
</span><del>- if (event->defaultHandled())
</del><ins>+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><span class="cx">
</span><del>- if (event->type() == eventNames().keypressEvent && is<KeyboardEvent>(*event)) {
- KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(*event);
</del><ins>+ if (event.type() == eventNames().keypressEvent && is<KeyboardEvent>(event)) {
+ KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(event);
</ins><span class="cx"> if (!keyboardEvent.ctrlKey() && !keyboardEvent.altKey() && !keyboardEvent.metaKey() && u_isprint(keyboardEvent.charCode())) {
</span><span class="cx"> typeAheadFind(keyboardEvent);
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLSelectElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSelectElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSelectElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSelectElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> private:
</span><span class="cx"> const AtomicString& formControlType() const final;
</span><span class="cx">
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const final;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const final;
</ins><span class="cx"> bool isMouseFocusable() const final;
</span><span class="cx">
</span><span class="cx"> void dispatchFocusEvent(RefPtr<Element>&& oldFocusedElement, FocusDirection) final;
</span><span class="lines">@@ -133,7 +133,7 @@
</span><span class="cx">
</span><span class="cx"> void reset() final;
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx"> bool willRespondToMouseClickEvents() final;
</span><span class="cx">
</span><span class="cx"> void dispatchChangeEventForMenuList();
</span><span class="lines">@@ -164,9 +164,9 @@
</span><span class="cx"> void parseMultipleAttribute(const AtomicString&);
</span><span class="cx"> int lastSelectedListIndex() const;
</span><span class="cx"> void updateSelectedState(int listIndex, bool multi, bool shift);
</span><del>- void menuListDefaultEventHandler(Event*);
</del><ins>+ void menuListDefaultEventHandler(Event&);
</ins><span class="cx"> bool platformHandleKeydownEvent(KeyboardEvent*);
</span><del>- void listBoxDefaultEventHandler(Event*);
</del><ins>+ void listBoxDefaultEventHandler(Event&);
</ins><span class="cx"> void setOptionsChangedOnRenderer();
</span><span class="cx"> size_t searchOptionsForValue(const String&, size_t listIndexStart, size_t listIndexEnd) const;
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLSummaryElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSummaryElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSummaryElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSummaryElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -98,18 +98,18 @@
</span><span class="cx"> return isActiveSummary();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLSummaryElement::defaultEventHandler(Event* event)
</del><ins>+void HTMLSummaryElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> if (isActiveSummary() && renderer()) {
</span><del>- if (event->type() == eventNames().DOMActivateEvent && !isClickableControl(event->target()->toNode())) {
</del><ins>+ if (event.type() == eventNames().DOMActivateEvent && !isClickableControl(event.target()->toNode())) {
</ins><span class="cx"> if (HTMLDetailsElement* details = detailsElement())
</span><span class="cx"> details->toggleOpen();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (is<KeyboardEvent>(*event)) {
- KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(*event);
</del><ins>+ if (is<KeyboardEvent>(event)) {
+ KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(event);
</ins><span class="cx"> if (keyboardEvent.type() == eventNames().keydownEvent && keyboardEvent.keyIdentifier() == "U+0020") {
</span><span class="cx"> setActive(true, true);
</span><span class="cx"> // No setDefaultHandled() - IE dispatches a keypress in this case.
</span><span class="lines">@@ -118,7 +118,7 @@
</span><span class="cx"> if (keyboardEvent.type() == eventNames().keypressEvent) {
</span><span class="cx"> switch (keyboardEvent.charCode()) {
</span><span class="cx"> case '\r':
</span><del>- dispatchSimulatedClick(event);
</del><ins>+ dispatchSimulatedClick(&event);
</ins><span class="cx"> keyboardEvent.setDefaultHandled();
</span><span class="cx"> return;
</span><span class="cx"> case ' ':
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx"> }
</span><span class="cx"> if (keyboardEvent.type() == eventNames().keyupEvent && keyboardEvent.keyIdentifier() == "U+0020") {
</span><span class="cx"> if (active())
</span><del>- dispatchSimulatedClick(event);
</del><ins>+ dispatchSimulatedClick(&event);
</ins><span class="cx"> keyboardEvent.setDefaultHandled();
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLSummaryElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSummaryElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSummaryElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLSummaryElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> HTMLSummaryElement(const QualifiedName&, Document&);
</span><span class="cx">
</span><span class="cx"> RenderPtr<RenderElement> createElementRenderer(RenderStyle&&, const RenderTreePosition&) final;
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx">
</span><span class="cx"> void didAddUserAgentShadowRoot(ShadowRoot*) final;
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLTextAreaElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextAreaElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextAreaElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextAreaElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -238,7 +238,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool HTMLTextAreaElement::isKeyboardFocusable(KeyboardEvent*) const
</del><ins>+bool HTMLTextAreaElement::isKeyboardFocusable(KeyboardEvent&) const
</ins><span class="cx"> {
</span><span class="cx"> // If a given text area can be focused at all, then it will always be keyboard focusable.
</span><span class="cx"> return isFocusable();
</span><span class="lines">@@ -263,11 +263,11 @@
</span><span class="cx"> document().frame()->selection().revealSelection(revealMode);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLTextAreaElement::defaultEventHandler(Event* event)
</del><ins>+void HTMLTextAreaElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (renderer() && (event->isMouseEvent() || event->type() == eventNames().blurEvent))
</del><ins>+ if (renderer() && (event.isMouseEvent() || event.type() == eventNames().blurEvent))
</ins><span class="cx"> forwardEvent(event);
</span><del>- else if (renderer() && is<BeforeTextInsertedEvent>(*event))
</del><ins>+ else if (renderer() && is<BeforeTextInsertedEvent>(event))
</ins><span class="cx"> handleBeforeTextInsertedEvent(downcast<BeforeTextInsertedEvent>(event));
</span><span class="cx">
</span><span class="cx"> HTMLTextFormControlElement::defaultEventHandler(event);
</span><span class="lines">@@ -288,9 +288,8 @@
</span><span class="cx"> calculateAndAdjustDirectionality();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLTextAreaElement::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent* event) const
</del><ins>+void HTMLTextAreaElement::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent& event) const
</ins><span class="cx"> {
</span><del>- ASSERT(event);
</del><span class="cx"> ASSERT(renderer());
</span><span class="cx"> int signedMaxLength = effectiveMaxLength();
</span><span class="cx"> if (signedMaxLength < 0)
</span><span class="lines">@@ -300,7 +299,7 @@
</span><span class="cx"> const String& currentValue = innerTextValue();
</span><span class="cx"> unsigned numberOfLineBreaksInCurrentValue = numberOfLineBreaks(currentValue);
</span><span class="cx"> if (upperBoundForLengthForSubmission(currentValue, numberOfLineBreaksInCurrentValue)
</span><del>- + upperBoundForLengthForSubmission(event->text(), numberOfLineBreaks(event->text())) < unsignedMaxLength)
</del><ins>+ + upperBoundForLengthForSubmission(event.text(), numberOfLineBreaks(event.text())) < unsignedMaxLength)
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> unsigned currentLength = computeLengthForSubmission(currentValue, numberOfLineBreaksInCurrentValue);
</span><span class="lines">@@ -313,7 +312,7 @@
</span><span class="cx"> ASSERT(currentLength >= selectionLength);
</span><span class="cx"> unsigned baseLength = currentLength - selectionLength;
</span><span class="cx"> unsigned appendableLength = unsignedMaxLength > baseLength ? unsignedMaxLength - baseLength : 0;
</span><del>- event->setText(sanitizeUserInputValue(event->text(), appendableLength));
</del><ins>+ event.setText(sanitizeUserInputValue(event.text(), appendableLength));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String HTMLTextAreaElement::sanitizeUserInputValue(const String& proposedValue, unsigned maxLength)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLTextAreaElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextAreaElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextAreaElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextAreaElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx">
</span><span class="cx"> void maxLengthAttributeChanged(const AtomicString& newValue);
</span><span class="cx">
</span><del>- void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*) const;
</del><ins>+ void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent&) const;
</ins><span class="cx"> static String sanitizeUserInputValue(const String&, unsigned maxLength);
</span><span class="cx"> void updateValue() const;
</span><span class="cx"> void setNonDirtyValue(const String&);
</span><span class="lines">@@ -88,7 +88,7 @@
</span><span class="cx"> bool isOptionalFormControl() const final { return !isRequiredFormControl(); }
</span><span class="cx"> bool isRequiredFormControl() const final { return isRequired(); }
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx">
</span><span class="cx"> void subtreeHasChanged() final;
</span><span class="cx">
</span><span class="lines">@@ -111,7 +111,7 @@
</span><span class="cx"> void reset() final;
</span><span class="cx"> bool hasCustomFocusLogic() const final;
</span><span class="cx"> bool isMouseFocusable() const final;
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const final;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const final;
</ins><span class="cx"> void updateFocusAppearance(SelectionRestorationMode, SelectionRevealMode) final;
</span><span class="cx">
</span><span class="cx"> void accessKeyAction(bool sendMouseEvents) final;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLTextFormControlElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextFormControlElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextFormControlElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextFormControlElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -116,9 +116,9 @@
</span><span class="cx"> subtreeHasChanged();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLTextFormControlElement::forwardEvent(Event* event)
</del><ins>+void HTMLTextFormControlElement::forwardEvent(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().blurEvent || event->type() == eventNames().focusEvent)
</del><ins>+ if (event.type() == eventNames().blurEvent || event.type() == eventNames().focusEvent)
</ins><span class="cx"> return;
</span><span class="cx"> innerTextElement()->defaultEventHandler(event);
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlHTMLTextFormControlElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextFormControlElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextFormControlElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/HTMLTextFormControlElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> virtual ~HTMLTextFormControlElement();
</span><span class="cx">
</span><span class="cx"> void didEditInnerTextValue();
</span><del>- void forwardEvent(Event*);
</del><ins>+ void forwardEvent(Event&);
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT void setMaxLengthForBindings(int, ExceptionCode&);
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlImageInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ImageInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ImageInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ImageInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -80,7 +80,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ImageInputType::handleDOMActivateEvent(Event* event)
</del><ins>+void ImageInputType::handleDOMActivateEvent(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> Ref<HTMLInputElement> element(this->element());
</span><span class="cx"> if (element->isDisabledFormControl() || !element->form())
</span><span class="lines">@@ -88,8 +88,8 @@
</span><span class="cx"> element->setActivatedSubmit(true);
</span><span class="cx">
</span><span class="cx"> m_clickLocation = IntPoint();
</span><del>- if (event->underlyingEvent()) {
- Event& underlyingEvent = *event->underlyingEvent();
</del><ins>+ if (event.underlyingEvent()) {
+ Event& underlyingEvent = *event.underlyingEvent();
</ins><span class="cx"> if (is<MouseEvent>(underlyingEvent)) {
</span><span class="cx"> MouseEvent& mouseEvent = downcast<MouseEvent>(underlyingEvent);
</span><span class="cx"> if (!mouseEvent.isSimulated())
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx">
</span><span class="cx"> element->form()->prepareForSubmission(event); // Event handlers can run.
</span><span class="cx"> element->setActivatedSubmit(false);
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RenderPtr<RenderElement> ImageInputType::createInputRenderer(RenderStyle&& style)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlImageInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ImageInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ImageInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ImageInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> bool appendFormData(FormDataList&, bool) const override;
</span><span class="cx"> bool supportsValidation() const override;
</span><span class="cx"> RenderPtr<RenderElement> createInputRenderer(RenderStyle&&) override;
</span><del>- void handleDOMActivateEvent(Event*) override;
</del><ins>+ void handleDOMActivateEvent(Event&) override;
</ins><span class="cx"> void altAttributeChanged() override;
</span><span class="cx"> void srcAttributeChanged() override;
</span><span class="cx"> void attach() override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/InputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/InputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/InputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -438,47 +438,47 @@
</span><span class="cx"> return emptyString();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InputType::handleClickEvent(MouseEvent*)
</del><ins>+void InputType::handleClickEvent(MouseEvent&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InputType::handleMouseDownEvent(MouseEvent*)
</del><ins>+void InputType::handleMouseDownEvent(MouseEvent&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InputType::handleDOMActivateEvent(Event*)
</del><ins>+void InputType::handleDOMActivateEvent(Event&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InputType::handleKeydownEvent(KeyboardEvent*)
</del><ins>+void InputType::handleKeydownEvent(KeyboardEvent&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InputType::handleKeypressEvent(KeyboardEvent*)
</del><ins>+void InputType::handleKeypressEvent(KeyboardEvent&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InputType::handleKeyupEvent(KeyboardEvent*)
</del><ins>+void InputType::handleKeyupEvent(KeyboardEvent&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InputType::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*)
</del><ins>+void InputType::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><del>-void InputType::handleTouchEvent(TouchEvent*)
</del><ins>+void InputType::handleTouchEvent(TouchEvent&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void InputType::forwardEvent(Event*)
</del><ins>+void InputType::forwardEvent(Event&)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool InputType::shouldSubmitImplicitly(Event* event)
</del><ins>+bool InputType::shouldSubmitImplicitly(Event& event)
</ins><span class="cx"> {
</span><del>- return is<KeyboardEvent>(*event) && event->type() == eventNames().keypressEvent && downcast<KeyboardEvent>(*event).charCode() == '\r';
</del><ins>+ return is<KeyboardEvent>(event) && event.type() == eventNames().keypressEvent && downcast<KeyboardEvent>(event).charCode() == '\r';
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<HTMLFormElement> InputType::formForSubmission() const
</span><span class="lines">@@ -539,11 +539,11 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-void InputType::dispatchSimulatedClickIfActive(KeyboardEvent* event) const
</del><ins>+void InputType::dispatchSimulatedClickIfActive(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> if (element().active())
</span><del>- element().dispatchSimulatedClick(event);
- event->setDefaultHandled();
</del><ins>+ element().dispatchSimulatedClick(&event);
+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Chrome* InputType::chrome() const
</span><span class="lines">@@ -563,7 +563,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool InputType::isKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool InputType::isKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> return !element().isReadOnly() && element().isTextFormControlKeyboardFocusable(event);
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/InputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/InputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/InputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -178,27 +178,27 @@
</span><span class="cx">
</span><span class="cx"> // Event handlers.
</span><span class="cx">
</span><del>- virtual void handleClickEvent(MouseEvent*);
- virtual void handleMouseDownEvent(MouseEvent*);
</del><ins>+ virtual void handleClickEvent(MouseEvent&);
+ virtual void handleMouseDownEvent(MouseEvent&);
</ins><span class="cx"> virtual void willDispatchClick(InputElementClickState&);
</span><span class="cx"> virtual void didDispatchClick(Event*, const InputElementClickState&);
</span><del>- virtual void handleDOMActivateEvent(Event*);
- virtual void handleKeydownEvent(KeyboardEvent*);
- virtual void handleKeypressEvent(KeyboardEvent*);
- virtual void handleKeyupEvent(KeyboardEvent*);
- virtual void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*);
- virtual void forwardEvent(Event*);
</del><ins>+ virtual void handleDOMActivateEvent(Event&);
+ virtual void handleKeydownEvent(KeyboardEvent&);
+ virtual void handleKeypressEvent(KeyboardEvent&);
+ virtual void handleKeyupEvent(KeyboardEvent&);
+ virtual void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent&);
+ virtual void forwardEvent(Event&);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><del>- virtual void handleTouchEvent(TouchEvent*);
</del><ins>+ virtual void handleTouchEvent(TouchEvent&);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> // Helpers for event handlers.
</span><span class="cx">
</span><del>- virtual bool shouldSubmitImplicitly(Event*);
</del><ins>+ virtual bool shouldSubmitImplicitly(Event&);
</ins><span class="cx"> virtual PassRefPtr<HTMLFormElement> formForSubmission() const;
</span><span class="cx"> virtual bool hasCustomFocusLogic() const;
</span><del>- virtual bool isKeyboardFocusable(KeyboardEvent*) const;
</del><ins>+ virtual bool isKeyboardFocusable(KeyboardEvent&) const;
</ins><span class="cx"> virtual bool isMouseFocusable() const;
</span><span class="cx"> virtual bool shouldUseInputMethod() const;
</span><span class="cx"> virtual void handleFocusEvent(Node* oldFocusedNode, FocusDirection);
</span><span class="lines">@@ -295,7 +295,7 @@
</span><span class="cx"> virtual unsigned height() const;
</span><span class="cx"> virtual unsigned width() const;
</span><span class="cx">
</span><del>- void dispatchSimulatedClickIfActive(KeyboardEvent*) const;
</del><ins>+ void dispatchSimulatedClickIfActive(KeyboardEvent&) const;
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(DATALIST_ELEMENT)
</span><span class="cx"> virtual void listAttributeTargetChanged();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlMediaDocumentcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/MediaDocument.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/MediaDocument.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/MediaDocument.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -178,24 +178,24 @@
</span><span class="cx"> return downcast<HTMLVideoElement>(node);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaDocument::defaultEventHandler(Event* event)
</del><ins>+void MediaDocument::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> // Match the default Quicktime plugin behavior to allow
</span><span class="cx"> // clicking and double-clicking to pause and play the media.
</span><del>- Node* targetNode = event->target()->toNode();
</del><ins>+ Node* targetNode = event.target()->toNode();
</ins><span class="cx"> if (!targetNode)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (HTMLVideoElement* video = ancestorVideoElement(targetNode)) {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> if (!video->canPlay()) {
</span><span class="cx"> video->pause();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><del>- } else if (event->type() == eventNames().dblclickEvent) {
</del><ins>+ } else if (event.type() == eventNames().dblclickEvent) {
</ins><span class="cx"> if (video->canPlay()) {
</span><span class="cx"> video->play();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -203,12 +203,12 @@
</span><span class="cx"> if (!is<ContainerNode>(*targetNode))
</span><span class="cx"> return;
</span><span class="cx"> ContainerNode& targetContainer = downcast<ContainerNode>(*targetNode);
</span><del>- if (event->type() == eventNames().keydownEvent && is<KeyboardEvent>(*event)) {
</del><ins>+ if (event.type() == eventNames().keydownEvent && is<KeyboardEvent>(event)) {
</ins><span class="cx"> HTMLVideoElement* video = descendantVideoElement(targetContainer);
</span><span class="cx"> if (!video)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(*event);
</del><ins>+ KeyboardEvent& keyboardEvent = downcast<KeyboardEvent>(event);
</ins><span class="cx"> if (keyboardEvent.keyIdentifier() == "U+0020") { // space
</span><span class="cx"> if (video->paused()) {
</span><span class="cx"> if (video->canPlay())
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlMediaDocumenth"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/MediaDocument.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/MediaDocument.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/MediaDocument.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -49,7 +49,7 @@
</span><span class="cx">
</span><span class="cx"> Ref<DocumentParser> createParser() override;
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> void replaceMediaElementTimerFired();
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlNumberInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/NumberInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/NumberInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/NumberInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -219,10 +219,10 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void NumberInputType::handleKeydownEvent(KeyboardEvent* event)
</del><ins>+void NumberInputType::handleKeydownEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> handleKeydownEventForSpinButton(event);
</span><del>- if (!event->defaultHandled())
</del><ins>+ if (!event.defaultHandled())
</ins><span class="cx"> TextFieldInputType::handleKeydownEvent(event);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlNumberInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/NumberInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/NumberInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/NumberInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> float decorationWidth() const override;
</span><span class="cx"> bool isSteppable() const override;
</span><span class="cx"> StepRange createStepRange(AnyStepHandling) const override;
</span><del>- void handleKeydownEvent(KeyboardEvent*) override;
</del><ins>+ void handleKeydownEvent(KeyboardEvent&) override;
</ins><span class="cx"> Decimal parseToNumber(const String&, const Decimal&) const override;
</span><span class="cx"> String serialize(const Decimal&) const override;
</span><span class="cx"> String localizeValue(const String&) const override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlRadioInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RadioInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RadioInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RadioInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -53,17 +53,17 @@
</span><span class="cx"> return validationMessageValueMissingForRadioText();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RadioInputType::handleClickEvent(MouseEvent* event)
</del><ins>+void RadioInputType::handleClickEvent(MouseEvent& event)
</ins><span class="cx"> {
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void RadioInputType::handleKeydownEvent(KeyboardEvent* event)
</del><ins>+void RadioInputType::handleKeydownEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> BaseCheckableInputType::handleKeydownEvent(event);
</span><del>- if (event->defaultHandled())
</del><ins>+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><del>- const String& key = event->keyIdentifier();
</del><ins>+ const String& key = event.keyIdentifier();
</ins><span class="cx"> if (key != "Up" && key != "Down" && key != "Left" && key != "Right")
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -91,16 +91,16 @@
</span><span class="cx"> break;
</span><span class="cx"> if (inputElement->isRadioButton() && inputElement->name() == element().name() && inputElement->isFocusable()) {
</span><span class="cx"> element().document().setFocusedElement(inputElement.get());
</span><del>- inputElement->dispatchSimulatedClick(event, SendNoEvents, DoNotShowPressedLook);
- event->setDefaultHandled();
</del><ins>+ inputElement->dispatchSimulatedClick(&event, SendNoEvents, DoNotShowPressedLook);
+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void RadioInputType::handleKeyupEvent(KeyboardEvent* event)
</del><ins>+void RadioInputType::handleKeyupEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- const String& key = event->keyIdentifier();
</del><ins>+ const String& key = event.keyIdentifier();
</ins><span class="cx"> if (key != "U+0020")
</span><span class="cx"> return;
</span><span class="cx"> // If an unselected radio is tabbed into (because the entire group has nothing
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> dispatchSimulatedClickIfActive(event);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool RadioInputType::isKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool RadioInputType::isKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> if (!InputType::isKeyboardFocusable(event))
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlRadioInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RadioInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RadioInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RadioInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -44,10 +44,10 @@
</span><span class="cx"> const AtomicString& formControlType() const override;
</span><span class="cx"> bool valueMissing(const String&) const override;
</span><span class="cx"> String valueMissingText() const override;
</span><del>- void handleClickEvent(MouseEvent*) override;
- void handleKeydownEvent(KeyboardEvent*) override;
- void handleKeyupEvent(KeyboardEvent*) override;
- bool isKeyboardFocusable(KeyboardEvent*) const override;
</del><ins>+ void handleClickEvent(MouseEvent&) override;
+ void handleKeydownEvent(KeyboardEvent&) override;
+ void handleKeyupEvent(KeyboardEvent&) override;
+ bool isKeyboardFocusable(KeyboardEvent&) const override;
</ins><span class="cx"> bool shouldSendChangeEventAfterCheckedChanged() override;
</span><span class="cx"> void willDispatchClick(InputElementClickState&) override;
</span><span class="cx"> void didDispatchClick(Event*, const InputElementClickState&) override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlRangeInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RangeInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RangeInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RangeInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -136,13 +136,13 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if !PLATFORM(IOS)
</span><del>-void RangeInputType::handleMouseDownEvent(MouseEvent* event)
</del><ins>+void RangeInputType::handleMouseDownEvent(MouseEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> if (element().isDisabledOrReadOnly())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- Node* targetNode = event->target()->toNode();
- if (event->button() != LeftButton || !targetNode)
</del><ins>+ Node* targetNode = event.target()->toNode();
+ if (event.button() != LeftButton || !targetNode)
</ins><span class="cx"> return;
</span><span class="cx"> ASSERT(element().shadowRoot());
</span><span class="cx"> if (targetNode != &element() && !targetNode->isDescendantOf(element().userAgentShadowRoot()))
</span><span class="lines">@@ -150,12 +150,12 @@
</span><span class="cx"> SliderThumbElement& thumb = typedSliderThumbElement();
</span><span class="cx"> if (targetNode == &thumb)
</span><span class="cx"> return;
</span><del>- thumb.dragFrom(event->absoluteLocation());
</del><ins>+ thumb.dragFrom(event.absoluteLocation());
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><del>-void RangeInputType::handleTouchEvent(TouchEvent* event)
</del><ins>+void RangeInputType::handleTouchEvent(TouchEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> typedSliderThumbElement().handleTouchEvent(event);
</span><span class="lines">@@ -163,15 +163,15 @@
</span><span class="cx"> if (element().isDisabledOrReadOnly())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (event->type() == eventNames().touchendEvent) {
- event->setDefaultHandled();
</del><ins>+ if (event.type() == eventNames().touchendEvent) {
+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- TouchList* touches = event->targetTouches();
</del><ins>+ TouchList* touches = event.targetTouches();
</ins><span class="cx"> if (touches->length() == 1) {
</span><span class="cx"> typedSliderThumbElement().setPositionFromPoint(touches->item(0)->absoluteLocation());
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> #else
</span><span class="cx"> UNUSED_PARAM(event);
</span><span class="lines">@@ -193,12 +193,12 @@
</span><span class="cx"> #endif
</span><span class="cx"> #endif // ENABLE(TOUCH_EVENTS)
</span><span class="cx">
</span><del>-void RangeInputType::handleKeydownEvent(KeyboardEvent* event)
</del><ins>+void RangeInputType::handleKeydownEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> if (element().isDisabledOrReadOnly())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- const String& key = event->keyIdentifier();
</del><ins>+ const String& key = event.keyIdentifier();
</ins><span class="cx">
</span><span class="cx"> const Decimal current = parseToNumberOrNaN(element().value());
</span><span class="cx"> ASSERT(current.isFinite());
</span><span class="lines">@@ -247,7 +247,7 @@
</span><span class="cx"> cache->postNotification(&element(), AXObjectCache::AXValueChanged);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RangeInputType::createShadowSubtree()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlRangeInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RangeInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RangeInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/RangeInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -51,9 +51,9 @@
</span><span class="cx"> StepRange createStepRange(AnyStepHandling) const override;
</span><span class="cx"> bool isSteppable() const override;
</span><span class="cx"> #if !PLATFORM(IOS)
</span><del>- void handleMouseDownEvent(MouseEvent*) override;
</del><ins>+ void handleMouseDownEvent(MouseEvent&) override;
</ins><span class="cx"> #endif
</span><del>- void handleKeydownEvent(KeyboardEvent*) override;
</del><ins>+ void handleKeydownEvent(KeyboardEvent&) override;
</ins><span class="cx"> RenderPtr<RenderElement> createInputRenderer(RenderStyle&&) override;
</span><span class="cx"> void createShadowSubtree() override;
</span><span class="cx"> Decimal parseToNumber(const String&, const Decimal&) const override;
</span><span class="lines">@@ -79,7 +79,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><del>- void handleTouchEvent(TouchEvent*) override;
</del><ins>+ void handleTouchEvent(TouchEvent&) override;
</ins><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> void disabledAttributeChanged() override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlResetInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ResetInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ResetInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ResetInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -50,12 +50,12 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ResetInputType::handleDOMActivateEvent(Event* event)
</del><ins>+void ResetInputType::handleDOMActivateEvent(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> if (element().isDisabledFormControl() || !element().form())
</span><span class="cx"> return;
</span><span class="cx"> element().form()->reset();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String ResetInputType::defaultValue() const
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlResetInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ResetInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ResetInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/ResetInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> private:
</span><span class="cx"> const AtomicString& formControlType() const override;
</span><span class="cx"> bool supportsValidation() const override;
</span><del>- void handleDOMActivateEvent(Event*) override;
</del><ins>+ void handleDOMActivateEvent(Event&) override;
</ins><span class="cx"> String defaultValue() const override;
</span><span class="cx"> bool isTextButton() const override;
</span><span class="cx"> };
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlSearchInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SearchInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SearchInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SearchInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -127,7 +127,7 @@
</span><span class="cx"> return m_cancelButton;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SearchInputType::handleKeydownEvent(KeyboardEvent* event)
</del><ins>+void SearchInputType::handleKeydownEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> if (element().isDisabledOrReadOnly()) {
</span><span class="cx"> TextFieldInputType::handleKeydownEvent(event);
</span><span class="lines">@@ -134,12 +134,12 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const String& key = event->keyIdentifier();
</del><ins>+ const String& key = event.keyIdentifier();
</ins><span class="cx"> if (key == "U+001B") {
</span><span class="cx"> Ref<HTMLInputElement> input(this->element());
</span><span class="cx"> input->setValueForUser(emptyString());
</span><span class="cx"> input->onSearch();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> TextFieldInputType::handleKeydownEvent(event);
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlSearchInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SearchInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SearchInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SearchInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> void destroyShadowSubtree() override;
</span><span class="cx"> HTMLElement* resultsButtonElement() const override;
</span><span class="cx"> HTMLElement* cancelButtonElement() const override;
</span><del>- void handleKeydownEvent(KeyboardEvent*) override;
</del><ins>+ void handleKeydownEvent(KeyboardEvent&) override;
</ins><span class="cx"> void didSetValueByUserEdit() override;
</span><span class="cx"> bool sizeShouldIncludeDecoration(int defaultSize, int& preferredSize) const override;
</span><span class="cx"> float decorationWidth() const override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlSubmitInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SubmitInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SubmitInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SubmitInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SubmitInputType::handleDOMActivateEvent(Event* event)
</del><ins>+void SubmitInputType::handleDOMActivateEvent(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> Ref<HTMLInputElement> element(this->element());
</span><span class="cx"> if (element->isDisabledFormControl() || !element->form())
</span><span class="lines">@@ -67,7 +67,7 @@
</span><span class="cx"> element->setActivatedSubmit(true);
</span><span class="cx"> element->form()->prepareForSubmission(event); // Event handlers can run.
</span><span class="cx"> element->setActivatedSubmit(false);
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool SubmitInputType::canBeSuccessfulSubmitButton()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlSubmitInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SubmitInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SubmitInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/SubmitInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> const AtomicString& formControlType() const override;
</span><span class="cx"> bool appendFormData(FormDataList&, bool) const override;
</span><span class="cx"> bool supportsRequired() const override;
</span><del>- void handleDOMActivateEvent(Event*) override;
</del><ins>+ void handleDOMActivateEvent(Event&) override;
</ins><span class="cx"> bool canBeSuccessfulSubmitButton() override;
</span><span class="cx"> String defaultValue() const override;
</span><span class="cx"> bool isSubmitButton() const override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlTextFieldInputTypecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/TextFieldInputType.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/TextFieldInputType.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/TextFieldInputType.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> m_innerSpinButton->removeSpinButtonOwner();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool TextFieldInputType::isKeyboardFocusable(KeyboardEvent*) const
</del><ins>+bool TextFieldInputType::isKeyboardFocusable(KeyboardEvent&) const
</ins><span class="cx"> {
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> if (element().isReadOnly())
</span><span class="lines">@@ -156,21 +156,21 @@
</span><span class="cx"> input->setTextAsOfLastFormControlChangeEvent(sanitizedValue);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void TextFieldInputType::handleKeydownEvent(KeyboardEvent* event)
</del><ins>+void TextFieldInputType::handleKeydownEvent(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> if (!element().focused())
</span><span class="cx"> return;
</span><span class="cx"> Frame* frame = element().document().frame();
</span><del>- if (!frame || !frame->editor().doTextFieldCommandFromEvent(&element(), event))
</del><ins>+ if (!frame || !frame->editor().doTextFieldCommandFromEvent(&element(), &event))
</ins><span class="cx"> return;
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void TextFieldInputType::handleKeydownEventForSpinButton(KeyboardEvent* event)
</del><ins>+void TextFieldInputType::handleKeydownEventForSpinButton(KeyboardEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> if (element().isDisabledOrReadOnly())
</span><span class="cx"> return;
</span><del>- const String& key = event->keyIdentifier();
</del><ins>+ const String& key = event.keyIdentifier();
</ins><span class="cx"> if (key == "Up")
</span><span class="cx"> spinButtonStepUp();
</span><span class="cx"> else if (key == "Down")
</span><span class="lines">@@ -177,26 +177,26 @@
</span><span class="cx"> spinButtonStepDown();
</span><span class="cx"> else
</span><span class="cx"> return;
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void TextFieldInputType::forwardEvent(Event* event)
</del><ins>+void TextFieldInputType::forwardEvent(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> if (m_innerSpinButton) {
</span><span class="cx"> m_innerSpinButton->forwardEvent(event);
</span><del>- if (event->defaultHandled())
</del><ins>+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (event->isMouseEvent()
- || event->type() == eventNames().blurEvent
- || event->type() == eventNames().focusEvent)
</del><ins>+ if (event.isMouseEvent()
+ || event.type() == eventNames().blurEvent
+ || event.type() == eventNames().focusEvent)
</ins><span class="cx"> {
</span><span class="cx"> element().document().updateStyleIfNeeded();
</span><span class="cx">
</span><span class="cx"> auto* renderer = element().renderer();
</span><span class="cx"> if (element().renderer()) {
</span><del>- if (event->type() == eventNames().blurEvent) {
</del><ins>+ if (event.type() == eventNames().blurEvent) {
</ins><span class="cx"> if (auto* innerTextRenderer = innerTextElement()->renderer()) {
</span><span class="cx"> if (auto* innerLayer = innerTextRenderer->layer()) {
</span><span class="cx"> bool isLeftToRightDirection = downcast<RenderTextControlSingleLine>(*renderer).style().isLeftToRightDirection();
</span><span class="lines">@@ -205,7 +205,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> capsLockStateMayHaveChanged();
</span><del>- } else if (event->type() == eventNames().focusEvent)
</del><ins>+ } else if (event.type() == eventNames().focusEvent)
</ins><span class="cx"> capsLockStateMayHaveChanged();
</span><span class="cx">
</span><span class="cx"> element().forwardEvent(event);
</span><span class="lines">@@ -226,9 +226,9 @@
</span><span class="cx"> element().endEditing();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool TextFieldInputType::shouldSubmitImplicitly(Event* event)
</del><ins>+bool TextFieldInputType::shouldSubmitImplicitly(Event& event)
</ins><span class="cx"> {
</span><del>- return (event->type() == eventNames().textInputEvent && is<TextEvent>(*event) && downcast<TextEvent>(*event).data() == "\n")
</del><ins>+ return (event.type() == eventNames().textInputEvent && is<TextEvent>(event) && downcast<TextEvent>(event).data() == "\n")
</ins><span class="cx"> || InputType::shouldSubmitImplicitly(event);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -449,7 +449,7 @@
</span><span class="cx"> return limitLength(proposedValue.removeCharacters(isASCIILineBreak), HTMLInputElement::maxEffectiveLength);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void TextFieldInputType::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent* event)
</del><ins>+void TextFieldInputType::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> // Make sure that the text to be inserted will not violate the maxLength.
</span><span class="cx">
</span><span class="lines">@@ -480,7 +480,7 @@
</span><span class="cx"> unsigned appendableLength = maxLength > baseLength ? maxLength - baseLength : 0;
</span><span class="cx">
</span><span class="cx"> // Truncate the inserted text to avoid violating the maxLength and other constraints.
</span><del>- String eventText = event->text();
</del><ins>+ String eventText = event.text();
</ins><span class="cx"> unsigned textLength = eventText.length();
</span><span class="cx"> while (textLength > 0 && isASCIILineBreak(eventText[textLength - 1]))
</span><span class="cx"> textLength--;
</span><span class="lines">@@ -489,7 +489,7 @@
</span><span class="cx"> eventText.replace('\r', ' ');
</span><span class="cx"> eventText.replace('\n', ' ');
</span><span class="cx">
</span><del>- event->setText(limitLength(eventText, appendableLength));
</del><ins>+ event.setText(limitLength(eventText, appendableLength));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool TextFieldInputType::shouldRespectListAttribute()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlTextFieldInputTypeh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/TextFieldInputType.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/TextFieldInputType.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/TextFieldInputType.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -46,8 +46,8 @@
</span><span class="cx"> protected:
</span><span class="cx"> explicit TextFieldInputType(HTMLInputElement&);
</span><span class="cx"> virtual ~TextFieldInputType();
</span><del>- void handleKeydownEvent(KeyboardEvent*) override;
- void handleKeydownEventForSpinButton(KeyboardEvent*);
</del><ins>+ void handleKeydownEvent(KeyboardEvent&) override;
+ void handleKeydownEventForSpinButton(KeyboardEvent&);
</ins><span class="cx">
</span><span class="cx"> HTMLElement* containerElement() const final;
</span><span class="cx"> HTMLElement* innerBlockElement() const final;
</span><span class="lines">@@ -74,14 +74,14 @@
</span><span class="cx"> virtual void didSetValueByUserEdit();
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const final;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const final;
</ins><span class="cx"> bool isMouseFocusable() const final;
</span><span class="cx"> bool isTextField() const final;
</span><span class="cx"> bool isEmptyValue() const final;
</span><span class="cx"> bool valueMissing(const String&) const final;
</span><del>- void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*) final;
- void forwardEvent(Event*) final;
- bool shouldSubmitImplicitly(Event*) final;
</del><ins>+ void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent&) final;
+ void forwardEvent(Event&) final;
+ bool shouldSubmitImplicitly(Event&) final;
</ins><span class="cx"> RenderPtr<RenderElement> createInputRenderer(RenderStyle&&) override;
</span><span class="cx"> bool shouldUseInputMethod() const override;
</span><span class="cx"> bool shouldRespectListAttribute() override;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowAutoFillButtonElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/AutoFillButtonElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/AutoFillButtonElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/AutoFillButtonElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -47,22 +47,22 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void AutoFillButtonElement::defaultEventHandler(Event* event)
</del><ins>+void AutoFillButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (!is<MouseEvent>(*event)) {
- if (!event->defaultHandled())
</del><ins>+ if (!is<MouseEvent>(event)) {
+ if (!event.defaultHandled())
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- MouseEvent& mouseEvent = downcast<MouseEvent>(*event);
</del><ins>+ MouseEvent& mouseEvent = downcast<MouseEvent>(event);
</ins><span class="cx">
</span><span class="cx"> if (mouseEvent.type() == eventNames().clickEvent) {
</span><span class="cx"> m_owner.autoFillButtonElementWasClicked();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- if (!event->defaultHandled())
</del><ins>+ if (!event.defaultHandled())
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowAutoFillButtonElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/AutoFillButtonElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/AutoFillButtonElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/AutoFillButtonElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit AutoFillButtonElement(Document&, AutoFillButtonOwner&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> AutoFillButtonOwner& m_owner;
</span><span class="cx"> };
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlElementTypescpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElementTypes.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElementTypes.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElementTypes.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -138,11 +138,11 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlMuteButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlMuteButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> mediaController()->setMuted(!mediaController()->muted());
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLInputElement::defaultEventHandler(event);
</span><span class="lines">@@ -165,12 +165,12 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlSeekButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlSeekButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> // Set the mousedown and mouseup events as defaultHandled so they
</span><span class="cx"> // do not trigger drag start or end actions in MediaControlPanelElement.
</span><del>- if (event->type() == eventNames().mousedownEvent || event->type() == eventNames().mouseupEvent)
- event->setDefaultHandled();
</del><ins>+ if (event.type() == eventNames().mousedownEvent || event.type() == eventNames().mouseupEvent)
+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void MediaControlSeekButtonElement::setActive(bool flag, bool pause)
</span><span class="lines">@@ -194,10 +194,10 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlVolumeSliderElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlVolumeSliderElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> // Left button is 0. Rejects mouse events not from left button.
</span><del>- if (is<MouseEvent>(*event) && downcast<MouseEvent>(*event).button())
</del><ins>+ if (is<MouseEvent>(event) && downcast<MouseEvent>(event).button())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (!renderer())
</span><span class="lines">@@ -205,7 +205,7 @@
</span><span class="cx">
</span><span class="cx"> MediaControlInputElement::defaultEventHandler(event);
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mouseoverEvent || event->type() == eventNames().mouseoutEvent || event->type() == eventNames().mousemoveEvent)
</del><ins>+ if (event.type() == eventNames().mouseoverEvent || event.type() == eventNames().mouseoutEvent || event.type() == eventNames().mousemoveEvent)
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> double volume = value().toDouble();
</span><span class="lines">@@ -213,7 +213,7 @@
</span><span class="cx"> mediaController()->setVolume(volume, ASSERT_NO_EXCEPTION);
</span><span class="cx"> if (m_clearMutedOnUserInteraction)
</span><span class="cx"> mediaController()->setMuted(false);
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool MediaControlVolumeSliderElement::willRespondToMouseMoveEvents()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlElementTypesh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElementTypes.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElementTypes.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElementTypes.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -151,7 +151,7 @@
</span><span class="cx"> protected:
</span><span class="cx"> explicit MediaControlMuteButtonElement(Document&, MediaControlElementType);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void updateDisplayType() override;
</span><span class="lines">@@ -166,7 +166,7 @@
</span><span class="cx"> protected:
</span><span class="cx"> explicit MediaControlSeekButtonElement(Document&, MediaControlElementType);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> virtual bool isForwardButton() const = 0;
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="lines">@@ -185,7 +185,7 @@
</span><span class="cx"> protected:
</span><span class="cx"> explicit MediaControlVolumeSliderElement(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> bool m_clearMutedOnUserInteraction;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlElementscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElements.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElements.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElements.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -215,21 +215,21 @@
</span><span class="cx"> startTimer();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlPanelElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlPanelElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> MediaControlDivElement::defaultEventHandler(event);
</span><span class="cx">
</span><del>- if (is<MouseEvent>(*event)) {
- LayoutPoint location = downcast<MouseEvent>(*event).absoluteLocation();
- if (event->type() == eventNames().mousedownEvent && event->target() == this) {
</del><ins>+ if (is<MouseEvent>(event)) {
+ LayoutPoint location = downcast<MouseEvent>(event).absoluteLocation();
+ if (event.type() == eventNames().mousedownEvent && event.target() == this) {
</ins><span class="cx"> startDrag(location);
</span><del>- event->setDefaultHandled();
- } else if (event->type() == eventNames().mousemoveEvent && m_isBeingDragged)
</del><ins>+ event.setDefaultHandled();
+ } else if (event.type() == eventNames().mousemoveEvent && m_isBeingDragged)
</ins><span class="cx"> continueDrag(location);
</span><del>- else if (event->type() == eventNames().mouseupEvent && m_isBeingDragged) {
</del><ins>+ else if (event.type() == eventNames().mouseupEvent && m_isBeingDragged) {
</ins><span class="cx"> continueDrag(location);
</span><span class="cx"> endDrag();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -333,13 +333,13 @@
</span><span class="cx"> return createRenderer<RenderMediaVolumeSliderContainer>(*this, WTFMove(style));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlVolumeSliderContainerElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlVolumeSliderContainerElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (!is<MouseEvent>(*event) || event->type() != eventNames().mouseoutEvent)
</del><ins>+ if (!is<MouseEvent>(event) || event.type() != eventNames().mouseoutEvent)
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // Poor man's mouseleave event detection.
</span><del>- MouseEvent& mouseEvent = downcast<MouseEvent>(*event);
</del><ins>+ MouseEvent& mouseEvent = downcast<MouseEvent>(event);
</ins><span class="cx"> EventTarget* relatedTarget = mouseEvent.relatedTarget();
</span><span class="cx"> if (!relatedTarget || !relatedTarget->toNode())
</span><span class="cx"> return;
</span><span class="lines">@@ -418,9 +418,9 @@
</span><span class="cx"> return button;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlPanelMuteButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlPanelMuteButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().mouseoverEvent)
</del><ins>+ if (event.type() == eventNames().mouseoverEvent)
</ins><span class="cx"> m_controls->showVolumeSlider();
</span><span class="cx">
</span><span class="cx"> MediaControlMuteButtonElement::defaultEventHandler(event);
</span><span class="lines">@@ -458,15 +458,15 @@
</span><span class="cx"> return button;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlPlayButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlPlayButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> if (mediaController()->canPlay())
</span><span class="cx"> mediaController()->play();
</span><span class="cx"> else
</span><span class="cx"> mediaController()->pause();
</span><span class="cx"> updateDisplayType();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> HTMLInputElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="lines">@@ -492,12 +492,12 @@
</span><span class="cx"> return button;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlOverlayPlayButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlOverlayPlayButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent && mediaController()->canPlay()) {
</del><ins>+ if (event.type() == eventNames().clickEvent && mediaController()->canPlay()) {
</ins><span class="cx"> mediaController()->play();
</span><span class="cx"> updateDisplayType();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> HTMLInputElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="lines">@@ -558,11 +558,11 @@
</span><span class="cx"> return button;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlRewindButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlRewindButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> mediaController()->setCurrentTime(std::max<double>(0, mediaController()->currentTime() - 30));
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> HTMLInputElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="lines">@@ -584,11 +584,11 @@
</span><span class="cx"> return button;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlReturnToRealtimeButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlReturnToRealtimeButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> mediaController()->returnToRealtime();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> HTMLInputElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="lines">@@ -625,9 +625,9 @@
</span><span class="cx"> setChecked(captionsVisible);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> // FIXME: It's not great that the shared code is dictating behavior of platform-specific
</span><span class="cx"> // UI. Not all ports may want the closed captions button to toggle a list of tracks, so
</span><span class="cx"> // we have to use #if.
</span><span class="lines">@@ -639,7 +639,7 @@
</span><span class="cx"> #else
</span><span class="cx"> m_controls->toggleClosedCaptionTrackList();
</span><span class="cx"> #endif
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> HTMLInputElement::defaultEventHandler(event);
</span><span class="lines">@@ -682,11 +682,11 @@
</span><span class="cx"> return element;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlClosedCaptionsTrackListElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlClosedCaptionsTrackListElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (event->type() == eventNames().clickEvent) {
- Node* target = event->target()->toNode();
</del><ins>+ if (event.type() == eventNames().clickEvent) {
+ Node* target = event.target()->toNode();
</ins><span class="cx"> if (!is<Element>(target))
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -842,28 +842,28 @@
</span><span class="cx"> return timeline;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlTimelineElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlTimelineElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> // Left button is 0. Rejects mouse events not from left button.
</span><del>- if (is<MouseEvent>(*event) && downcast<MouseEvent>(*event).button())
</del><ins>+ if (is<MouseEvent>(event) && downcast<MouseEvent>(event).button())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (!renderer())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mousedownEvent)
</del><ins>+ if (event.type() == eventNames().mousedownEvent)
</ins><span class="cx"> mediaController()->beginScrubbing();
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mouseupEvent)
</del><ins>+ if (event.type() == eventNames().mouseupEvent)
</ins><span class="cx"> mediaController()->endScrubbing();
</span><span class="cx">
</span><span class="cx"> MediaControlInputElement::defaultEventHandler(event);
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mouseoverEvent || event->type() == eventNames().mouseoutEvent || event->type() == eventNames().mousemoveEvent)
</del><ins>+ if (event.type() == eventNames().mouseoverEvent || event.type() == eventNames().mouseoutEvent || event.type() == eventNames().mousemoveEvent)
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> double time = value().toDouble();
</span><del>- if (event->type() == eventNames().inputEvent && time != mediaController()->currentTime())
</del><ins>+ if (event.type() == eventNames().inputEvent && time != mediaController()->currentTime())
</ins><span class="cx"> mediaController()->setCurrentTime(time);
</span><span class="cx">
</span><span class="cx"> RenderSlider& slider = downcast<RenderSlider>(*renderer());
</span><span class="lines">@@ -944,9 +944,9 @@
</span><span class="cx"> return button;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlFullscreenButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlFullscreenButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> #if ENABLE(FULLSCREEN_API)
</span><span class="cx"> // Only use the new full screen API if the fullScreenEnabled setting has
</span><span class="cx"> // been explicitly enabled. Otherwise, use the old fullscreen API. This
</span><span class="lines">@@ -961,7 +961,7 @@
</span><span class="cx"> } else
</span><span class="cx"> #endif
</span><span class="cx"> mediaController()->enterFullscreen();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> HTMLInputElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="lines">@@ -987,12 +987,12 @@
</span><span class="cx"> return button;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> ExceptionCode code = 0;
</span><span class="cx"> mediaController()->setVolume(0, code);
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> HTMLInputElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="lines">@@ -1013,12 +1013,12 @@
</span><span class="cx"> return button;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler(Event* event)
</del><ins>+void MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> ExceptionCode code = 0;
</span><span class="cx"> mediaController()->setVolume(1, code);
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> HTMLInputElement::defaultEventHandler(event);
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlElementsh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElements.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElements.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlElements.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlPanelElement(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> void startDrag(const LayoutPoint& eventLocation);
</span><span class="cx"> void continueDrag(const LayoutPoint& eventLocation);
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlVolumeSliderContainerElement(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> RenderPtr<RenderElement> createElementRenderer(RenderStyle&&, const RenderTreePosition&) override;
</span><span class="cx"> };
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlPanelMuteButtonElement(Document&, MediaControls*);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> MediaControls* m_controls;
</span><span class="cx"> };
</span><span class="lines">@@ -190,7 +190,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlPlayButtonElement(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // ----------------------------
</span><span class="lines">@@ -204,7 +204,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlOverlayPlayButtonElement(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // ----------------------------
</span><span class="lines">@@ -244,7 +244,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlRewindButtonElement(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // ----------------------------
</span><span class="lines">@@ -260,7 +260,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlReturnToRealtimeButtonElement(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // ----------------------------
</span><span class="lines">@@ -278,7 +278,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlToggleClosedCaptionsButtonElement(Document&, MediaControls*);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA) || PLATFORM(WIN) || PLATFORM(GTK)
</span><span class="cx"> MediaControls* m_controls;
</span><span class="lines">@@ -316,7 +316,7 @@
</span><span class="cx">
</span><span class="cx"> void rebuildTrackListMenu();
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> typedef Vector<RefPtr<Element>> TrackMenuItems;
</span><span class="cx"> TrackMenuItems m_menuItems;
</span><span class="lines">@@ -343,7 +343,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlTimelineElement(Document&, MediaControls*);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> MediaControls* m_controls;
</span><span class="cx"> };
</span><span class="lines">@@ -363,7 +363,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlFullscreenButtonElement(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // ----------------------------
</span><span class="lines">@@ -397,7 +397,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlFullscreenVolumeMinButtonElement(Document&);
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // ----------------------------
</span><span class="lines">@@ -413,7 +413,7 @@
</span><span class="cx"> private:
</span><span class="cx"> explicit MediaControlFullscreenVolumeMaxButtonElement(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControls.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControls.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControls.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -297,11 +297,11 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControls::defaultEventHandler(Event* event)
</del><ins>+void MediaControls::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mouseoverEvent) {
</del><ins>+ if (event.type() == eventNames().mouseoverEvent) {
</ins><span class="cx"> if (!containsRelatedTarget(event)) {
</span><span class="cx"> m_isMouseOverControls = true;
</span><span class="cx"> if (!m_mediaController->canPlay()) {
</span><span class="lines">@@ -313,7 +313,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mouseoutEvent) {
</del><ins>+ if (event.type() == eventNames().mouseoutEvent) {
</ins><span class="cx"> if (!containsRelatedTarget(event)) {
</span><span class="cx"> m_isMouseOverControls = false;
</span><span class="cx"> stopHideFullscreenControlsTimer();
</span><span class="lines">@@ -321,7 +321,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mousemoveEvent) {
</del><ins>+ if (event.type() == eventNames().mousemoveEvent) {
</ins><span class="cx"> if (m_isFullscreen) {
</span><span class="cx"> // When we get a mouse move in fullscreen mode, show the media controls, and start a timer
</span><span class="cx"> // that will hide the media controls after a 3 seconds without a mouse move.
</span><span class="lines">@@ -367,11 +367,11 @@
</span><span class="cx"> m_hideFullscreenControlsTimer.stop();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool MediaControls::containsRelatedTarget(Event* event)
</del><ins>+bool MediaControls::containsRelatedTarget(Event& event)
</ins><span class="cx"> {
</span><del>- if (!is<MouseEvent>(*event))
</del><ins>+ if (!is<MouseEvent>(event))
</ins><span class="cx"> return false;
</span><del>- EventTarget* relatedTarget = downcast<MouseEvent>(*event).relatedTarget();
</del><ins>+ EventTarget* relatedTarget = downcast<MouseEvent>(event).relatedTarget();
</ins><span class="cx"> if (!relatedTarget)
</span><span class="cx"> return false;
</span><span class="cx"> return contains(relatedTarget->toNode());
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlsh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControls.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControls.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControls.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -110,9 +110,9 @@
</span><span class="cx"> protected:
</span><span class="cx"> explicit MediaControls(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><del>- virtual bool containsRelatedTarget(Event*);
</del><ins>+ virtual bool containsRelatedTarget(Event&);
</ins><span class="cx">
</span><span class="cx"> void setSliderVolume();
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlsApplecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlsApple.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlsApple.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlsApple.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -265,12 +265,12 @@
</span><span class="cx"> m_closedCaptionsContainer->setMediaController(controller);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlsApple::defaultEventHandler(Event* event)
</del><ins>+void MediaControlsApple::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> if (m_closedCaptionsContainer && m_closedCaptionsContainer->isShowing()) {
</span><span class="cx"> hideClosedCaptionTrackList();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -555,15 +555,15 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MediaControlsApple::handleClickEvent(Event* event)
</del><ins>+void MediaControlsApple::handleClickEvent(Event& event)
</ins><span class="cx"> {
</span><del>- Node* currentTarget = event->currentTarget()->toNode();
- Node* target = event->target()->toNode();
</del><ins>+ Node* currentTarget = event.currentTarget()->toNode();
+ Node* target = event.target()->toNode();
</ins><span class="cx">
</span><span class="cx"> if ((currentTarget == &document() && !shadowHost()->contains(target)) || (currentTarget == this && !m_closedCaptionsContainer->contains(target))) {
</span><span class="cx"> hideClosedCaptionTrackList();
</span><del>- event->stopImmediatePropagation();
- event->setDefaultHandled();
</del><ins>+ event.stopImmediatePropagation();
+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -589,7 +589,7 @@
</span><span class="cx"> void MediaControlsAppleEventListener::handleEvent(ScriptExecutionContext*, Event* event)
</span><span class="cx"> {
</span><span class="cx"> if (event->type() == eventNames().clickEvent)
</span><del>- m_mediaControls->handleClickEvent(event);
</del><ins>+ m_mediaControls->handleClickEvent(*event);
</ins><span class="cx"> else if (eventNames().isWheelEventType(event->type()) && is<WheelEvent>(*event)) {
</span><span class="cx"> WheelEvent& wheelEvent = downcast<WheelEvent>(*event);
</span><span class="cx"> if (m_mediaControls->shouldClosedCaptionsContainerPreventPageScrolling(wheelEvent.wheelDeltaY()))
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowMediaControlsAppleh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlsApple.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlsApple.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/MediaControlsApple.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -89,12 +89,12 @@
</span><span class="cx"> void closedCaptionTracksChanged() override;
</span><span class="cx">
</span><span class="cx"> bool shouldClosedCaptionsContainerPreventPageScrolling(int wheelDeltaY);
</span><del>- void handleClickEvent(Event*);
</del><ins>+ void handleClickEvent(Event&);
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> MediaControlsApple(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> MediaControlsAppleEventListener& eventListener();
</span><span class="cx">
</span><span class="cx"> void showClosedCaptionTrackList();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowSliderThumbElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SliderThumbElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SliderThumbElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SliderThumbElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -343,9 +343,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if !PLATFORM(IOS)
</span><del>-void SliderThumbElement::defaultEventHandler(Event* event)
</del><ins>+void SliderThumbElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (!is<MouseEvent>(*event)) {
</del><ins>+ if (!is<MouseEvent>(event)) {
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -359,7 +359,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- MouseEvent& mouseEvent = downcast<MouseEvent>(*event);
</del><ins>+ MouseEvent& mouseEvent = downcast<MouseEvent>(event);
</ins><span class="cx"> bool isLeftButton = mouseEvent.button() == LeftButton;
</span><span class="cx"> const AtomicString& eventType = mouseEvent.type();
</span><span class="cx">
</span><span class="lines">@@ -378,7 +378,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- HTMLDivElement::defaultEventHandler(&mouseEvent);
</del><ins>+ HTMLDivElement::defaultEventHandler(mouseEvent);
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -441,9 +441,9 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SliderThumbElement::handleTouchStart(TouchEvent* touchEvent)
</del><ins>+void SliderThumbElement::handleTouchStart(TouchEvent& touchEvent)
</ins><span class="cx"> {
</span><del>- TouchList* targetTouches = touchEvent->targetTouches();
</del><ins>+ TouchList* targetTouches = touchEvent.targetTouches();
</ins><span class="cx"> if (!targetTouches)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -461,16 +461,16 @@
</span><span class="cx"> setExclusiveTouchIdentifier(touch->identifier());
</span><span class="cx">
</span><span class="cx"> startDragging();
</span><del>- touchEvent->setDefaultHandled();
</del><ins>+ touchEvent.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void SliderThumbElement::handleTouchMove(TouchEvent* touchEvent)
</del><ins>+void SliderThumbElement::handleTouchMove(TouchEvent& touchEvent)
</ins><span class="cx"> {
</span><span class="cx"> unsigned identifier = exclusiveTouchIdentifier();
</span><span class="cx"> if (identifier == NoIdentifier)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- TouchList* targetTouches = touchEvent->targetTouches();
</del><ins>+ TouchList* targetTouches = touchEvent.targetTouches();
</ins><span class="cx"> if (!targetTouches)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -480,16 +480,16 @@
</span><span class="cx">
</span><span class="cx"> if (m_inDragMode)
</span><span class="cx"> setPositionFromPoint(IntPoint(touch->pageX(), touch->pageY()));
</span><del>- touchEvent->setDefaultHandled();
</del><ins>+ touchEvent.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void SliderThumbElement::handleTouchEndAndCancel(TouchEvent* touchEvent)
</del><ins>+void SliderThumbElement::handleTouchEndAndCancel(TouchEvent& touchEvent)
</ins><span class="cx"> {
</span><span class="cx"> unsigned identifier = exclusiveTouchIdentifier();
</span><span class="cx"> if (identifier == NoIdentifier)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- TouchList* targetTouches = touchEvent->targetTouches();
</del><ins>+ TouchList* targetTouches = touchEvent.targetTouches();
</ins><span class="cx"> if (!targetTouches)
</span><span class="cx"> return;
</span><span class="cx"> // If our exclusive touch still exists, it was not the touch
</span><span class="lines">@@ -509,7 +509,7 @@
</span><span class="cx"> registerForTouchEvents();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SliderThumbElement::handleTouchEvent(TouchEvent* touchEvent)
</del><ins>+void SliderThumbElement::handleTouchEvent(TouchEvent& touchEvent)
</ins><span class="cx"> {
</span><span class="cx"> HTMLInputElement* input = hostInput();
</span><span class="cx"> ASSERT(input);
</span><span class="lines">@@ -516,12 +516,12 @@
</span><span class="cx"> if (input->isReadOnly() || input->isDisabledFormControl()) {
</span><span class="cx"> clearExclusiveTouchIdentifier();
</span><span class="cx"> stopDragging();
</span><del>- touchEvent->setDefaultHandled();
</del><ins>+ touchEvent.setDefaultHandled();
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(touchEvent);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const AtomicString& eventType = touchEvent->type();
</del><ins>+ const AtomicString& eventType = touchEvent.type();
</ins><span class="cx"> if (eventType == eventNames().touchstartEvent) {
</span><span class="cx"> handleTouchStart(touchEvent);
</span><span class="cx"> return;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowSliderThumbElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SliderThumbElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SliderThumbElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SliderThumbElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> void setPositionFromPoint(const LayoutPoint&);
</span><span class="cx">
</span><span class="cx"> #if ENABLE(IOS_TOUCH_EVENTS)
</span><del>- void handleTouchEvent(TouchEvent*);
</del><ins>+ void handleTouchEvent(TouchEvent&);
</ins><span class="cx">
</span><span class="cx"> void disabledAttributeChanged();
</span><span class="cx"> #endif
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> bool matchesReadWritePseudoClass() const override;
</span><span class="cx"> Element* focusDelegate() override;
</span><span class="cx"> #if !PLATFORM(IOS)
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> bool willRespondToMouseMoveEvents() override;
</span><span class="cx"> bool willRespondToMouseClickEvents() override;
</span><span class="cx"> #endif
</span><span class="lines">@@ -89,9 +89,9 @@
</span><span class="cx"> void setExclusiveTouchIdentifier(unsigned);
</span><span class="cx"> void clearExclusiveTouchIdentifier();
</span><span class="cx">
</span><del>- void handleTouchStart(TouchEvent*);
- void handleTouchMove(TouchEvent*);
- void handleTouchEndAndCancel(TouchEvent*);
</del><ins>+ void handleTouchStart(TouchEvent&);
+ void handleTouchMove(TouchEvent&);
+ void handleTouchEndAndCancel(TouchEvent&);
</ins><span class="cx">
</span><span class="cx"> bool shouldAcceptTouchEvents();
</span><span class="cx"> void registerForTouchEvents();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowSpinButtonElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SpinButtonElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SpinButtonElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SpinButtonElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -66,10 +66,10 @@
</span><span class="cx"> releaseCapture();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SpinButtonElement::defaultEventHandler(Event* event)
</del><ins>+void SpinButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (!is<MouseEvent>(*event)) {
- if (!event->defaultHandled())
</del><ins>+ if (!is<MouseEvent>(event)) {
+ if (!event.defaultHandled())
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -76,18 +76,18 @@
</span><span class="cx">
</span><span class="cx"> RenderBox* box = renderBox();
</span><span class="cx"> if (!box) {
</span><del>- if (!event->defaultHandled())
</del><ins>+ if (!event.defaultHandled())
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!shouldRespondToMouseEvents()) {
</span><del>- if (!event->defaultHandled())
</del><ins>+ if (!event.defaultHandled())
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- MouseEvent& mouseEvent = downcast<MouseEvent>(*event);
</del><ins>+ MouseEvent& mouseEvent = downcast<MouseEvent>(event);
</ins><span class="cx"> IntPoint local = roundedIntPoint(box->absoluteToLocal(mouseEvent.absoluteLocation(), UseTransforms));
</span><span class="cx"> if (mouseEvent.type() == eventNames().mousedownEvent && mouseEvent.button() == LeftButton) {
</span><span class="cx"> if (box->borderBoxRect().contains(local)) {
</span><span class="lines">@@ -143,7 +143,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!mouseEvent.defaultHandled())
</span><del>- HTMLDivElement::defaultEventHandler(&mouseEvent);
</del><ins>+ HTMLDivElement::defaultEventHandler(mouseEvent);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SpinButtonElement::willOpenPopup()
</span><span class="lines">@@ -152,12 +152,12 @@
</span><span class="cx"> m_upDownState = Indeterminate;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SpinButtonElement::forwardEvent(Event* event)
</del><ins>+void SpinButtonElement::forwardEvent(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> if (!renderBox())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (!is<WheelEvent>(*event))
</del><ins>+ if (!is<WheelEvent>(event))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (!m_spinButtonOwner)
</span><span class="lines">@@ -166,8 +166,8 @@
</span><span class="cx"> if (!m_spinButtonOwner->shouldSpinButtonRespondToWheelEvents())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- doStepAction(downcast<WheelEvent>(*event).wheelDeltaY());
- event->setDefaultHandled();
</del><ins>+ doStepAction(downcast<WheelEvent>(event).wheelDeltaY());
+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool SpinButtonElement::willRespondToMouseMoveEvents()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowSpinButtonElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SpinButtonElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SpinButtonElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/SpinButtonElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx"> bool willRespondToMouseMoveEvents() override;
</span><span class="cx"> bool willRespondToMouseClickEvents() override;
</span><span class="cx">
</span><del>- void forwardEvent(Event*);
</del><ins>+ void forwardEvent(Event&);
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> SpinButtonElement(Document&, SpinButtonOwner&);
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> bool isSpinButtonElement() const override { return true; }
</span><span class="cx"> bool isDisabledFormControl() const override { return shadowHost() && shadowHost()->isDisabledFormControl(); }
</span><span class="cx"> bool matchesReadWritePseudoClass() const override;
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> void willOpenPopup() override;
</span><span class="cx"> void doStepAction(int);
</span><span class="cx"> void startRepeatingTimer();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowTextControlInnerElementscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/TextControlInnerElements.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/TextControlInnerElements.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/TextControlInnerElements.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -105,12 +105,12 @@
</span><span class="cx"> return adoptRef(*new TextControlInnerTextElement(document));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void TextControlInnerTextElement::defaultEventHandler(Event* event)
</del><ins>+void TextControlInnerTextElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> // FIXME: In the future, we should add a way to have default event listeners.
</span><span class="cx"> // Then we would add one to the text field's inner div, and we wouldn't need this subclass.
</span><span class="cx"> // Or possibly we could just use a normal event listener.
</span><del>- if (event->isBeforeTextInsertedEvent() || event->type() == eventNames().webkitEditableContentChangedEvent) {
</del><ins>+ if (event.isBeforeTextInsertedEvent() || event.type() == eventNames().webkitEditableContentChangedEvent) {
</ins><span class="cx"> Element* shadowAncestor = shadowHost();
</span><span class="cx"> // A TextControlInnerTextElement can have no host if its been detached,
</span><span class="cx"> // but kept alive by an EditCommand. In this case, an undo/redo can
</span><span class="lines">@@ -120,7 +120,7 @@
</span><span class="cx"> if (shadowAncestor)
</span><span class="cx"> shadowAncestor->defaultEventHandler(event);
</span><span class="cx"> }
</span><del>- if (!event->defaultHandled())
</del><ins>+ if (!event.defaultHandled())
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -175,11 +175,11 @@
</span><span class="cx"> return adoptRef(*new SearchFieldResultsButtonElement(document));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SearchFieldResultsButtonElement::defaultEventHandler(Event* event)
</del><ins>+void SearchFieldResultsButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> // On mousedown, bring up a menu, if needed
</span><span class="cx"> auto* input = downcast<HTMLInputElement>(shadowHost());
</span><del>- if (input && event->type() == eventNames().mousedownEvent && is<MouseEvent>(*event) && downcast<MouseEvent>(*event).button() == LeftButton) {
</del><ins>+ if (input && event.type() == eventNames().mousedownEvent && is<MouseEvent>(event) && downcast<MouseEvent>(event).button() == LeftButton) {
</ins><span class="cx"> input->focus();
</span><span class="cx"> input->select();
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="lines">@@ -191,10 +191,10 @@
</span><span class="cx"> searchFieldRenderer.showPopup();
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- if (!event->defaultHandled())
</del><ins>+ if (!event.defaultHandled())
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -222,28 +222,28 @@
</span><span class="cx"> return adoptRef(*new SearchFieldCancelButtonElement(document));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SearchFieldCancelButtonElement::defaultEventHandler(Event* event)
</del><ins>+void SearchFieldCancelButtonElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<HTMLInputElement> input(downcast<HTMLInputElement>(shadowHost()));
</span><span class="cx"> if (!input || input->isDisabledOrReadOnly()) {
</span><del>- if (!event->defaultHandled())
</del><ins>+ if (!event.defaultHandled())
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (event->type() == eventNames().mousedownEvent && is<MouseEvent>(*event) && downcast<MouseEvent>(*event).button() == LeftButton) {
</del><ins>+ if (event.type() == eventNames().mousedownEvent && is<MouseEvent>(event) && downcast<MouseEvent>(event).button() == LeftButton) {
</ins><span class="cx"> input->focus();
</span><span class="cx"> input->select();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> input->setValueForUser(emptyString());
</span><span class="cx"> input->onSearch();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- if (!event->defaultHandled())
</del><ins>+ if (!event.defaultHandled())
</ins><span class="cx"> HTMLDivElement::defaultEventHandler(event);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowTextControlInnerElementsh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/TextControlInnerElements.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/TextControlInnerElements.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/TextControlInnerElements.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> public:
</span><span class="cx"> static Ref<TextControlInnerTextElement> create(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> RenderTextControlInnerBlock* renderer() const;
</span><span class="cx">
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> public:
</span><span class="cx"> static Ref<SearchFieldResultsButtonElement> create(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> bool willRespondToMouseClickEvents() override;
</span><span class="cx"> #endif
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> public:
</span><span class="cx"> static Ref<SearchFieldCancelButtonElement> create(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> bool willRespondToMouseClickEvents() override;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowmacImageControlsButtonElementMaccpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -107,9 +107,9 @@
</span><span class="cx"> return WTFMove(button);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ImageControlsButtonElementMac::defaultEventHandler(Event* event)
</del><ins>+void ImageControlsButtonElementMac::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> Frame* frame = document().frame();
</span><span class="cx"> if (!frame)
</span><span class="cx"> return;
</span><span class="lines">@@ -118,8 +118,8 @@
</span><span class="cx"> if (!page)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- page->contextMenuController().showImageControlsMenu(event);
- event->setDefaultHandled();
</del><ins>+ page->contextMenuController().showImageControlsMenu(&event);
+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorehtmlshadowmacImageControlsButtonElementMach"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/html/shadow/mac/ImageControlsButtonElementMac.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> private:
</span><span class="cx"> ImageControlsButtonElementMac(Document&);
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx"> RenderPtr<RenderElement> createElementRenderer(RenderStyle&&, const RenderTreePosition&) override;
</span><span class="cx">
</span><span class="cx"> bool isImageControlsButtonElement() const override { return true; }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoreloaderFrameLoadercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/loader/FrameLoader.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/loader/FrameLoader.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/loader/FrameLoader.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -2990,7 +2990,7 @@
</span><span class="cx"> m_pageDismissalEventBeingDispatched = PageDismissalType::None;
</span><span class="cx">
</span><span class="cx"> if (!beforeUnloadEvent->defaultPrevented())
</span><del>- document->defaultEventHandler(beforeUnloadEvent.ptr());
</del><ins>+ document->defaultEventHandler(beforeUnloadEvent.get());
</ins><span class="cx"> if (beforeUnloadEvent->returnValue().isNull())
</span><span class="cx"> return true;
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoremathmlMathMLElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -267,20 +267,20 @@
</span><span class="cx"> return isLink() || StyledElement::willRespondToMouseClickEvents();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MathMLElement::defaultEventHandler(Event* event)
</del><ins>+void MathMLElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> if (isLink()) {
</span><span class="cx"> if (focused() && isEnterKeyKeydownEvent(event)) {
</span><del>- event->setDefaultHandled();
- dispatchSimulatedClick(event);
</del><ins>+ event.setDefaultHandled();
+ dispatchSimulatedClick(&event);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><del>- if (MouseEvent::canTriggerActivationBehavior(*event)) {
</del><ins>+ if (MouseEvent::canTriggerActivationBehavior(event)) {
</ins><span class="cx"> auto& href = attributeWithoutSynchronization(hrefAttr);
</span><span class="cx"> const auto& url = stripLeadingAndTrailingHTMLSpaces(href);
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> if (auto* frame = document().frame())
</span><del>- frame->loader().urlSelected(document().completeURL(url), "_self", event, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate());
</del><ins>+ frame->loader().urlSelected(document().completeURL(url), "_self", &event, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate());
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -304,13 +304,13 @@
</span><span class="cx"> return StyledElement::isFocusable();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool MathMLElement::isKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool MathMLElement::isKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> if (isFocusable() && StyledElement::supportsFocus())
</span><span class="cx"> return StyledElement::isKeyboardFocusable(event);
</span><span class="cx">
</span><span class="cx"> if (isLink())
</span><del>- return document().frame()->eventHandler().tabsToLinks(event);
</del><ins>+ return document().frame()->eventHandler().tabsToLinks(&event);
</ins><span class="cx">
</span><span class="cx"> return StyledElement::isKeyboardFocusable(event);
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoremathmlMathMLElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -105,7 +105,7 @@
</span><span class="cx"> bool isFlowContent(const Node&) const;
</span><span class="cx">
</span><span class="cx"> bool willRespondToMouseClickEvents() override;
</span><del>- void defaultEventHandler(Event*) override;
</del><ins>+ void defaultEventHandler(Event&) override;
</ins><span class="cx">
</span><span class="cx"> const Length& cachedMathMLLength(const QualifiedName&, Optional<Length>&);
</span><span class="cx"> const BooleanValue& cachedBooleanAttribute(const QualifiedName&, Optional<BooleanValue>&);
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx">
</span><span class="cx"> bool canStartSelection() const final;
</span><span class="cx"> bool isFocusable() const final;
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const final;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const final;
</ins><span class="cx"> bool isMouseFocusable() const final;
</span><span class="cx"> bool isURLAttribute(const Attribute&) const final;
</span><span class="cx"> bool supportsFocus() const final;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoremathmlMathMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLSelectElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLSelectElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLSelectElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -209,12 +209,12 @@
</span><span class="cx"> setNeedsStyleRecalc();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void MathMLSelectElement::defaultEventHandler(Event* event)
</del><ins>+void MathMLSelectElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().clickEvent) {
</del><ins>+ if (event.type() == eventNames().clickEvent) {
</ins><span class="cx"> if (attributeWithoutSynchronization(MathMLNames::actiontypeAttr) == "toggle") {
</span><span class="cx"> toggle();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoremathmlMathMLSelectElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLSelectElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLSelectElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/mathml/MathMLSelectElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> void finishParsingChildren() final;
</span><span class="cx"> void childrenChanged(const ChildChange&) final;
</span><span class="cx"> void attributeChanged(const QualifiedName&, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason = ModifiedDirectly) final;
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx"> bool willRespondToMouseClickEvents() final;
</span><span class="cx">
</span><span class="cx"> void toggle();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorepageEventHandlercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/page/EventHandler.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/page/EventHandler.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/page/EventHandler.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -287,26 +287,26 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline bool didScrollInScrollableArea(ScrollableArea* scrollableArea, WheelEvent* wheelEvent)
</del><ins>+static inline bool didScrollInScrollableArea(ScrollableArea* scrollableArea, WheelEvent& wheelEvent)
</ins><span class="cx"> {
</span><del>- ScrollGranularity scrollGranularity = wheelGranularityToScrollGranularity(wheelEvent->deltaMode());
</del><ins>+ ScrollGranularity scrollGranularity = wheelGranularityToScrollGranularity(wheelEvent.deltaMode());
</ins><span class="cx"> bool didHandleWheelEvent = false;
</span><del>- if (float absoluteDelta = std::abs(wheelEvent->deltaX()))
- didHandleWheelEvent |= scrollableArea->scroll(wheelEvent->deltaX() > 0 ? ScrollRight : ScrollLeft, scrollGranularity, absoluteDelta);
</del><ins>+ if (float absoluteDelta = std::abs(wheelEvent.deltaX()))
+ didHandleWheelEvent |= scrollableArea->scroll(wheelEvent.deltaX() > 0 ? ScrollRight : ScrollLeft, scrollGranularity, absoluteDelta);
</ins><span class="cx">
</span><del>- if (float absoluteDelta = std::abs(wheelEvent->deltaY()))
- didHandleWheelEvent |= scrollableArea->scroll(wheelEvent->deltaY() > 0 ? ScrollDown : ScrollUp, scrollGranularity, absoluteDelta);
</del><ins>+ if (float absoluteDelta = std::abs(wheelEvent.deltaY()))
+ didHandleWheelEvent |= scrollableArea->scroll(wheelEvent.deltaY() > 0 ? ScrollDown : ScrollUp, scrollGranularity, absoluteDelta);
</ins><span class="cx">
</span><span class="cx"> return didHandleWheelEvent;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline bool handleWheelEventInAppropriateEnclosingBox(Node* startNode, WheelEvent* wheelEvent, Element** stopElement, const FloatSize& filteredPlatformDelta)
</del><ins>+static inline bool handleWheelEventInAppropriateEnclosingBox(Node* startNode, WheelEvent& wheelEvent, Element** stopElement, const FloatSize& filteredPlatformDelta)
</ins><span class="cx"> {
</span><del>- bool shouldHandleEvent = wheelEvent->deltaX() || wheelEvent->deltaY();
</del><ins>+ bool shouldHandleEvent = wheelEvent.deltaX() || wheelEvent.deltaY();
</ins><span class="cx"> #if PLATFORM(MAC)
</span><del>- shouldHandleEvent |= wheelEvent->phase() == PlatformWheelEventPhaseEnded;
</del><ins>+ shouldHandleEvent |= wheelEvent.phase() == PlatformWheelEventPhaseEnded;
</ins><span class="cx"> #if ENABLE(CSS_SCROLL_SNAP)
</span><del>- shouldHandleEvent |= wheelEvent->momentumPhase() == PlatformWheelEventPhaseEnded;
</del><ins>+ shouldHandleEvent |= wheelEvent.momentumPhase() == PlatformWheelEventPhaseEnded;
</ins><span class="cx"> #endif
</span><span class="cx"> #endif
</span><span class="cx"> if (!startNode->renderer() || !shouldHandleEvent)
</span><span class="lines">@@ -319,7 +319,7 @@
</span><span class="cx"> RenderBox* currentEnclosingBox = &initialEnclosingBox;
</span><span class="cx"> while (currentEnclosingBox) {
</span><span class="cx"> if (RenderLayer* boxLayer = currentEnclosingBox->layer()) {
</span><del>- const PlatformWheelEvent* platformEvent = wheelEvent->wheelEvent();
</del><ins>+ const PlatformWheelEvent* platformEvent = wheelEvent.wheelEvent();
</ins><span class="cx"> bool scrollingWasHandled;
</span><span class="cx"> if (platformEvent != nullptr)
</span><span class="cx"> scrollingWasHandled = boxLayer->handleWheelEvent(platformEvent->copyWithDeltas(filteredPlatformDelta.width(), filteredPlatformDelta.height()));
</span><span class="lines">@@ -338,7 +338,7 @@
</span><span class="cx">
</span><span class="cx"> currentEnclosingBox = currentEnclosingBox->containingBlock();
</span><span class="cx"> if (currentEnclosingBox && currentEnclosingBox->isRenderNamedFlowThread())
</span><del>- currentEnclosingBox = RenderNamedFlowThread::fragmentFromRenderBoxAsRenderBlock(currentEnclosingBox, roundedIntPoint(wheelEvent->absoluteLocation()), initialEnclosingBox);
</del><ins>+ currentEnclosingBox = RenderNamedFlowThread::fragmentFromRenderBoxAsRenderBlock(currentEnclosingBox, roundedIntPoint(wheelEvent.absoluteLocation()), initialEnclosingBox);
</ins><span class="cx"> if (!currentEnclosingBox || currentEnclosingBox->isRenderView())
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="lines">@@ -2717,13 +2717,13 @@
</span><span class="cx"> filter->endFilteringDeltas();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void EventHandler::defaultWheelEventHandler(Node* startNode, WheelEvent* wheelEvent)
</del><ins>+void EventHandler::defaultWheelEventHandler(Node* startNode, WheelEvent& wheelEvent)
</ins><span class="cx"> {
</span><del>- if (!startNode || !wheelEvent)
</del><ins>+ if (!startNode)
</ins><span class="cx"> return;
</span><span class="cx">
</span><del>- FloatSize filteredPlatformDelta(wheelEvent->deltaX(), wheelEvent->deltaY());
- if (const PlatformWheelEvent* platformWheelEvent = wheelEvent->wheelEvent()) {
</del><ins>+ FloatSize filteredPlatformDelta(wheelEvent.deltaX(), wheelEvent.deltaY());
+ if (const PlatformWheelEvent* platformWheelEvent = wheelEvent.wheelEvent()) {
</ins><span class="cx"> filteredPlatformDelta.setWidth(platformWheelEvent->deltaX());
</span><span class="cx"> filteredPlatformDelta.setHeight(platformWheelEvent->deltaY());
</span><span class="cx"> }
</span><span class="lines">@@ -2740,7 +2740,7 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> if (handleWheelEventInAppropriateEnclosingBox(startNode, wheelEvent, &stopElement, filteredPlatformDelta))
</span><del>- wheelEvent->setDefaultHandled();
</del><ins>+ wheelEvent.setDefaultHandled();
</ins><span class="cx">
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> if (latchedState && !latchedState->wheelEventElement())
</span><span class="lines">@@ -3089,7 +3089,7 @@
</span><span class="cx"> // in order to match IE:
</span><span class="cx"> // 1. preventing default handling of keydown and keypress events has no effect on IM input;
</span><span class="cx"> // 2. if an input method handles the event, its keyCode is set to 229 in keydown event.
</span><del>- m_frame.editor().handleInputMethodKeydown(keydown.ptr());
</del><ins>+ m_frame.editor().handleInputMethodKeydown(keydown.get());
</ins><span class="cx">
</span><span class="cx"> bool handledByInputMethod = keydown->defaultHandled();
</span><span class="cx">
</span><span class="lines">@@ -3190,22 +3190,19 @@
</span><span class="cx"> selection.setSelection(visiblePosition, FrameSelection::defaultSetSelectionOptions(UserTriggered), intent);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static void handleKeyboardSelectionMovement(Frame& frame, KeyboardEvent* event)
</del><ins>+static void handleKeyboardSelectionMovement(Frame& frame, KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- if (!event)
- return;
-
</del><span class="cx"> FrameSelection& selection = frame.selection();
</span><span class="cx">
</span><del>- bool isCommanded = event->getModifierState("Meta");
- bool isOptioned = event->getModifierState("Alt");
</del><ins>+ bool isCommanded = event.getModifierState("Meta");
+ bool isOptioned = event.getModifierState("Alt");
</ins><span class="cx"> bool isSelection = !selection.isNone();
</span><span class="cx">
</span><del>- FrameSelection::EAlteration alternation = event->getModifierState("Shift") ? FrameSelection::AlterationExtend : FrameSelection::AlterationMove;
</del><ins>+ FrameSelection::EAlteration alternation = event.getModifierState("Shift") ? FrameSelection::AlterationExtend : FrameSelection::AlterationMove;
</ins><span class="cx"> SelectionDirection direction = DirectionForward;
</span><span class="cx"> TextGranularity granularity = CharacterGranularity;
</span><span class="cx">
</span><del>- switch (focusDirectionForKey(event->keyIdentifier())) {
</del><ins>+ switch (focusDirectionForKey(event.keyIdentifier())) {
</ins><span class="cx"> case FocusDirectionNone:
</span><span class="cx"> return;
</span><span class="cx"> case FocusDirectionForward:
</span><span class="lines">@@ -3235,12 +3232,12 @@
</span><span class="cx"> else
</span><span class="cx"> setInitialKeyboardSelection(frame, direction);
</span><span class="cx">
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void EventHandler::handleKeyboardSelectionMovementForAccessibility(KeyboardEvent* event)
</del><ins>+void EventHandler::handleKeyboardSelectionMovementForAccessibility(KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().keydownEvent) {
</del><ins>+ if (event.type() == eventNames().keydownEvent) {
</ins><span class="cx"> if (AXObjectCache::accessibilityEnhancedUserInterfaceEnabled())
</span><span class="cx"> handleKeyboardSelectionMovement(m_frame, event);
</span><span class="cx"> }
</span><span class="lines">@@ -3267,18 +3264,18 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void EventHandler::defaultKeyboardEventHandler(KeyboardEvent* event)
</del><ins>+void EventHandler::defaultKeyboardEventHandler(KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- if (event->type() == eventNames().keydownEvent) {
</del><ins>+ if (event.type() == eventNames().keydownEvent) {
</ins><span class="cx"> m_frame.editor().handleKeyboardEvent(event);
</span><del>- if (event->defaultHandled())
</del><ins>+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><del>- if (event->keyIdentifier() == "U+0009")
</del><ins>+ if (event.keyIdentifier() == "U+0009")
</ins><span class="cx"> defaultTabEventHandler(event);
</span><del>- else if (event->keyIdentifier() == "U+0008")
</del><ins>+ else if (event.keyIdentifier() == "U+0008")
</ins><span class="cx"> defaultBackspaceEventHandler(event);
</span><span class="cx"> else {
</span><del>- FocusDirection direction = focusDirectionForKey(event->keyIdentifier());
</del><ins>+ FocusDirection direction = focusDirectionForKey(event.keyIdentifier());
</ins><span class="cx"> if (direction != FocusDirectionNone)
</span><span class="cx"> defaultArrowEventHandler(direction, event);
</span><span class="cx"> }
</span><span class="lines">@@ -3285,11 +3282,11 @@
</span><span class="cx">
</span><span class="cx"> handleKeyboardSelectionMovementForAccessibility(event);
</span><span class="cx"> }
</span><del>- if (event->type() == eventNames().keypressEvent) {
</del><ins>+ if (event.type() == eventNames().keypressEvent) {
</ins><span class="cx"> m_frame.editor().handleKeyboardEvent(event);
</span><del>- if (event->defaultHandled())
</del><ins>+ if (event.defaultHandled())
</ins><span class="cx"> return;
</span><del>- if (event->charCode() == ' ')
</del><ins>+ if (event.charCode() == ' ')
</ins><span class="cx"> defaultSpaceEventHandler(event);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -3593,23 +3590,23 @@
</span><span class="cx"> return eventInvertsTabsToLinksClientCallResult(event) ? !tabsToLinksClientCallResult : tabsToLinksClientCallResult;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void EventHandler::defaultTextInputEventHandler(TextEvent* event)
</del><ins>+void EventHandler::defaultTextInputEventHandler(TextEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> if (m_frame.editor().handleTextEvent(event))
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><del>-void EventHandler::defaultSpaceEventHandler(KeyboardEvent* event)
</del><ins>+void EventHandler::defaultSpaceEventHandler(KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- ASSERT(event->type() == eventNames().keypressEvent);
</del><ins>+ ASSERT(event.type() == eventNames().keypressEvent);
</ins><span class="cx">
</span><del>- if (event->ctrlKey() || event->metaKey() || event->altKey() || event->altGraphKey())
</del><ins>+ if (event.ctrlKey() || event.metaKey() || event.altKey() || event.altGraphKey())
</ins><span class="cx"> return;
</span><span class="cx">
</span><del>- ScrollLogicalDirection direction = event->shiftKey() ? ScrollBlockDirectionBackward : ScrollBlockDirectionForward;
</del><ins>+ ScrollLogicalDirection direction = event.shiftKey() ? ScrollBlockDirectionBackward : ScrollBlockDirectionForward;
</ins><span class="cx"> if (logicalScrollOverflow(direction, ScrollByPage)) {
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3618,14 +3615,14 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (view->logicalScroll(direction, ScrollByPage))
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void EventHandler::defaultBackspaceEventHandler(KeyboardEvent* event)
</del><ins>+void EventHandler::defaultBackspaceEventHandler(KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- ASSERT(event->type() == eventNames().keydownEvent);
</del><ins>+ ASSERT(event.type() == eventNames().keydownEvent);
</ins><span class="cx">
</span><del>- if (event->ctrlKey() || event->metaKey() || event->altKey() || event->altGraphKey())
</del><ins>+ if (event.ctrlKey() || event.metaKey() || event.altKey() || event.altGraphKey())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (!m_frame.editor().behavior().shouldNavigateBackOnBackspace())
</span><span class="lines">@@ -3640,21 +3637,21 @@
</span><span class="cx">
</span><span class="cx"> bool handledEvent = false;
</span><span class="cx">
</span><del>- if (event->shiftKey())
</del><ins>+ if (event.shiftKey())
</ins><span class="cx"> handledEvent = page->backForward().goForward();
</span><span class="cx"> else
</span><span class="cx"> handledEvent = page->backForward().goBack();
</span><span class="cx">
</span><span class="cx"> if (handledEvent)
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><del>-void EventHandler::defaultArrowEventHandler(FocusDirection focusDirection, KeyboardEvent* event)
</del><ins>+void EventHandler::defaultArrowEventHandler(FocusDirection focusDirection, KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- ASSERT(event->type() == eventNames().keydownEvent);
</del><ins>+ ASSERT(event.type() == eventNames().keydownEvent);
</ins><span class="cx">
</span><del>- if (event->ctrlKey() || event->metaKey() || event->altGraphKey() || event->shiftKey())
</del><ins>+ if (event.ctrlKey() || event.metaKey() || event.altGraphKey() || event.shiftKey())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> Page* page = m_frame.page();
</span><span class="lines">@@ -3669,16 +3666,16 @@
</span><span class="cx"> if (m_frame.document()->inDesignMode())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (page->focusController().advanceFocus(focusDirection, event))
- event->setDefaultHandled();
</del><ins>+ if (page->focusController().advanceFocus(focusDirection, &event))
+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void EventHandler::defaultTabEventHandler(KeyboardEvent* event)
</del><ins>+void EventHandler::defaultTabEventHandler(KeyboardEvent& event)
</ins><span class="cx"> {
</span><del>- ASSERT(event->type() == eventNames().keydownEvent);
</del><ins>+ ASSERT(event.type() == eventNames().keydownEvent);
</ins><span class="cx">
</span><span class="cx"> // We should only advance focus on tabs if no special modifier keys are held down.
</span><del>- if (event->ctrlKey() || event->metaKey() || event->altGraphKey())
</del><ins>+ if (event.ctrlKey() || event.metaKey() || event.altGraphKey())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> Page* page = m_frame.page();
</span><span class="lines">@@ -3687,14 +3684,14 @@
</span><span class="cx"> if (!page->tabKeyCyclesThroughElements())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- FocusDirection focusDirection = event->shiftKey() ? FocusDirectionBackward : FocusDirectionForward;
</del><ins>+ FocusDirection focusDirection = event.shiftKey() ? FocusDirectionBackward : FocusDirectionForward;
</ins><span class="cx">
</span><span class="cx"> // Tabs can be used in design mode editing.
</span><span class="cx"> if (m_frame.document()->inDesignMode())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (page->focusController().advanceFocus(focusDirection, event))
- event->setDefaultHandled();
</del><ins>+ if (page->focusController().advanceFocus(focusDirection, &event))
+ event.setDefaultHandled();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void EventHandler::sendScrollEvent()
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorepageEventHandlerh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/page/EventHandler.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/page/EventHandler.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/page/EventHandler.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -201,7 +201,7 @@
</span><span class="cx"> WEBCORE_EXPORT bool handleMouseReleaseEvent(const PlatformMouseEvent&);
</span><span class="cx"> bool handleMouseForceEvent(const PlatformMouseEvent&);
</span><span class="cx"> WEBCORE_EXPORT bool handleWheelEvent(const PlatformWheelEvent&);
</span><del>- void defaultWheelEventHandler(Node*, WheelEvent*);
</del><ins>+ void defaultWheelEventHandler(Node*, WheelEvent&);
</ins><span class="cx"> bool handlePasteGlobalSelection(const PlatformMouseEvent&);
</span><span class="cx">
</span><span class="cx"> void platformPrepareForWheelEvents(const PlatformWheelEvent&, const HitTestResult&, RefPtr<Element>& eventTarget, RefPtr<ContainerNode>& scrollableContainer, WeakPtr<ScrollableArea>&, bool& isOverWidget);
</span><span class="lines">@@ -247,13 +247,13 @@
</span><span class="cx"> static unsigned accessKeyModifiers();
</span><span class="cx"> WEBCORE_EXPORT bool handleAccessKey(const PlatformKeyboardEvent&);
</span><span class="cx"> WEBCORE_EXPORT bool keyEvent(const PlatformKeyboardEvent&);
</span><del>- void defaultKeyboardEventHandler(KeyboardEvent*);
</del><ins>+ void defaultKeyboardEventHandler(KeyboardEvent&);
</ins><span class="cx">
</span><span class="cx"> bool accessibilityPreventsEventPropogation(KeyboardEvent&);
</span><del>- WEBCORE_EXPORT void handleKeyboardSelectionMovementForAccessibility(KeyboardEvent*);
</del><ins>+ WEBCORE_EXPORT void handleKeyboardSelectionMovementForAccessibility(KeyboardEvent&);
</ins><span class="cx">
</span><span class="cx"> bool handleTextInputEvent(const String& text, Event* underlyingEvent = nullptr, TextEventInputType = TextEventInputKeyboard);
</span><del>- void defaultTextInputEventHandler(TextEvent*);
</del><ins>+ void defaultTextInputEventHandler(TextEvent&);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(DRAG_SUPPORT)
</span><span class="cx"> WEBCORE_EXPORT bool eventMayStartDrag(const PlatformMouseEvent&) const;
</span><span class="lines">@@ -420,10 +420,10 @@
</span><span class="cx"> bool widgetDidHandleWheelEvent(const PlatformWheelEvent&, Widget&);
</span><span class="cx"> bool completeWidgetWheelEvent(const PlatformWheelEvent&, const WeakPtr<Widget>&, const WeakPtr<ScrollableArea>&, ContainerNode*);
</span><span class="cx">
</span><del>- void defaultSpaceEventHandler(KeyboardEvent*);
- void defaultBackspaceEventHandler(KeyboardEvent*);
- void defaultTabEventHandler(KeyboardEvent*);
- void defaultArrowEventHandler(FocusDirection, KeyboardEvent*);
</del><ins>+ void defaultSpaceEventHandler(KeyboardEvent&);
+ void defaultBackspaceEventHandler(KeyboardEvent&);
+ void defaultTabEventHandler(KeyboardEvent&);
+ void defaultArrowEventHandler(FocusDirection, KeyboardEvent&);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(DRAG_SUPPORT)
</span><span class="cx"> DragSourceAction updateDragSourceActionsAllowed() const;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorepageFocusControllercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/page/FocusController.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/page/FocusController.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/page/FocusController.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -291,17 +291,17 @@
</span><span class="cx">
</span><span class="cx"> static inline bool isFocusableElementOrScopeOwner(Element& element, KeyboardEvent* event)
</span><span class="cx"> {
</span><del>- return element.isKeyboardFocusable(event) || isFocusScopeOwner(element);
</del><ins>+ return element.isKeyboardFocusable(*event) || isFocusScopeOwner(element);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline bool isNonFocusableScopeOwner(Element& element, KeyboardEvent* event)
</span><span class="cx"> {
</span><del>- return !element.isKeyboardFocusable(event) && isFocusScopeOwner(element);
</del><ins>+ return !element.isKeyboardFocusable(*event) && isFocusScopeOwner(element);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline bool isFocusableScopeOwner(Element& element, KeyboardEvent* event)
</span><span class="cx"> {
</span><del>- return element.isKeyboardFocusable(event) && isFocusScopeOwner(element);
</del><ins>+ return element.isKeyboardFocusable(*event) && isFocusScopeOwner(element);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline int shadowAdjustedTabIndex(Element& element, KeyboardEvent* event)
</span><span class="lines">@@ -464,7 +464,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (is<HTMLFrameOwnerElement>(*element) && (!is<HTMLPlugInElement>(*element) || !element->isKeyboardFocusable(event))) {
</del><ins>+ if (is<HTMLFrameOwnerElement>(*element) && (!is<HTMLPlugInElement>(*element) || !element->isKeyboardFocusable(*event))) {
</ins><span class="cx"> // We focus frames rather than frame owners.
</span><span class="cx"> // FIXME: We should not focus frames that have no scrollbars, as focusing them isn't useful to the user.
</span><span class="cx"> HTMLFrameOwnerElement& owner = downcast<HTMLFrameOwnerElement>(*element);
</span><span class="lines">@@ -954,7 +954,7 @@
</span><span class="cx"> if (element == focusedNode)
</span><span class="cx"> continue;
</span><span class="cx">
</span><del>- if (!element->isKeyboardFocusable(event) && !element->isFrameOwnerElement() && !canScrollInDirection(element, direction))
</del><ins>+ if (!element->isKeyboardFocusable(*event) && !element->isFrameOwnerElement() && !canScrollInDirection(element, direction))
</ins><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> FocusCandidate candidate = FocusCandidate(element, direction);
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorerenderingRenderFrameSetcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/rendering/RenderFrameSet.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/rendering/RenderFrameSet.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/rendering/RenderFrameSet.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -677,7 +677,7 @@
</span><span class="cx"> setNeedsLayout();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool RenderFrameSet::userResize(MouseEvent* evt)
</del><ins>+bool RenderFrameSet::userResize(MouseEvent& event)
</ins><span class="cx"> {
</span><span class="cx"> if (flattenFrameSet())
</span><span class="cx"> return false;
</span><span class="lines">@@ -685,8 +685,8 @@
</span><span class="cx"> if (!m_isResizing) {
</span><span class="cx"> if (needsLayout())
</span><span class="cx"> return false;
</span><del>- if (evt->type() == eventNames().mousedownEvent && evt->button() == LeftButton) {
- FloatPoint localPos = absoluteToLocal(evt->absoluteLocation(), UseTransforms);
</del><ins>+ if (event.type() == eventNames().mousedownEvent && event.button() == LeftButton) {
+ FloatPoint localPos = absoluteToLocal(event.absoluteLocation(), UseTransforms);
</ins><span class="cx"> startResizing(m_cols, localPos.x());
</span><span class="cx"> startResizing(m_rows, localPos.y());
</span><span class="cx"> if (m_cols.m_splitBeingResized != noSplit || m_rows.m_splitBeingResized != noSplit) {
</span><span class="lines">@@ -695,11 +695,11 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><del>- if (evt->type() == eventNames().mousemoveEvent || (evt->type() == eventNames().mouseupEvent && evt->button() == LeftButton)) {
- FloatPoint localPos = absoluteToLocal(evt->absoluteLocation(), UseTransforms);
</del><ins>+ if (event.type() == eventNames().mousemoveEvent || (event.type() == eventNames().mouseupEvent && event.button() == LeftButton)) {
+ FloatPoint localPos = absoluteToLocal(event.absoluteLocation(), UseTransforms);
</ins><span class="cx"> continueResizing(m_cols, localPos.x());
</span><span class="cx"> continueResizing(m_rows, localPos.y());
</span><del>- if (evt->type() == eventNames().mouseupEvent && evt->button() == LeftButton) {
</del><ins>+ if (event.type() == eventNames().mouseupEvent && event.button() == LeftButton) {
</ins><span class="cx"> setIsResizing(false);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCorerenderingRenderFrameSeth"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/rendering/RenderFrameSet.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/rendering/RenderFrameSet.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/rendering/RenderFrameSet.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx">
</span><span class="cx"> FrameEdgeInfo edgeInfo() const;
</span><span class="cx">
</span><del>- bool userResize(MouseEvent*);
</del><ins>+ bool userResize(MouseEvent&);
</ins><span class="cx">
</span><span class="cx"> bool isResizingRow() const;
</span><span class="cx"> bool isResizingColumn() const;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoresvgSVGAElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/svg/SVGAElement.cpp (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/svg/SVGAElement.cpp 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/svg/SVGAElement.cpp 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -113,16 +113,16 @@
</span><span class="cx"> return createRenderer<RenderSVGTransformableContainer>(*this, WTFMove(style));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void SVGAElement::defaultEventHandler(Event* event)
</del><ins>+void SVGAElement::defaultEventHandler(Event& event)
</ins><span class="cx"> {
</span><span class="cx"> if (isLink()) {
</span><span class="cx"> if (focused() && isEnterKeyKeydownEvent(event)) {
</span><del>- event->setDefaultHandled();
- dispatchSimulatedClick(event);
</del><ins>+ event.setDefaultHandled();
+ dispatchSimulatedClick(&event);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (MouseEvent::canTriggerActivationBehavior(*event)) {
</del><ins>+ if (MouseEvent::canTriggerActivationBehavior(event)) {
</ins><span class="cx"> String url = stripLeadingAndTrailingHTMLSpaces(href());
</span><span class="cx">
</span><span class="cx"> if (url[0] == '#') {
</span><span class="lines">@@ -129,7 +129,7 @@
</span><span class="cx"> Element* targetElement = treeScope().getElementById(url.substringSharingImpl(1));
</span><span class="cx"> if (is<SVGSMILElement>(targetElement)) {
</span><span class="cx"> downcast<SVGSMILElement>(*targetElement).beginByLinkActivation();
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> // Only allow navigation to internal <view> anchors.
</span><span class="lines">@@ -140,12 +140,12 @@
</span><span class="cx"> String target = this->target();
</span><span class="cx"> if (target.isEmpty() && attributeWithoutSynchronization(XLinkNames::showAttr) == "new")
</span><span class="cx"> target = "_blank";
</span><del>- event->setDefaultHandled();
</del><ins>+ event.setDefaultHandled();
</ins><span class="cx">
</span><span class="cx"> Frame* frame = document().frame();
</span><span class="cx"> if (!frame)
</span><span class="cx"> return;
</span><del>- frame->loader().urlSelected(document().completeURL(url), target, event, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate());
</del><ins>+ frame->loader().urlSelected(document().completeURL(url), target, &event, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate());
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -190,13 +190,13 @@
</span><span class="cx"> return SVGElement::isMouseFocusable();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool SVGAElement::isKeyboardFocusable(KeyboardEvent* event) const
</del><ins>+bool SVGAElement::isKeyboardFocusable(KeyboardEvent& event) const
</ins><span class="cx"> {
</span><span class="cx"> if (isFocusable() && Element::supportsFocus())
</span><span class="cx"> return SVGElement::isKeyboardFocusable(event);
</span><span class="cx">
</span><span class="cx"> if (isLink())
</span><del>- return document().frame()->eventHandler().tabsToLinks(event);
</del><ins>+ return document().frame()->eventHandler().tabsToLinks(&event);
</ins><span class="cx">
</span><span class="cx"> return SVGElement::isKeyboardFocusable(event);
</span><span class="cx"> }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebCoresvgSVGAElementh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/svg/SVGAElement.h (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebCore/svg/SVGAElement.h 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/svg/SVGAElement.h 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -49,11 +49,11 @@
</span><span class="cx"> RenderPtr<RenderElement> createElementRenderer(RenderStyle&&, const RenderTreePosition&) final;
</span><span class="cx"> bool childShouldCreateRenderer(const Node&) const final;
</span><span class="cx">
</span><del>- void defaultEventHandler(Event*) final;
</del><ins>+ void defaultEventHandler(Event&) final;
</ins><span class="cx">
</span><span class="cx"> bool supportsFocus() const final;
</span><span class="cx"> bool isMouseFocusable() const final;
</span><del>- bool isKeyboardFocusable(KeyboardEvent*) const final;
</del><ins>+ bool isKeyboardFocusable(KeyboardEvent&) const final;
</ins><span class="cx"> bool isFocusable() const final;
</span><span class="cx"> bool isURLAttribute(const Attribute&) const final;
</span><span class="cx"> bool canStartSelection() const final;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-08-31 Andreas Kling <akling@apple.com>
+
+ DOM event handling should pass Event around by reference.
+ <https://webkit.org/b/161398>
+
+ Reviewed by Chris Dumez.
+
+ * WebProcess/WebPage/mac/WebPageMac.mm:
+ (WebKit::WebPage::performNonEditingBehaviorForSelector):
+
</ins><span class="cx"> 2016-08-30 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> Introduce the ThrowScope and force every throw site to instantiate a ThrowScope.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit214SourceWebKit2WebProcessWebPagemacWebPageMacmm"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (205603 => 205604)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2016-09-08 08:00:34 UTC (rev 205603)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2016-09-08 08:19:12 UTC (rev 205604)
</span><span class="lines">@@ -532,7 +532,7 @@
</span><span class="cx"> {
</span><span class="cx"> // First give accessibility a chance to handle the event.
</span><span class="cx"> Frame* frame = frameForEvent(event);
</span><del>- frame->eventHandler().handleKeyboardSelectionMovementForAccessibility(event);
</del><ins>+ frame->eventHandler().handleKeyboardSelectionMovementForAccessibility(*event);
</ins><span class="cx"> if (event->defaultHandled())
</span><span class="cx"> return true;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>