<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205554] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205554">205554</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-09-07 10:21:44 -0700 (Wed, 07 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Drop legacy canvas.probablySupportsContext()
https://bugs.webkit.org/show_bug.cgi?id=161692
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
* web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical-expected.txt:
Source/WebCore:
Drop legacy canvas.probablySupportsContext() as it is no longer in the specification:
- https://html.spec.whatwg.org/#htmlcanvaselement
Firefox and Chrome do not support canvas.probablySupportsContext().
No new tests, rebaselined existing test.
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::probablySupportsContext): Deleted.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::probablySupportsContext): Deleted.
* html/HTMLCanvasElement.h:
* html/HTMLCanvasElement.idl:
Source/WebInspectorUI:
* UserInterface/Models/NativeFunctionParameters.js:
LayoutTests:
Drop legacy layout test.
* fast/canvas/webgl/canvas-supports-context-expected.txt: Removed.
* fast/canvas/webgl/canvas-supports-context.html: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsembeddedcontentthecanvaselementhistoricalexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSHTMLCanvasElementCustomcpp">trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCanvasElementcpp">trunk/Source/WebCore/html/HTMLCanvasElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCanvasElementh">trunk/Source/WebCore/html/HTMLCanvasElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCanvasElementidl">trunk/Source/WebCore/html/HTMLCanvasElement.idl</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs">trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcanvaswebglcanvassupportscontextexpectedtxt">trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcanvaswebglcanvassupportscontexthtml">trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/LayoutTests/ChangeLog 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-09-07 Chris Dumez <cdumez@apple.com>
+
+ Drop legacy canvas.probablySupportsContext()
+ https://bugs.webkit.org/show_bug.cgi?id=161692
+
+ Reviewed by Alex Christensen.
+
+ Drop legacy layout test.
+
+ * fast/canvas/webgl/canvas-supports-context-expected.txt: Removed.
+ * fast/canvas/webgl/canvas-supports-context.html: Removed.
+
</ins><span class="cx"> 2016-09-07 Nan Wang <n_wang@apple.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Layout test accessibility/media-emits-object-replacement.html fails
</span></span></pre></div>
<a id="trunkLayoutTestsfastcanvaswebglcanvassupportscontextexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -1,121 +0,0 @@
</span><del>-This test ensures WebGL implementations interact correctly with the canvas tag's probablySupportsContext function, that getContext and probablySupportsContext are implemented consistently with one another, and that malformed parameters to probablySupportsContext are handled correctly.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-Canvas.probablySupportsContext('2d')
-
-PASS probablySupportsContext('2d') is consistent with getContext('2d')
-PASS probablySupportsContext('2d') returns true
-PASS getContext('2d') returns true (context exists)
-Testing getContext and probablySupportsContext('2d') after a context is created
-PASS probablySupportsContext('2d') returns true
-PASS probablySupportsContext('webkit-3d') returns false
-PASS webkit-3d context does not exist
-
-WebGL disabled
-
-Canvas.probablySupportsContext('webkit-3d')
-
-PASS probablySupportsContext('webkit-3d') is consistent with getContext('webkit-3d')
-FAIL probablySupportsContext('webkit-3d') returns false
-FAIL getContext('webkit-3d') returns false (context does not exist)
-
-Canvas.probablySupportsContext('experimental-webgl')
-
-PASS probablySupportsContext('experimental-webgl') is consistent with getContext('experimental-webgl')
-FAIL probablySupportsContext('experimental-webgl') returns false
-FAIL getContext('experimental-webgl') returns false (context does not exist)
-
-Canvas.probablySupportsContext('moz-webgl')
-
-PASS probablySupportsContext('moz-webgl') is consistent with getContext('moz-webgl')
-FAIL probablySupportsContext('moz-webgl') returns false
-FAIL getContext('moz-webgl') returns false (context does not exist)
-
-WebGL enabled
-
-Canvas.probablySupportsContext('webkit-3d')
-
-PASS probablySupportsContext('webkit-3d') is consistent with getContext('webkit-3d')
-PASS probablySupportsContext('webkit-3d') returns true
-PASS getContext('webkit-3d') returns true (context exists)
-Testing getContext and probablySupportsContext('webkit-3d') after a context is created
-PASS probablySupportsContext('webkit-3d') returns true
-PASS probablySupportsContext('2d') returns false
-PASS 2d context does not exist
-
-Canvas.probablySupportsContext('experimental-webgl')
-
-PASS probablySupportsContext('experimental-webgl') is consistent with getContext('experimental-webgl')
-PASS probablySupportsContext('experimental-webgl') returns true
-PASS getContext('experimental-webgl') returns true (context exists)
-Testing getContext and probablySupportsContext('experimental-webgl') after a context is created
-PASS probablySupportsContext('experimental-webgl') returns true
-PASS probablySupportsContext('2d') returns false
-PASS 2d context does not exist
-
-Canvas.probablySupportsContext('moz-webgl')
-
-PASS probablySupportsContext('moz-webgl') is consistent with getContext('moz-webgl')
-FAIL probablySupportsContext('moz-webgl') returns false
-FAIL getContext('moz-webgl') returns false (context does not exist)
-
-Testing malformed attributes that cause probablySupportsContext and getContext to be undefined
-
-canvas.probablySupportsContext('webkit-3d' ,{ get alpha() { throw 'Test alpha Error'; } })
-
-PASS supports is undefined
-PASS context is undefined
-PASS probablySupportsContext('webkit-3d' ,{ get alpha() { throw 'Test alpha Error'; } }) is consistent with getContext('webkit-3d' ,{ get alpha() { throw 'Test alpha Error'; } })
-FAIL probablySupportsContext('webkit-3d' ,{ get alpha() { throw 'Test alpha Error'; } }) returns false
-FAIL getContext('webkit-3d' ,{ get alpha() { throw 'Test alpha Error'; } }) returns false (context does not exist)
-
-canvas.probablySupportsContext('webkit-3d' ,{ get depth() { throw 'Test depth Error'; } })
-
-PASS supports is undefined
-PASS context is undefined
-PASS probablySupportsContext('webkit-3d' ,{ get depth() { throw 'Test depth Error'; } }) is consistent with getContext('webkit-3d' ,{ get depth() { throw 'Test depth Error'; } })
-FAIL probablySupportsContext('webkit-3d' ,{ get depth() { throw 'Test depth Error'; } }) returns false
-FAIL getContext('webkit-3d' ,{ get depth() { throw 'Test depth Error'; } }) returns false (context does not exist)
-
-canvas.probablySupportsContext('webkit-3d' ,{ get stencil() { throw 'Test stencil Error'; } })
-
-PASS supports is undefined
-PASS context is undefined
-PASS probablySupportsContext('webkit-3d' ,{ get stencil() { throw 'Test stencil Error'; } }) is consistent with getContext('webkit-3d' ,{ get stencil() { throw 'Test stencil Error'; } })
-FAIL probablySupportsContext('webkit-3d' ,{ get stencil() { throw 'Test stencil Error'; } }) returns false
-FAIL getContext('webkit-3d' ,{ get stencil() { throw 'Test stencil Error'; } }) returns false (context does not exist)
-
-canvas.probablySupportsContext('webkit-3d' ,{ get antialias() { throw 'Test antialias Error'; } })
-
-PASS supports is undefined
-PASS context is undefined
-PASS probablySupportsContext('webkit-3d' ,{ get antialias() { throw 'Test antialias Error'; } }) is consistent with getContext('webkit-3d' ,{ get antialias() { throw 'Test antialias Error'; } })
-FAIL probablySupportsContext('webkit-3d' ,{ get antialias() { throw 'Test antialias Error'; } }) returns false
-FAIL getContext('webkit-3d' ,{ get antialias() { throw 'Test antialias Error'; } }) returns false (context does not exist)
-
-canvas.probablySupportsContext('webkit-3d' ,{ get premultipliedAlpha() { throw 'Test premultipliedAlpha Error'; } })
-
-PASS supports is undefined
-PASS context is undefined
-PASS probablySupportsContext('webkit-3d' ,{ get premultipliedAlpha() { throw 'Test premultipliedAlpha Error'; } }) is consistent with getContext('webkit-3d' ,{ get premultipliedAlpha() { throw 'Test premultipliedAlpha Error'; } })
-FAIL probablySupportsContext('webkit-3d' ,{ get premultipliedAlpha() { throw 'Test premultipliedAlpha Error'; } }) returns false
-FAIL getContext('webkit-3d' ,{ get premultipliedAlpha() { throw 'Test premultipliedAlpha Error'; } }) returns false (context does not exist)
-
-canvas.probablySupportsContext('webkit-3d' ,{ get preserveDrawingBUffer() { throw 'Test preserveDrawingBuffer Error'; } })
-
-PASS supports is undefined
-PASS context is undefined
-PASS probablySupportsContext('webkit-3d' ,{ get preserveDrawingBUffer() { throw 'Test preserveDrawingBuffer Error'; } }) is consistent with getContext('webkit-3d' ,{ get preserveDrawingBUffer() { throw 'Test preserveDrawingBuffer Error'; } })
-FAIL probablySupportsContext('webkit-3d' ,{ get preserveDrawingBUffer() { throw 'Test preserveDrawingBuffer Error'; } }) returns false
-FAIL getContext('webkit-3d' ,{ get preserveDrawingBUffer() { throw 'Test preserveDrawingBuffer Error'; } }) returns false (context does not exist)
-
-Testing how probablySupportsContext handles no parameters
-PASS document.createElement('canvas').probablySupportsContext() threw exception TypeError: Not enough arguments.
-
-PASS successfullyParsed is true
-Some tests failed.
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastcanvaswebglcanvassupportscontexthtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context.html (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context.html 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context.html 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -1,169 +0,0 @@
</span><del>-<html>
-<head>
-<title>WebGL Canvas probablySupportsContext Tests</title>
-<script src="../../../resources/js-test.js"></script>
-</head>
-<body>
-<div id="description"></div>
-<div id="console"></div>
-<script>
-var type2d = "2d";
-var type3dlegacy = "webkit-3d";
-var type3dprovisional = "experimental-webgl";
-var type3dmoz = "moz-webgl";
-
-function print_basic_results(supports, context, args_str)
-{
- if (context && !supports)
- testFailed(type_of_context + " context exists yet canvas.probablySupportsContext(" + args_str + ") returns false");
- else
- testPassed("probablySupportsContext(" + args_str + ") is consistent with getContext(" + args_str + ")");
-
- if (supports)
- testPassed("probablySupportsContext(" + args_str + ") returns true");
- else
- testFailed("probablySupportsContext(" + args_str + ") returns false");
-
- if (context) {
- testPassed("getContext(" + args_str + ") returns true (context exists)");
- return true;
- } else {
- testFailed("getContext(" + args_str + ") returns false (context does not exist)");
- return false;
- }
-}
-
-function other_type_of_context(type_of_context)
-{
- if (type_of_context == type2d)
- return type3dlegacy;
- else if ((type_of_context == type3dlegacy) || (type_of_context == type3dprovisional))
- return type2d;
- else
- return "";
-}
-
-function test_post_creation(canvas, type_of_context)
-{
- debug("Testing getContext and probablySupportsContext('" + type_of_context + "') after a context is created");
-
- if (canvas.probablySupportsContext(type_of_context))
- testPassed("probablySupportsContext('" + type_of_context + "') returns true");
- else
- testFailed("probablySupportsContext('" + type_of_context + "') returns false");
-
- var other_type = other_type_of_context(type_of_context);
-
- if (!other_type) {
- testFailed(type_of_context + ' not currently supported');
- return;
- }
-
- if (!canvas.probablySupportsContext(other_type))
- testPassed("probablySupportsContext('" + other_type + "') returns false");
- else
- testFailed("probablySupportsContext('" + other_type + "') returns true");
-
- if (!canvas.getContext(other_type))
- testPassed(other_type + " context does not exist");
- else
- testFailed(other_type + " context exists");
-
-}
-
-function check_context(type_of_context)
-{
- debug("");
- debug("Canvas.probablySupportsContext('" + type_of_context + "')");
- debug("");
-
- var canvas = document.createElement("canvas");
- var supports = canvas.probablySupportsContext(type_of_context);
- var context = canvas.getContext(type_of_context);
-
- if(print_basic_results(supports, context, "'" + type_of_context + "'"))
- test_post_creation(canvas, type_of_context);
-}
-
-function malformed_attrs(attrs, attrs_str)
-{
- type_of_context = type3dlegacy;
-
- debug("");
- debug("canvas.probablySupportsContext('" + type_of_context + "' ," + attrs_str + ")");
- debug("");
-
- var canvas = document.createElement("canvas");
- var supports;
- try {
- supports = canvas.probablySupportsContext(type_of_context, attrs);
- } catch (e) { } finally {
- if (typeof(supports) == typeof(undefined))
- testPassed("supports is undefined");
- else
- testFailed("supports is not undefined");
- }
-
- var context;
- try {
- context = canvas.getContext(type_of_context, attrs);
- } catch (e) { } finally {
- if (typeof(context) == typeof(undefined))
- testPassed("context is undefined");
- else
- testFailed("context is not undefined");
-
- }
-
- print_basic_results(supports, context, "'" + type_of_context + "' ," + attrs_str);
-}
-
-function run_tests()
-{
- description("This test ensures WebGL implementations interact correctly with the canvas tag's probablySupportsContext function, that getContext and probablySupportsContext are implemented consistently with one another, and that malformed parameters to probablySupportsContext are handled correctly.");
-
- check_context(type2d);
-
- debug("");
- debug("WebGL disabled");
- window.testRunner.overridePreference("WebKitWebGLEnabled", "0");
-
- check_context(type3dlegacy);
- check_context(type3dprovisional);
- check_context(type3dmoz); // "moz-webgl" is not supported in WK2, but was used in create3DContext
-
- debug("");
- debug("WebGL enabled");
- window.testRunner.overridePreference("WebKitWebGLEnabled", "1");
-
- check_context(type3dlegacy);
- check_context(type3dprovisional);
- check_context(type3dmoz);
-
- debug("");
- debug("Testing malformed attributes that cause probablySupportsContext and getContext to be undefined");
-
- malformed_attrs({ get alpha() { throw 'Test alpha Error'; } },
- "{ get alpha() { throw 'Test alpha Error'; } }");
- malformed_attrs({ get depth() { throw 'Test depth Error'; } },
- "{ get depth() { throw 'Test depth Error'; } }");
- malformed_attrs({ get stencil() { throw 'Test stencil Error'; } },
- "{ get stencil() { throw 'Test stencil Error'; } }");
- malformed_attrs({ get antialias() { throw 'Test antialias Error'; } },
- "{ get antialias() { throw 'Test antialias Error'; } }");
- malformed_attrs({ get premultipliedAlpha() { throw 'premultipliedAlpha Error'; } },
- "{ get premultipliedAlpha() { throw 'Test premultipliedAlpha Error'; } }");
- malformed_attrs({ get preserveDrawingBuffer() { throw 'preserveDrawingBuffer Error'; } },
- "{ get preserveDrawingBUffer() { throw 'Test preserveDrawingBuffer Error'; } }");
-
- debug("");
- debug("Testing how probablySupportsContext handles no parameters");
- shouldThrow("document.createElement('canvas').probablySupportsContext()");
-
- debug("");
-}
-
-run_tests();
-</script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-09-07 Chris Dumez <cdumez@apple.com>
+
+ Drop legacy canvas.probablySupportsContext()
+ https://bugs.webkit.org/show_bug.cgi?id=161692
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline W3C test now that one more check is passing.
+
+ * web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical-expected.txt:
+
</ins><span class="cx"> 2016-09-06 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Add support for input.minLength / textArea.minLength
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsembeddedcontentthecanvaselementhistoricalexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical-expected.txt (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical-expected.txt 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical-expected.txt 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><span class="cx">
</span><span class="cx"> PASS Canvas support for supportsContext
</span><del>-FAIL Canvas support for probablySupportsContext assert_false: expected false got true
</del><ins>+PASS Canvas support for probablySupportsContext
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/Source/WebCore/ChangeLog 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-09-07 Chris Dumez <cdumez@apple.com>
+
+ Drop legacy canvas.probablySupportsContext()
+ https://bugs.webkit.org/show_bug.cgi?id=161692
+
+ Reviewed by Alex Christensen.
+
+ Drop legacy canvas.probablySupportsContext() as it is no longer in the specification:
+ - https://html.spec.whatwg.org/#htmlcanvaselement
+
+ Firefox and Chrome do not support canvas.probablySupportsContext().
+
+ No new tests, rebaselined existing test.
+
+ * bindings/js/JSHTMLCanvasElementCustom.cpp:
+ (WebCore::JSHTMLCanvasElement::probablySupportsContext): Deleted.
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::getContext):
+ (WebCore::HTMLCanvasElement::probablySupportsContext): Deleted.
+ * html/HTMLCanvasElement.h:
+ * html/HTMLCanvasElement.idl:
+
</ins><span class="cx"> 2016-09-07 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Rename ScrollBehavior to ScrollAlignment::Behavior
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSHTMLCanvasElementCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -100,31 +100,6 @@
</span><span class="cx"> return toJS(&state, globalObject(), downcast<CanvasRenderingContext2D>(*context));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-JSValue JSHTMLCanvasElement::probablySupportsContext(ExecState& state)
-{
- VM& vm = state.vm();
- auto scope = DECLARE_THROW_SCOPE(vm);
-
- if (UNLIKELY(state.argumentCount() < 1))
- return throwException(&state, scope, createNotEnoughArgumentsError(&state));
-
- HTMLCanvasElement& canvas = wrapped();
- const String& contextId = state.uncheckedArgument(0).toWTFString(&state);
- if (state.hadException())
- return jsUndefined();
-
- RefPtr<CanvasContextAttributes> attrs;
-#if ENABLE(WEBGL)
- if (HTMLCanvasElement::is3dType(contextId)) {
- get3DContextAttributes(state, attrs);
- if (state.hadException())
- return jsUndefined();
- }
-#endif
-
- return jsBoolean(canvas.probablySupportsContext(contextId, attrs.get()));
-}
-
</del><span class="cx"> JSValue JSHTMLCanvasElement::toDataURL(ExecState& state)
</span><span class="cx"> {
</span><span class="cx"> HTMLCanvasElement& canvas = wrapped();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCanvasElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -261,23 +261,7 @@
</span><span class="cx"> #endif
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><del>-
-bool HTMLCanvasElement::probablySupportsContext(const String& type, CanvasContextAttributes*)
-{
- // FIXME: Provide implementation that accounts for attributes.
- // https://bugs.webkit.org/show_bug.cgi?id=117093
- if (is2dType(type))
- return !m_context || m_context->is2d();
</del><span class="cx">
</span><del>-#if ENABLE(WEBGL)
- if (shouldEnableWebGL(document().settings())) {
- if (is3dType(type))
- return !m_context || m_context->is3d();
- }
-#endif
- return false;
-}
-
</del><span class="cx"> bool HTMLCanvasElement::is2dType(const String& type)
</span><span class="cx"> {
</span><span class="cx"> return type == "2d";
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCanvasElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCanvasElement.h (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCanvasElement.h 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.h 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -86,7 +86,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CanvasRenderingContext* getContext(const String&, CanvasContextAttributes* = nullptr);
</span><del>- bool probablySupportsContext(const String&, CanvasContextAttributes* = nullptr);
</del><span class="cx"> static bool is2dType(const String&);
</span><span class="cx"> #if ENABLE(WEBGL)
</span><span class="cx"> static bool is3dType(const String&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCanvasElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCanvasElement.idl (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCanvasElement.idl 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.idl 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -36,6 +36,5 @@
</span><span class="cx">
</span><span class="cx"> // The custom binding is needed to handle context creation attributes.
</span><span class="cx"> [Custom] any getContext(DOMString contextId, any... arguments);
</span><del>- [Custom] boolean probablySupportsContext(DOMString contextId, any... arguments);
</del><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-09-07 Chris Dumez <cdumez@apple.com>
+
+ Drop legacy canvas.probablySupportsContext()
+ https://bugs.webkit.org/show_bug.cgi?id=161692
+
+ Reviewed by Alex Christensen.
+
+ * UserInterface/Models/NativeFunctionParameters.js:
+
</ins><span class="cx"> 2016-09-06 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Avoid linkifying some schemes in console logs
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (205553 => 205554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-09-07 17:12:54 UTC (rev 205553)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-09-07 17:21:44 UTC (rev 205554)
</span><span class="lines">@@ -872,7 +872,6 @@
</span><span class="cx">
</span><span class="cx"> HTMLCanvasElement: {
</span><span class="cx"> getContext: "contextId",
</span><del>- probablySupportsContext: "contextId",
</del><span class="cx"> toDataURL: "[type]",
</span><span class="cx"> __proto__: null,
</span><span class="cx"> },
</span></span></pre>
</div>
</div>
</body>
</html>