<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205590] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205590">205590</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2016-09-07 23:49:16 -0700 (Wed, 07 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Remove stale WebSoupRequestManager headers
https://bugs.webkit.org/show_bug.cgi?id=161691
Reviewed by Sergio Villar Senin.
WebSoupRequestManager, WebSoupRequestManagerProxy and WebSoupRequestManagerClient
classes were used to implement custom URI scheme support for Soup. This API and
the implementations of these classes were removed in <a href="http://trac.webkit.org/projects/webkit/changeset/174584">r174584</a>, but curiously the
headers went unnoticed. This patch removes them, as well as the
WebSoupRequestManagerProxy forwarding declaration in WKAPICastSoup.h.
* UIProcess/API/C/soup/WKAPICastSoup.h:
* UIProcess/soup/WebSoupRequestManagerClient.h: Removed.
* UIProcess/soup/WebSoupRequestManagerProxy.h: Removed.
(WebKit::WebSoupRequestManagerProxy::registeredURISchemes): Deleted.
* WebProcess/soup/WebSoupRequestManager.h: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICsoupWKAPICastSouph">trunk/Source/WebKit2/UIProcess/API/C/soup/WKAPICastSoup.h</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2UIProcesssoupWebSoupRequestManagerClienth">trunk/Source/WebKit2/UIProcess/soup/WebSoupRequestManagerClient.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcesssoupWebSoupRequestManagerProxyh">trunk/Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcesssoupWebSoupRequestManagerh">trunk/Source/WebKit2/WebProcess/soup/WebSoupRequestManager.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (205589 => 205590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-09-08 06:44:42 UTC (rev 205589)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-08 06:49:16 UTC (rev 205590)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-09-07 Zan Dobersek <zdobersek@igalia.com>
+
+ [GTK] Remove stale WebSoupRequestManager headers
+ https://bugs.webkit.org/show_bug.cgi?id=161691
+
+ Reviewed by Sergio Villar Senin.
+
+ WebSoupRequestManager, WebSoupRequestManagerProxy and WebSoupRequestManagerClient
+ classes were used to implement custom URI scheme support for Soup. This API and
+ the implementations of these classes were removed in r174584, but curiously the
+ headers went unnoticed. This patch removes them, as well as the
+ WebSoupRequestManagerProxy forwarding declaration in WKAPICastSoup.h.
+
+ * UIProcess/API/C/soup/WKAPICastSoup.h:
+ * UIProcess/soup/WebSoupRequestManagerClient.h: Removed.
+ * UIProcess/soup/WebSoupRequestManagerProxy.h: Removed.
+ (WebKit::WebSoupRequestManagerProxy::registeredURISchemes): Deleted.
+ * WebProcess/soup/WebSoupRequestManager.h: Removed.
+
</ins><span class="cx"> 2016-09-07 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Enable the <meter> element on iOS
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICsoupWKAPICastSouph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/soup/WKAPICastSoup.h (205589 => 205590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/soup/WKAPICastSoup.h 2016-09-08 06:44:42 UTC (rev 205589)
+++ trunk/Source/WebKit2/UIProcess/API/C/soup/WKAPICastSoup.h 2016-09-08 06:49:16 UTC (rev 205590)
</span><span class="lines">@@ -33,7 +33,6 @@
</span><span class="cx"> namespace WebKit {
</span><span class="cx">
</span><span class="cx"> class WebSoupCustomProtocolRequestManager;
</span><del>-class WebSoupRequestManagerProxy;
</del><span class="cx">
</span><span class="cx"> WK_ADD_API_MAPPING(WKSoupCustomProtocolRequestManagerRef, WebSoupCustomProtocolRequestManager)
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcesssoupWebSoupRequestManagerClienth"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebKit2/UIProcess/soup/WebSoupRequestManagerClient.h (205589 => 205590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/soup/WebSoupRequestManagerClient.h 2016-09-08 06:44:42 UTC (rev 205589)
+++ trunk/Source/WebKit2/UIProcess/soup/WebSoupRequestManagerClient.h 2016-09-08 06:49:16 UTC (rev 205590)
</span><span class="lines">@@ -1,47 +0,0 @@
</span><del>-/*
- * Copyright (C) 2012 Igalia S.L.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#ifndef WebSoupRequestManagerClient_h
-#define WebSoupRequestManagerClient_h
-
-#include "APIClient.h"
-#include "WKAPICast.h"
-#include "WKSoupRequestManager.h"
-
-namespace API {
-class URL;
-
-template<> struct ClientTraits<WKSoupRequestManagerClientBase> {
- typedef std::tuple<WKSoupRequestManagerClientV0> Versions;
-};
-}
-
-namespace WebKit {
-
-class WebSoupRequestManagerProxy;
-
-class WebSoupRequestManagerClient : public API::Client<WKSoupRequestManagerClientBase> {
-public:
- bool didReceiveURIRequest(WebSoupRequestManagerProxy*, API::URL*, WebPageProxy*, uint64_t requestID);
- void didFailToLoadURIRequest(WebSoupRequestManagerProxy*, uint64_t requestID);
-};
-
-} // namespace WebKit
-
-#endif // WebSoupRequestManagerClient_h
</del></span></pre></div>
<a id="trunkSourceWebKit2UIProcesssoupWebSoupRequestManagerProxyh"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.h (205589 => 205590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.h 2016-09-08 06:44:42 UTC (rev 205589)
+++ trunk/Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.h 2016-09-08 06:49:16 UTC (rev 205590)
</span><span class="lines">@@ -1,81 +0,0 @@
</span><del>-/*
- * Copyright (C) 2012 Igalia S.L.
- * Copyright (C) 2013 Apple Inc. All rights reserved.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#ifndef WebSoupRequestManagerProxy_h
-#define WebSoupRequestManagerProxy_h
-
-#include "APIObject.h"
-#include "MessageReceiver.h"
-#include "WebContextSupplement.h"
-#include "WebSoupRequestManagerClient.h"
-#include <wtf/PassRefPtr.h>
-#include <wtf/RefPtr.h>
-#include <wtf/text/WTFString.h>
-
-namespace API {
-class Data;
-}
-
-namespace WebKit {
-
-class WebProcessPool;
-
-class WebSoupRequestManagerProxy : public API::ObjectImpl<API::Object::Type::SoupRequestManager>, public WebContextSupplement, private IPC::MessageReceiver {
-public:
- static const char* supplementName();
-
- static PassRefPtr<WebSoupRequestManagerProxy> create(WebProcessPool*);
- virtual ~WebSoupRequestManagerProxy();
-
- void initializeClient(const WKSoupRequestManagerClientBase*);
-
- void registerURIScheme(const String& scheme);
- void didHandleURIRequest(const API::Data*, uint64_t contentLength, const String& mimeType, uint64_t requestID);
- void didReceiveURIRequestData(const API::Data*, uint64_t requestID);
- void didReceiveURIRequest(const String& uriString, WebPageProxy*, uint64_t requestID);
- void didFailURIRequest(const WebCore::ResourceError&, uint64_t requestID);
-
- const Vector<String>& registeredURISchemes() const { return m_registeredURISchemes; }
-
- using API::Object::ref;
- using API::Object::deref;
-
-private:
- WebSoupRequestManagerProxy(WebProcessPool*);
-
- // WebContextSupplement
- void contextDestroyed() override;
- void processDidClose(WebProcessProxy*) override;
- void refWebContextSupplement() override;
- void derefWebContextSupplement() override;
-
- // IPC::MessageReceiver
- void didReceiveMessage(IPC::Connection*, IPC::Decoder&) override;
-
- void didFailToLoadURIRequest(uint64_t requestID);
-
- WebSoupRequestManagerClient m_client;
- bool m_loadFailed;
- Vector<String> m_registeredURISchemes;
-};
-
-} // namespace WebKit
-
-#endif // WebSoupRequestManagerProxy_h
</del></span></pre></div>
<a id="trunkSourceWebKit2WebProcesssoupWebSoupRequestManagerh"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebKit2/WebProcess/soup/WebSoupRequestManager.h (205589 => 205590)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/soup/WebSoupRequestManager.h 2016-09-08 06:44:42 UTC (rev 205589)
+++ trunk/Source/WebKit2/WebProcess/soup/WebSoupRequestManager.h 2016-09-08 06:49:16 UTC (rev 205590)
</span><span class="lines">@@ -1,69 +0,0 @@
</span><del>-/*
- * Copyright (C) 2012 Igalia S.L.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#ifndef WebSoupRequestManager_h
-#define WebSoupRequestManager_h
-
-#include "DataReference.h"
-#include "MessageReceiver.h"
-#include "WebProcessSupplement.h"
-#include <WebCore/ResourceError.h>
-#include <memory>
-#include <wtf/HashMap.h>
-#include <wtf/Noncopyable.h>
-#include <wtf/glib/GRefPtr.h>
-#include <wtf/text/WTFString.h>
-
-typedef struct _GInputStream GInputStream;
-typedef struct _GTask GTask;
-
-namespace WebKit {
-
-class WebProcess;
-struct WebSoupRequestAsyncData;
-
-class WebSoupRequestManager : public WebProcessSupplement, private IPC::MessageReceiver {
- WTF_MAKE_NONCOPYABLE(WebSoupRequestManager);
-public:
- explicit WebSoupRequestManager(WebProcess*);
- ~WebSoupRequestManager();
-
- static const char* supplementName();
-
- void send(GTask*);
- GInputStream* finish(GTask*, GError**);
-
- void registerURIScheme(const String& scheme);
-
-private:
- // IPC::MessageReceiver
- void didReceiveMessage(IPC::Connection*, IPC::Decoder&) override;
-
- void didHandleURIRequest(const IPC::DataReference&, uint64_t contentLength, const String& mimeType, uint64_t requestID);
- void didReceiveURIRequestData(const IPC::DataReference&, uint64_t requestID);
- void didFailURIRequest(const WebCore::ResourceError&, uint64_t requestID);
-
- WebProcess* m_process;
- GRefPtr<GPtrArray> m_schemes;
- HashMap<uint64_t, std::unique_ptr<WebSoupRequestAsyncData> > m_requestMap;
-};
-
-} // namespace WebKit
-
-#endif
</del></span></pre>
</div>
</div>
</body>
</html>