<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205329] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205329">205329</a></dd>
<dt>Author</dt> <dd>timothy_horton@apple.com</dd>
<dt>Date</dt> <dd>2016-09-01 18:16:56 -0700 (Thu, 01 Sep 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
https://bugs.webkit.org/show_bug.cgi?id=161413
Reviewed by Simon Fraser.
Add TestNavigationDelegate, which provides block properties to make
writing tests feel a little more natural (the callbacks can be inline),
and also add WKWebView _test_waitForDidFinishNavigation, so that many
tests don't even need to manually allocate a navigation delegate at all.
Adopt in some of the simpler tests; there are a few navigation delegates
left behind, which we can move to the new model in the future.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
(TEST):
(-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
(TEST):
(-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
(animatedResizeWebView):
(-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
(-[AutoLayoutWKWebView initWithFrame:configuration:]):
(-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
(TEST):
(-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
(TEST):
(-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
(WebKit2_CommandBackForwardTestWKWebView::SetUp):
(WebKit2_CommandBackForwardTestWKWebView::loadFiles):
(TEST_F):
(-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
(expectLinkCount):
(TEST):
(-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
(TEST):
(-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
(TEST):
(-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
(TEST):
(-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
(-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
(TEST):
(-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
(-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
(RequiresUserActionForPlaybackTest::createWebView):
(RequiresUserActionForPlaybackTest::testVideoWithAudio):
(RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
(RequiresUserActionForPlaybackTest::testAudioOnly):
(-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
(TEST):
(-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
(TEST):
(webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
* TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
(TEST):
(-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
(TEST):
(-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
(TEST):
(-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
(TEST):
(-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
* TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
(-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
(-[TestNavigationDelegate webView:didFinishNavigation:]):
(-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
(-[TestNavigationDelegate waitForDidFinishNavigation]):
(-[WKWebView _test_waitForDidFinishNavigation]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestWebKitAPIxcodeprojprojectpbxproj">trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2WKBackForwardListmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaAlwaysRevalidatedURLSchemesmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaAnimatedResizemm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaAutoLayoutIntegrationmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaCancelFontSubresourcemm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaCommandBackForwardmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaDataDetectionmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaFindInPagemm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaFixedLayoutSizemm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaIndexedDBDatabaseProcessKillmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaIndexedDBPersistencemm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaProvisionalURLNotChangemm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaRequiresUserActionForPlaybackmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaShrinkToFitmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaUserContentControllermm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaUserContentWorldmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaWKPDFViewResizeCrashmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaWKWebViewEvaluateJavaScriptmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKit2CocoaWKWebViewTextInputmm">trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkToolsTestWebKitAPIcocoaTestNavigationDelegateh">trunk/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h</a></li>
<li><a href="#trunkToolsTestWebKitAPIcocoaTestNavigationDelegatemm">trunk/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/ChangeLog 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -1,3 +1,92 @@
</span><ins>+2016-09-01 Tim Horton <timothy_horton@apple.com>
+
+ Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
+ https://bugs.webkit.org/show_bug.cgi?id=161413
+
+ Reviewed by Simon Fraser.
+
+ Add TestNavigationDelegate, which provides block properties to make
+ writing tests feel a little more natural (the callbacks can be inline),
+ and also add WKWebView _test_waitForDidFinishNavigation, so that many
+ tests don't even need to manually allocate a navigation delegate at all.
+
+ Adopt in some of the simpler tests; there are a few navigation delegates
+ left behind, which we can move to the new model in the future.
+
+ * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+ * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
+ (TEST):
+ (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
+ (TEST):
+ (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
+ (animatedResizeWebView):
+ (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
+ (-[AutoLayoutWKWebView initWithFrame:configuration:]):
+ (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
+ (TEST):
+ (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
+ (TEST):
+ (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
+ (WebKit2_CommandBackForwardTestWKWebView::SetUp):
+ (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
+ (TEST_F):
+ (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
+ (expectLinkCount):
+ (TEST):
+ (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
+ (TEST):
+ (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
+ (TEST):
+ (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
+ (TEST):
+ (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
+ (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
+ (TEST):
+ (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
+ (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
+ (RequiresUserActionForPlaybackTest::createWebView):
+ (RequiresUserActionForPlaybackTest::testVideoWithAudio):
+ (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
+ (RequiresUserActionForPlaybackTest::testAudioOnly):
+ (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
+ (TEST):
+ (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
+ (TEST):
+ (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
+ * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
+ (TEST):
+ (-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
+ (TEST):
+ (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
+ (TEST):
+ (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
+ (TEST):
+ (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
+ * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
+ * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
+ (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
+ (-[TestNavigationDelegate webView:didFinishNavigation:]):
+ (-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
+ (-[TestNavigationDelegate waitForDidFinishNavigation]):
+ (-[WKWebView _test_waitForDidFinishNavigation]):
+
</ins><span class="cx"> 2016-09-01 Ricky Mondello <rmondello@apple.com>
</span><span class="cx">
</span><span class="cx"> YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestWebKitAPIxcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -52,6 +52,7 @@
</span><span class="cx"> 297234B7173AFAC700983601 /* CustomProtocolsInvalidScheme_Bundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 297234B5173AFAC700983601 /* CustomProtocolsInvalidScheme_Bundle.cpp */; };
</span><span class="cx"> 2D00065F1C1F589A0088E6A7 /* WKPDFViewResizeCrash.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2D00065D1C1F58940088E6A7 /* WKPDFViewResizeCrash.mm */; };
</span><span class="cx"> 2D1646E21D1862CD00015A1A /* DeferredViewInWindowStateChange.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2D1646E11D1862CD00015A1A /* DeferredViewInWindowStateChange.mm */; };
</span><ins>+ 2D1C04A71D76298B000A6816 /* TestNavigationDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2D1C04A61D76298B000A6816 /* TestNavigationDelegate.mm */; };
</ins><span class="cx"> 2D51A0C71C8BF00C00765C45 /* DOMHTMLVideoElementWrapper.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2D51A0C51C8BF00400765C45 /* DOMHTMLVideoElementWrapper.mm */; };
</span><span class="cx"> 2DC4CF771D2D9DD800ECCC94 /* DataDetection.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2DC4CF761D2D9DD800ECCC94 /* DataDetection.mm */; };
</span><span class="cx"> 2DD7D3AF178227B30026E1E3 /* lots-of-text-vertical-lr.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 2DD7D3AE178227AC0026E1E3 /* lots-of-text-vertical-lr.html */; };
</span><span class="lines">@@ -723,6 +724,8 @@
</span><span class="cx"> 29AB8AA3164C7A9300D49BEC /* TestBrowsingContextLoadDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TestBrowsingContextLoadDelegate.h; sourceTree = "<group>"; };
</span><span class="cx"> 2D00065D1C1F58940088E6A7 /* WKPDFViewResizeCrash.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKPDFViewResizeCrash.mm; sourceTree = "<group>"; };
</span><span class="cx"> 2D1646E11D1862CD00015A1A /* DeferredViewInWindowStateChange.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = DeferredViewInWindowStateChange.mm; path = WebKit2/DeferredViewInWindowStateChange.mm; sourceTree = "<group>"; };
</span><ins>+ 2D1C04A51D76298B000A6816 /* TestNavigationDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = TestNavigationDelegate.h; path = cocoa/TestNavigationDelegate.h; sourceTree = "<group>"; };
+ 2D1C04A61D76298B000A6816 /* TestNavigationDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = TestNavigationDelegate.mm; path = cocoa/TestNavigationDelegate.mm; sourceTree = "<group>"; };
</ins><span class="cx"> 2D1FE0AF1AD465C1006CD9E6 /* FixedLayoutSize.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = FixedLayoutSize.mm; sourceTree = "<group>"; };
</span><span class="cx"> 2D51A0C51C8BF00400765C45 /* DOMHTMLVideoElementWrapper.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DOMHTMLVideoElementWrapper.mm; sourceTree = "<group>"; };
</span><span class="cx"> 2D640B5417875DFF00BFAF99 /* ScrollPinningBehaviors.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ScrollPinningBehaviors.cpp; sourceTree = "<group>"; };
</span><span class="lines">@@ -1228,6 +1231,8 @@
</span><span class="cx"> 5C726D6D1D3EE06800C5E1A1 /* InstanceMethodSwizzler.h */,
</span><span class="cx"> 5C726D6E1D3EE06800C5E1A1 /* InstanceMethodSwizzler.mm */,
</span><span class="cx"> 0F139E721A423A2B00F590F5 /* PlatformUtilitiesCocoa.mm */,
</span><ins>+ 2D1C04A51D76298B000A6816 /* TestNavigationDelegate.h */,
+ 2D1C04A61D76298B000A6816 /* TestNavigationDelegate.mm */,
</ins><span class="cx"> A14FC58D1B8AE36500D107EB /* TestProtocol.h */,
</span><span class="cx"> A14FC58E1B8AE36500D107EB /* TestProtocol.mm */,
</span><span class="cx"> 7C83E0391D0A602700FEBCF3 /* UtilitiesCocoa.mm */,
</span><span class="lines">@@ -2202,6 +2207,7 @@
</span><span class="cx"> 5C2936931D5BF70D00DEAB1E /* CookieAcceptPolicy.mm in Sources */,
</span><span class="cx"> 7CCE7EE81A411AE600447C4C /* CookieManager.cpp in Sources */,
</span><span class="cx"> 7CCE7EAC1A411A3400447C4C /* Counters.cpp in Sources */,
</span><ins>+ 2D1C04A71D76298B000A6816 /* TestNavigationDelegate.mm in Sources */,
</ins><span class="cx"> 7CCE7EDB1A411A9200447C4C /* CSSParser.cpp in Sources */,
</span><span class="cx"> 7CCE7F291A411B1000447C4C /* CustomProtocolsInvalidScheme.mm in Sources */,
</span><span class="cx"> 7CCE7F2A1A411B1000447C4C /* CustomProtocolsSyncXHRTest.mm in Sources */,
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2WKBackForwardListmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -26,9 +26,9 @@
</span><span class="cx"> #import "config.h"
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx">
</span><span class="cx"> #import <WebKit/WKBackForwardListPrivate.h>
</span><del>-#import <WebKit/WKNavigationDelegate.h>
</del><span class="cx"> #import <WebKit/WKNavigationPrivate.h>
</span><span class="cx"> #import <WebKit/WKWebViewPrivate.h>
</span><span class="cx"> #import <WebKit/_WKSessionState.h>
</span><span class="lines">@@ -36,20 +36,6 @@
</span><span class="cx">
</span><span class="cx"> #if WK_API_ENABLED
</span><span class="cx">
</span><del>-static bool isDone;
-
-@interface WKBackForwardListTestNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation WKBackForwardListTestNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- isDone = true;
-}
-
-@end
-
</del><span class="cx"> static NSString *loadableURL1 = @"data:text/html,no%20error%20A";
</span><span class="cx"> static NSString *loadableURL2 = @"data:text/html,no%20error%20B";
</span><span class="cx"> static NSString *loadableURL3 = @"data:text/html,no%20error%20C";
</span><span class="lines">@@ -57,20 +43,15 @@
</span><span class="cx"> TEST(WKBackForwardList, RemoveCurrentItem)
</span><span class="cx"> {
</span><span class="cx"> auto webView = adoptNS([[WKWebView alloc] init]);
</span><del>- auto controller = adoptNS([[WKBackForwardListTestNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:controller.get()];
</del><span class="cx">
</span><span class="cx"> [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:loadableURL1]]];
</span><del>- TestWebKitAPI::Util::run(&isDone);
- isDone = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:loadableURL2]]];
</span><del>- TestWebKitAPI::Util::run(&isDone);
- isDone = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:loadableURL3]]];
</span><del>- TestWebKitAPI::Util::run(&isDone);
- isDone = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> WKBackForwardList *list = [webView backForwardList];
</span><span class="cx"> EXPECT_EQ((NSUInteger)2, list.backList.count);
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaAlwaysRevalidatedURLSchemesmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx"> #if WK_API_ENABLED
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKBrowsingContextController.h>
</span><span class="cx"> #import <WebKit/WKProcessPoolPrivate.h>
</span><span class="cx"> #import <WebKit/_WKProcessPoolConfiguration.h>
</span><span class="lines">@@ -34,7 +35,6 @@
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><span class="cx"> static NSString * const customScheme = @"custom";
</span><del>-static bool isDone;
</del><span class="cx"> static size_t loadsStarted;
</span><span class="cx">
</span><span class="cx"> @interface AlwaysRevalidatedURLSchemeProtocol : NSURLProtocol
</span><span class="lines">@@ -74,18 +74,6 @@
</span><span class="cx">
</span><span class="cx"> @end
</span><span class="cx">
</span><del>-@interface AlwaysRevalidatedURLSchemesDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation AlwaysRevalidatedURLSchemesDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- isDone = true;
-}
-
-@end
-
</del><span class="cx"> TEST(WebKit2, AlwaysRevalidatedURLSchemes)
</span><span class="cx"> {
</span><span class="cx"> @autoreleasepool {
</span><span class="lines">@@ -99,18 +87,15 @@
</span><span class="cx"> auto webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
</span><span class="cx"> [webViewConfiguration setProcessPool:processPool.get()];
</span><span class="cx">
</span><del>- auto navigationDelegate = adoptNS([[AlwaysRevalidatedURLSchemesDelegate alloc] init]);
</del><span class="cx"> auto webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectZero configuration:webViewConfiguration.get()]);
</span><del>- [webView setNavigationDelegate:navigationDelegate.get()];
</del><span class="cx">
</span><span class="cx"> NSString *htmlString = [NSString stringWithFormat:@"<!DOCTYPE html><body><img src='%@://image'>", customScheme];
</span><span class="cx"> [webView loadHTMLString:htmlString baseURL:nil];
</span><del>- TestWebKitAPI::Util::run(&isDone);
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx"> EXPECT_EQ(1UL, loadsStarted);
</span><span class="cx">
</span><del>- isDone = false;
</del><span class="cx"> [webView loadHTMLString:htmlString baseURL:nil];
</span><del>- TestWebKitAPI::Util::run(&isDone);
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx"> EXPECT_EQ(2UL, loadsStarted);
</span><span class="cx">
</span><span class="cx"> [WKBrowsingContextController unregisterSchemeForCustomProtocol:customScheme];
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaAnimatedResizemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -26,7 +26,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><del>-#import <WebKit/WKNavigationDelegatePrivate.h>
</del><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKPreferences.h>
</span><span class="cx"> #import <WebKit/WKProcessPoolPrivate.h>
</span><span class="cx"> #import <WebKit/WKWebView.h>
</span><span class="lines">@@ -40,19 +40,6 @@
</span><span class="cx"> static bool didLayout;
</span><span class="cx"> static bool didEndAnimatedResize;
</span><span class="cx">
</span><del>-@interface AnimatedResizeNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation AnimatedResizeNavigationDelegate
-
-- (void)_webView:(WKWebView *)webView renderingProgressDidChange:(_WKRenderingProgressEvents)progressEvents
-{
- if (progressEvents & _WKRenderingProgressEventFirstVisuallyNonEmptyLayout)
- didLayout = true;
-}
-
-@end
-
</del><span class="cx"> @interface AnimatedResizeWebView : WKWebView
</span><span class="cx">
</span><span class="cx"> @end
</span><span class="lines">@@ -70,17 +57,21 @@
</span><span class="cx">
</span><span class="cx"> static RetainPtr<WKWebView> animatedResizeWebView()
</span><span class="cx"> {
</span><del>- RetainPtr<_WKProcessPoolConfiguration> processPoolConfiguration = [[_WKProcessPoolConfiguration alloc] init];
</del><ins>+ RetainPtr<_WKProcessPoolConfiguration> processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
</ins><span class="cx"> [processPoolConfiguration setIgnoreSynchronousMessagingTimeoutsForTesting:YES];
</span><del>- RetainPtr<WKProcessPool> processPool = [[WKProcessPool alloc] _initWithConfiguration:processPoolConfiguration.get()];
</del><ins>+ RetainPtr<WKProcessPool> processPool = adoptNS([[WKProcessPool alloc] _initWithConfiguration:processPoolConfiguration.get()]);
</ins><span class="cx">
</span><del>- RetainPtr<WKWebViewConfiguration> webViewConfiguration = [[WKWebViewConfiguration alloc] init];
</del><ins>+ RetainPtr<WKWebViewConfiguration> webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
</ins><span class="cx"> [webViewConfiguration setProcessPool:processPool.get()];
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[AnimatedResizeWebView alloc] initWithFrame:CGRectMake(0, 0, 800, 600) configuration:webViewConfiguration.get()]);
</span><span class="cx">
</span><del>- AnimatedResizeNavigationDelegate *navigationDelegate = [[AnimatedResizeNavigationDelegate alloc] init];
- [webView setNavigationDelegate:navigationDelegate];
</del><ins>+ auto navigationDelegate = adoptNS([[TestNavigationDelegate alloc] init]);
+ [navigationDelegate setRenderingProgressDidChange:^(WKWebView *, _WKRenderingProgressEvents progressEvents) {
+ if (progressEvents & _WKRenderingProgressEventFirstVisuallyNonEmptyLayout)
+ didLayout = true;
+ }];
+ [webView setNavigationDelegate:navigationDelegate.get()];
</ins><span class="cx">
</span><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"blinking-div" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaAutoLayoutIntegrationmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -26,27 +26,15 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKWebViewPrivate.h>
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><span class="cx"> #if WK_API_ENABLED && PLATFORM(MAC)
</span><span class="cx">
</span><del>-static bool didFinishNavigation;
</del><span class="cx"> static bool didInvalidateIntrinsicContentSize;
</span><span class="cx"> static bool didEvaluateJavaScript;
</span><span class="cx">
</span><del>-@interface AutoLayoutNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation AutoLayoutNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- didFinishNavigation = true;
-}
-
-@end
-
</del><span class="cx"> @interface AutoLayoutWKWebView : WKWebView
</span><span class="cx"> @end
</span><span class="cx">
</span><span class="lines">@@ -55,6 +43,15 @@
</span><span class="cx"> NSSize _expectedIntrinsicContentSize;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (instancetype)initWithFrame:(NSRect)frame configuration:(WKWebViewConfiguration *)configuration
+{
+ self = [super initWithFrame:frame configuration:configuration];
+ if (!self)
+ return nil;
+
+ return self;
+}
+
</ins><span class="cx"> - (void)load:(NSString *)HTMLString withWidth:(CGFloat)width expectingContentSize:(NSSize)size
</span><span class="cx"> {
</span><span class="cx"> [self load:HTMLString withWidth:width expectingContentSize:size resettingWidth:YES];
</span><span class="lines">@@ -73,9 +70,8 @@
</span><span class="cx"> ".inline { display: inline-block; }"
</span><span class="cx"> "</style>";
</span><span class="cx">
</span><del>- didFinishNavigation = false;
</del><span class="cx"> [self loadHTMLString:[baseHTML stringByAppendingString:HTMLString] baseURL:nil];
</span><del>- TestWebKitAPI::Util::run(&didFinishNavigation);
</del><ins>+ [self _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> [self layoutAtMinimumWidth:width andExpectContentSizeChange:size resettingWidth:resetAfter];
</span><span class="cx"> }
</span><span class="lines">@@ -116,9 +112,6 @@
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<AutoLayoutWKWebView> webView = adoptNS([[AutoLayoutWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 1000, 1000)]);
</span><span class="cx">
</span><del>- AutoLayoutNavigationDelegate *delegate = [[AutoLayoutNavigationDelegate alloc] init];
- [webView setNavigationDelegate:delegate];
-
</del><span class="cx"> // 10x10 rect with the constraint (width >= 50) -> 50x10
</span><span class="cx"> [webView load:@"<div class='small'></div>" withWidth:50 expectingContentSize:NSMakeSize(50, 10)];
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaCancelFontSubresourcemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import "UserContentWorldProtocol.h"
</span><span class="cx"> #import "WKWebViewConfigurationExtras.h"
</span><span class="cx"> #import <WebKit/WKProcessPoolPrivate.h>
</span><span class="lines">@@ -44,20 +45,6 @@
</span><span class="cx"> #import <WebKit/_WKUserStyleSheet.h>
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><del>-@interface CancelFontSubresourceNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation CancelFontSubresourceNavigationDelegate
-
-static bool navigationComplete = false;
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- navigationComplete = true;
-}
-
-@end
-
</del><span class="cx"> TEST(CancelLoading, CancelFontSubresource)
</span><span class="cx"> {
</span><span class="cx"> NSString * const testPlugInClassName = @"CancelFontSubresourcePlugIn";
</span><span class="lines">@@ -66,13 +53,9 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- CancelFontSubresourceNavigationDelegate *delegate = [[CancelFontSubresourceNavigationDelegate alloc] init];
- [webView setNavigationDelegate:delegate];
-
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"webfont" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><del>-
- TestWebKitAPI::Util::run(&navigationComplete);
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaCommandBackForwardmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <Carbon/Carbon.h> // for GetCurrentEventTime()
</span><span class="cx"> #import <WebKit/WKRetainPtr.h>
</span><span class="cx"> #import <WebKit/WKViewPrivate.h>
</span><span class="lines">@@ -152,19 +153,6 @@
</span><span class="cx">
</span><span class="cx"> #if WK_API_ENABLED
</span><span class="cx">
</span><del>-@interface CommandBackForwardNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation CommandBackForwardNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- didFinishNavigation = true;
-}
-
-@end
-
-
</del><span class="cx"> class WebKit2_CommandBackForwardTestWKWebView : public WebKit2_CommandBackForwardTest {
</span><span class="cx"> public:
</span><span class="cx"> RetainPtr<WKWebView> webView;
</span><span class="lines">@@ -175,9 +163,6 @@
</span><span class="cx">
</span><span class="cx"> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100)]);
</span><span class="cx"> [[window contentView] addSubview:webView.get()];
</span><del>-
- CommandBackForwardNavigationDelegate *delegate = [[CommandBackForwardNavigationDelegate alloc] init];
- [webView setNavigationDelegate:delegate];
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void loadFiles()
</span><span class="lines">@@ -184,15 +169,11 @@
</span><span class="cx"> {
</span><span class="cx"> NSURL *file1 = [[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
</span><span class="cx"> [webView loadFileURL:file1 allowingReadAccessToURL:file1];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&didFinishNavigation);
- didFinishNavigation = false;
-
</del><span class="cx"> NSURL *file2 = [[NSBundle mainBundle] URLForResource:@"simple2" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
</span><span class="cx"> [webView loadFileURL:file2 allowingReadAccessToURL:file2];
</span><del>-
- TestWebKitAPI::Util::run(&didFinishNavigation);
- didFinishNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx"> }
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -206,15 +187,13 @@
</span><span class="cx">
</span><span class="cx"> // Attempt to go back (using command-left).
</span><span class="cx"> simulateCommandArrow(webView.get(), Left);
</span><del>- TestWebKitAPI::Util::run(&didFinishNavigation);
- didFinishNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> EXPECT_WK_STREQ([webView URL].path.lastPathComponent, @"simple.html");
</span><span class="cx">
</span><span class="cx"> // Attempt to go back (using command-right).
</span><span class="cx"> simulateCommandArrow(webView.get(), Right);
</span><del>- TestWebKitAPI::Util::run(&didFinishNavigation);
- didFinishNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> EXPECT_WK_STREQ([webView URL].path.lastPathComponent, @"simple2.html");
</span><span class="cx"> }
</span><span class="lines">@@ -230,15 +209,13 @@
</span><span class="cx">
</span><span class="cx"> // Attempt to go back (using command-right)
</span><span class="cx"> simulateCommandArrow(webView.get(), Right);
</span><del>- TestWebKitAPI::Util::run(&didFinishNavigation);
- didFinishNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> EXPECT_WK_STREQ([webView URL].path.lastPathComponent, @"simple.html");
</span><span class="cx">
</span><span class="cx"> // Attempt to go back (using command-left).
</span><span class="cx"> simulateCommandArrow(webView.get(), Left);
</span><del>- TestWebKitAPI::Util::run(&didFinishNavigation);
- didFinishNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> EXPECT_WK_STREQ([webView URL].path.lastPathComponent, @"simple2.html");
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaDataDetectionmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -27,26 +27,14 @@
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WebKit.h>
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><span class="cx"> #if WK_API_ENABLED && PLATFORM(IOS)
</span><span class="cx">
</span><del>-static bool finishedLoading;
</del><span class="cx"> static bool ranScript;
</span><span class="cx">
</span><del>-@interface DataDetectionNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation DataDetectionNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- finishedLoading = true;
-}
-
-@end
-
</del><span class="cx"> @interface DataDetectionUIDelegate : NSObject <WKUIDelegate>
</span><span class="cx">
</span><span class="cx"> @property (nonatomic, retain) NSDate *referenceDate;
</span><span class="lines">@@ -70,10 +58,8 @@
</span><span class="cx"> void expectLinkCount(WKWebView *webView, NSString *HTMLString, unsigned linkCount)
</span><span class="cx"> {
</span><span class="cx"> [webView loadHTMLString:HTMLString baseURL:nil];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&finishedLoading);
- finishedLoading = false;
-
</del><span class="cx"> [webView evaluateJavaScript:@"document.getElementsByTagName('a').length" completionHandler:^(id value, NSError *error) {
</span><span class="cx"> EXPECT_EQ(linkCount, [value unsignedIntValue]);
</span><span class="cx"> ranScript = true;
</span><span class="lines">@@ -90,9 +76,6 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<DataDetectionNavigationDelegate> navigationDelegate = adoptNS([[DataDetectionNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:navigationDelegate.get()];
-
</del><span class="cx"> RetainPtr<DataDetectionUIDelegate> UIDelegate = adoptNS([[DataDetectionUIDelegate alloc] init]);
</span><span class="cx"> [webView setUIDelegate:UIDelegate.get()];
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaFindInPagemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKWebViewPrivate.h>
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><span class="lines">@@ -46,34 +47,17 @@
</span><span class="cx">
</span><span class="cx"> @end
</span><span class="cx">
</span><del>-static bool navigationDone;
</del><span class="cx"> static bool findMatchesDone;
</span><span class="cx">
</span><del>-@interface FindInPageNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation FindInPageNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- navigationDone = true;
-}
-
-@end
-
</del><span class="cx"> TEST(WebKit2, FindInPage)
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100)]);
</span><span class="cx"> [webView _setOverrideDeviceScaleFactor:2];
</span><span class="cx">
</span><del>- RetainPtr<FindInPageNavigationDelegate> delegate = adoptNS([[FindInPageNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"lots-of-text" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&navigationDone);
-
</del><span class="cx"> NSTextFinderAsynchronousDocumentFindOptions noFindOptions = (NSTextFinderAsynchronousDocumentFindOptions)0;
</span><span class="cx">
</span><span class="cx"> // Find all matches.
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaFixedLayoutSizemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKPreferences.h>
</span><span class="cx"> #import <WebKit/WKWebViewPrivate.h>
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="lines">@@ -36,29 +37,10 @@
</span><span class="cx"> static bool fixedLayoutSizeAfterNavigationDone;
</span><span class="cx"> static bool fixedLayoutSizeDisabledDone;
</span><span class="cx">
</span><del>-@interface FixedLayoutSizeNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation FixedLayoutSizeNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- // After navigating, fixed layout size should be persisted.
- [webView evaluateJavaScript:@"document.body.clientWidth" completionHandler:^(id result, NSError *error) {
- EXPECT_EQ(200, [result integerValue]);
- fixedLayoutSizeAfterNavigationDone = true;
- }];
-}
-
-@end
-
</del><span class="cx"> TEST(WebKit2, FixedLayoutSize)
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100)]);
</span><span class="cx">
</span><del>- FixedLayoutSizeNavigationDelegate *delegate = [[FixedLayoutSizeNavigationDelegate alloc] init];
- [webView setNavigationDelegate:delegate];
-
</del><span class="cx"> [webView evaluateJavaScript:@"document.body.clientWidth" completionHandler:^(id result, NSError *error) {
</span><span class="cx"> EXPECT_EQ(100, [result integerValue]);
</span><span class="cx">
</span><span class="lines">@@ -76,7 +58,14 @@
</span><span class="cx">
</span><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><ins>+ // After navigating, fixed layout size should be persisted.
+ [webView evaluateJavaScript:@"document.body.clientWidth" completionHandler:^(id result, NSError *error) {
+ EXPECT_EQ(200, [result integerValue]);
+ fixedLayoutSizeAfterNavigationDone = true;
+ }];
+
</ins><span class="cx"> TestWebKitAPI::Util::run(&fixedLayoutSizeAfterNavigationDone);
</span><span class="cx">
</span><span class="cx"> [webView _setLayoutMode:_WKLayoutModeViewSize];
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaIndexedDBDatabaseProcessKillmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKProcessPoolPrivate.h>
</span><span class="cx"> #import <WebKit/WKUserContentControllerPrivate.h>
</span><span class="cx"> #import <WebKit/WKWebViewConfigurationPrivate.h>
</span><span class="lines">@@ -36,20 +37,6 @@
</span><span class="cx">
</span><span class="cx"> #if WK_API_ENABLED
</span><span class="cx">
</span><del>-static bool isDoneWithNavigation;
-
-@interface DatabaseProcessKillNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation DatabaseProcessKillNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- isDoneWithNavigation = true;
-}
-
-@end
-
</del><span class="cx"> static bool receivedScriptMessage;
</span><span class="cx"> static bool receivedAtLeastOneOpenError;
</span><span class="cx"> static bool receivedAtLeastOneDeleteError;
</span><span class="lines">@@ -94,14 +81,10 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- DatabaseProcessKillNavigationDelegate *delegate = [[DatabaseProcessKillNavigationDelegate alloc] init];
- [webView setNavigationDelegate:delegate];
-
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"IndexedDBDatabaseProcessKill-1" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
-
</del><span class="cx"> bool killedDBProcess = false;
</span><span class="cx"> while (true) {
</span><span class="cx"> if (databaseErrorReceived)
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaIndexedDBPersistencemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -37,20 +37,6 @@
</span><span class="cx">
</span><span class="cx"> #if WK_API_ENABLED
</span><span class="cx">
</span><del>-static bool isDoneWithNavigation;
-
-@interface IndexedDBNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation IndexedDBNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- isDoneWithNavigation = true;
-}
-
-@end
-
</del><span class="cx"> static bool receivedScriptMessage;
</span><span class="cx"> static RetainPtr<WKScriptMessage> lastScriptMessage;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaProvisionalURLNotChangemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -30,33 +30,24 @@
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><span class="cx"> static bool isDone;
</span><span class="cx">
</span><del>-@interface ProvisionalURLNotChangeController : NSObject <WKNavigationDelegate>
-@end
-
-@implementation ProvisionalURLNotChangeController
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- isDone = true;
-}
-
-- (void)webView:(WKWebView *)webView didFailProvisionalNavigation:(WKNavigation *)navigation withError:(NSError *)error
-{
- isDone = true;
-}
-
-@end
-
</del><span class="cx"> TEST(WKWebView, ProvisionalURLNotChange)
</span><span class="cx"> {
</span><span class="cx"> auto webView = adoptNS([[WKWebView alloc] init]);
</span><del>- auto controller = adoptNS([[ProvisionalURLNotChangeController alloc] init]);
- [webView setNavigationDelegate:controller.get()];
</del><span class="cx">
</span><ins>+ auto navigationDelegate = adoptNS([[TestNavigationDelegate alloc] init]);
+ [navigationDelegate setDidFinishNavigation:^(WKWebView *, WKNavigation *) {
+ isDone = true;
+ }];
+ [navigationDelegate setDidFailProvisionalNavigation:^(WKWebView *, WKNavigation *, NSError *) {
+ isDone = true;
+ }];
+ [webView setNavigationDelegate:navigationDelegate.get()];
+
</ins><span class="cx"> [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"data:text/html,start"]]];
</span><span class="cx"> TestWebKitAPI::Util::run(&isDone);
</span><span class="cx"> isDone = false;
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaRequiresUserActionForPlaybackmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebCore/SoftLinking.h>
</span><span class="cx"> #import <WebKit/WKWebViewConfigurationPrivate.h>
</span><span class="cx"> #import <WebKit/WebKit.h>
</span><span class="lines">@@ -39,18 +40,6 @@
</span><span class="cx"> SOFT_LINK_CLASS(UIKit, UIWindow)
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-static bool isDoneWithNavigation;
-
-@interface RequiresUserActionForPlaybackNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation RequiresUserActionForPlaybackNavigationDelegate
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- isDoneWithNavigation = true;
-}
-@end
-
</del><span class="cx"> static bool receivedScriptMessage;
</span><span class="cx"> static RetainPtr<WKScriptMessage> lastScriptMessage;
</span><span class="cx">
</span><span class="lines">@@ -82,9 +71,7 @@
</span><span class="cx">
</span><span class="cx"> void createWebView()
</span><span class="cx"> {
</span><del>- delegate = adoptNS([[RequiresUserActionForPlaybackNavigationDelegate alloc] init]);
</del><span class="cx"> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><del>- [webView setNavigationDelegate:delegate.get()];
</del><span class="cx"> #if TARGET_OS_IPHONE
</span><span class="cx"> window = adoptNS([[getUIWindowClass() alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
</span><span class="cx"> [window addSubview:webView.get()];
</span><span class="lines">@@ -98,8 +85,7 @@
</span><span class="cx"> {
</span><span class="cx"> NSURL *fileURL = [[NSBundle mainBundle] URLForResource:@"video-with-audio" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
</span><span class="cx"> [webView loadFileURL:fileURL allowingReadAccessToURL:fileURL];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> TestWebKitAPI::Util::run(&receivedScriptMessage);
</span><span class="cx"> receivedScriptMessage = false;
</span><span class="lines">@@ -109,8 +95,7 @@
</span><span class="cx"> {
</span><span class="cx"> NSURL *fileURL = [[NSBundle mainBundle] URLForResource:@"video-without-audio" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
</span><span class="cx"> [webView loadFileURL:fileURL allowingReadAccessToURL:fileURL];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> TestWebKitAPI::Util::run(&receivedScriptMessage);
</span><span class="cx"> receivedScriptMessage = false;
</span><span class="lines">@@ -120,8 +105,7 @@
</span><span class="cx"> {
</span><span class="cx"> NSURL *fileURL = [[NSBundle mainBundle] URLForResource:@"audio-only" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
</span><span class="cx"> [webView loadFileURL:fileURL allowingReadAccessToURL:fileURL];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> TestWebKitAPI::Util::run(&receivedScriptMessage);
</span><span class="cx"> receivedScriptMessage = false;
</span><span class="lines">@@ -129,7 +113,6 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<RequiresUserActionForPlaybackMessageHandler> handler;
</span><span class="cx"> RetainPtr<WKWebViewConfiguration> configuration;
</span><del>- RetainPtr<RequiresUserActionForPlaybackNavigationDelegate> delegate;
</del><span class="cx"> RetainPtr<WKWebView> webView;
</span><span class="cx"> #if TARGET_OS_IPHONE
</span><span class="cx"> RetainPtr<UIWindow> window;
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaShrinkToFitmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKWebViewPrivate.h>
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><span class="lines">@@ -35,29 +36,10 @@
</span><span class="cx"> static bool shrinkToFitAfterNavigationDone;
</span><span class="cx"> static bool shrinkToFitDisabledDone;
</span><span class="cx">
</span><del>-@interface ShrinkToFitNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation ShrinkToFitNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- // After loading a wide page, the view should be scaled to fit the width of the document.
- [webView evaluateJavaScript:@"document.body.clientWidth" completionHandler:^(id result, NSError *error) {
- EXPECT_EQ(808, [result integerValue]);
- shrinkToFitAfterNavigationDone = true;
- }];
-}
-
-@end
-
</del><span class="cx"> TEST(WebKit2, ShrinkToFit)
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100)]);
</span><span class="cx">
</span><del>- ShrinkToFitNavigationDelegate *delegate = [[ShrinkToFitNavigationDelegate alloc] init];
- [webView setNavigationDelegate:delegate];
-
</del><span class="cx"> [webView evaluateJavaScript:@"document.body.clientWidth" completionHandler:^(id result, NSError *error) {
</span><span class="cx"> EXPECT_EQ(100, [result integerValue]);
</span><span class="cx">
</span><span class="lines">@@ -69,7 +51,14 @@
</span><span class="cx">
</span><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"lots-of-text" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><ins>+ // After loading a wide page, the view should be scaled to fit the width of the document.
+ [webView evaluateJavaScript:@"document.body.clientWidth" completionHandler:^(id result, NSError *error) {
+ EXPECT_EQ(808, [result integerValue]);
+ shrinkToFitAfterNavigationDone = true;
+ }];
+
</ins><span class="cx"> TestWebKitAPI::Util::run(&shrinkToFitAfterNavigationDone);
</span><span class="cx">
</span><span class="cx"> [webView _setLayoutMode:_WKLayoutModeViewSize];
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaUserContentControllermm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKProcessPoolPrivate.h>
</span><span class="cx"> #import <WebKit/WKUserContentControllerPrivate.h>
</span><span class="cx"> #import <WebKit/WKUserScript.h>
</span><span class="lines">@@ -78,15 +79,11 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx">
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
-
</del><span class="cx"> [webView evaluateJavaScript:@"window.webkit.messageHandlers.testHandler.postMessage('Hello')" completionHandler:nil];
</span><span class="cx">
</span><span class="cx"> TestWebKitAPI::Util::run(&receivedScriptMessage);
</span><span class="lines">@@ -154,15 +151,11 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx">
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
-
</del><span class="cx"> // Test that handlerToRemove was succesfully added.
</span><span class="cx"> [webView evaluateJavaScript:
</span><span class="cx"> @"if (window.webkit.messageHandlers.handlerToRemove) {"
</span><span class="lines">@@ -202,15 +195,11 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx">
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
-
</del><span class="cx"> [webView evaluateJavaScript:@"var handlerToRemove = window.webkit.messageHandlers.handlerToRemove;" completionHandler:nil];
</span><span class="cx">
</span><span class="cx"> [userContentController removeScriptMessageHandlerForName:@"handlerToRemove"];
</span><span class="lines">@@ -237,12 +226,9 @@
</span><span class="cx"> [[configurationCopy userContentController] addScriptMessageHandler:handler.get() name:@"handlerToRemove"];
</span><span class="cx"> [[configurationCopy userContentController] addScriptMessageHandler:handler.get() name:@"handlerToPost"];
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configurationCopy.get()]);
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> return webView;
</span><span class="cx"> }
</span><span class="lines">@@ -282,15 +268,10 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
-
</del><span class="cx"> [webView evaluateJavaScript:@"window.webkit.messageHandlers.testHandler.postMessage('First Message')" completionHandler:nil];
</span><span class="cx">
</span><span class="cx"> TestWebKitAPI::Util::run(&receivedScriptMessage);
</span><span class="lines">@@ -300,10 +281,8 @@
</span><span class="cx"> receivedScriptMessage = false;
</span><span class="cx"> lastScriptMessage = nullptr;
</span><span class="cx">
</span><del>-
</del><span class="cx"> [webView loadRequest:request];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> [webView evaluateJavaScript:@"window.webkit.messageHandlers.testHandler.postMessage('Second Message')" completionHandler:nil];
</span><span class="cx">
</span><span class="lines">@@ -322,15 +301,11 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx">
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
-
</del><span class="cx"> // Test that handlerToReplace was succesfully added.
</span><span class="cx"> [webView evaluateJavaScript:@"window.webkit.messageHandlers.handlerToReplace.postMessage('PASS1');" completionHandler:nil];
</span><span class="cx">
</span><span class="lines">@@ -381,12 +356,8 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> [webView loadHTMLString:@"<body style='background-color: red;'></body>" baseURL:nil];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> expectScriptEvaluatesToColor(webView.get(), backgroundColorScript, greenInRGB);
</span><span class="cx"> }
</span><span class="lines">@@ -395,12 +366,8 @@
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> [webView loadHTMLString:@"<body style='background-color: red;'></body>" baseURL:nil];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> expectScriptEvaluatesToColor(webView.get(), backgroundColorScript, redInRGB);
</span><span class="cx">
</span><span class="lines">@@ -419,12 +386,8 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> [webView loadHTMLString:@"<body style='background-color: red;'><iframe></iframe></body>" baseURL:nil];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> // The main frame should be affected.
</span><span class="cx"> expectScriptEvaluatesToColor(webView.get(), backgroundColorScript, greenInRGB);
</span><span class="lines">@@ -442,12 +405,8 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleNavigationDelegate> delegate = adoptNS([[SimpleNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> [webView loadHTMLString:@"<body style='background-color: red;'><iframe></iframe></body>" baseURL:nil];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> // The main frame should be affected.
</span><span class="cx"> expectScriptEvaluatesToColor(webView.get(), backgroundColorScript, greenInRGB);
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaUserContentWorldmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import "UserContentWorldProtocol.h"
</span><span class="cx"> #import "WKWebViewConfigurationExtras.h"
</span><span class="cx"> #import <WebKit/WKProcessPoolPrivate.h>
</span><span class="lines">@@ -44,19 +45,6 @@
</span><span class="cx"> #import <WebKit/_WKUserStyleSheet.h>
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><del>-static bool isDoneWithNavigation;
-
-@interface SimpleDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation SimpleDelegate
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- isDoneWithNavigation = true;
-}
-@end
-
-
</del><span class="cx"> TEST(UserContentWorld, NormalWorld)
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<WKUserScript> basicUserScript = adoptNS([[WKUserScript alloc] initWithSource:@"" injectionTime:WKUserScriptInjectionTimeAtDocumentStart forMainFrameOnly:YES]);
</span><span class="lines">@@ -73,12 +61,8 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleDelegate> delegate = adoptNS([[SimpleDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> [webView loadHTMLString:@"<body style='background-color: red;'></body>" baseURL:nil];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> __block bool isDone = false;
</span><span class="cx"> [webView evaluateJavaScript:@"window.setFromUserScript ? 'variable accessible' : 'variable inaccessible';" completionHandler:^(id result, NSError *error) {
</span><span class="lines">@@ -112,12 +96,8 @@
</span><span class="cx">
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
</span><span class="cx">
</span><del>- RetainPtr<SimpleDelegate> delegate = adoptNS([[SimpleDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> [webView loadHTMLString:@"<body style='background-color: red;'></body>" baseURL:nil];
</span><del>- TestWebKitAPI::Util::run(&isDoneWithNavigation);
- isDoneWithNavigation = false;
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> __block bool isDone = false;
</span><span class="cx"> [webView evaluateJavaScript:@"window.setFromUserScript ? 'variable accessible' : 'variable inaccessible';" completionHandler:^(id result, NSError *error) {
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaWKPDFViewResizeCrashmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -25,41 +25,24 @@
</span><span class="cx">
</span><span class="cx"> #include "config.h"
</span><span class="cx">
</span><del>-#import <WebKit/WKNavigationDelegate.h>
</del><ins>+#import "PlatformUtilities.h"
+#import "Test.h"
+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKWebView.h>
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><del>-#import "PlatformUtilities.h"
-#import "Test.h"
</del><span class="cx">
</span><span class="cx"> #if WK_API_ENABLED
</span><span class="cx">
</span><del>-static bool finishedLoading;
</del><span class="cx"> static bool finishedDispatch;
</span><span class="cx">
</span><del>-@interface WKPDFViewResizeNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation WKPDFViewResizeNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- finishedLoading = true;
-}
-
-@end
-
</del><span class="cx"> TEST(WebKit2, WKPDFViewResizeCrash)
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
</span><span class="cx">
</span><del>- RetainPtr<WKPDFViewResizeNavigationDelegate> delegate = adoptNS([[WKPDFViewResizeNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
-
</del><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"test" withExtension:@"pdf" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><del>- TestWebKitAPI::Util::run(&finishedLoading);
-
</del><span class="cx"> [webView setFrame:NSMakeRect(0, 0, 100, 100)];
</span><span class="cx"> webView = nil;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaWKWebViewEvaluateJavaScriptmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx">
</span><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><ins>+#import "TestNavigationDelegate.h"
</ins><span class="cx"> #import <WebKit/WKWebView.h>
</span><span class="cx"> #import <WebKit/WKErrorPrivate.h>
</span><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="lines">@@ -36,18 +37,6 @@
</span><span class="cx">
</span><span class="cx"> static bool isDone;
</span><span class="cx">
</span><del>-@interface EvaluateJavaScriptNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation EvaluateJavaScriptNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- isDone = true;
-}
-
-@end
-
</del><span class="cx"> TEST(WKWebView, EvaluateJavaScriptBlockCrash)
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
</span><span class="lines">@@ -76,12 +65,10 @@
</span><span class="cx"> TEST(WKWebView, EvaluateJavaScriptErrorCases)
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
</span><del>- RetainPtr<EvaluateJavaScriptNavigationDelegate> delegate = adoptNS([[EvaluateJavaScriptNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
</del><span class="cx">
</span><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><del>- TestWebKitAPI::Util::run(&isDone);
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> [webView evaluateJavaScript:@"document.body" completionHandler:^(id result, NSError *error) {
</span><span class="cx"> EXPECT_NULL(result);
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKit2CocoaWKWebViewTextInputmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm (205328 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm 2016-09-02 01:01:29 UTC (rev 205328)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -28,35 +28,19 @@
</span><span class="cx"> #if WK_API_ENABLED
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx">
</span><del>-#import <WebKit/WKFoundation.h>
</del><span class="cx"> #import "PlatformUtilities.h"
</span><span class="cx"> #import "Test.h"
</span><del>-#import <WebKit/WKWebView.h>
</del><ins>+#import "TestNavigationDelegate.h"
+#import <WebKit/WebKit.h>
</ins><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><del>-static bool isDone;
-
-@interface DummyNavigationDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation DummyNavigationDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
- isDone = true;
-}
-
-@end
-
</del><span class="cx"> TEST(WKWebView, ShouldHaveInputContextForEditableContent)
</span><span class="cx"> {
</span><span class="cx"> RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
</span><del>- RetainPtr<DummyNavigationDelegate> delegate = adoptNS([[DummyNavigationDelegate alloc] init]);
- [webView setNavigationDelegate:delegate.get()];
</del><span class="cx">
</span><span class="cx"> NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"editable-body" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
</span><span class="cx"> [webView loadRequest:request];
</span><del>- TestWebKitAPI::Util::run(&isDone);
</del><ins>+ [webView _test_waitForDidFinishNavigation];
</ins><span class="cx">
</span><span class="cx"> EXPECT_NOT_NULL([webView inputContext]);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPIcocoaTestNavigationDelegatehfromrev205328trunkToolsTestWebKitAPITestsWebKit2CocoaWKWebViewTextInputmm"></a>
<div class="copfile"><h4>Copied: trunk/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h (from rev 205328, trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm) (0 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h (rev 0)
+++ trunk/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -0,0 +1,47 @@
</span><ins>+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#pragma once
+
+#if WK_API_ENABLED
+
+#import <WebKit/WKNavigationDelegatePrivate.h>
+#import <WebKit/WebKit.h>
+
+@interface TestNavigationDelegate : NSObject <WKNavigationDelegate>
+
+@property (nonatomic, copy) void (^didFailProvisionalNavigation)(WKWebView *, WKNavigation *, NSError *);
+@property (nonatomic, copy) void (^didFinishNavigation)(WKWebView *, WKNavigation *);
+@property (nonatomic, copy) void (^renderingProgressDidChange)(WKWebView *, _WKRenderingProgressEvents);
+
+- (void)waitForDidFinishNavigation;
+
+@end
+
+@interface WKWebView (TestWebKitAPIExtras)
+- (void)_test_waitForDidFinishNavigation;
+@end
+
+#endif
</ins></span></pre></div>
<a id="trunkToolsTestWebKitAPIcocoaTestNavigationDelegatemmfromrev205328trunkToolsTestWebKitAPITestsWebKit2CocoaProvisionalURLNotChangemm"></a>
<div class="copfile"><h4>Copied: trunk/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm (from rev 205328, trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm) (0 => 205329)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm (rev 0)
+++ trunk/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm 2016-09-02 01:16:56 UTC (rev 205329)
</span><span class="lines">@@ -0,0 +1,85 @@
</span><ins>+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import "config.h"
+#import "TestNavigationDelegate.h"
+
+#import "Utilities.h"
+#import <wtf/RetainPtr.h>
+
+#if WK_API_ENABLED
+
+@implementation TestNavigationDelegate
+
+- (void)webView:(WKWebView *)webView didFailProvisionalNavigation:(WKNavigation *)navigation withError:(NSError *)error
+{
+ if (_didFailProvisionalNavigation)
+ _didFailProvisionalNavigation(webView, navigation, error);
+}
+
+- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
+{
+ if (_didFinishNavigation)
+ _didFinishNavigation(webView, navigation);
+}
+
+- (void)_webView:(WKWebView *)webView renderingProgressDidChange:(_WKRenderingProgressEvents)progressEvents
+{
+ if (_renderingProgressDidChange)
+ _renderingProgressDidChange(webView, progressEvents);
+}
+
+- (void)waitForDidFinishNavigation
+{
+ EXPECT_FALSE(self.didFinishNavigation);
+
+ __block bool finished = false;
+ self.didFinishNavigation = ^(WKWebView *, WKNavigation *) {
+ finished = true;
+ };
+
+ TestWebKitAPI::Util::run(&finished);
+
+ self.didFinishNavigation = nil;
+}
+
+@end
+
+@implementation WKWebView (TestWebKitAPIExtras)
+
+- (void)_test_waitForDidFinishNavigation
+{
+ EXPECT_FALSE(self.navigationDelegate);
+
+ auto navigationDelegate = adoptNS([[TestNavigationDelegate alloc] init]);
+ self.navigationDelegate = navigationDelegate.get();
+ [navigationDelegate waitForDidFinishNavigation];
+
+ self.navigationDelegate = nil;
+}
+
+@end
+
+#endif
</ins></span></pre>
</div>
</div>
</body>
</html>