<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205267] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205267">205267</a></dd>
<dt>Author</dt> <dd>utatane.tea@gmail.com</dd>
<dt>Date</dt> <dd>2016-08-31 14:03:34 -0700 (Wed, 31 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>stress/random-53bit.js.ftl-no-cjit-no-inline-validate sometimes fails
https://bugs.webkit.org/show_bug.cgi?id=161436
Reviewed by Filip Pizlo.
JSTests:
The test checks Math.random() correctly produces 53bit random values.
The test can fail by design, but this should be fairly rare.
However, when introducing, we wrap the `test()` with 1e4 to ensure the FTL compilation, and this
increases the failure rate. By increasing the MAX in the test, we make the failures much more rare case.
And we also add getRandomSeed() and setRandomSeed(seed) JSC shell helpers to dump more useful information
and reproduce the situation easily.
* stress/random-53bit.js:
(test):
Source/JavaScriptCore:
* jsc.cpp:
(GlobalObject::finishCreation):
(functionGetRandomSeed):
(functionSetRandomSeed):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::weakRandom):
(JSC::JSGlobalObject::weakRandomInteger): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkJSTestsstressrandom53bitjs">trunk/JSTests/stress/random-53bit.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorejsccpp">trunk/Source/JavaScriptCore/jsc.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjecth">trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (205266 => 205267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog 2016-08-31 20:19:39 UTC (rev 205266)
+++ trunk/JSTests/ChangeLog 2016-08-31 21:03:34 UTC (rev 205267)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-08-31 Yusuke Suzuki <utatane.tea@gmail.com>
+
+ stress/random-53bit.js.ftl-no-cjit-no-inline-validate sometimes fails
+ https://bugs.webkit.org/show_bug.cgi?id=161436
+
+ Reviewed by Filip Pizlo.
+
+ The test checks Math.random() correctly produces 53bit random values.
+ The test can fail by design, but this should be fairly rare.
+
+ However, when introducing, we wrap the `test()` with 1e4 to ensure the FTL compilation, and this
+ increases the failure rate. By increasing the MAX in the test, we make the failures much more rare case.
+
+ And we also add getRandomSeed() and setRandomSeed(seed) JSC shell helpers to dump more useful information
+ and reproduce the situation easily.
+
+ * stress/random-53bit.js:
+ (test):
+
</ins><span class="cx"> 2016-08-29 Benjamin Poulain <bpoulain@apple.com>
</span><span class="cx">
</span><span class="cx"> [JSC] Improve ArithAbs with polymorphic input
</span></span></pre></div>
<a id="trunkJSTestsstressrandom53bitjs"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/stress/random-53bit.js (205266 => 205267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/stress/random-53bit.js 2016-08-31 20:19:39 UTC (rev 205266)
+++ trunk/JSTests/stress/random-53bit.js 2016-08-31 21:03:34 UTC (rev 205267)
</span><span class="lines">@@ -1,10 +1,12 @@
</span><span class="cx"> function test() {
</span><del>- var MAX = 30;
</del><ins>+ var MAX = 50;
</ins><span class="cx"> var found53Bit = false;
</span><span class="cx"> var foundLessThan53Bit = false;
</span><ins>+ var results = new Array(MAX);
</ins><span class="cx">
</span><span class="cx"> for (var i = 0; i < MAX; ++i) {
</span><span class="cx"> var str = Math.random().toString(2);
</span><ins>+ results[i] = str;
</ins><span class="cx"> // 53 bit + '0.'.length
</span><span class="cx"> if (str.length === (53 + 2))
</span><span class="cx"> found53Bit = true;
</span><span class="lines">@@ -14,6 +16,8 @@
</span><span class="cx"> if (found53Bit && foundLessThan53Bit)
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><ins>+ print(`Random seed ${getRandomSeed()}`);
+ print(results.join('\n'));
</ins><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx"> noInline(test);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (205266 => 205267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-08-31 20:19:39 UTC (rev 205266)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-08-31 21:03:34 UTC (rev 205267)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-08-31 Yusuke Suzuki <utatane.tea@gmail.com>
+
+ stress/random-53bit.js.ftl-no-cjit-no-inline-validate sometimes fails
+ https://bugs.webkit.org/show_bug.cgi?id=161436
+
+ Reviewed by Filip Pizlo.
+
+ * jsc.cpp:
+ (GlobalObject::finishCreation):
+ (functionGetRandomSeed):
+ (functionSetRandomSeed):
+ * runtime/JSGlobalObject.h:
+ (JSC::JSGlobalObject::weakRandom):
+ (JSC::JSGlobalObject::weakRandomInteger): Deleted.
+
</ins><span class="cx"> 2016-08-31 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Object.getPrototypeOf() should return null cross-origin
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejsccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jsc.cpp (205266 => 205267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jsc.cpp 2016-08-31 20:19:39 UTC (rev 205266)
+++ trunk/Source/JavaScriptCore/jsc.cpp 2016-08-31 21:03:34 UTC (rev 205267)
</span><span class="lines">@@ -647,6 +647,8 @@
</span><span class="cx">
</span><span class="cx"> static EncodedJSValue JSC_HOST_CALL functionShadowChickenFunctionsOnStack(ExecState*);
</span><span class="cx"> static EncodedJSValue JSC_HOST_CALL functionSetGlobalConstRedeclarationShouldNotThrow(ExecState*);
</span><ins>+static EncodedJSValue JSC_HOST_CALL functionGetRandomSeed(ExecState*);
+static EncodedJSValue JSC_HOST_CALL functionSetRandomSeed(ExecState*);
</ins><span class="cx">
</span><span class="cx"> struct Script {
</span><span class="cx"> enum class StrictMode {
</span><span class="lines">@@ -857,6 +859,9 @@
</span><span class="cx">
</span><span class="cx"> addFunction(vm, "drainMicrotasks", functionDrainMicrotasks, 0);
</span><span class="cx">
</span><ins>+ addFunction(vm, "getRandomSeed", functionGetRandomSeed, 0);
+ addFunction(vm, "setRandomSeed", functionSetRandomSeed, 1);
+
</ins><span class="cx"> addFunction(vm, "is32BitPlatform", functionIs32BitPlatform, 0);
</span><span class="cx">
</span><span class="cx"> addFunction(vm, "loadModule", functionLoadModule, 1);
</span><span class="lines">@@ -1597,6 +1602,20 @@
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+EncodedJSValue JSC_HOST_CALL functionGetRandomSeed(ExecState* exec)
+{
+ return JSValue::encode(jsNumber(exec->lexicalGlobalObject()->weakRandom().seed()));
+}
+
+EncodedJSValue JSC_HOST_CALL functionSetRandomSeed(ExecState* exec)
+{
+ unsigned seed = exec->argument(0).toUInt32(exec);
+ if (exec->hadException())
+ return JSValue::encode(jsUndefined());
+ exec->lexicalGlobalObject()->weakRandom().setSeed(seed);
+ return JSValue::encode(jsUndefined());
+}
+
</ins><span class="cx"> EncodedJSValue JSC_HOST_CALL functionReadline(ExecState* exec)
</span><span class="cx"> {
</span><span class="cx"> Vector<char, 256> line;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h (205266 => 205267)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h 2016-08-31 20:19:39 UTC (rev 205266)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h 2016-08-31 21:03:34 UTC (rev 205267)
</span><span class="lines">@@ -766,6 +766,7 @@
</span><span class="cx"> static ptrdiff_t weakRandomOffset() { return OBJECT_OFFSETOF(JSGlobalObject, m_weakRandom); }
</span><span class="cx"> double weakRandomNumber() { return m_weakRandom.get(); }
</span><span class="cx"> unsigned weakRandomInteger() { return m_weakRandom.getUint32(); }
</span><ins>+ WeakRandom& weakRandom() { return m_weakRandom; }
</ins><span class="cx">
</span><span class="cx"> UnlinkedProgramCodeBlock* createProgramCodeBlock(CallFrame*, ProgramExecutable*, JSObject** exception);
</span><span class="cx"> UnlinkedEvalCodeBlock* createEvalCodeBlock(CallFrame*, EvalExecutable*, const VariableEnvironment*);
</span></span></pre>
</div>
</div>
</body>
</html>