<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205220] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205220">205220</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-30 22:18:54 -0700 (Tue, 30 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add "get" to CustomElementsRegistry
https://bugs.webkit.org/show_bug.cgi?id=161421
Reviewed by Yusuke Suzuki.
Source/WebCore:
Add the support for "get" method on CustomElementsRegistry, which returns the constructor
of the custom element with the given name:
https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementregistry-get
Tests: fast/custom-elements/CustomElementRegistry.html
* dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::get): Added.
* dom/CustomElementRegistry.h:
* dom/CustomElementRegistry.idl:
LayoutTests:
Added test cases for "get" method on CustomElementsRegistry.
* fast/custom-elements/CustomElementRegistry-expected.txt:
* fast/custom-elements/CustomElementRegistry.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcustomelementsCustomElementRegistryexpectedtxt">trunk/LayoutTests/fast/custom-elements/CustomElementRegistry-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcustomelementsCustomElementRegistryhtml">trunk/LayoutTests/fast/custom-elements/CustomElementRegistry.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomCustomElementRegistrycpp">trunk/Source/WebCore/dom/CustomElementRegistry.cpp</a></li>
<li><a href="#trunkSourceWebCoredomCustomElementRegistryh">trunk/Source/WebCore/dom/CustomElementRegistry.h</a></li>
<li><a href="#trunkSourceWebCoredomCustomElementRegistryidl">trunk/Source/WebCore/dom/CustomElementRegistry.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (205219 => 205220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-31 05:03:10 UTC (rev 205219)
+++ trunk/LayoutTests/ChangeLog 2016-08-31 05:18:54 UTC (rev 205220)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-08-30 Ryosuke Niwa <rniwa@webkit.org>
+
+ Add "get" to CustomElementsRegistry
+ https://bugs.webkit.org/show_bug.cgi?id=161421
+
+ Reviewed by Yusuke Suzuki.
+
+ Added test cases for "get" method on CustomElementsRegistry.
+
+ * fast/custom-elements/CustomElementRegistry-expected.txt:
+ * fast/custom-elements/CustomElementRegistry.html:
+
</ins><span class="cx"> 2016-08-30 Jiewen Tan <jiewen_tan@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, update iOS simulator WK1 flaky tests.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcustomelementsCustomElementRegistryexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/custom-elements/CustomElementRegistry-expected.txt (205219 => 205220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/custom-elements/CustomElementRegistry-expected.txt 2016-08-31 05:03:10 UTC (rev 205219)
+++ trunk/LayoutTests/fast/custom-elements/CustomElementRegistry-expected.txt 2016-08-31 05:18:54 UTC (rev 205220)
</span><span class="lines">@@ -17,4 +17,8 @@
</span><span class="cx"> PASS customElements.define must rethrow an exception thrown while retrieving Symbol.iterator on observedAttributes
</span><span class="cx"> PASS customElements.define must not throw even if "observedAttributes" fails to convert if "attributeChangedCallback" is not defined
</span><span class="cx"> PASS customElements.define must define an instantiatable custom element
</span><ins>+PASS CustomElementRegistry interface must have get as a method
+PASS "get" must return undefined when the registry does not contain an entry with the given name
+PASS "get" must return undefined when the registry does not contain an entry with the given name even if the name was not a valid custom element name
+PASS "get" return the constructor of the entry with the given name when there is a matching entry.
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastcustomelementsCustomElementRegistryhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/custom-elements/CustomElementRegistry.html (205219 => 205220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/custom-elements/CustomElementRegistry.html 2016-08-31 05:03:10 UTC (rev 205219)
+++ trunk/LayoutTests/fast/custom-elements/CustomElementRegistry.html 2016-08-31 05:18:54 UTC (rev 205220)
</span><span class="lines">@@ -267,6 +267,30 @@
</span><span class="cx">
</span><span class="cx"> }, 'customElements.define must define an instantiatable custom element');
</span><span class="cx">
</span><ins>+test(function () {
+ assert_true('get' in CustomElementRegistry.prototype, '"get" exists on CustomElementRegistry.prototype');
+ assert_true('get' in customElements, '"get" exists on window.customElements');
+}, 'CustomElementRegistry interface must have get as a method');
+
+test(function () {
+ assert_equals(customElements.get('a-b'), undefined);
+}, '"get" must return undefined when the registry does not contain an entry with the given name');
+
+test(function () {
+ assert_equals(customElements.get('html'), undefined);
+ assert_equals(customElements.get('span'), undefined);
+ assert_equals(customElements.get('div'), undefined);
+ assert_equals(customElements.get('g'), undefined);
+ assert_equals(customElements.get('ab'), undefined);
+}, '"get" must return undefined when the registry does not contain an entry with the given name even if the name was not a valid custom element name');
+
+test(function () {
+ assert_equals(customElements.get('existing-custom-element'), undefined);
+ class ExistingCustomElement extends HTMLElement {};
+ customElements.define('existing-custom-element', ExistingCustomElement);
+ assert_equals(customElements.get('existing-custom-element'), ExistingCustomElement);
+}, '"get" return the constructor of the entry with the given name when there is a matching entry.');
+
</ins><span class="cx"> </script>
</span><span class="cx"> </body>
</span><span class="cx"> </html>
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (205219 => 205220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-31 05:03:10 UTC (rev 205219)
+++ trunk/Source/WebCore/ChangeLog 2016-08-31 05:18:54 UTC (rev 205220)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-08-30 Ryosuke Niwa <rniwa@webkit.org>
+
+ Add "get" to CustomElementsRegistry
+ https://bugs.webkit.org/show_bug.cgi?id=161421
+
+ Reviewed by Yusuke Suzuki.
+
+ Add the support for "get" method on CustomElementsRegistry, which returns the constructor
+ of the custom element with the given name:
+ https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementregistry-get
+
+ Tests: fast/custom-elements/CustomElementRegistry.html
+
+ * dom/CustomElementRegistry.cpp:
+ (WebCore::CustomElementRegistry::get): Added.
+ * dom/CustomElementRegistry.h:
+ * dom/CustomElementRegistry.idl:
+
</ins><span class="cx"> 2016-08-30 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Make PendingScript as ref-counted
</span></span></pre></div>
<a id="trunkSourceWebCoredomCustomElementRegistrycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CustomElementRegistry.cpp (205219 => 205220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/CustomElementRegistry.cpp 2016-08-31 05:03:10 UTC (rev 205219)
+++ trunk/Source/WebCore/dom/CustomElementRegistry.cpp 2016-08-31 05:18:54 UTC (rev 205220)
</span><span class="lines">@@ -105,6 +105,13 @@
</span><span class="cx"> return m_constructorMap.contains(constructor);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+JSC::JSValue CustomElementRegistry::get(const AtomicString& name)
+{
+ if (auto* elementInterface = m_nameMap.get(name))
+ return elementInterface->constructor();
+ return JSC::jsUndefined();
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+}
+
</ins><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoredomCustomElementRegistryh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CustomElementRegistry.h (205219 => 205220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/CustomElementRegistry.h 2016-08-31 05:03:10 UTC (rev 205219)
+++ trunk/Source/WebCore/dom/CustomElementRegistry.h 2016-08-31 05:18:54 UTC (rev 205220)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> namespace JSC {
</span><span class="cx">
</span><span class="cx"> class JSObject;
</span><ins>+class JSValue;
</ins><span class="cx">
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -57,6 +58,8 @@
</span><span class="cx"> JSCustomElementInterface* findInterface(const JSC::JSObject*) const;
</span><span class="cx"> bool containsConstructor(const JSC::JSObject*) const;
</span><span class="cx">
</span><ins>+ JSC::JSValue get(const AtomicString&);
+
</ins><span class="cx"> private:
</span><span class="cx"> CustomElementRegistry();
</span><span class="cx">
</span><span class="lines">@@ -64,7 +67,7 @@
</span><span class="cx"> HashMap<AtomicString, Ref<JSCustomElementInterface>> m_nameMap;
</span><span class="cx"> HashMap<const JSC::JSObject*, JSCustomElementInterface*> m_constructorMap;
</span><span class="cx"> };
</span><del>-
</del><ins>+
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoredomCustomElementRegistryidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/CustomElementRegistry.idl (205219 => 205220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/CustomElementRegistry.idl 2016-08-31 05:03:10 UTC (rev 205219)
+++ trunk/Source/WebCore/dom/CustomElementRegistry.idl 2016-08-31 05:18:54 UTC (rev 205220)
</span><span class="lines">@@ -31,5 +31,6 @@
</span><span class="cx"> ] interface CustomElementRegistry {
</span><span class="cx">
</span><span class="cx"> [CEReactions, Custom] void define(DOMString name, Function constructor);
</span><ins>+ any get(DOMString name);
</ins><span class="cx">
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>