<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205202] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205202">205202</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-30 15:29:42 -0700 (Tue, 30 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Introduce a MathMLUnknownElement class
https://bugs.webkit.org/show_bug.cgi?id=161298
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-30
Reviewed by Darin Adler.
Source/WebCore:
For consistency with SVG and HTML, we make MathML elements use a
fallback MathMLUnknownElement class. Like SVG, we ensure that unknown
MathML elements do not create any renderer.
Test: mathml/mathml-unknown.xhtml
* mathml/MathMLUnknownElement.h: Added. This is a simple class for
unknown MathML elements, preventing the creation of renderers.
* mathml/mathtags.in: Map fallbackInterfaceName to MathMLUnknownElement.
LayoutTests:
We add a test to check that non-standard or content MathML elements
are handled by MathMLUnknownElement and so do not create renderers.
* mathml/mathml-unknown-expected.txt: Added.
* mathml/mathml-unknown.xhtml: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoremathmlmathtagsin">trunk/Source/WebCore/mathml/mathtags.in</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsmathmlmathmlunknownexpectedtxt">trunk/LayoutTests/mathml/mathml-unknown-expected.txt</a></li>
<li><a href="#trunkLayoutTestsmathmlmathmlunknownxhtml">trunk/LayoutTests/mathml/mathml-unknown.xhtml</a></li>
<li><a href="#trunkSourceWebCoremathmlMathMLUnknownElementh">trunk/Source/WebCore/mathml/MathMLUnknownElement.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (205201 => 205202)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-30 22:28:20 UTC (rev 205201)
+++ trunk/LayoutTests/ChangeLog 2016-08-30 22:29:42 UTC (rev 205202)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-08-30 Frederic Wang <fwang@igalia.com>
+
+ Introduce a MathMLUnknownElement class
+ https://bugs.webkit.org/show_bug.cgi?id=161298
+
+ Reviewed by Darin Adler.
+
+ We add a test to check that non-standard or content MathML elements
+ are handled by MathMLUnknownElement and so do not create renderers.
+
+ * mathml/mathml-unknown-expected.txt: Added.
+ * mathml/mathml-unknown.xhtml: Added.
+
</ins><span class="cx"> 2016-08-30 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> [[Delete]] should throw for cross-origin Window / Location objects
</span></span></pre></div>
<a id="trunkLayoutTestsmathmlmathmlunknownexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/mathml/mathml-unknown-expected.txt (0 => 205202)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/mathml/mathml-unknown-expected.txt (rev 0)
+++ trunk/LayoutTests/mathml/mathml-unknown-expected.txt 2016-08-30 22:29:42 UTC (rev 205202)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+This test passes if the unknown MathML elements do not create any renderer.
+
+Content MathML element:
+
+Non-standard MathML element:
</ins></span></pre></div>
<a id="trunkLayoutTestsmathmlmathmlunknownxhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/mathml/mathml-unknown.xhtml (0 => 205202)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/mathml/mathml-unknown.xhtml (rev 0)
+++ trunk/LayoutTests/mathml/mathml-unknown.xhtml 2016-08-30 22:29:42 UTC (rev 205202)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE html PUBLIC
+ "-//W3C//DTD XHTML 1.1 plus MathML 2.0 plus SVG 1.1//EN"
+ "http://www.w3.org/2002/04/xhtml-math-svg/xhtml-math-svg.dtd">
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<head>
+ <title>Unknown MathML elements</title>
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ </script>
+</head>
+<body>
+ <p>This test passes if the unknown MathML elements do not create any renderer.</p>
+ <p>Content MathML element: <math xmlns="http://www.w3.org/1998/Math/MathML"><csymbol><mtext>FAIL</mtext></csymbol></math></p>
+ <p>Non-standard MathML element: <non-standard xmlns="http://www.w3.org/1998/Math/MathML"><mtext>FAIL</mtext></non-standard></p>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (205201 => 205202)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-30 22:28:20 UTC (rev 205201)
+++ trunk/Source/WebCore/ChangeLog 2016-08-30 22:29:42 UTC (rev 205202)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-08-30 Frederic Wang <fwang@igalia.com>
+
+ Introduce a MathMLUnknownElement class
+ https://bugs.webkit.org/show_bug.cgi?id=161298
+
+ Reviewed by Darin Adler.
+
+ For consistency with SVG and HTML, we make MathML elements use a
+ fallback MathMLUnknownElement class. Like SVG, we ensure that unknown
+ MathML elements do not create any renderer.
+
+ Test: mathml/mathml-unknown.xhtml
+
+ * mathml/MathMLUnknownElement.h: Added. This is a simple class for
+ unknown MathML elements, preventing the creation of renderers.
+ * mathml/mathtags.in: Map fallbackInterfaceName to MathMLUnknownElement.
+
</ins><span class="cx"> 2016-08-30 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> [[Delete]] should throw for cross-origin Window / Location objects
</span></span></pre></div>
<a id="trunkSourceWebCoremathmlMathMLUnknownElementh"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/mathml/MathMLUnknownElement.h (0 => 205202)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/MathMLUnknownElement.h (rev 0)
+++ trunk/Source/WebCore/mathml/MathMLUnknownElement.h 2016-08-30 22:29:42 UTC (rev 205202)
</span><span class="lines">@@ -0,0 +1,51 @@
</span><ins>+/*
+ * Copyright (C) 2016 Igalia S.L. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef MathMLUnknownElement_h
+#define MathMLUnknownElement_h
+
+#include "MathMLElement.h"
+
+namespace WebCore {
+
+class MathMLUnknownElement final : public MathMLElement {
+public:
+ static Ref<MathMLUnknownElement> create(const QualifiedName& tagName, Document& document)
+ {
+ return adoptRef(*new MathMLUnknownElement(tagName, document));
+ }
+
+private:
+ MathMLUnknownElement(const QualifiedName& tagName, Document& document)
+ : MathMLElement(tagName, document)
+ {
+ }
+
+ bool rendererIsNeeded(const RenderStyle&) final { return false; }
+};
+
+} // namespace WebCore
+
+#endif // MathMLUnknownElement_h
</ins></span></pre></div>
<a id="trunkSourceWebCoremathmlmathtagsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/mathml/mathtags.in (205201 => 205202)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/mathtags.in 2016-08-30 22:28:20 UTC (rev 205201)
+++ trunk/Source/WebCore/mathml/mathtags.in 2016-08-30 22:29:42 UTC (rev 205202)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx"> namespace="MathML"
</span><span class="cx"> namespaceURI="http://www.w3.org/1998/Math/MathML"
</span><span class="cx"> guardFactoryWith="ENABLE(MATHML)"
</span><del>-fallbackInterfaceName="MathMLElement"
</del><ins>+fallbackInterfaceName="MathMLUnknownElement"
</ins><span class="cx">
</span><span class="cx"> annotation interfaceName=MathMLAnnotationElement
</span><span class="cx"> annotation-xml interfaceName=MathMLAnnotationElement
</span></span></pre>
</div>
</div>
</body>
</html>