<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205138] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205138">205138</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-08-29 12:55:11 -0700 (Mon, 29 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>document.createEvent("popstateevent") should create a PopStateEvent
https://bugs.webkit.org/show_bug.cgi?id=161321
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
* web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
* web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
* web-platform-tests/html/browsers/browsing-the-web/history-traversal/PopStateEvent-expected.txt:
Source/WebCore:
document.createEvent("popstateevent") should create a PopStateEvent as per:
- https://dom.spec.whatwg.org/#dom-document-createevent
Firefox and Chrome match the specification but WebKit throws an exception,
which is risky compatibility-wise.
No new tests, rebaselined existing tests.
* dom/Document.cpp:
(WebCore::Document::createEvent):
* dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::createForBindings):
* dom/PopStateEvent.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomeventsEventTargetdispatchEventexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentcreateEventexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlbrowsersbrowsingthewebhistorytraversalPopStateEventexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/PopStateEvent-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomPopStateEventcpp">trunk/Source/WebCore/dom/PopStateEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomPopStateEventh">trunk/Source/WebCore/dom/PopStateEvent.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (205137 => 205138)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-29 19:44:48 UTC (rev 205137)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-29 19:55:11 UTC (rev 205138)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2016-08-29 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ document.createEvent("popstateevent") should create a PopStateEvent
+ https://bugs.webkit.org/show_bug.cgi?id=161321
+
+ Reviewed by Darin Adler.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
+ * web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
+ * web-platform-tests/html/browsers/browsing-the-web/history-traversal/PopStateEvent-expected.txt:
+
+2016-08-29 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> We should throw a SecurityError when denying access to cross-origin Window properties
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=161316
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomeventsEventTargetdispatchEventexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt (205137 => 205138)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt 2016-08-29 19:44:48 UTC (rev 205137)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt 2016-08-29 19:55:11 UTC (rev 205138)
</span><span class="lines">@@ -21,7 +21,7 @@
</span><span class="cx"> PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (MouseEvent).
</span><span class="cx"> PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (MouseEvents).
</span><span class="cx"> FAIL If the event's initialized flag is not set, an InvalidStateError must be thrown (PageTransitionEvent). The operation is not supported.
</span><del>-FAIL If the event's initialized flag is not set, an InvalidStateError must be thrown (PopStateEvent). The operation is not supported.
</del><ins>+PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (PopStateEvent).
</ins><span class="cx"> FAIL If the event's initialized flag is not set, an InvalidStateError must be thrown (ProgressEvent). The operation is not supported.
</span><span class="cx"> PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (StorageEvent).
</span><span class="cx"> FAIL If the event's initialized flag is not set, an InvalidStateError must be thrown (SVGEvents). The operation is not supported.
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentcreateEventexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent-expected.txt (205137 => 205138)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent-expected.txt 2016-08-29 19:44:48 UTC (rev 205137)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent-expected.txt 2016-08-29 19:55:11 UTC (rev 205138)
</span><span class="lines">@@ -135,12 +135,12 @@
</span><span class="cx"> FAIL PAGETRANSITIONEVENT should be an alias for PageTransitionEvent. The operation is not supported.
</span><span class="cx"> FAIL createEvent('PAGETRANSITIONEVENT') should be initialized correctly. undefined is not an object (evaluating 'ev.type')
</span><span class="cx"> PASS Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "PageTransitionEvents"
</span><del>-FAIL PopStateEvent should be an alias for PopStateEvent. The operation is not supported.
-FAIL createEvent('PopStateEvent') should be initialized correctly. undefined is not an object (evaluating 'ev.type')
-FAIL popstateevent should be an alias for PopStateEvent. The operation is not supported.
-FAIL createEvent('popstateevent') should be initialized correctly. undefined is not an object (evaluating 'ev.type')
-FAIL POPSTATEEVENT should be an alias for PopStateEvent. The operation is not supported.
-FAIL createEvent('POPSTATEEVENT') should be initialized correctly. undefined is not an object (evaluating 'ev.type')
</del><ins>+PASS PopStateEvent should be an alias for PopStateEvent.
+PASS createEvent('PopStateEvent') should be initialized correctly.
+PASS popstateevent should be an alias for PopStateEvent.
+PASS createEvent('popstateevent') should be initialized correctly.
+PASS POPSTATEEVENT should be an alias for PopStateEvent.
+PASS createEvent('POPSTATEEVENT') should be initialized correctly.
</ins><span class="cx"> PASS Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "PopStateEvents"
</span><span class="cx"> FAIL ProgressEvent should be an alias for ProgressEvent. The operation is not supported.
</span><span class="cx"> FAIL createEvent('ProgressEvent') should be initialized correctly. undefined is not an object (evaluating 'ev.type')
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlbrowsersbrowsingthewebhistorytraversalPopStateEventexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/PopStateEvent-expected.txt (205137 => 205138)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/PopStateEvent-expected.txt 2016-08-29 19:44:48 UTC (rev 205137)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/PopStateEvent-expected.txt 2016-08-29 19:55:11 UTC (rev 205138)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx">
</span><del>-FAIL document.createEvent The operation is not supported.
</del><ins>+PASS document.createEvent
</ins><span class="cx"> PASS initPopStateEvent
</span><span class="cx"> PASS Dispatching a synthetic PopStateEvent
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (205137 => 205138)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-29 19:44:48 UTC (rev 205137)
+++ trunk/Source/WebCore/ChangeLog 2016-08-29 19:55:11 UTC (rev 205138)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2016-08-29 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ document.createEvent("popstateevent") should create a PopStateEvent
+ https://bugs.webkit.org/show_bug.cgi?id=161321
+
+ Reviewed by Darin Adler.
+
+ document.createEvent("popstateevent") should create a PopStateEvent as per:
+ - https://dom.spec.whatwg.org/#dom-document-createevent
+
+ Firefox and Chrome match the specification but WebKit throws an exception,
+ which is risky compatibility-wise.
+
+ No new tests, rebaselined existing tests.
+
+ * dom/Document.cpp:
+ (WebCore::Document::createEvent):
+ * dom/PopStateEvent.cpp:
+ (WebCore::PopStateEvent::createForBindings):
+ * dom/PopStateEvent.h:
+
+2016-08-29 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> We should throw a SecurityError when denying access to cross-origin Window properties
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=161316
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (205137 => 205138)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-08-29 19:44:48 UTC (rev 205137)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-08-29 19:55:11 UTC (rev 205138)
</span><span class="lines">@@ -4303,6 +4303,8 @@
</span><span class="cx"> return MouseEvent::createForBindings();
</span><span class="cx"> if (equalLettersIgnoringASCIICase(type, "uievent") || equalLettersIgnoringASCIICase(type, "uievents"))
</span><span class="cx"> return UIEvent::createForBindings();
</span><ins>+ if (equalLettersIgnoringASCIICase(type, "popstateevent"))
+ return PopStateEvent::createForBindings();
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(TOUCH_EVENTS)
</span><span class="cx"> if (equalLettersIgnoringASCIICase(type, "touchevent"))
</span></span></pre></div>
<a id="trunkSourceWebCoredomPopStateEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/PopStateEvent.cpp (205137 => 205138)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/PopStateEvent.cpp 2016-08-29 19:44:48 UTC (rev 205137)
+++ trunk/Source/WebCore/dom/PopStateEvent.cpp 2016-08-29 19:55:11 UTC (rev 205138)
</span><span class="lines">@@ -60,6 +60,11 @@
</span><span class="cx"> return adoptRef(*new PopStateEvent(type, initializer));
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+Ref<PopStateEvent> PopStateEvent::createForBindings()
+{
+ return adoptRef(*new PopStateEvent);
+}
+
</ins><span class="cx"> RefPtr<SerializedScriptValue> PopStateEvent::trySerializeState(JSC::ExecState* exec)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!m_state.hasNoValue());
</span></span></pre></div>
<a id="trunkSourceWebCoredomPopStateEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/PopStateEvent.h (205137 => 205138)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/PopStateEvent.h 2016-08-29 19:44:48 UTC (rev 205137)
+++ trunk/Source/WebCore/dom/PopStateEvent.h 2016-08-29 19:55:11 UTC (rev 205138)
</span><span class="lines">@@ -43,6 +43,7 @@
</span><span class="cx"> virtual ~PopStateEvent();
</span><span class="cx"> static Ref<PopStateEvent> create(RefPtr<SerializedScriptValue>&&, PassRefPtr<History>);
</span><span class="cx"> static Ref<PopStateEvent> createForBindings(const AtomicString&, const PopStateEventInit&);
</span><ins>+ static Ref<PopStateEvent> createForBindings();
</ins><span class="cx">
</span><span class="cx"> JSC::JSValue state() const { return m_state; }
</span><span class="cx"> SerializedScriptValue* serializedState() const { return m_serializedState.get(); }
</span><span class="lines">@@ -54,6 +55,7 @@
</span><span class="cx"> EventInterface eventInterface() const override;
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ PopStateEvent() = default;
</ins><span class="cx"> PopStateEvent(const AtomicString&, const PopStateEventInit&);
</span><span class="cx"> explicit PopStateEvent(PassRefPtr<SerializedScriptValue>, PassRefPtr<History>);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>