<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205106] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205106">205106</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2016-08-28 15:38:41 -0700 (Sun, 28 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>document.title setter can't throw.
<https://webkit.org/b/161302>
Reviewed by Antti Koivisto.
Source/WebCore:
Remove [SetterRaisesException] from document.title and replace
ExceptionCode propagation with ASSERT_NO_EXCEPTION.
Setting the .textContent of a SVGTitleElement or HTMLTitleElement
will never fail, so there's no exception to propagate.
* dom/Document.cpp:
(WebCore::Document::setTitle):
* dom/Document.h:
* dom/Document.idl:
* html/ImageDocument.cpp:
(WebCore::ImageDocument::finishedParsing):
Source/WebKit/mac:
* DOM/DOMDocument.mm:
(-[DOMDocument setTitle:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumentidl">trunk/Source/WebCore/dom/Document.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlImageDocumentcpp">trunk/Source/WebCore/html/ImageDocument.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacDOMDOMDocumentmm">trunk/Source/WebKit/mac/DOM/DOMDocument.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (205105 => 205106)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-28 17:36:05 UTC (rev 205105)
+++ trunk/Source/WebCore/ChangeLog 2016-08-28 22:38:41 UTC (rev 205106)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-08-28 Andreas Kling <akling@apple.com>
+
+ document.title setter can't throw.
+ <https://webkit.org/b/161302>
+
+ Reviewed by Antti Koivisto.
+
+ Remove [SetterRaisesException] from document.title and replace
+ ExceptionCode propagation with ASSERT_NO_EXCEPTION.
+
+ Setting the .textContent of a SVGTitleElement or HTMLTitleElement
+ will never fail, so there's no exception to propagate.
+
+ * dom/Document.cpp:
+ (WebCore::Document::setTitle):
+ * dom/Document.h:
+ * dom/Document.idl:
+ * html/ImageDocument.cpp:
+ (WebCore::ImageDocument::finishedParsing):
+
</ins><span class="cx"> 2016-08-23 Frederic Wang <fwang@igalia.com>
</span><span class="cx">
</span><span class="cx"> MathML renderers should use struct to pass long list of LayoutUnits
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (205105 => 205106)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-08-28 17:36:05 UTC (rev 205105)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-08-28 22:38:41 UTC (rev 205106)
</span><span class="lines">@@ -1631,7 +1631,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Document::setTitle(const String& title, ExceptionCode& ec)
</del><ins>+void Document::setTitle(const String& title)
</ins><span class="cx"> {
</span><span class="cx"> if (!m_titleElement) {
</span><span class="cx"> if (isHTMLDocument() || isXHTMLDocument()) {
</span><span class="lines">@@ -1654,9 +1654,9 @@
</span><span class="cx"> updateTitle(StringWithDirection(title, LTR));
</span><span class="cx">
</span><span class="cx"> if (is<HTMLTitleElement>(m_titleElement.get()))
</span><del>- downcast<HTMLTitleElement>(*m_titleElement).setTextContent(title, ec);
</del><ins>+ downcast<HTMLTitleElement>(*m_titleElement).setTextContent(title, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> else if (is<SVGTitleElement>(m_titleElement.get()))
</span><del>- downcast<SVGTitleElement>(*m_titleElement).setTextContent(title, ec);
</del><ins>+ downcast<SVGTitleElement>(*m_titleElement).setTextContent(title, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Document::updateTitleElement(Element* newTitleElement)
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (205105 => 205106)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2016-08-28 17:36:05 UTC (rev 205105)
+++ trunk/Source/WebCore/dom/Document.h 2016-08-28 22:38:41 UTC (rev 205106)
</span><span class="lines">@@ -857,7 +857,7 @@
</span><span class="cx">
</span><span class="cx"> // Used by DOM bindings; no direction known.
</span><span class="cx"> String title() const { return m_title.string(); }
</span><del>- WEBCORE_EXPORT void setTitle(const String&, ExceptionCode&);
</del><ins>+ WEBCORE_EXPORT void setTitle(const String&);
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT const AtomicString& dir() const;
</span><span class="cx"> WEBCORE_EXPORT void setDir(const AtomicString&);
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.idl (205105 => 205106)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.idl 2016-08-28 17:36:05 UTC (rev 205105)
+++ trunk/Source/WebCore/dom/Document.idl 2016-08-28 22:38:41 UTC (rev 205106)
</span><span class="lines">@@ -115,7 +115,7 @@
</span><span class="cx"> boolean queryCommandSupported(DOMString command);
</span><span class="cx"> DOMString queryCommandValue(DOMString command);
</span><span class="cx">
</span><del>- [SetterRaisesException] attribute DOMString title;
</del><ins>+ attribute DOMString title;
</ins><span class="cx"> attribute DOMString dir;
</span><span class="cx"> attribute DOMString designMode;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageDocument.cpp (205105 => 205106)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageDocument.cpp 2016-08-28 17:36:05 UTC (rev 205105)
+++ trunk/Source/WebCore/html/ImageDocument.cpp 2016-08-28 22:38:41 UTC (rev 205106)
</span><span class="lines">@@ -164,7 +164,7 @@
</span><span class="cx"> String name = decodeURLEscapeSequences(url().lastPathComponent());
</span><span class="cx"> if (name.isEmpty())
</span><span class="cx"> name = url().host();
</span><del>- setTitle(imageTitle(name, size), IGNORE_EXCEPTION);
</del><ins>+ setTitle(imageTitle(name, size));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> imageUpdated();
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (205105 => 205106)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-08-28 17:36:05 UTC (rev 205105)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-08-28 22:38:41 UTC (rev 205106)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2016-08-28 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><ins>+ document.title setter can't throw.
+ <https://webkit.org/b/161302>
+
+ Reviewed by Antti Koivisto.
+
+ * DOM/DOMDocument.mm:
+ (-[DOMDocument setTitle:]):
+
+2016-08-28 Andreas Kling <akling@apple.com>
+
</ins><span class="cx"> Clean up some .text attribute setters that don't throw.
</span><span class="cx"> <https://webkit.org/b/161292>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacDOMDOMDocumentmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/DOM/DOMDocument.mm (205105 => 205106)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/DOM/DOMDocument.mm 2016-08-28 17:36:05 UTC (rev 205105)
+++ trunk/Source/WebKit/mac/DOM/DOMDocument.mm 2016-08-28 22:38:41 UTC (rev 205106)
</span><span class="lines">@@ -191,9 +191,7 @@
</span><span class="cx"> - (void)setTitle:(NSString *)newTitle
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- WebCore::ExceptionCode ec = 0;
- IMPL->setTitle(newTitle, ec);
- raiseOnDOMError(ec);
</del><ins>+ IMPL->setTitle(newTitle);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (NSString *)dir
</span></span></pre>
</div>
</div>
</body>
</html>