<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[205104] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/205104">205104</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2016-08-28 09:54:43 -0700 (Sun, 28 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up some .text attribute setters that don't throw.
<https://webkit.org/b/161292>
Reviewed by Darin Adler.
Source/WebCore:
Remove [SetterRaisesException] for three .text attributes
and replace them with ASSERT_NO_EXCEPTION.
These setters behave like .textContent, which can't throw as
it's always okay to replace an Element's children with a Text.
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setText):
* html/HTMLAnchorElement.h:
* html/HTMLAnchorElement.idl:
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setText):
* html/HTMLOptionElement.h:
* html/HTMLOptionElement.idl:
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
* html/HTMLTitleElement.h:
* html/HTMLTitleElement.idl:
Source/WebKit/mac:
* DOM/DOMHTMLTitleElement.mm:
(-[DOMHTMLTitleElement setText:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedcpp">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedh">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedsymbols">trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectwebkitdomsymbols">trunk/Source/WebCore/bindings/gobject/webkitdom.symbols</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementcpp">trunk/Source/WebCore/html/HTMLAnchorElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementh">trunk/Source/WebCore/html/HTMLAnchorElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLAnchorElementidl">trunk/Source/WebCore/html/HTMLAnchorElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionElementcpp">trunk/Source/WebCore/html/HTMLOptionElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionElementh">trunk/Source/WebCore/html/HTMLOptionElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionElementidl">trunk/Source/WebCore/html/HTMLOptionElement.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTitleElementcpp">trunk/Source/WebCore/html/HTMLTitleElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTitleElementh">trunk/Source/WebCore/html/HTMLTitleElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTitleElementidl">trunk/Source/WebCore/html/HTMLTitleElement.idl</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacDOMDOMHTMLTitleElementmm">trunk/Source/WebKit/mac/DOM/DOMHTMLTitleElement.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/ChangeLog 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-08-28 Andreas Kling <akling@apple.com>
+
+ Clean up some .text attribute setters that don't throw.
+ <https://webkit.org/b/161292>
+
+ Reviewed by Darin Adler.
+
+ Remove [SetterRaisesException] for three .text attributes
+ and replace them with ASSERT_NO_EXCEPTION.
+
+ These setters behave like .textContent, which can't throw as
+ it's always okay to replace an Element's children with a Text.
+
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::setText):
+ * html/HTMLAnchorElement.h:
+ * html/HTMLAnchorElement.idl:
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::setText):
+ * html/HTMLOptionElement.h:
+ * html/HTMLOptionElement.idl:
+ * html/HTMLTitleElement.cpp:
+ (WebCore::HTMLTitleElement::setText):
+ * html/HTMLTitleElement.h:
+ * html/HTMLTitleElement.idl:
+
</ins><span class="cx"> 2016-08-24 Dave Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> Initial landing of CSS Parser Tokenization (and files to support that). Not used yet.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -142,16 +142,6 @@
</span><span class="cx"> return webkit_dom_node_clone_node_with_error(self, deep, nullptr);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void webkit_dom_document_set_title(WebKitDOMDocument* self, const gchar* title)
-{
- webkit_dom_document_set_title_with_error(self, title, nullptr);
-}
-
-void webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement* self, const gchar* text)
-{
- webkit_dom_html_title_element_set_text_with_error(self, text, nullptr);
-}
-
</del><span class="cx"> gchar* webkit_dom_document_get_default_charset(WebKitDOMDocument* self)
</span><span class="cx"> {
</span><span class="cx"> g_return_val_if_fail(WEBKIT_DOM_IS_DOCUMENT(self), nullptr);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -171,27 +171,8 @@
</span><span class="cx"> WEBKIT_DEPRECATED_FOR(webkit_dom_node_clone_node_with_error) WebKitDOMNode*
</span><span class="cx"> webkit_dom_node_clone_node(WebKitDOMNode* self, gboolean deep, GError** error);
</span><span class="cx">
</span><del>-/**
- * webkit_dom_document_set_title:
- * @self: A #WebKitDOMDocument
- * @title: A #gchar
- *
- * Deprecated: 2.14: Use webkit_dom_document_set_title_with_error() instead.
- */
-WEBKIT_DEPRECATED_FOR(webkit_dom_document_set_title_with_error) void
-webkit_dom_document_set_title(WebKitDOMDocument* self, const gchar* title);
</del><span class="cx">
</span><span class="cx"> /**
</span><del>- * webkit_dom_html_title_element_set_text:
- * @self: A #WebKitDOMHTMLTitleElement
- * @text: A #gchar
- *
- * Deprecated: 2.14: Use webkit_dom_html_title_element_set_text_with_error() instead.
- */
-WEBKIT_DEPRECATED_FOR(webkit_dom_html_title_element_set_text_with_error) void
-webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement* self, const gchar* text);
-
-/**
</del><span class="cx"> * webkit_dom_document_get_default_charset:
</span><span class="cx"> * @self: A #WebKitDOMDocument
</span><span class="cx"> *
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMDeprecatedsymbols"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -21,8 +21,6 @@
</span><span class="cx"> void webkit_dom_html_base_font_element_set_face(WebKitDOMHTMLBaseFontElement*, const gchar*)
</span><span class="cx"> void webkit_dom_html_base_font_element_set_size(WebKitDOMHTMLBaseFontElement*, glong)
</span><span class="cx"> WebKitDOMNode* webkit_dom_node_clone_node(WebKitDOMNode*, gboolean)
</span><del>-void webkit_dom_document_set_title(WebKitDOMDocument*, const gchar*)
-void webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement*, const gchar*)
</del><span class="cx"> gchar* webkit_dom_document_get_default_charset(WebKitDOMDocument*)
</span><span class="cx"> WebKitDOMText* webkit_dom_text_replace_whole_text(WebKitDOMText*, const gchar*, GError**)
</span><span class="cx"> gboolean webkit_dom_html_input_element_get_capture(WebKitDOMHTMLInputElement*)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectwebkitdomsymbols"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/webkitdom.symbols (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -37,7 +37,6 @@
</span><span class="cx"> WebKitDOMHTMLCollection* webkit_dom_document_get_images(WebKitDOMDocument*)
</span><span class="cx"> gchar* webkit_dom_document_get_title(WebKitDOMDocument*)
</span><span class="cx"> void webkit_dom_document_set_title(WebKitDOMDocument*, const gchar*)
</span><del>-void webkit_dom_document_set_title_with_error(WebKitDOMDocument*, const gchar*, GError**)@2.14
</del><span class="cx"> gchar* webkit_dom_document_get_charset(WebKitDOMDocument*)
</span><span class="cx"> void webkit_dom_document_set_charset(WebKitDOMDocument*, const gchar*)
</span><span class="cx"> gchar* webkit_dom_document_get_default_charset(WebKitDOMDocument*)
</span><span class="lines">@@ -964,7 +963,6 @@
</span><span class="cx"> GType webkit_dom_html_title_element_get_type(void)
</span><span class="cx"> gchar* webkit_dom_html_title_element_get_text(WebKitDOMHTMLTitleElement*)
</span><span class="cx"> void webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement*, const gchar*)
</span><del>-void webkit_dom_html_title_element_set_text_with_error(WebKitDOMHTMLTitleElement*, const gchar*, GError**)@2.14
</del><span class="cx"> GType webkit_dom_html_u_list_element_get_type(void)
</span><span class="cx"> gchar* webkit_dom_html_u_list_element_get_type_attr(WebKitDOMHTMLUListElement*)
</span><span class="cx"> void webkit_dom_html_u_list_element_set_type_attr(WebKitDOMHTMLUListElement*, const gchar*)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorGObjectpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -1057,9 +1057,7 @@
</span><span class="cx"> sub FunctionUsedToNotRaiseException {
</span><span class="cx"> my $functionName = shift;
</span><span class="cx">
</span><del>- return $functionName eq "webkit_dom_document_set_title"
- || $functionName eq "webkit_dom_html_title_element_set_text"
- || $functionName eq "webkit_dom_node_clone_node";
</del><ins>+ return $functionName eq "webkit_dom_node_clone_node";
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub GenerateFunction {
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAnchorElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -332,9 +332,9 @@
</span><span class="cx"> return textContent();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLAnchorElement::setText(const String& text, ExceptionCode& ec)
</del><ins>+void HTMLAnchorElement::setText(const String& text)
</ins><span class="cx"> {
</span><del>- setTextContent(text, ec);
</del><ins>+ setTextContent(text, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool HTMLAnchorElement::isLiveLink() const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAnchorElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAnchorElement.h (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAnchorElement.h 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.h 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx"> WEBCORE_EXPORT String origin() const;
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT String text();
</span><del>- void setText(const String&, ExceptionCode&);
</del><ins>+ void setText(const String&);
</ins><span class="cx">
</span><span class="cx"> bool isLiveLink() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLAnchorElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLAnchorElement.idl (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLAnchorElement.idl 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.idl 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> [Reflect] attribute DOMString target;
</span><span class="cx"> [Reflect] attribute DOMString type;
</span><span class="cx">
</span><del>- [SetterRaisesException] attribute DOMString text;
</del><ins>+ attribute DOMString text;
</ins><span class="cx">
</span><span class="cx"> [PutForwards=value] readonly attribute DOMTokenList relList;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionElement.cpp (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionElement.cpp 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/html/HTMLOptionElement.cpp 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> return document().displayStringModifiedByEncoding(text).stripWhiteSpace(isHTMLSpace).simplifyWhiteSpace(isHTMLSpace);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLOptionElement::setText(const String &text, ExceptionCode& ec)
</del><ins>+void HTMLOptionElement::setText(const String &text)
</ins><span class="cx"> {
</span><span class="cx"> Ref<HTMLOptionElement> protectedThis(*this);
</span><span class="cx">
</span><span class="lines">@@ -127,7 +127,7 @@
</span><span class="cx"> downcast<Text>(*child).setData(text);
</span><span class="cx"> else {
</span><span class="cx"> removeChildren();
</span><del>- appendChild(Text::create(document(), text), ec);
</del><ins>+ appendChild(Text::create(document(), text), ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (selectIsMenuList && select->selectedIndex() != oldSelectedIndex)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionElement.h (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionElement.h 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/html/HTMLOptionElement.h 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> bool defaultSelected, bool selected, ExceptionCode&);
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT String text() const;
</span><del>- void setText(const String&, ExceptionCode&);
</del><ins>+ void setText(const String&);
</ins><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT int index() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionElement.idl (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionElement.idl 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/html/HTMLOptionElement.idl 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> attribute DOMString value;
</span><span class="cx">
</span><span class="cx"> #if !(defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT)
</span><del>- [SetterRaisesException] attribute DOMString text;
</del><ins>+ attribute DOMString text;
</ins><span class="cx"> #else
</span><span class="cx"> readonly attribute DOMString text;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTitleElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTitleElement.cpp (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTitleElement.cpp 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/html/HTMLTitleElement.cpp 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -92,9 +92,9 @@
</span><span class="cx"> return StringWithDirection(text(), direction);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLTitleElement::setText(const String& value, ExceptionCode& ec)
</del><ins>+void HTMLTitleElement::setText(const String& value)
</ins><span class="cx"> {
</span><del>- setTextContent(value, ec);
</del><ins>+ setTextContent(value, ASSERT_NO_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTitleElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTitleElement.h (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTitleElement.h 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/html/HTMLTitleElement.h 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> static Ref<HTMLTitleElement> create(const QualifiedName&, Document&);
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT String text() const;
</span><del>- WEBCORE_EXPORT void setText(const String&, ExceptionCode&);
</del><ins>+ WEBCORE_EXPORT void setText(const String&);
</ins><span class="cx">
</span><span class="cx"> const StringWithDirection& textWithDirection() const { return m_title; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTitleElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTitleElement.idl (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTitleElement.idl 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebCore/html/HTMLTitleElement.idl 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -18,6 +18,6 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> interface HTMLTitleElement : HTMLElement {
</span><del>- [SetterRaisesException] attribute DOMString text;
</del><ins>+ attribute DOMString text;
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-08-28 Andreas Kling <akling@apple.com>
+
+ Clean up some .text attribute setters that don't throw.
+ <https://webkit.org/b/161292>
+
+ Reviewed by Darin Adler.
+
+ * DOM/DOMHTMLTitleElement.mm:
+ (-[DOMHTMLTitleElement setText:]):
+
</ins><span class="cx"> 2016-08-26 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove support for ENABLE_LEGACY_WEB_AUDIO
</span></span></pre></div>
<a id="trunkSourceWebKitmacDOMDOMHTMLTitleElementmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/DOM/DOMHTMLTitleElement.mm (205103 => 205104)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/DOM/DOMHTMLTitleElement.mm 2016-08-28 15:46:11 UTC (rev 205103)
+++ trunk/Source/WebKit/mac/DOM/DOMHTMLTitleElement.mm 2016-08-28 16:54:43 UTC (rev 205104)
</span><span class="lines">@@ -47,9 +47,7 @@
</span><span class="cx"> - (void)setText:(NSString *)newText
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- WebCore::ExceptionCode ec = 0;
- IMPL->setText(newText, ec);
- raiseOnDOMError(ec);
</del><ins>+ IMPL->setText(newText);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> @end
</span></span></pre>
</div>
</div>
</body>
</html>