<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204936] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204936">204936</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-08-24 14:58:33 -0700 (Wed, 24 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Assertion hit: ASSERT(!m_parserScheduler) in ~HTMLDocumentParser()
https://bugs.webkit.org/show_bug.cgi?id=161083
<rdar://problem/27986937>
Reviewed by Darin Adler.
Source/WebCore:
Call cancelParsing() right before re-creating the new parser in
Document::implicitOpen(). We would previously call removeChildren()
in between which is was an issue because it can cause JS to be
executed and therefore the parser to be re-created after we have
cancelled parsing.
No new tests, unskipped html/browsers/browsing-the-web/unloading-documents/004.html
which was consistently crashing.
* dom/Document.cpp:
(WebCore::Document::implicitOpen):
LayoutTests:
Unskip html/browsers/browsing-the-web/unloading-documents/004.html as
it is no longer crashing.
* TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204935 => 204936)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-08-24 21:55:27 UTC (rev 204935)
+++ trunk/LayoutTests/ChangeLog        2016-08-24 21:58:33 UTC (rev 204936)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-08-24 Chris Dumez <cdumez@apple.com>
+
+ Assertion hit: ASSERT(!m_parserScheduler) in ~HTMLDocumentParser()
+ https://bugs.webkit.org/show_bug.cgi?id=161083
+ <rdar://problem/27986937>
+
+ Reviewed by Darin Adler.
+
+ Unskip html/browsers/browsing-the-web/unloading-documents/004.html as
+ it is no longer crashing.
+
+ * TestExpectations:
+
</ins><span class="cx"> 2016-08-24 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] Add support for OverConstrained Error
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (204935 => 204936)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations        2016-08-24 21:55:27 UTC (rev 204935)
+++ trunk/LayoutTests/TestExpectations        2016-08-24 21:58:33 UTC (rev 204936)
</span><span class="lines">@@ -237,8 +237,6 @@
</span><span class="cx"> # Promises/A+ 2.3.3 has many tests and it sometimes exceeds the time limit.
</span><span class="cx"> webkit.org/b/136878 js/promises-tests/promises-tests-2-3-3.html [ Slow ]
</span><span class="cx">
</span><del>-webkit.org/b/161083 [ Debug ] imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html [ Crash ]
-
</del><span class="cx"> # Resource files not in resources folder
</span><span class="cx"> imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-sync-block-defer-scripts-subframe.html [ Skip ]
</span><span class="cx"> imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-sync-not-hang-scriptloader-subframe.html [ Skip ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204935 => 204936)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2016-08-24 21:55:27 UTC (rev 204935)
+++ trunk/Source/WebCore/ChangeLog        2016-08-24 21:58:33 UTC (rev 204936)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-08-24 Chris Dumez <cdumez@apple.com>
+
+ Assertion hit: ASSERT(!m_parserScheduler) in ~HTMLDocumentParser()
+ https://bugs.webkit.org/show_bug.cgi?id=161083
+ <rdar://problem/27986937>
+
+ Reviewed by Darin Adler.
+
+ Call cancelParsing() right before re-creating the new parser in
+ Document::implicitOpen(). We would previously call removeChildren()
+ in between which is was an issue because it can cause JS to be
+ executed and therefore the parser to be re-created after we have
+ cancelled parsing.
+
+ No new tests, unskipped html/browsers/browsing-the-web/unloading-documents/004.html
+ which was consistently crashing.
+
+ * dom/Document.cpp:
+ (WebCore::Document::implicitOpen):
+
</ins><span class="cx"> 2016-08-24 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] Add support for OverConstrained Error
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (204935 => 204936)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp        2016-08-24 21:55:27 UTC (rev 204935)
+++ trunk/Source/WebCore/dom/Document.cpp        2016-08-24 21:58:33 UTC (rev 204936)
</span><span class="lines">@@ -2613,12 +2613,11 @@
</span><span class="cx">
</span><span class="cx"> void Document::implicitOpen()
</span><span class="cx"> {
</span><del>- cancelParsing();
-
</del><span class="cx"> removeChildren();
</span><span class="cx">
</span><span class="cx"> setCompatibilityMode(DocumentCompatibilityMode::NoQuirksMode);
</span><span class="cx">
</span><ins>+ cancelParsing();
</ins><span class="cx"> m_parser = createParser();
</span><span class="cx"> setParsing(true);
</span><span class="cx"> setReadyState(Loading);
</span></span></pre>
</div>
</div>
</body>
</html>