<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204846] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204846">204846</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-23 12:00:49 -0700 (Tue, 23 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: No open/copy src resource in context menu
https://bugs.webkit.org/show_bug.cgi?id=159028
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-08-23
Reviewed by Joseph Pecoraro.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
Add options in the context menu of link attributes of DOM nodes to
- Open in New Tab
- Reveal in Resources Tab
- Copy Link Address</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (204845 => 204846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2016-08-23 18:56:57 UTC (rev 204845)
+++ trunk/Source/WebInspectorUI/ChangeLog        2016-08-23 19:00:49 UTC (rev 204846)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2016-08-23 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: No open/copy src resource in context menu
+ https://bugs.webkit.org/show_bug.cgi?id=159028
+
+ Reviewed by Joseph Pecoraro.
+
+ * Localizations/en.lproj/localizedStrings.js:
+
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
+ Add options in the context menu of link attributes of DOM nodes to
+ - Open in New Tab
+ - Reveal in Resources Tab
+ - Copy Link Address
+
+2016-08-23 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Add visual editor for spring() timing-function
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=159315
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (204845 => 204846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2016-08-23 18:56:57 UTC (rev 204845)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2016-08-23 19:00:49 UTC (rev 204846)
</span><span class="lines">@@ -197,6 +197,7 @@
</span><span class="cx"> localizedStrings["Continue to Here"] = "Continue to Here";
</span><span class="cx"> localizedStrings["Controls"] = "Controls";
</span><span class="cx"> localizedStrings["Cookies"] = "Cookies";
</span><ins>+localizedStrings["Copy Link Address"] = "Copy Link Address";
</ins><span class="cx"> localizedStrings["Copy Path to Property"] = "Copy Path to Property";
</span><span class="cx"> localizedStrings["Copy Row"] = "Copy Row";
</span><span class="cx"> localizedStrings["Copy Rule"] = "Copy Rule";
</span><span class="lines">@@ -516,6 +517,7 @@
</span><span class="cx"> localizedStrings["Only show resources with issues"] = "Only show resources with issues";
</span><span class="cx"> localizedStrings["Opacity"] = "Opacity";
</span><span class="cx"> localizedStrings["Open"] = "Open";
</span><ins>+localizedStrings["Open in New Tab"] = "Open in New Tab";
</ins><span class="cx"> localizedStrings["Option-click to show all units"] = "Option-click to show all units";
</span><span class="cx"> localizedStrings["Option-click to show all values"] = "Option-click to show all values";
</span><span class="cx"> localizedStrings["Option-click to show source"] = "Option-click to show source";
</span><span class="lines">@@ -606,6 +608,7 @@
</span><span class="cx"> localizedStrings["Reveal in DOM Tree"] = "Reveal in DOM Tree";
</span><span class="cx"> localizedStrings["Reveal in Debugger Tab"] = "Reveal in Debugger Tab";
</span><span class="cx"> localizedStrings["Reveal in Original Resource"] = "Reveal in Original Resource";
</span><ins>+localizedStrings["Reveal in Resources Tab"] = "Reveal in Resources Tab";
</ins><span class="cx"> localizedStrings["Right"] = "Right";
</span><span class="cx"> localizedStrings["Role"] = "Role";
</span><span class="cx"> localizedStrings["Rule"] = "Rule";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (204845 => 204846)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js        2016-08-23 18:56:57 UTC (rev 204845)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js        2016-08-23 19:00:49 UTC (rev 204846)
</span><span class="lines">@@ -643,10 +643,33 @@
</span><span class="cx">
</span><span class="cx"> _populateTagContextMenu(contextMenu, event)
</span><span class="cx"> {
</span><del>- var node = this.representedObject;
</del><ins>+ let node = this.representedObject;
</ins><span class="cx"> if (!node.isInUserAgentShadowTree()) {
</span><del>- var attribute = event.target.enclosingNodeOrSelfWithClass("html-attribute");
</del><ins>+ let attribute = event.target.enclosingNodeOrSelfWithClass("html-attribute");
</ins><span class="cx">
</span><ins>+ if (event.target && event.target.tagName === "A") {
+ let url = event.target.href;
+
+ contextMenu.appendItem(WebInspector.UIString("Open in New Tab"), () => {
+ const frame = null;
+ const alwaysOpenExternally = true;
+ WebInspector.openURL(url, frame, alwaysOpenExternally);
+ });
+
+ if (WebInspector.frameResourceManager.resourceForURL(url)) {
+ contextMenu.appendItem(WebInspector.UIString("Reveal in Resources Tab"), () => {
+ let frame = WebInspector.frameResourceManager.frameForIdentifier(node.frameIdentifier);
+ WebInspector.openURL(url, frame);
+ });
+ }
+
+ contextMenu.appendItem(WebInspector.UIString("Copy Link Address"), () => {
+ InspectorFrontendHost.copyText(url);
+ });
+
+ contextMenu.appendSeparator();
+ }
+
</ins><span class="cx"> // Add attribute-related actions.
</span><span class="cx"> if (this.editable) {
</span><span class="cx"> contextMenu.appendItem(WebInspector.UIString("Add Attribute"), this._addNewAttribute.bind(this));
</span><span class="lines">@@ -656,7 +679,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (WebInspector.cssStyleManager.canForcePseudoClasses()) {
</span><del>- var pseudoSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Forced Pseudo-Classes"));
</del><ins>+ let pseudoSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Forced Pseudo-Classes"));
</ins><span class="cx"> this._populateForcedPseudoStateItems(pseudoSubMenu);
</span><span class="cx"> contextMenu.appendSeparator();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>