<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204872] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204872">204872</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-23 17:30:22 -0700 (Tue, 23 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION: SVG clip-path doesn't work on root <svg>
https://bugs.webkit.org/show_bug.cgi?id=129180
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-08-23
Reviewed by Tim Horton.
Source/WebCore:
Build the resources cache for the RenderSVGRoot element when it's been
inserted in the render tree. Remove the resources cache before removing
the RenderSVGRoot from the render tree. No worries for the child <svg>
elements since their renderers are of type RenderSVGViewportContainer.
Tests: svg/clip-path/clip-path-on-svg-003.svg
svg/clip-path/clip-path-on-svg-004.svg
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::insertedIntoTree):
(WebCore::RenderSVGRoot::willBeRemovedFromTree):
* rendering/svg/RenderSVGRoot.h:
These changes are very similar to what we do for adding and removing the
child SVG elements in RenderSVGRoot::addChild() and removeChild().
LayoutTests:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
* svg/clip-path/clip-path-on-svg-003-expected.svg: Added.
* svg/clip-path/clip-path-on-svg-003.svg: Added.
* svg/clip-path/clip-path-on-svg-004-expected.svg: Added.
* svg/clip-path/clip-path-on-svg-004.svg: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorTestExpectations">trunk/LayoutTests/platform/ios-simulator/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGRootcpp">trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGRooth">trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgclippathclippathonsvg003expectedsvg">trunk/LayoutTests/svg/clip-path/clip-path-on-svg-003-expected.svg</a></li>
<li><a href="#trunkLayoutTestssvgclippathclippathonsvg003svg">trunk/LayoutTests/svg/clip-path/clip-path-on-svg-003.svg</a></li>
<li><a href="#trunkLayoutTestssvgclippathclippathonsvg004expectedsvg">trunk/LayoutTests/svg/clip-path/clip-path-on-svg-004-expected.svg</a></li>
<li><a href="#trunkLayoutTestssvgclippathclippathonsvg004svg">trunk/LayoutTests/svg/clip-path/clip-path-on-svg-004.svg</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204871 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-24 00:24:34 UTC (rev 204871)
+++ trunk/LayoutTests/ChangeLog 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-08-23 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ REGRESSION: SVG clip-path doesn't work on root <svg>
+ https://bugs.webkit.org/show_bug.cgi?id=129180
+
+ Reviewed by Tim Horton.
+
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+ * platform/ios-simulator/TestExpectations:
+ * platform/mac/TestExpectations:
+ * platform/win/TestExpectations:
+ * svg/clip-path/clip-path-on-svg-003-expected.svg: Added.
+ * svg/clip-path/clip-path-on-svg-003.svg: Added.
+ * svg/clip-path/clip-path-on-svg-004-expected.svg: Added.
+ * svg/clip-path/clip-path-on-svg-004.svg: Added.
+
</ins><span class="cx"> 2016-08-23 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> HTMLAreaElement should have a stringifier
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (204871 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations 2016-08-24 00:24:34 UTC (rev 204871)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -949,10 +949,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/125573 compositing/backgrounds/fixed-backgrounds.html [ Crash Pass ]
</span><span class="cx">
</span><del>-# Regressions in svg/clip-path
-webkit.org/b/129180 svg/clip-path/clip-path-on-svg-001.svg [ ImageOnlyFailure Pass ]
-webkit.org/b/129180 svg/clip-path/clip-path-on-svg-002.svg [ ImageOnlyFailure Pass ]
-
</del><span class="cx"> webkit.org/b/119789 fast/events/touch/touch-inside-iframe.html [ Crash Pass ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/133305 fast/text/mark-matches-rendering.html [ ImageOnlyFailure Pass ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (204871 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-08-24 00:24:34 UTC (rev 204871)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -1274,8 +1274,6 @@
</span><span class="cx"> webkit.org/b/118665 fast/regions/webkit-flow-float-unable-to-push.html [ ImageOnlyFailure Pass ]
</span><span class="cx">
</span><span class="cx"> # Regressions in svg/clip-path
</span><del>-webkit.org/b/129180 svg/clip-path/clip-path-on-svg-001.svg [ ImageOnlyFailure Pass ]
-webkit.org/b/129180 svg/clip-path/clip-path-on-svg-002.svg [ ImageOnlyFailure Pass ]
</del><span class="cx"> webkit.org/b/115440 svg/stroke/animated-non-scaling-stroke.html [ ImageOnlyFailure Pass ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Pass Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (204871 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-08-24 00:24:34 UTC (rev 204871)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -1115,8 +1115,6 @@
</span><span class="cx"> svg/carto.net/tabgroup.svg [ Failure ]
</span><span class="cx"> svg/carto.net/textbox.svg [ Failure ]
</span><span class="cx"> svg/carto.net/window.svg [ Failure ]
</span><del>-svg/clip-path/clip-path-on-svg-001.svg [ ImageOnlyFailure ]
-svg/clip-path/clip-path-on-svg-002.svg [ ImageOnlyFailure ]
</del><span class="cx"> svg/css/composite-shadow-example.html [ Failure ]
</span><span class="cx"> svg/css/composite-shadow-with-opacity.html [ Failure ]
</span><span class="cx"> svg/css/css-box-min-width.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (204871 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2016-08-24 00:24:34 UTC (rev 204871)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -775,10 +775,6 @@
</span><span class="cx"> webkit.org/b/122040 animations/combo-transform-translate+scale.html [ Pass Failure ]
</span><span class="cx"> webkit.org/b/128379 animations/suspend-resume-animation.html [ Pass Failure ]
</span><span class="cx">
</span><del>-# Regressions in svg/clip-path
-webkit.org/b/129180 svg/clip-path/clip-path-on-svg-001.svg [ ImageOnlyFailure ]
-webkit.org/b/129180 svg/clip-path/clip-path-on-svg-002.svg [ ImageOnlyFailure ]
-
</del><span class="cx"> # Skipped for ios-simulator as well:
</span><span class="cx"> webkit.org/b/129758 js/dom/create-lots-of-workers.html [ Skip ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (204871 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2016-08-24 00:24:34 UTC (rev 204871)
+++ trunk/LayoutTests/platform/win/TestExpectations 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -1883,10 +1883,6 @@
</span><span class="cx"> svg/animations/animate-linear-discrete-additive.svg [ Pass Timeout ]
</span><span class="cx"> svg/custom/use-display-none.svg [ Pass Timeout ]
</span><span class="cx">
</span><del>-# Regressions in svg/clip-path
-webkit.org/b/129180 svg/clip-path/clip-path-on-svg-001.svg [ ImageOnlyFailure ]
-webkit.org/b/129180 svg/clip-path/clip-path-on-svg-002.svg [ ImageOnlyFailure ]
-
</del><span class="cx"> svg/clip-path/mask-objectboundingbox-content-clip.svg [ ImageOnlyFailure ]
</span><span class="cx"> svg/clip-path/mask-userspaceonuse-content-clip.svg [ ImageOnlyFailure ]
</span><span class="cx"> svg/custom/inline-svg-in-xhtml.xml [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestssvgclippathclippathonsvg003expectedsvg"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/clip-path/clip-path-on-svg-003-expected.svg (0 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/clip-path/clip-path-on-svg-003-expected.svg (rev 0)
+++ trunk/LayoutTests/svg/clip-path/clip-path-on-svg-003-expected.svg 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+<svg xmlns="http://www.w3.org/2000/svg">
+ <rect x="25" y="25" width="150" height="150" fill="green"/>
+</svg>
</ins></span></pre></div>
<a id="trunkLayoutTestssvgclippathclippathonsvg003svg"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/clip-path/clip-path-on-svg-003.svg (0 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/clip-path/clip-path-on-svg-003.svg (rev 0)
+++ trunk/LayoutTests/svg/clip-path/clip-path-on-svg-003.svg 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+<svg xmlns="http://www.w3.org/2000/svg" clip-path="url(#clip1)">
+ <clipPath id="clip2">
+ <rect x="25" y="25" width="150" height="150"/>
+ </clipPath>
+ <clipPath id="clip1">
+ <rect x="50" y="50" width="100" height="100"/>
+ </clipPath>
+ <rect width="200" height="200" fill="green"/>
+ <script>
+ var svg = document.documentElement;
+ svg.setAttribute('clip-path','url(#clip2)');
+ </script>
+</svg>
</ins></span></pre></div>
<a id="trunkLayoutTestssvgclippathclippathonsvg004expectedsvg"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/clip-path/clip-path-on-svg-004-expected.svg (0 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/clip-path/clip-path-on-svg-004-expected.svg (rev 0)
+++ trunk/LayoutTests/svg/clip-path/clip-path-on-svg-004-expected.svg 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+<svg xmlns="http://www.w3.org/2000/svg">
+ <rect x="25" y="25" width="150" height="150" fill="green"/>
+</svg>
</ins></span></pre></div>
<a id="trunkLayoutTestssvgclippathclippathonsvg004svg"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/clip-path/clip-path-on-svg-004.svg (0 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/clip-path/clip-path-on-svg-004.svg (rev 0)
+++ trunk/LayoutTests/svg/clip-path/clip-path-on-svg-004.svg 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+<svg xmlns="http://www.w3.org/2000/svg" clip-path="url(#clip1)">
+ <clipPath id="clip2">
+ <rect x="25" y="25" width="175" height="175"/>
+ </clipPath>
+ <clipPath id="clip1">
+ <rect width="175" height="175"/>
+ </clipPath>
+ <svg clip-path="url(#clip2)">
+ <rect width="200" height="200" fill="green"/>
+ </svg>
+</svg>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204871 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-24 00:24:34 UTC (rev 204871)
+++ trunk/Source/WebCore/ChangeLog 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-08-23 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ REGRESSION: SVG clip-path doesn't work on root <svg>
+ https://bugs.webkit.org/show_bug.cgi?id=129180
+
+ Reviewed by Tim Horton.
+
+ Build the resources cache for the RenderSVGRoot element when it's been
+ inserted in the render tree. Remove the resources cache before removing
+ the RenderSVGRoot from the render tree. No worries for the child <svg>
+ elements since their renderers are of type RenderSVGViewportContainer.
+
+ Tests: svg/clip-path/clip-path-on-svg-003.svg
+ svg/clip-path/clip-path-on-svg-004.svg
+
+ * rendering/svg/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::insertedIntoTree):
+ (WebCore::RenderSVGRoot::willBeRemovedFromTree):
+ * rendering/svg/RenderSVGRoot.h:
+ These changes are very similar to what we do for adding and removing the
+ child SVG elements in RenderSVGRoot::addChild() and removeChild().
+
</ins><span class="cx"> 2016-08-23 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> HTMLAreaElement should have a stringifier
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGRootcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (204871 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2016-08-24 00:24:34 UTC (rev 204871)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -298,6 +298,18 @@
</span><span class="cx"> RenderReplaced::willBeDestroyed();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void RenderSVGRoot::insertedIntoTree()
+{
+ RenderReplaced::insertedIntoTree();
+ SVGResourcesCache::clientWasAddedToTree(*this);
+}
+
+void RenderSVGRoot::willBeRemovedFromTree()
+{
+ SVGResourcesCache::clientWillBeRemovedFromTree(*this);
+ RenderReplaced::willBeRemovedFromTree();
+}
+
</ins><span class="cx"> void RenderSVGRoot::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
</span><span class="cx"> {
</span><span class="cx"> if (diff == StyleDifferenceLayout)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGRooth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h (204871 => 204872)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h 2016-08-24 00:24:34 UTC (rev 204871)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h 2016-08-24 00:30:22 UTC (rev 204872)
</span><span class="lines">@@ -78,6 +78,10 @@
</span><span class="cx"> void paintReplaced(PaintInfo&, const LayoutPoint&) override;
</span><span class="cx">
</span><span class="cx"> void willBeDestroyed() override;
</span><ins>+
+ void insertedIntoTree() override;
+ void willBeRemovedFromTree() override;
+
</ins><span class="cx"> void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
</span><span class="cx"> void addChild(RenderObject* child, RenderObject* beforeChild = 0) override;
</span><span class="cx"> void removeChild(RenderObject&) override;
</span></span></pre>
</div>
</div>
</body>
</html>