<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204724] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204724">204724</a></dd>
<dt>Author</dt> <dd>antti@apple.com</dd>
<dt>Date</dt> <dd>2016-08-22 10:19:29 -0700 (Mon, 22 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Can't style descendants in shadow tree using the :host pseudo class
https://bugs.webkit.org/show_bug.cgi?id=160754
Reviewed by Darin Adler.
Source/WebCore:
"The :host pseudo-class, when evaluated in the context of a shadow tree, matches the shadow tree’s shadow host."
Currently :host() works for styling the host element itself (:host(.foo) { ... }). It should also be usable
for styling elements in the shadow tree:
:host(.foo) div { ... }
Test: fast/shadow-dom/css-scoping-host-descendant.html
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchHostPseudoClass):
(WebCore::localContextForParent):
Move to shadow host if we are matching :host and are at the root of the shadow tree.
Set didMoveToShadowHost bit in the context.
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
Call the existing matchHostPseudoClass to do :host matching if didMoveToShadowHost bit has been set.
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
Disallow :host in the compiler (cases where it would match didn't reach the compiler before).
LayoutTests:
* fast/shadow-dom/css-scoping-host-descendant-expected.html: Added.
* fast/shadow-dom/css-scoping-host-descendant.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssSelectorCheckercpp">trunk/Source/WebCore/css/SelectorChecker.cpp</a></li>
<li><a href="#trunkSourceWebCorecssjitSelectorCompilercpp">trunk/Source/WebCore/cssjit/SelectorCompiler.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastshadowdomcssscopinghostdescendantexpectedhtml">trunk/LayoutTests/fast/shadow-dom/css-scoping-host-descendant-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastshadowdomcssscopinghostdescendanthtml">trunk/LayoutTests/fast/shadow-dom/css-scoping-host-descendant.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204723 => 204724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-22 16:40:49 UTC (rev 204723)
+++ trunk/LayoutTests/ChangeLog 2016-08-22 17:19:29 UTC (rev 204724)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-08-22 Antti Koivisto <antti@apple.com>
+
+ Can't style descendants in shadow tree using the :host pseudo class
+ https://bugs.webkit.org/show_bug.cgi?id=160754
+
+ Reviewed by Darin Adler.
+
+ * fast/shadow-dom/css-scoping-host-descendant-expected.html: Added.
+ * fast/shadow-dom/css-scoping-host-descendant.html: Added.
+
</ins><span class="cx"> 2016-08-22 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] <a ping> and <area ping> tests time out
</span></span></pre></div>
<a id="trunkLayoutTestsfastshadowdomcssscopinghostdescendantexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/shadow-dom/css-scoping-host-descendant-expected.html (0 => 204724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/shadow-dom/css-scoping-host-descendant-expected.html (rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/css-scoping-host-descendant-expected.html 2016-08-22 17:19:29 UTC (rev 204724)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <body>
+ <p>Test passes if you see a single 100px by 100px green box below.</p>
+ <div style="width: 100px; height: 100px; background: green;"></div>
+ </body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastshadowdomcssscopinghostdescendanthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/shadow-dom/css-scoping-host-descendant.html (0 => 204724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/shadow-dom/css-scoping-host-descendant.html (rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/css-scoping-host-descendant.html 2016-08-22 17:19:29 UTC (rev 204724)
</span><span class="lines">@@ -0,0 +1,65 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+my-host {
+ display: block;
+ width: 100px;
+ height: 25px;
+ background: red;
+}
+</style>
+</head>
+<body>
+<p>Test passes if you see a single 100px by 100px green box below.</p>
+<my-host id="t1"></my-host>
+<my-host id="t2" class="match"></my-host>
+<my-host id="t3" class="no-match"></my-host>
+<my-host id="t4" class="match"><div></div></my-host>
+
+<script>
+var host = document.querySelector('#t1');
+host.attachShadow({ mode: 'open' }).innerHTML = `
+ <style>
+ :host > div {
+ background-color: green; width: 100%; height: 100%;
+ }
+ </style>
+ <div></div>
+`;
+
+var host = document.querySelector('#t2');
+host.attachShadow({ mode: 'open' }).innerHTML = `
+ <style>
+ div { background-color: red; width: 100%; height: 100%; }
+ :host(.match) .descendant {
+ background-color: green;
+ }
+ </style>
+ <div><div class="descendant"></div></div>
+`;
+
+var host = document.querySelector('#t3');
+host.attachShadow({ mode: 'open' }).innerHTML = `
+ <style>
+ div { background-color: green; width: 100%; height: 100%; }
+ :host(.match) div {
+ background-color: red;
+ }
+ </style>
+ <div></div>
+`;
+
+var host = document.querySelector('#t4');
+host.attachShadow({ mode: 'open' }).innerHTML = `
+ <style>
+ :host(.match) ::slotted(div) {
+ background-color: green; width: 100%; height: 100%;
+ }
+ </style>
+ <slot></slot>
+`;
+
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204723 => 204724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-22 16:40:49 UTC (rev 204723)
+++ trunk/Source/WebCore/ChangeLog 2016-08-22 17:19:29 UTC (rev 204724)
</span><span class="lines">@@ -1,3 +1,36 @@
</span><ins>+2016-08-22 Antti Koivisto <antti@apple.com>
+
+ Can't style descendants in shadow tree using the :host pseudo class
+ https://bugs.webkit.org/show_bug.cgi?id=160754
+
+ Reviewed by Darin Adler.
+
+ "The :host pseudo-class, when evaluated in the context of a shadow tree, matches the shadow tree’s shadow host."
+
+ Currently :host() works for styling the host element itself (:host(.foo) { ... }). It should also be usable
+ for styling elements in the shadow tree:
+
+ :host(.foo) div { ... }
+
+ Test: fast/shadow-dom/css-scoping-host-descendant.html
+
+ * css/SelectorChecker.cpp:
+ (WebCore::SelectorChecker::matchHostPseudoClass):
+ (WebCore::localContextForParent):
+
+ Move to shadow host if we are matching :host and are at the root of the shadow tree.
+ Set didMoveToShadowHost bit in the context.
+
+ (WebCore::SelectorChecker::matchRecursively):
+ (WebCore::SelectorChecker::checkOne):
+
+ Call the existing matchHostPseudoClass to do :host matching if didMoveToShadowHost bit has been set.
+
+ * cssjit/SelectorCompiler.cpp:
+ (WebCore::SelectorCompiler::addPseudoClassType):
+
+ Disallow :host in the compiler (cases where it would match didn't reach the compiler before).
+
</ins><span class="cx"> 2016-08-22 Frederic Wang <fwang@igalia.com>
</span><span class="cx">
</span><span class="cx"> Use memoize pattern for the menclose notation attribute
</span></span></pre></div>
<a id="trunkSourceWebCorecssSelectorCheckercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (204723 => 204724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/SelectorChecker.cpp 2016-08-22 16:40:49 UTC (rev 204723)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp 2016-08-22 17:19:29 UTC (rev 204724)
</span><span class="lines">@@ -81,6 +81,7 @@
</span><span class="cx"> bool pseudoElementEffective { true };
</span><span class="cx"> bool hasScrollbarPseudo { false };
</span><span class="cx"> bool hasSelectionPseudo { false };
</span><ins>+ bool didMoveToShadowHost { false };
</ins><span class="cx">
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -211,7 +212,6 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(element.shadowRoot());
</span><span class="cx"> ASSERT(selector.match() == CSSSelector::PseudoClass && selector.pseudoClassType() == CSSSelector::PseudoClassHost);
</span><del>- ASSERT(checkingContext.resolvingMode != SelectorChecker::Mode::QueryingRules);
</del><span class="cx">
</span><span class="cx"> specificity = selector.simpleSelectorSpecificity();
</span><span class="cx">
</span><span class="lines">@@ -249,8 +249,22 @@
</span><span class="cx"> // Disable :visited matching when we see the first link.
</span><span class="cx"> if (context.element->isLink())
</span><span class="cx"> updatedContext.visitedMatchType = VisitedMatchType::Disabled;
</span><ins>+
+ updatedContext.isMatchElement = false;
+
+ if (updatedContext.didMoveToShadowHost) {
+ updatedContext.element = nullptr;
+ return updatedContext;
+ }
+
+ // Move to the shadow host if matching :host and the parent is the shadow root.
+ if (context.selector->match() == CSSSelector::PseudoClass && context.selector->pseudoClassType() == CSSSelector::PseudoClassHost && is<ShadowRoot>(context.element->parentNode())) {
+ updatedContext.element = downcast<ShadowRoot>(*context.element->parentNode()).host();
+ updatedContext.didMoveToShadowHost = true;
+ return updatedContext;
+ }
+
</ins><span class="cx"> updatedContext.element = context.element->parentElement();
</span><del>- updatedContext.isMatchElement = false;
</del><span class="cx"> return updatedContext;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -300,12 +314,12 @@
</span><span class="cx"> CSSSelector::Relation relation = context.selector->relation();
</span><span class="cx">
</span><span class="cx"> // Prepare next selector
</span><del>- const CSSSelector* historySelector = context.selector->tagHistory();
- if (!historySelector)
</del><ins>+ const CSSSelector* leftSelector = context.selector->tagHistory();
+ if (!leftSelector)
</ins><span class="cx"> return MatchResult::matches(matchType);
</span><span class="cx">
</span><span class="cx"> LocalContext nextContext(context);
</span><del>- nextContext.selector = historySelector;
</del><ins>+ nextContext.selector = leftSelector;
</ins><span class="cx">
</span><span class="cx"> if (relation != CSSSelector::SubSelector) {
</span><span class="cx"> // Bail-out if this selector is irrelevant for the pseudoId
</span><span class="lines">@@ -1021,16 +1035,21 @@
</span><span class="cx"> return matchesPastCuePseudoClass(element);
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- case CSSSelector::PseudoClassScope:
- {
- const Node* contextualReferenceNode = !checkingContext.scope ? element.document().documentElement() : checkingContext.scope;
- if (&element == contextualReferenceNode)
- return true;
- break;
- }
- case CSSSelector::PseudoClassHost:
- // :host matches based on context. Cases that reach selector checker don't match.
- return false;
</del><ins>+ case CSSSelector::PseudoClassScope: {
+ const Node* contextualReferenceNode = !checkingContext.scope ? element.document().documentElement() : checkingContext.scope;
+ if (&element == contextualReferenceNode)
+ return true;
+ break;
+ }
+ case CSSSelector::PseudoClassHost: {
+ if (!context.didMoveToShadowHost)
+ return false;
+ unsigned hostSpecificity;
+ if (!matchHostPseudoClass(selector, element, checkingContext, hostSpecificity))
+ return false;
+ specificity = CSSSelector::addSpecificities(specificity, hostSpecificity);
+ return true;
+ }
</ins><span class="cx"> #if ENABLE(CUSTOM_ELEMENTS)
</span><span class="cx"> case CSSSelector::PseudoClassDefined:
</span><span class="cx"> return isDefinedElement(element);
</span></span></pre></div>
<a id="trunkSourceWebCorecssjitSelectorCompilercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/cssjit/SelectorCompiler.cpp (204723 => 204724)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2016-08-22 16:40:49 UTC (rev 204723)
+++ trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2016-08-22 17:19:29 UTC (rev 204724)
</span><span class="lines">@@ -829,8 +829,7 @@
</span><span class="cx"> return functionType;
</span><span class="cx"> }
</span><span class="cx"> case CSSSelector::PseudoClassHost:
</span><del>- // :host matches based on context. Cases that reach selector checker don't match.
- return FunctionType::CannotMatchAnything;
</del><ins>+ return FunctionType::CannotCompile;
</ins><span class="cx"> case CSSSelector::PseudoClassUnknown:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> return FunctionType::CannotMatchAnything;
</span></span></pre>
</div>
</div>
</body>
</html>