<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204729] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204729">204729</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-08-22 12:00:08 -0700 (Mon, 22 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add support for GlobalEventHandlers.oncuechange attribute
https://bugs.webkit.org/show_bug.cgi?id=161046
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Add support for GlobalEventHandlers.oncuechange attribute:
- https://html.spec.whatwg.org/#handler-oncuechange
Test: fast/media/window-oncuechange.html
* dom/GlobalEventHandlers.idl:
LayoutTests:
Add layout test coverage.
* fast/media/window-oncuechange-expected.txt: Added.
* fast/media/window-oncuechange.html: Added.
* js/dom/dom-static-property-for-in-iteration-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomdomstaticpropertyforiniterationexpectedtxt">trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomGlobalEventHandlersidl">trunk/Source/WebCore/dom/GlobalEventHandlers.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastmediawindowoncuechangeexpectedtxt">trunk/LayoutTests/fast/media/window-oncuechange-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastmediawindowoncuechangehtml">trunk/LayoutTests/fast/media/window-oncuechange.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204728 => 204729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/LayoutTests/ChangeLog 2016-08-22 19:00:08 UTC (rev 204729)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-08-22 Chris Dumez <cdumez@apple.com>
+
+ Add support for GlobalEventHandlers.oncuechange attribute
+ https://bugs.webkit.org/show_bug.cgi?id=161046
+
+ Reviewed by Alex Christensen.
+
+ Add layout test coverage.
+
+ * fast/media/window-oncuechange-expected.txt: Added.
+ * fast/media/window-oncuechange.html: Added.
+ * js/dom/dom-static-property-for-in-iteration-expected.txt:
+
</ins><span class="cx"> 2016-08-22 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> <select> menu on iPad causes shifting of hit-testing areas
</span></span></pre></div>
<a id="trunkLayoutTestsfastmediawindowoncuechangeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/media/window-oncuechange-expected.txt (0 => 204729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/media/window-oncuechange-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/media/window-oncuechange-expected.txt 2016-08-22 19:00:08 UTC (rev 204729)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+Test window.oncuechange EventHandler attribute
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.oncuechange is null
+window.oncuechange = function() { ran = true; };
+window.dispatchEvent(testEvent)
+PASS ran is true
+window.oncuechange = null
+track.dispatchEvent(testEvent)
+PASS ran is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastmediawindowoncuechangehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/media/window-oncuechange.html (0 => 204729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/media/window-oncuechange.html (rev 0)
+++ trunk/LayoutTests/fast/media/window-oncuechange.html 2016-08-22 19:00:08 UTC (rev 204729)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Test window.oncuechange EventHandler attribute");
+
+shouldBeNull("window.oncuechange");
+
+var video = document.createElement('video');
+var track = video.addTextTrack('subtitles');
+var testEvent = new Event('cuechange');
+var ran = false;
+evalAndLog("window.oncuechange = function() { ran = true; };");
+
+evalAndLog("window.dispatchEvent(testEvent)");
+shouldBeTrue("ran");
+
+evalAndLog("window.oncuechange = null");
+ran = false;
+evalAndLog("track.dispatchEvent(testEvent)");
+shouldBeFalse("ran");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204728 => 204729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-22 19:00:08 UTC (rev 204729)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-08-22 Chris Dumez <cdumez@apple.com>
+
+ Add support for GlobalEventHandlers.oncuechange attribute
+ https://bugs.webkit.org/show_bug.cgi?id=161046
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
</ins><span class="cx"> 2016-08-19 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, roll out part of r204662 to see if it addresses flakiness.
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (204728 => 204729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-08-22 19:00:08 UTC (rev 204729)
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx"> PASS Document interface: attribute onclick
</span><span class="cx"> FAIL Document interface: attribute onclose assert_true: The prototype object must have a property "onclose" expected true got false
</span><span class="cx"> PASS Document interface: attribute oncontextmenu
</span><del>-FAIL Document interface: attribute oncuechange assert_true: The prototype object must have a property "oncuechange" expected true got false
</del><ins>+PASS Document interface: attribute oncuechange
</ins><span class="cx"> PASS Document interface: attribute ondblclick
</span><span class="cx"> PASS Document interface: attribute ondrag
</span><span class="cx"> PASS Document interface: attribute ondragend
</span><span class="lines">@@ -255,7 +255,7 @@
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "onclick" with the proper type (99)
</span><span class="cx"> FAIL Document interface: iframe.contentDocument must inherit property "onclose" with the proper type (100) assert_inherits: property "onclose" not found in prototype chain
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "oncontextmenu" with the proper type (101)
</span><del>-FAIL Document interface: iframe.contentDocument must inherit property "oncuechange" with the proper type (102) assert_inherits: property "oncuechange" not found in prototype chain
</del><ins>+PASS Document interface: iframe.contentDocument must inherit property "oncuechange" with the proper type (102)
</ins><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "ondblclick" with the proper type (103)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "ondrag" with the proper type (104)
</span><span class="cx"> PASS Document interface: iframe.contentDocument must inherit property "ondragend" with the proper type (105)
</span><span class="lines">@@ -502,7 +502,7 @@
</span><span class="cx"> PASS Document interface: new Document() must inherit property "onclick" with the proper type (99)
</span><span class="cx"> FAIL Document interface: new Document() must inherit property "onclose" with the proper type (100) assert_inherits: property "onclose" not found in prototype chain
</span><span class="cx"> PASS Document interface: new Document() must inherit property "oncontextmenu" with the proper type (101)
</span><del>-FAIL Document interface: new Document() must inherit property "oncuechange" with the proper type (102) assert_inherits: property "oncuechange" not found in prototype chain
</del><ins>+PASS Document interface: new Document() must inherit property "oncuechange" with the proper type (102)
</ins><span class="cx"> PASS Document interface: new Document() must inherit property "ondblclick" with the proper type (103)
</span><span class="cx"> PASS Document interface: new Document() must inherit property "ondrag" with the proper type (104)
</span><span class="cx"> PASS Document interface: new Document() must inherit property "ondragend" with the proper type (105)
</span><span class="lines">@@ -749,7 +749,7 @@
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "onclick" with the proper type (99)
</span><span class="cx"> FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "onclose" with the proper type (100) assert_inherits: property "onclose" not found in prototype chain
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "oncontextmenu" with the proper type (101)
</span><del>-FAIL Document interface: document.implementation.createDocument(null, "", null) must inherit property "oncuechange" with the proper type (102) assert_inherits: property "oncuechange" not found in prototype chain
</del><ins>+PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "oncuechange" with the proper type (102)
</ins><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "ondblclick" with the proper type (103)
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "ondrag" with the proper type (104)
</span><span class="cx"> PASS Document interface: document.implementation.createDocument(null, "", null) must inherit property "ondragend" with the proper type (105)
</span><span class="lines">@@ -980,7 +980,7 @@
</span><span class="cx"> PASS HTMLElement interface: attribute onclick
</span><span class="cx"> FAIL HTMLElement interface: attribute onclose assert_true: The prototype object must have a property "onclose" expected true got false
</span><span class="cx"> PASS HTMLElement interface: attribute oncontextmenu
</span><del>-FAIL HTMLElement interface: attribute oncuechange assert_true: The prototype object must have a property "oncuechange" expected true got false
</del><ins>+PASS HTMLElement interface: attribute oncuechange
</ins><span class="cx"> PASS HTMLElement interface: attribute ondblclick
</span><span class="cx"> PASS HTMLElement interface: attribute ondrag
</span><span class="cx"> PASS HTMLElement interface: attribute ondragend
</span><span class="lines">@@ -1070,7 +1070,7 @@
</span><span class="cx"> PASS HTMLElement interface: document.createElement("noscript") must inherit property "onclick" with the proper type (34)
</span><span class="cx"> FAIL HTMLElement interface: document.createElement("noscript") must inherit property "onclose" with the proper type (35) assert_inherits: property "onclose" not found in prototype chain
</span><span class="cx"> PASS HTMLElement interface: document.createElement("noscript") must inherit property "oncontextmenu" with the proper type (36)
</span><del>-FAIL HTMLElement interface: document.createElement("noscript") must inherit property "oncuechange" with the proper type (37) assert_inherits: property "oncuechange" not found in prototype chain
</del><ins>+PASS HTMLElement interface: document.createElement("noscript") must inherit property "oncuechange" with the proper type (37)
</ins><span class="cx"> PASS HTMLElement interface: document.createElement("noscript") must inherit property "ondblclick" with the proper type (38)
</span><span class="cx"> PASS HTMLElement interface: document.createElement("noscript") must inherit property "ondrag" with the proper type (39)
</span><span class="cx"> PASS HTMLElement interface: document.createElement("noscript") must inherit property "ondragend" with the proper type (40)
</span><span class="lines">@@ -5139,7 +5139,7 @@
</span><span class="cx"> PASS Window interface: attribute onclick
</span><span class="cx"> FAIL Window interface: attribute onclose assert_own_property: The global object must have a property "onclose" expected property "onclose" missing
</span><span class="cx"> PASS Window interface: attribute oncontextmenu
</span><del>-FAIL Window interface: attribute oncuechange assert_own_property: The global object must have a property "oncuechange" expected property "oncuechange" missing
</del><ins>+PASS Window interface: attribute oncuechange
</ins><span class="cx"> PASS Window interface: attribute ondblclick
</span><span class="cx"> PASS Window interface: attribute ondrag
</span><span class="cx"> PASS Window interface: attribute ondragend
</span><span class="lines">@@ -5268,7 +5268,7 @@
</span><span class="cx"> PASS Window interface: window must inherit property "onclick" with the proper type (46)
</span><span class="cx"> FAIL Window interface: window must inherit property "onclose" with the proper type (47) assert_own_property: expected property "onclose" missing
</span><span class="cx"> PASS Window interface: window must inherit property "oncontextmenu" with the proper type (48)
</span><del>-FAIL Window interface: window must inherit property "oncuechange" with the proper type (49) assert_own_property: expected property "oncuechange" missing
</del><ins>+PASS Window interface: window must inherit property "oncuechange" with the proper type (49)
</ins><span class="cx"> PASS Window interface: window must inherit property "ondblclick" with the proper type (50)
</span><span class="cx"> PASS Window interface: window must inherit property "ondrag" with the proper type (51)
</span><span class="cx"> PASS Window interface: window must inherit property "ondragend" with the proper type (52)
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomdomstaticpropertyforiniterationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt (204728 => 204729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-08-22 19:00:08 UTC (rev 204729)
</span><span class="lines">@@ -53,6 +53,7 @@
</span><span class="cx"> PASS a["onchange"] is null
</span><span class="cx"> PASS a["onclick"] is null
</span><span class="cx"> PASS a["oncontextmenu"] is null
</span><ins>+PASS a["oncuechange"] is null
</ins><span class="cx"> PASS a["ondblclick"] is null
</span><span class="cx"> PASS a["ondrag"] is null
</span><span class="cx"> PASS a["ondragend"] is null
</span><span class="lines">@@ -108,7 +109,7 @@
</span><span class="cx"> PASS a["prefix"] is null
</span><span class="cx"> PASS a["localName"] is a
</span><span class="cx"> PASS a["offsetLeft"] is 8
</span><del>-PASS a["offsetTop"] is 1659
</del><ins>+PASS a["offsetTop"] is 1674
</ins><span class="cx"> PASS a["offsetWidth"] is 40
</span><span class="cx"> PASS a["offsetHeight"] is 18
</span><span class="cx"> PASS a["clientLeft"] is 0
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204728 => 204729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/Source/WebCore/ChangeLog 2016-08-22 19:00:08 UTC (rev 204729)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-08-22 Chris Dumez <cdumez@apple.com>
+
+ Add support for GlobalEventHandlers.oncuechange attribute
+ https://bugs.webkit.org/show_bug.cgi?id=161046
+
+ Reviewed by Alex Christensen.
+
+ Add support for GlobalEventHandlers.oncuechange attribute:
+ - https://html.spec.whatwg.org/#handler-oncuechange
+
+ Test: fast/media/window-oncuechange.html
+
+ * dom/GlobalEventHandlers.idl:
+
</ins><span class="cx"> 2016-08-22 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Fix bindings tests after r204717.
</span></span></pre></div>
<a id="trunkSourceWebCoredomGlobalEventHandlersidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/GlobalEventHandlers.idl (204728 => 204729)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/GlobalEventHandlers.idl 2016-08-22 18:02:03 UTC (rev 204728)
+++ trunk/Source/WebCore/dom/GlobalEventHandlers.idl 2016-08-22 19:00:08 UTC (rev 204729)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> attribute EventHandler onclick;
</span><span class="cx"> // attribute EventHandler onclose;
</span><span class="cx"> attribute EventHandler oncontextmenu;
</span><del>- // attribute EventHandler oncuechange;
</del><ins>+ attribute EventHandler oncuechange;
</ins><span class="cx"> attribute EventHandler ondblclick;
</span><span class="cx"> attribute EventHandler ondrag;
</span><span class="cx"> attribute EventHandler ondragend;
</span></span></pre>
</div>
</div>
</body>
</html>