<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204759] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204759">204759</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-22 23:09:33 -0700 (Mon, 22 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Styles -> Computed -> Box Model shows NaN x NaN for invisible elements
https://bugs.webkit.org/show_bug.cgi?id=161038
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-08-22
Reviewed by Joseph Pecoraro.
* UserInterface/Base/Utilities.js:
Add figureDash variable.
* UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
Moved isNaN check of value to common createElement.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseUtilitiesjs">trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsBoxModelDetailsSectionRowjs">trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (204758 => 204759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-08-23 05:56:45 UTC (rev 204758)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-08-23 06:09:33 UTC (rev 204759)
</span><span class="lines">@@ -1,5 +1,20 @@
</span><span class="cx"> 2016-08-22 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Styles -> Computed -> Box Model shows NaN x NaN for invisible elements
+ https://bugs.webkit.org/show_bug.cgi?id=161038
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Base/Utilities.js:
+ Add figureDash variable.
+
+ * UserInterface/Views/BoxModelDetailsSectionRow.js:
+ (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
+ (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
+ Moved isNaN check of value to common createElement.
+
+2016-08-22 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Visual styles sidebar should do something sane for SVG elements
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=148269
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseUtilitiesjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js (204758 => 204759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2016-08-23 05:56:45 UTC (rev 204758)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2016-08-23 06:09:33 UTC (rev 204759)
</span><span class="lines">@@ -25,6 +25,7 @@
</span><span class="cx">
</span><span class="cx"> var emDash = "\u2014";
</span><span class="cx"> var enDash = "\u2013";
</span><ins>+var figureDash = "\u2012";
</ins><span class="cx"> var ellipsis = "\u2026";
</span><span class="cx">
</span><span class="cx"> Object.defineProperty(Object, "shallowCopy",
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsBoxModelDetailsSectionRowjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js (204758 => 204759)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js 2016-08-23 05:56:45 UTC (rev 204758)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js 2016-08-23 06:09:33 UTC (rev 204759)
</span><span class="lines">@@ -112,10 +112,13 @@
</span><span class="cx"> function createElement(type, value, name, propertyName, style)
</span><span class="cx"> {
</span><span class="cx"> // Check if the value is a float and whether it should be rounded.
</span><del>- var floatValue = parseFloat(value);
- var shouldRoundValue = (!isNaN(floatValue) && floatValue % 1 !== 0);
</del><ins>+ let floatValue = parseFloat(value);
+ let shouldRoundValue = (!isNaN(floatValue) && floatValue % 1 !== 0);
</ins><span class="cx">
</span><del>- var element = document.createElement(type);
</del><ins>+ if (isNaN(floatValue))
+ value = figureDash;
+
+ let element = document.createElement(type);
</ins><span class="cx"> element.textContent = shouldRoundValue ? ("~" + Math.round(floatValue * 100) / 100) : value;
</span><span class="cx"> if (shouldRoundValue)
</span><span class="cx"> element.title = value;
</span><span class="lines">@@ -125,15 +128,14 @@
</span><span class="cx">
</span><span class="cx"> function createBoxPartElement(style, name, side, suffix)
</span><span class="cx"> {
</span><del>- var propertyName = (name !== "position" ? name + "-" : "") + side + suffix;
- var value = style.propertyForName(propertyName).value;
- if (value === "" || (name !== "position" && value === "0px"))
- value = "\u2012";
- else if (name === "position" && value === "auto")
- value = "\u2012";
- value = value.replace(/px$/, "");
</del><ins>+ let propertyName = (name !== "position" ? name + "-" : "") + side + suffix;
+ let value = style.propertyForName(propertyName).value;
+ if (value === "" || (name !== "position" && value === "0px") || (name === "position" && value === "auto"))
+ value = "";
+ else
+ value = value.replace(/px$/, "");
</ins><span class="cx">
</span><del>- var element = createElement.call(this, "div", value, name, propertyName, style);
</del><ins>+ let element = createElement.call(this, "div", value, name, propertyName, style);
</ins><span class="cx"> element.className = side;
</span><span class="cx"> return element;
</span><span class="cx"> }
</span><span class="lines">@@ -379,9 +381,9 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (context.box !== "position" && (!userInput || userInput === "\u2012"))
</del><ins>+ if (context.box !== "position" && (!userInput || userInput === figureDash))
</ins><span class="cx"> userInput = "0px";
</span><del>- else if (context.box === "position" && (!userInput || userInput === "\u2012"))
</del><ins>+ else if (context.box === "position" && (!userInput || userInput === figureDash))
</ins><span class="cx"> userInput = "auto";
</span><span class="cx">
</span><span class="cx"> userInput = userInput.toLowerCase();
</span></span></pre>
</div>
</div>
</body>
</html>