<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204757] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204757">204757</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-22 22:34:42 -0700 (Mon, 22 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Visual Styles: "Text -> Content" section should only be visible for pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=158272
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-08-22
Reviewed by Joseph Pecoraro.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/VisualStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style .visual > .details-section :matches(.details-section, .group).inactive):
(.sidebar > .panel.details.css-style .visual > .details-section :matches(.details-section, .group).inactive > *):
(.visual-style-property-container.transition): Deleted.
(.visual-style-property-container.animation): Deleted.
* UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
(WebInspector.VisualStyleDetailsPanel.prototype._populateContentSection):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleDetailsPanelcss">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleDetailsPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleSelectorSectionjs">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (204756 => 204757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2016-08-23 05:12:51 UTC (rev 204756)
+++ trunk/Source/WebInspectorUI/ChangeLog        2016-08-23 05:34:42 UTC (rev 204757)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2016-08-22 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Visual Styles: "Text -> Content" section should only be visible for pseudo-element
+ https://bugs.webkit.org/show_bug.cgi?id=158272
+
+ Reviewed by Joseph Pecoraro.
+
+ * Localizations/en.lproj/localizedStrings.js:
+
+ * UserInterface/Views/VisualStyleDetailsPanel.css:
+ (.sidebar > .panel.details.css-style .visual > .details-section :matches(.details-section, .group).inactive):
+ (.sidebar > .panel.details.css-style .visual > .details-section :matches(.details-section, .group).inactive > *):
+ (.visual-style-property-container.transition): Deleted.
+ (.visual-style-property-container.animation): Deleted.
+
+ * UserInterface/Views/VisualStyleDetailsPanel.js:
+ (WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
+ (WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
+ (WebInspector.VisualStyleDetailsPanel.prototype._populateContentSection):
+
+2016-08-22 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Entering ":n" in Open Resource Dialog, where n > number of lines, should jump to the last line
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160840
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (204756 => 204757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2016-08-23 05:12:51 UTC (rev 204756)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2016-08-23 05:34:42 UTC (rev 204757)
</span><span class="lines">@@ -301,6 +301,7 @@
</span><span class="cx"> localizedStrings["Enter a URL"] = "Enter a URL";
</span><span class="cx"> localizedStrings["Enter a name."] = "Enter a name.";
</span><span class="cx"> localizedStrings["Enter the name of a Keyframe"] = "Enter the name of a Keyframe";
</span><ins>+localizedStrings["Enter value"] = "Enter value";
</ins><span class="cx"> localizedStrings["Entire Recording"] = "Entire Recording";
</span><span class="cx"> localizedStrings["Error: "] = "Error: ";
</span><span class="cx"> localizedStrings["Errors"] = "Errors";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleDetailsPanelcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.css (204756 => 204757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.css        2016-08-23 05:12:51 UTC (rev 204756)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.css        2016-08-23 05:34:42 UTC (rev 204757)
</span><span class="lines">@@ -23,6 +23,14 @@
</span><span class="cx"> * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><ins>+.sidebar > .panel.details.css-style .visual > .details-section :matches(.details-section, .group).inactive {
+ border-bottom: none;
+}
+
+.sidebar > .panel.details.css-style .visual > .details-section :matches(.details-section, .group).inactive > * {
+ display: none;
+}
+
</ins><span class="cx"> .sidebar > .panel.details.css-style .visual > .details-section .details-section > .header {
</span><span class="cx"> font-weight: normal;
</span><span class="cx"> }
</span><span class="lines">@@ -94,11 +102,6 @@
</span><span class="cx"> width: 55px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.visual-style-property-container.transition,
-.visual-style-property-container.animation {
- margin-left: 11px;
-}
-
</del><span class="cx"> .sidebar > .panel.details.css-style .visual.disabled > .details-section:not(.visual-style-selector-section) {
</span><span class="cx"> opacity: 0.5;
</span><span class="cx"> pointer-events: none;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleDetailsPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js (204756 => 204757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js        2016-08-23 05:12:51 UTC (rev 204756)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js        2016-08-23 05:34:42 UTC (rev 204757)
</span><span class="lines">@@ -91,6 +91,7 @@
</span><span class="cx"> this.element.appendChild(this._sections.layout.element);
</span><span class="cx">
</span><span class="cx"> // Text Section
</span><ins>+ this._generateSection("content", WebInspector.UIString("Content"));
</ins><span class="cx"> this._generateSection("text-style", WebInspector.UIString("Style"));
</span><span class="cx"> this._generateSection("font", WebInspector.UIString("Font"));
</span><span class="cx"> this._generateSection("font-variants", WebInspector.UIString("Variants"));
</span><span class="lines">@@ -97,7 +98,7 @@
</span><span class="cx"> this._generateSection("text-spacing", WebInspector.UIString("Spacing"));
</span><span class="cx"> this._generateSection("text-shadow", WebInspector.UIString("Shadow"));
</span><span class="cx">
</span><del>- this._sections.text = new WebInspector.DetailsSection("text", WebInspector.UIString("Text"), [this._groups.textStyle.section, this._groups.font.section, this._groups.fontVariants.section, this._groups.textSpacing.section, this._groups.textShadow.section]);
</del><ins>+ this._sections.text = new WebInspector.DetailsSection("text", WebInspector.UIString("Text"), [this._groups.content.section, this._groups.textStyle.section, this._groups.font.section, this._groups.fontVariants.section, this._groups.textSpacing.section, this._groups.textShadow.section]);
</ins><span class="cx"> this.element.appendChild(this._sections.text.element);
</span><span class="cx">
</span><span class="cx"> // Background Section
</span><span class="lines">@@ -187,6 +188,10 @@
</span><span class="cx"> section.collapsed = false;
</span><span class="cx"> }
</span><span class="cx"> }
</span><ins>+
+ let hasMatchedElementPseudoSelector = this._currentStyle.ownerRule && this._currentStyle.ownerRule.hasMatchedPseudoElementSelector();
+ this._groups.content.section.element.classList.toggle("inactive", !hasMatchedElementPseudoSelector);
+ this._groups.listStyle.section.element.classList.toggle("inactive", hasMatchedElementPseudoSelector);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _updateProperties(group, forceStyleUpdate)
</span><span class="lines">@@ -653,6 +658,21 @@
</span><span class="cx"> properties.alignSelf.addDependency("display", allowedDisplayValues);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ _populateContentSection()
+ {
+ let group = this._groups.content;
+ let properties = group.properties;
+
+ let contentRow = new WebInspector.DetailsSectionRow;
+
+ properties.content = new WebInspector.VisualStyleBasicInput("content", null, WebInspector.UIString("Enter value"));
+
+ contentRow.element.appendChild(properties.content.element);
+
+ let contentGroup = new WebInspector.DetailsSectionGroup([contentRow]);
+ this._populateSection(group, [contentGroup]);
+ }
+
</ins><span class="cx"> _populateTextStyleSection()
</span><span class="cx"> {
</span><span class="cx"> let group = this._groups.textStyle;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleSelectorSectionjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js (204756 => 204757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js        2016-08-23 05:12:51 UTC (rev 204756)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js        2016-08-23 05:34:42 UTC (rev 204757)
</span><span class="lines">@@ -207,7 +207,7 @@
</span><span class="cx"> currentStyle()
</span><span class="cx"> {
</span><span class="cx"> if (!this._nodeStyles || !this._selectors.selectedTreeElement)
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> return this._selectors.selectedTreeElement.representedObject;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>