<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204764] releases/WebKitGTK/webkit-2.12</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204764">204764</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-22 23:35:25 -0700 (Mon, 22 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/201407">r201407</a> - Setting overflow:hidden does not always repaint clipped content.
https://bugs.webkit.org/show_bug.cgi?id=116994
rdar://problem/26476697
Issue repaint for both layout and visual overflow rects when the container starts
clipping overflow content.
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/repaint/overflow-hidden-repaint.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::updateFromStyle):
LayoutTests:
* fast/repaint/overflow-hidden-repaint-expected.html: Added.
* fast/repaint/overflow-hidden-repaint.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorerenderingRenderBoxcpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderBox.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsfastrepaintoverflowhiddenrepaintexpectedhtml">releases/WebKitGTK/webkit-2.12/LayoutTests/fast/repaint/overflow-hidden-repaint-expected.html</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsfastrepaintoverflowhiddenrepainthtml">releases/WebKitGTK/webkit-2.12/LayoutTests/fast/repaint/overflow-hidden-repaint.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit212LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (204763 => 204764)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog        2016-08-23 06:34:03 UTC (rev 204763)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog        2016-08-23 06:35:25 UTC (rev 204764)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-05-25 Zalan Bujtas <zalan@apple.com>
+
+ Setting overflow:hidden does not always repaint clipped content.
+ https://bugs.webkit.org/show_bug.cgi?id=116994
+ rdar://problem/26476697
+
+ Issue repaint for both layout and visual overflow rects when the container starts
+ clipping overflow content.
+
+ Reviewed by David Hyatt.
+
+ * fast/repaint/overflow-hidden-repaint-expected.html: Added.
+ * fast/repaint/overflow-hidden-repaint.html: Added.
+
</ins><span class="cx"> 2016-05-24 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> fast/table/neighboring-cells-when-collapsed-border-changes.html is flaky.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsfastrepaintoverflowhiddenrepaintexpectedhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/fast/repaint/overflow-hidden-repaint-expected.html (0 => 204764)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/fast/repaint/overflow-hidden-repaint-expected.html         (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/fast/repaint/overflow-hidden-repaint-expected.html        2016-08-23 06:35:25 UTC (rev 204764)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that repaint overflow part when overflow becomes clipped.</title>
+<style>
+div {
+ background: green;
+ overflow: visible;
+ height: 50px;
+ width: 50px;
+}
+</style>
+</head>
+<body>
+PASS if no red is visible.
+<div></div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsfastrepaintoverflowhiddenrepainthtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/fast/repaint/overflow-hidden-repaint.html (0 => 204764)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/fast/repaint/overflow-hidden-repaint.html         (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/fast/repaint/overflow-hidden-repaint.html        2016-08-23 06:35:25 UTC (rev 204764)
</span><span class="lines">@@ -0,0 +1,37 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that repaint overflow part when overflow becomes clipped.</title>
+<style>
+#container {
+ background: green;
+ overflow: visible;
+ height: 50px;
+ width: 50px;
+}
+
+#inner {
+ background: red;
+        width: 50px;
+        height: 100px;
+        position: relative;
+        top: 100px;
+}
+</style>
+</head>
+<body>
+PASS if no red is visible.
+<div id=container><div id=inner></div></div>
+<script>
+if (window.testRunner)
+ testRunner.waitUntilDone();
+setTimeout(function() {
+ document.getElementById("inner").style.display = "none";
+ document.getElementById("container").style.overflow = "hidden";
+ document.body.offsetWidth;
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, 10);
+</script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (204763 => 204764)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog        2016-08-23 06:34:03 UTC (rev 204763)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog        2016-08-23 06:35:25 UTC (rev 204764)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2016-05-25 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><ins>+ Setting overflow:hidden does not always repaint clipped content.
+ https://bugs.webkit.org/show_bug.cgi?id=116994
+ rdar://problem/26476697
+
+ Issue repaint for both layout and visual overflow rects when the container starts
+ clipping overflow content.
+
+ Reviewed by David Hyatt.
+
+ Test: fast/repaint/overflow-hidden-repaint.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::updateFromStyle):
+
+2016-05-25 Zalan Bujtas <zalan@apple.com>
+
</ins><span class="cx"> Addressing post-review comments on r200971.
</span><span class="cx">
</span><span class="cx"> Reviewed by Darin Adler.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderBox.cpp (204763 => 204764)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderBox.cpp        2016-08-23 06:34:03 UTC (rev 204763)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderBox.cpp        2016-08-23 06:35:25 UTC (rev 204764)
</span><span class="lines">@@ -516,17 +516,19 @@
</span><span class="cx"> boxHasOverflowClip = false;
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>-
</del><span class="cx"> // Check for overflow clip.
</span><span class="cx"> // It's sufficient to just check one direction, since it's illegal to have visible on only one overflow value.
</span><span class="cx"> if (boxHasOverflowClip) {
</span><del>- if (!s_hadOverflowClip)
- // Erase the overflow
- repaint();
</del><ins>+ if (!s_hadOverflowClip && hasRenderOverflow()) {
+ // Erase the overflow.
+ // Overflow changes have to result in immediate repaints of the entire layout overflow area because
+ // repaints issued by removal of descendants get clipped using the updated style when they shouldn't.
+ repaintRectangle(visualOverflowRect());
+ repaintRectangle(layoutOverflowRect());
+ }
</ins><span class="cx"> setHasOverflowClip();
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>-
</del><span class="cx"> setHasTransformRelatedProperty(styleToUse.hasTransformRelatedProperty());
</span><span class="cx"> setHasReflection(styleToUse.boxReflect());
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>