<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204624] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204624">204624</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-08-18 19:40:11 -0700 (Thu, 18 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Move prefix / namespaceURI / localName attributes from Node to Attr / Element
https://bugs.webkit.org/show_bug.cgi?id=160988
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C test now that more checks are passing.
* web-platform-tests/dom/historical-expected.txt:
* web-platform-tests/dom/interfaces-expected.txt:
Source/WebCore:
Move prefix / namespaceURI / localName attributes from Node to Attr / Element
as per the latest DOM specification:
- https://dom.spec.whatwg.org/#element
- https://dom.spec.whatwg.org/#attr
Firefox and Chrome match the specification.
No new tests, rebaselined existing tests.
* dom/Attr.h:
* dom/Attr.idl:
* dom/Element.h:
* dom/Element.idl:
* dom/Node.idl:
LayoutTests:
Update existing layout tests to reflect behavior change.
* fast/dom/Node/initial-values-expected.txt:
* fast/dom/Node/script-tests/initial-values.js:
* http/tests/misc/createElementNamespace1-expected.txt:
* http/tests/misc/createElementNamespace1.xml:
* http/tests/misc/createElementNamespace2-expected.txt:
* http/tests/misc/createElementNamespace2.xhtml:
* http/tests/misc/createElementNamespace3-expected.txt:
* http/tests/misc/createElementNamespace3.html:
* js/dom/dom-static-property-for-in-iteration-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomNodeinitialvaluesexpectedtxt">trunk/LayoutTests/fast/dom/Node/initial-values-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomNodescripttestsinitialvaluesjs">trunk/LayoutTests/fast/dom/Node/script-tests/initial-values.js</a></li>
<li><a href="#trunkLayoutTestshttptestsmisccreateElementNamespace1expectedtxt">trunk/LayoutTests/http/tests/misc/createElementNamespace1-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsmisccreateElementNamespace1xml">trunk/LayoutTests/http/tests/misc/createElementNamespace1.xml</a></li>
<li><a href="#trunkLayoutTestshttptestsmisccreateElementNamespace2expectedtxt">trunk/LayoutTests/http/tests/misc/createElementNamespace2-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsmisccreateElementNamespace2xhtml">trunk/LayoutTests/http/tests/misc/createElementNamespace2.xhtml</a></li>
<li><a href="#trunkLayoutTestshttptestsmisccreateElementNamespace3expectedtxt">trunk/LayoutTests/http/tests/misc/createElementNamespace3-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsmisccreateElementNamespace3html">trunk/LayoutTests/http/tests/misc/createElementNamespace3.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomhistoricalexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomdomstaticpropertyforiniterationexpectedtxt">trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomAttrh">trunk/Source/WebCore/dom/Attr.h</a></li>
<li><a href="#trunkSourceWebCoredomAttridl">trunk/Source/WebCore/dom/Attr.idl</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
<li><a href="#trunkSourceWebCoredomElementidl">trunk/Source/WebCore/dom/Element.idl</a></li>
<li><a href="#trunkSourceWebCoredomNodeidl">trunk/Source/WebCore/dom/Node.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/ChangeLog 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-08-18 Chris Dumez <cdumez@apple.com>
+
+ Move prefix / namespaceURI / localName attributes from Node to Attr / Element
+ https://bugs.webkit.org/show_bug.cgi?id=160988
+
+ Reviewed by Ryosuke Niwa.
+
+ Update existing layout tests to reflect behavior change.
+
+ * fast/dom/Node/initial-values-expected.txt:
+ * fast/dom/Node/script-tests/initial-values.js:
+ * http/tests/misc/createElementNamespace1-expected.txt:
+ * http/tests/misc/createElementNamespace1.xml:
+ * http/tests/misc/createElementNamespace2-expected.txt:
+ * http/tests/misc/createElementNamespace2.xhtml:
+ * http/tests/misc/createElementNamespace3-expected.txt:
+ * http/tests/misc/createElementNamespace3.html:
+ * js/dom/dom-static-property-for-in-iteration-expected.txt:
+
</ins><span class="cx"> 2016-08-18 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> Support passing preferLowPowerToHighPerformance and failIfMajorPerformanceCaveat
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomNodeinitialvaluesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Node/initial-values-expected.txt (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Node/initial-values-expected.txt 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/fast/dom/Node/initial-values-expected.txt 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -36,33 +36,33 @@
</span><span class="cx"> PASS attr.nodeValue is ''
</span><span class="cx"> PASS attr.value is ''
</span><span class="cx"> PASS comment.nodeName is '#comment'
</span><del>-PASS comment.localName is null
-PASS comment.namespaceURI is null
-PASS comment.prefix is null
</del><ins>+PASS comment.localName is undefined.
+PASS comment.namespaceURI is undefined.
+PASS comment.prefix is undefined.
</ins><span class="cx"> PASS comment.nodeValue is 'foo'
</span><span class="cx"> PASS comment.data is 'foo'
</span><span class="cx"> PASS document.createCDATASection('foo') threw exception NotSupportedError (DOM Exception 9): The operation is not supported..
</span><span class="cx"> PASS cdata.nodeName is '#cdata-section'
</span><del>-PASS cdata.localName is null
-PASS cdata.namespaceURI is null
-PASS cdata.prefix is null
</del><ins>+PASS cdata.localName is undefined.
+PASS cdata.namespaceURI is undefined.
+PASS cdata.prefix is undefined.
</ins><span class="cx"> PASS cdata.nodeValue is 'foo'
</span><span class="cx"> PASS cdata.data is 'foo'
</span><span class="cx"> PASS fragment.nodeName is '#document-fragment'
</span><del>-PASS fragment.localName is null
-PASS fragment.namespaceURI is null
-PASS fragment.prefix is null
</del><ins>+PASS fragment.localName is undefined.
+PASS fragment.namespaceURI is undefined.
+PASS fragment.prefix is undefined.
</ins><span class="cx"> PASS fragment.nodeValue is null
</span><span class="cx"> PASS doc.nodeName is '#document'
</span><del>-PASS doc.localName is null
-FAIL doc.namespaceURI should be http://www.w3.org/1999/xhtml (of type string). Was null (of type object).
-PASS doc.prefix is null
</del><ins>+PASS doc.localName is undefined.
+PASS doc.namespaceURI is undefined.
+PASS doc.prefix is undefined.
</ins><span class="cx"> PASS doc.nodeValue is null
</span><span class="cx"> PASS doctype.nodeName is 'svg'
</span><span class="cx"> PASS doctype.name is 'svg'
</span><del>-PASS doctype.localName is null
-PASS doctype.namespaceURI is null
-PASS doctype.prefix is null
</del><ins>+PASS doctype.localName is undefined.
+PASS doctype.namespaceURI is undefined.
+PASS doctype.prefix is undefined.
</ins><span class="cx"> PASS doctype.nodeValue is null
</span><span class="cx"> Element creation using createElement on an HTML doc:
</span><span class="cx"> PASS element.nodeName is 'PRE'
</span><span class="lines">@@ -114,20 +114,20 @@
</span><span class="cx"> PASS element.nodeValue is null
</span><span class="cx"> PASS element.attributes.toString() is '[object NamedNodeMap]'
</span><span class="cx"> PASS processingInstruction.nodeName is 'xml-stylesheet'
</span><del>-PASS processingInstruction.localName is null
-PASS processingInstruction.namespaceURI is null
-PASS processingInstruction.prefix is null
</del><ins>+PASS processingInstruction.localName is undefined.
+PASS processingInstruction.namespaceURI is undefined.
+PASS processingInstruction.prefix is undefined.
</ins><span class="cx"> PASS processingInstruction.nodeName is 'xml-stylesheet'
</span><del>-PASS processingInstruction.localName is null
-PASS processingInstruction.namespaceURI is null
-PASS processingInstruction.prefix is null
</del><ins>+PASS processingInstruction.localName is undefined.
+PASS processingInstruction.namespaceURI is undefined.
+PASS processingInstruction.prefix is undefined.
</ins><span class="cx"> PASS processingInstruction.nodeValue is 'type="text/xsl" href="missing.xsl"'
</span><span class="cx"> PASS processingInstruction.target is 'xml-stylesheet'
</span><span class="cx"> PASS processingInstruction.data is 'type="text/xsl" href="missing.xsl"'
</span><span class="cx"> PASS text.nodeName is '#text'
</span><del>-PASS text.localName is null
-PASS text.namespaceURI is null
-PASS text.prefix is null
</del><ins>+PASS text.localName is undefined.
+PASS text.namespaceURI is undefined.
+PASS text.prefix is undefined.
</ins><span class="cx"> PASS text.nodeValue is 'foo'
</span><span class="cx"> PASS text.data is 'foo'
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomNodescripttestsinitialvaluesjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/Node/script-tests/initial-values.js (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Node/script-tests/initial-values.js 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/fast/dom/Node/script-tests/initial-values.js 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -48,9 +48,9 @@
</span><span class="cx">
</span><span class="cx"> var comment = document.createComment("foo");
</span><span class="cx"> shouldBe("comment.nodeName", "'#comment'");
</span><del>-shouldBe("comment.localName", "null");
-shouldBe("comment.namespaceURI", "null");
-shouldBe("comment.prefix", "null");
</del><ins>+shouldBeUndefined("comment.localName");
+shouldBeUndefined("comment.namespaceURI");
+shouldBeUndefined("comment.prefix");
</ins><span class="cx"> shouldBe("comment.nodeValue", "'foo'");
</span><span class="cx"> shouldBe("comment.data", "'foo'");
</span><span class="cx">
</span><span class="lines">@@ -57,34 +57,32 @@
</span><span class="cx"> shouldThrow("document.createCDATASection('foo')");
</span><span class="cx"> var cdata = xmlDoc.createCDATASection("foo");
</span><span class="cx"> shouldBe("cdata.nodeName", "'#cdata-section'");
</span><del>-shouldBe("cdata.localName", "null");
-shouldBe("cdata.namespaceURI", "null");
-shouldBe("cdata.prefix", "null");
</del><ins>+shouldBeUndefined("cdata.localName");
+shouldBeUndefined("cdata.namespaceURI");
+shouldBeUndefined("cdata.prefix");
</ins><span class="cx"> shouldBe("cdata.nodeValue", "'foo'");
</span><span class="cx"> shouldBe("cdata.data", "'foo'");
</span><span class="cx">
</span><span class="cx"> var fragment = document.createDocumentFragment();
</span><span class="cx"> shouldBe("fragment.nodeName", "'#document-fragment'");
</span><del>-shouldBe("fragment.localName", "null");
-shouldBe("fragment.namespaceURI", "null");
-shouldBe("fragment.prefix", "null");
</del><ins>+shouldBeUndefined("fragment.localName");
+shouldBeUndefined("fragment.namespaceURI");
+shouldBeUndefined("fragment.prefix");
</ins><span class="cx"> shouldBe("fragment.nodeValue", "null");
</span><span class="cx">
</span><span class="cx"> var doc = document.implementation.createDocument("http://www.w3.org/1999/xhtml", "html", null);
</span><span class="cx"> shouldBe("doc.nodeName", "'#document'");
</span><del>-shouldBe("doc.localName", "null");
-// Spec: http://www.w3.org/TR/DOM-Level-2-Core/core.html#Level-2-Core-DOM-createDocument
-// Currently both FF and WebKit return null here, disagreeing with the spec
-shouldBe("doc.namespaceURI", "'http://www.w3.org/1999/xhtml'");
-shouldBe("doc.prefix", "null");
</del><ins>+shouldBeUndefined("doc.localName");
+shouldBeUndefined("doc.namespaceURI");
+shouldBeUndefined("doc.prefix");
</ins><span class="cx"> shouldBe("doc.nodeValue", "null");
</span><span class="cx">
</span><span class="cx"> var doctype = document.implementation.createDocumentType("svg", "-//W3C//DTD SVG 1.1//EN", "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd");
</span><span class="cx"> shouldBe("doctype.nodeName", "'svg'");
</span><span class="cx"> shouldBe("doctype.name", "'svg'");
</span><del>-shouldBe("doctype.localName", "null");
-shouldBe("doctype.namespaceURI", "null");
-shouldBe("doctype.prefix", "null");
</del><ins>+shouldBeUndefined("doctype.localName");
+shouldBeUndefined("doctype.namespaceURI");
+shouldBeUndefined("doctype.prefix");
</ins><span class="cx"> shouldBe("doctype.nodeValue", "null");
</span><span class="cx">
</span><span class="cx"> debug("Element creation using createElement on an HTML doc:")
</span><span class="lines">@@ -160,15 +158,15 @@
</span><span class="cx">
</span><span class="cx"> var processingInstruction = document.createProcessingInstruction('xml-stylesheet', 'type=\"text/xsl\" href=\"missing.xsl\"');
</span><span class="cx"> shouldBe("processingInstruction.nodeName", "'xml-stylesheet'");
</span><del>-shouldBe("processingInstruction.localName", "null");
-shouldBe("processingInstruction.namespaceURI", "null");
-shouldBe("processingInstruction.prefix", "null");
</del><ins>+shouldBeUndefined("processingInstruction.localName");
+shouldBeUndefined("processingInstruction.namespaceURI");
+shouldBeUndefined("processingInstruction.prefix");
</ins><span class="cx">
</span><span class="cx"> processingInstruction = xmlDoc.createProcessingInstruction('xml-stylesheet', 'type="text/xsl" href="missing.xsl"');
</span><span class="cx"> shouldBe("processingInstruction.nodeName", "'xml-stylesheet'");
</span><del>-shouldBe("processingInstruction.localName", "null");
-shouldBe("processingInstruction.namespaceURI", "null");
-shouldBe("processingInstruction.prefix", "null");
</del><ins>+shouldBeUndefined("processingInstruction.localName");
+shouldBeUndefined("processingInstruction.namespaceURI");
+shouldBeUndefined("processingInstruction.prefix");
</ins><span class="cx"> // DOM Core Level 2 and DOM Core Level 3 disagree on ProcessingInstruction.nodeValue
</span><span class="cx"> // L2: entire content excluding the target
</span><span class="cx"> // L3: same as ProcessingInstruction.data
</span><span class="lines">@@ -179,8 +177,8 @@
</span><span class="cx">
</span><span class="cx"> var text = document.createTextNode("foo");
</span><span class="cx"> shouldBe("text.nodeName", "'#text'");
</span><del>-shouldBe("text.localName", "null");
-shouldBe("text.namespaceURI", "null");
-shouldBe("text.prefix", "null");
</del><ins>+shouldBeUndefined("text.localName");
+shouldBeUndefined("text.namespaceURI");
+shouldBeUndefined("text.prefix");
</ins><span class="cx"> shouldBe("text.nodeValue", "'foo'");
</span><span class="cx"> shouldBe("text.data", "'foo'");
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsmisccreateElementNamespace1expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/misc/createElementNamespace1-expected.txt (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/misc/createElementNamespace1-expected.txt 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/http/tests/misc/createElementNamespace1-expected.txt 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -1,8 +1,5 @@
</span><span class="cx"> This test was written to address rdar://problem/4976879. And tests how namespaceURI's are assigned.
</span><span class="cx">
</span><del>-Test1: document.namespaceURI
-PASS: document.namespaceURI should be 'null' and is.
-
</del><span class="cx"> Test2: document.createElement().namespaceURI
</span><span class="cx"> PASS: document.createElement("div").namespaceURI should be 'null' and is.
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsmisccreateElementNamespace1xml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/misc/createElementNamespace1.xml (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/misc/createElementNamespace1.xml 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/http/tests/misc/createElementNamespace1.xml 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -10,10 +10,6 @@
</span><span class="cx"> log("This test was written to address rdar://problem/4976879. And tests how namespaceURI's are assigned.");
</span><span class="cx"> log("");
</span><span class="cx">
</span><del>- log("Test1: document.namespaceURI")
- shouldBe("document.namespaceURI", "null");
- log("");
-
</del><span class="cx"> log("Test2: document.createElement().namespaceURI")
</span><span class="cx"> shouldBe("document.createElement(\"div\").namespaceURI", "null");
</span><span class="cx"> log("");
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsmisccreateElementNamespace2expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/misc/createElementNamespace2-expected.txt (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/misc/createElementNamespace2-expected.txt 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/http/tests/misc/createElementNamespace2-expected.txt 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -1,8 +1,5 @@
</span><span class="cx"> This test was written to address rdar://problem/4976879. And tests how namespaceURI's are assigned.
</span><span class="cx">
</span><del>-Test1: document.namespaceURI
-PASS: document.namespaceURI should be 'null' and is.
-
</del><span class="cx"> Test2: document.createElement().namespaceURI
</span><span class="cx"> PASS: document.createElement("div").namespaceURI should be 'http://www.w3.org/1999/xhtml' and is.
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsmisccreateElementNamespace2xhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/misc/createElementNamespace2.xhtml (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/misc/createElementNamespace2.xhtml 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/http/tests/misc/createElementNamespace2.xhtml 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -8,10 +8,6 @@
</span><span class="cx"> log("This test was written to address rdar://problem/4976879. And tests how namespaceURI's are assigned.");
</span><span class="cx"> log("");
</span><span class="cx">
</span><del>- log("Test1: document.namespaceURI")
- shouldBe("document.namespaceURI", "null");
- log("");
-
</del><span class="cx"> log("Test2: document.createElement().namespaceURI")
</span><span class="cx"> shouldBe("document.createElement(\"div\").namespaceURI", "'http://www.w3.org/1999/xhtml'");
</span><span class="cx"> log("");
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsmisccreateElementNamespace3expectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/misc/createElementNamespace3-expected.txt (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/misc/createElementNamespace3-expected.txt 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/http/tests/misc/createElementNamespace3-expected.txt 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -1,8 +1,5 @@
</span><span class="cx"> This test was written to address rdar://problem/4976879. And tests how namespaceURI's are assigned.
</span><span class="cx">
</span><del>-Test1: document.namespaceURI
-PASS: document.namespaceURI should be 'null' and is.
-
</del><span class="cx"> Test2: document.createElement().namespaceURI
</span><span class="cx"> PASS: document.createElement("div").namespaceURI should be 'http://www.w3.org/1999/xhtml' and is.
</span><span class="cx">
</span><span class="lines">@@ -9,9 +6,6 @@
</span><span class="cx"> Test3: script tag.namespaceURI
</span><span class="cx"> PASS: myScriptTag.namespaceURI should be 'http://www.w3.org/1999/xhtml' and is.
</span><span class="cx">
</span><del>-Test4: created document.namespaceURI
-PASS: newDoc.namespaceURI should be 'null' and is.
-
</del><span class="cx"> Test5: created document.createElement.namespaceURI
</span><span class="cx"> PASS: newDoc.createElement("div").namespaceURI should be 'http://www.w3.org/1999/xhtml' and is.
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsmisccreateElementNamespace3html"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/misc/createElementNamespace3.html (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/misc/createElementNamespace3.html 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/http/tests/misc/createElementNamespace3.html 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -12,10 +12,6 @@
</span><span class="cx"> log("This test was written to address rdar://problem/4976879. And tests how namespaceURI's are assigned.");
</span><span class="cx"> log("");
</span><span class="cx">
</span><del>- log("Test1: document.namespaceURI")
- shouldBe("document.namespaceURI", "null");
- log("");
-
</del><span class="cx"> log("Test2: document.createElement().namespaceURI")
</span><span class="cx"> shouldBe("document.createElement(\"div\").namespaceURI", "'http://www.w3.org/1999/xhtml'");
</span><span class="cx"> log("");
</span><span class="lines">@@ -26,9 +22,6 @@
</span><span class="cx"> log("");
</span><span class="cx">
</span><span class="cx"> var newDoc = document.implementation.createDocument("http://www.w3.org/1999/xhtml", "", null);
</span><del>- log("Test4: created document.namespaceURI");
- shouldBe("newDoc.namespaceURI", "null");
- log("");
</del><span class="cx">
</span><span class="cx"> log("Test5: created document.createElement.namespaceURI");
</span><span class="cx"> shouldBe("newDoc.createElement(\"div\").namespaceURI", "'http://www.w3.org/1999/xhtml'");
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-08-18 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Move prefix / namespaceURI / localName attributes from Node to Attr / Element
+ https://bugs.webkit.org/show_bug.cgi?id=160988
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline several W3C test now that more checks are passing.
+
+ * web-platform-tests/dom/historical-expected.txt:
+ * web-platform-tests/dom/interfaces-expected.txt:
+
+2016-08-18 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Re-sync DOM web platform tests from upstream
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160980
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomhistoricalexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -45,9 +45,9 @@
</span><span class="cx"> PASS Text member must be nuked: replaceWholeText
</span><span class="cx"> PASS Node member must be nuked: hasAttributes
</span><span class="cx"> PASS Node member must be nuked: attributes
</span><del>-FAIL Node member must be nuked: namespaceURI assert_equals: expected (undefined) undefined but got (object) null
-FAIL Node member must be nuked: prefix assert_equals: expected (undefined) undefined but got (object) null
-FAIL Node member must be nuked: localName assert_equals: expected (undefined) undefined but got (object) null
</del><ins>+PASS Node member must be nuked: namespaceURI
+PASS Node member must be nuked: prefix
+PASS Node member must be nuked: localName
</ins><span class="cx"> PASS Node member must be nuked: isSupported
</span><span class="cx"> PASS Node member must be nuked: getFeature
</span><span class="cx"> PASS Node member must be nuked: getUserData
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -732,9 +732,11 @@
</span><span class="cx"> PASS Element interface object name
</span><span class="cx"> PASS Element interface: existence and properties of interface prototype object
</span><span class="cx"> PASS Element interface: existence and properties of interface prototype object's "constructor" property
</span><del>-FAIL Element interface: attribute namespaceURI assert_own_property: expected property "namespaceURI" missing
-FAIL Element interface: attribute prefix assert_own_property: expected property "prefix" missing
-FAIL Element interface: attribute localName assert_own_property: expected property "localName" missing
</del><ins>+PASS Element interface: attribute namespaceURI
+FAIL Element interface: attribute prefix assert_equals: setter must be undefined for readonly attributes expected (undefined) undefined but got (function) function "function prefix() {
+ [native code]
+}"
+PASS Element interface: attribute localName
</ins><span class="cx"> PASS Element interface: attribute tagName
</span><span class="cx"> PASS Element interface: attribute id
</span><span class="cx"> PASS Element interface: attribute className
</span><span class="lines">@@ -947,9 +949,11 @@
</span><span class="cx"> PASS Attr interface object name
</span><span class="cx"> FAIL Attr interface: existence and properties of interface prototype object assert_equals: prototype of Attr.prototype is not Object.prototype expected object "[object Object]" but got object "[object NodePrototype]"
</span><span class="cx"> PASS Attr interface: existence and properties of interface prototype object's "constructor" property
</span><del>-FAIL Attr interface: attribute namespaceURI assert_own_property: expected property "namespaceURI" missing
-FAIL Attr interface: attribute prefix assert_own_property: expected property "prefix" missing
-FAIL Attr interface: attribute localName assert_own_property: expected property "localName" missing
</del><ins>+PASS Attr interface: attribute namespaceURI
+FAIL Attr interface: attribute prefix assert_equals: setter must be undefined for readonly attributes expected (undefined) undefined but got (function) function "function prefix() {
+ [native code]
+}"
+PASS Attr interface: attribute localName
</ins><span class="cx"> PASS Attr interface: attribute name
</span><span class="cx"> FAIL Attr interface: attribute nodeName assert_own_property: expected property "nodeName" missing
</span><span class="cx"> PASS Attr interface: attribute value
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomdomstaticpropertyforiniterationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -104,8 +104,11 @@
</span><span class="cx"> PASS a["attributes"] is [object NamedNodeMap]
</span><span class="cx"> PASS a["style"] is [object CSSStyleDeclaration]
</span><span class="cx"> PASS a["id"] is foo
</span><ins>+PASS a["namespaceURI"] is http://www.w3.org/1999/xhtml
+PASS a["prefix"] is null
+PASS a["localName"] is a
</ins><span class="cx"> PASS a["offsetLeft"] is 8
</span><del>-PASS a["offsetTop"] is 1614
</del><ins>+PASS a["offsetTop"] is 1659
</ins><span class="cx"> PASS a["offsetWidth"] is 40
</span><span class="cx"> PASS a["offsetHeight"] is 18
</span><span class="cx"> PASS a["clientLeft"] is 0
</span><span class="lines">@@ -143,9 +146,6 @@
</span><span class="cx"> PASS a["previousSibling"] is [object Text]
</span><span class="cx"> PASS a["nextSibling"] is [object Text]
</span><span class="cx"> PASS a["ownerDocument"] is [object HTMLDocument]
</span><del>-PASS a["namespaceURI"] is http://www.w3.org/1999/xhtml
-PASS a["prefix"] is null
-PASS a["localName"] is a
</del><span class="cx"> PASS a["textContent"] is nerget
</span><span class="cx"> PASS a["isConnected"] is true
</span><span class="cx"> PASS a["parentElement"] is [object HTMLBodyElement]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/Source/WebCore/ChangeLog 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-08-18 Chris Dumez <cdumez@apple.com>
+
+ Move prefix / namespaceURI / localName attributes from Node to Attr / Element
+ https://bugs.webkit.org/show_bug.cgi?id=160988
+
+ Reviewed by Ryosuke Niwa.
+
+ Move prefix / namespaceURI / localName attributes from Node to Attr / Element
+ as per the latest DOM specification:
+ - https://dom.spec.whatwg.org/#element
+ - https://dom.spec.whatwg.org/#attr
+
+ Firefox and Chrome match the specification.
+
+ No new tests, rebaselined existing tests.
+
+ * dom/Attr.h:
+ * dom/Attr.idl:
+ * dom/Element.h:
+ * dom/Element.idl:
+ * dom/Node.idl:
+
</ins><span class="cx"> 2016-08-18 Jonathan Bedard <jbedard@apple.com>
</span><span class="cx">
</span><span class="cx"> Binding NULL pointer to reference in WebCore::RenderObject
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttrh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.h (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.h 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/Source/WebCore/dom/Attr.h 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -64,8 +64,12 @@
</span><span class="cx"> void attachToElement(Element*);
</span><span class="cx"> void detachFromElementWithValue(const AtomicString&);
</span><span class="cx">
</span><del>- const AtomicString& namespaceURI() const override { return m_name.namespaceURI(); }
</del><ins>+ const AtomicString& namespaceURI() const final { return m_name.namespaceURI(); }
+ const AtomicString& localName() const final { return m_name.localName(); }
+ const AtomicString& prefix() const final { return m_name.prefix(); }
</ins><span class="cx">
</span><ins>+ void setPrefix(const AtomicString&, ExceptionCode&) final;
+
</ins><span class="cx"> private:
</span><span class="cx"> Attr(Element*, const QualifiedName&);
</span><span class="cx"> Attr(Document&, const QualifiedName&, const AtomicString& value);
</span><span class="lines">@@ -75,11 +79,6 @@
</span><span class="cx"> String nodeName() const override { return name(); }
</span><span class="cx"> NodeType nodeType() const override { return ATTRIBUTE_NODE; }
</span><span class="cx">
</span><del>- const AtomicString& localName() const override { return m_name.localName(); }
- const AtomicString& prefix() const override { return m_name.prefix(); }
-
- void setPrefix(const AtomicString&, ExceptionCode&) override;
-
</del><span class="cx"> String nodeValue() const override { return value(); }
</span><span class="cx"> void setNodeValue(const String&, ExceptionCode&) override;
</span><span class="cx"> Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttridl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.idl (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.idl 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/Source/WebCore/dom/Attr.idl 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -39,5 +39,9 @@
</span><span class="cx"> // DOM Level 3
</span><span class="cx">
</span><span class="cx"> readonly attribute boolean isId;
</span><ins>+
+ readonly attribute DOMString? namespaceURI;
+ [SetterRaisesException] attribute DOMString? prefix;
+ readonly attribute DOMString? localName;
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/Source/WebCore/dom/Element.h 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -209,6 +209,8 @@
</span><span class="cx"> const AtomicString& prefix() const final { return m_tagName.prefix(); }
</span><span class="cx"> const AtomicString& namespaceURI() const final { return m_tagName.namespaceURI(); }
</span><span class="cx">
</span><ins>+ void setPrefix(const AtomicString&, ExceptionCode&) final;
+
</ins><span class="cx"> String nodeName() const override;
</span><span class="cx">
</span><span class="cx"> Ref<Element> cloneElementWithChildren(Document&);
</span><span class="lines">@@ -605,7 +607,6 @@
</span><span class="cx">
</span><span class="cx"> void scrollByUnits(int units, ScrollGranularity);
</span><span class="cx">
</span><del>- void setPrefix(const AtomicString&, ExceptionCode&) final;
</del><span class="cx"> NodeType nodeType() const final;
</span><span class="cx"> bool childTypeAllowed(NodeType) const final;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.idl (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.idl 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/Source/WebCore/dom/Element.idl 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -65,6 +65,10 @@
</span><span class="cx"> // DOM 4
</span><span class="cx"> [Reflect] attribute DOMString id;
</span><span class="cx">
</span><ins>+ readonly attribute DOMString? namespaceURI;
+ [SetterRaisesException] attribute DOMString? prefix;
+ readonly attribute DOMString? localName;
+
</ins><span class="cx"> // Common extensions
</span><span class="cx">
</span><span class="cx"> readonly attribute double offsetLeft;
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.idl (204623 => 204624)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.idl 2016-08-19 02:37:52 UTC (rev 204623)
+++ trunk/Source/WebCore/dom/Node.idl 2016-08-19 02:40:11 UTC (rev 204624)
</span><span class="lines">@@ -72,10 +72,6 @@
</span><span class="cx"> [ImplementedAs=isSupportedForBindings] boolean isSupported(optional DOMString feature, optional DOMString version);
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- readonly attribute DOMString? namespaceURI;
- [SetterRaisesException] attribute DOMString? prefix;
- readonly attribute DOMString? localName;
-
</del><span class="cx"> // Introduced in DOM Level 3:
</span><span class="cx">
</span><span class="cx"> readonly attribute USVString baseURI;
</span></span></pre>
</div>
</div>
</body>
</html>