<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204610] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204610">204610</a></dd>
<dt>Author</dt> <dd>bdakin@apple.com</dd>
<dt>Date</dt> <dd>2016-08-18 14:19:26 -0700 (Thu, 18 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update the accessibility titles for list insertion
https://bugs.webkit.org/show_bug.cgi?id=160972
-and corresponding-
rdar://problem/27750446
Reviewed by Chris Fleizach.
Update accessibility titles based on feedback.
* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::insertListTypeNone):
(WebCore::insertListTypeBulleted):
(WebCore::insertListTypeBulletedAccessibilityTitle):
(WebCore::insertListTypeNumbered):
(WebCore::insertListTypeNumberedAccessibilityTitle):
(WebCore::insertListTypeNoneAccessibilityTitle): Deleted.
* platform/LocalizedStrings.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreEnglishlprojLocalizablestrings">trunk/Source/WebCore/English.lproj/Localizable.strings</a></li>
<li><a href="#trunkSourceWebCoreplatformLocalizedStringscpp">trunk/Source/WebCore/platform/LocalizedStrings.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformLocalizedStringsh">trunk/Source/WebCore/platform/LocalizedStrings.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204609 => 204610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-18 21:11:38 UTC (rev 204609)
+++ trunk/Source/WebCore/ChangeLog 2016-08-18 21:19:26 UTC (rev 204610)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-08-18 Beth Dakin <bdakin@apple.com>
+
+ Update the accessibility titles for list insertion
+ https://bugs.webkit.org/show_bug.cgi?id=160972
+ -and corresponding-
+ rdar://problem/27750446
+
+ Reviewed by Chris Fleizach.
+
+ Update accessibility titles based on feedback.
+ * English.lproj/Localizable.strings:
+ * platform/LocalizedStrings.cpp:
+ (WebCore::insertListTypeNone):
+ (WebCore::insertListTypeBulleted):
+ (WebCore::insertListTypeBulletedAccessibilityTitle):
+ (WebCore::insertListTypeNumbered):
+ (WebCore::insertListTypeNumberedAccessibilityTitle):
+ (WebCore::insertListTypeNoneAccessibilityTitle): Deleted.
+ * platform/LocalizedStrings.h:
+
</ins><span class="cx"> 2016-08-18 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Align our encoding labels with the encoding specification
</span></span></pre></div>
<a id="trunkSourceWebCoreEnglishlprojLocalizablestrings"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (204609 => 204610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/English.lproj/Localizable.strings 2016-08-18 21:11:38 UTC (rev 204609)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2016-08-18 21:19:26 UTC (rev 204610)
</span><span class="lines">@@ -31,12 +31,12 @@
</span><span class="cx"> /* Text track display name format that includes the country and language of the subtitle, in the form of 'Title (Language-Country)' */
</span><span class="cx"> "%@ (%@-%@)" = "%@ (%@-%@)";
</span><span class="cx">
</span><ins>+/* Text track contains Audio Descriptions */
+"%@ AD" = "%@ AD";
+
</ins><span class="cx"> /* Text track contains closed captions */
</span><span class="cx"> "%@ CC" = "%@ CC";
</span><span class="cx">
</span><del>-/* Text track contains Audio Descriptions */
-"%@ AD" = "%@ AD";
-
</del><span class="cx"> /* visible name of the database process. The argument is the application name. */
</span><span class="cx"> "%@ Database Storage" = "%@ Database Storage";
</span><span class="cx">
</span><span class="lines">@@ -130,6 +130,9 @@
</span><span class="cx"> /* Undo action name */
</span><span class="cx"> "Bold (Undo action name)" = "Bold";
</span><span class="cx">
</span><ins>+/* Option in segmented control for inserting a bulleted list in text editing */
+"Bulleted list" = "Bulleted list";
+
</ins><span class="cx"> /* menu item title for phone number */
</span><span class="cx"> "Call Using iPhone:" = "Call Using iPhone:";
</span><span class="cx">
</span><span class="lines">@@ -295,12 +298,6 @@
</span><span class="cx"> /* Undo action name */
</span><span class="cx"> "Insert List (Undo action name)" = "Insert List";
</span><span class="cx">
</span><del>-/* Option in segmented control for inserting a bulleted list in text editing */
-"Insert a bulleted list" = "Insert a bulleted list";
-
-/* Option in segmented control for inserting a numbered list in text editing */
-"Insert a numbered list" = "Insert a numbered list";
-
</del><span class="cx"> /* Inspect Element context menu item */
</span><span class="cx"> "Inspect Element" = "Inspect Element";
</span><span class="cx">
</span><span class="lines">@@ -376,9 +373,6 @@
</span><span class="cx"> /* Empty select list */
</span><span class="cx"> "No Options Select Popover" = "No Options";
</span><span class="cx">
</span><del>-/* Accessibility label for not inserting a list in text editing */
-"No list" = "No list";
-
</del><span class="cx"> /* Label for only item in menu that appears when clicking on the search field image, when no searches have been performed */
</span><span class="cx"> "No recent searches" = "No recent searches";
</span><span class="cx">
</span><span class="lines">@@ -388,6 +382,9 @@
</span><span class="cx"> /* WebKitErrorCannotUseRestrictedPort description */
</span><span class="cx"> "Not allowed to use restricted network port" = "Not allowed to use restricted network port";
</span><span class="cx">
</span><ins>+/* Option in segmented control for inserting a numbered list in text editing */
+"Numbered list" = "Numbered list";
+
</ins><span class="cx"> /* OK button label in PDF password failure alert */
</span><span class="cx"> "OK (PDF password failure alert)" = "OK";
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformLocalizedStringscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (204609 => 204610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2016-08-18 21:11:38 UTC (rev 204609)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2016-08-18 21:19:26 UTC (rev 204610)
</span><span class="lines">@@ -1187,11 +1187,6 @@
</span><span class="cx"> return WEB_UI_STRING("None", "Option in segmented control for choosing list type in text editing");
</span><span class="cx"> }
</span><span class="cx">
</span><del>-String insertListTypeNoneAccessibilityTitle()
-{
- return WEB_UI_STRING("No list", "Accessibility label for not inserting a list in text editing");
-}
-
</del><span class="cx"> String insertListTypeBulleted()
</span><span class="cx"> {
</span><span class="cx"> return WEB_UI_STRING("•", "Option in segmented control for choosing list type in text editing");
</span><span class="lines">@@ -1199,7 +1194,7 @@
</span><span class="cx">
</span><span class="cx"> String insertListTypeBulletedAccessibilityTitle()
</span><span class="cx"> {
</span><del>- return WEB_UI_STRING("Insert a bulleted list", "Option in segmented control for inserting a bulleted list in text editing");
</del><ins>+ return WEB_UI_STRING("Bulleted list", "Option in segmented control for inserting a bulleted list in text editing");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String insertListTypeNumbered()
</span><span class="lines">@@ -1209,7 +1204,7 @@
</span><span class="cx">
</span><span class="cx"> String insertListTypeNumberedAccessibilityTitle()
</span><span class="cx"> {
</span><del>- return WEB_UI_STRING("Insert a numbered list", "Option in segmented control for inserting a numbered list in text editing");
</del><ins>+ return WEB_UI_STRING("Numbered list", "Option in segmented control for inserting a numbered list in text editing");
</ins><span class="cx"> }
</span><span class="cx"> #endif // PLATFORM(MAC)
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformLocalizedStringsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/LocalizedStrings.h (204609 => 204610)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/LocalizedStrings.h 2016-08-18 21:11:38 UTC (rev 204609)
+++ trunk/Source/WebCore/platform/LocalizedStrings.h 2016-08-18 21:19:26 UTC (rev 204610)
</span><span class="lines">@@ -282,7 +282,6 @@
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> WEBCORE_EXPORT String insertListTypeNone();
</span><del>- WEBCORE_EXPORT String insertListTypeNoneAccessibilityTitle();
</del><span class="cx"> WEBCORE_EXPORT String insertListTypeBulleted();
</span><span class="cx"> WEBCORE_EXPORT String insertListTypeBulletedAccessibilityTitle();
</span><span class="cx"> WEBCORE_EXPORT String insertListTypeNumbered();
</span></span></pre>
</div>
</div>
</body>
</html>