<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204577] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204577">204577</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-17 15:18:36 -0700 (Wed, 17 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Extra logging for crash reason
https://bugs.webkit.org/show_bug.cgi?id=160943
Patch by Jonathan Bedard <jbedard@apple.com> on 2016-08-17
Reviewed by Alexey Proskuryakov.
A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
* Scripts/webkitpy/port/server_process.py:
(ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
(ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
(ServerProcess.has_crashed): Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpyportserver_processpy">trunk/Tools/Scripts/webkitpy/port/server_process.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (204576 => 204577)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-08-17 22:04:08 UTC (rev 204576)
+++ trunk/Tools/ChangeLog 2016-08-17 22:18:36 UTC (rev 204577)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-08-17 Jonathan Bedard <jbedard@apple.com>
+
+ Extra logging for crash reason
+ https://bugs.webkit.org/show_bug.cgi?id=160943
+
+ Reviewed by Alexey Proskuryakov.
+
+ A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
+
+ * Scripts/webkitpy/port/server_process.py:
+ (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
+ (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
+ (ServerProcess.has_crashed): Ditto.
+
</ins><span class="cx"> 2016-08-17 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpyportserver_processpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/port/server_process.py (204576 => 204577)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/port/server_process.py 2016-08-17 22:04:08 UTC (rev 204576)
+++ trunk/Tools/Scripts/webkitpy/port/server_process.py 2016-08-17 22:18:36 UTC (rev 204577)
</span><span class="lines">@@ -156,6 +156,7 @@
</span><span class="cx"> # stop() calls _reset(), so we have to set crashed to True after calling stop()
</span><span class="cx"> # unless we already know that this is a timeout.
</span><span class="cx"> if not ignore_crash:
</span><ins>+ _log.debug('This test marked as a crash because of a broken pipe when writing to stdin of the server process.')
</ins><span class="cx"> self._crashed = True
</span><span class="cx">
</span><span class="cx"> def _pop_stdout_line_if_ready(self):
</span><span class="lines">@@ -255,6 +256,7 @@
</span><span class="cx"> if out_fd in read_fds:
</span><span class="cx"> data = self._proc.stdout.read()
</span><span class="cx"> if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()):
</span><ins>+ _log.debug('This test marked as a crash because of no data while reading stdout for the server process.')
</ins><span class="cx"> self._crashed = True
</span><span class="cx"> self._output += data
</span><span class="cx">
</span><span class="lines">@@ -261,6 +263,7 @@
</span><span class="cx"> if err_fd in read_fds:
</span><span class="cx"> data = self._proc.stderr.read()
</span><span class="cx"> if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()):
</span><ins>+ _log.debug('This test marked as a crash because of no data while reading stdout for the server process.')
</ins><span class="cx"> self._crashed = True
</span><span class="cx"> self._error += data
</span><span class="cx"> except IOError, e:
</span><span class="lines">@@ -301,6 +304,7 @@
</span><span class="cx">
</span><span class="cx"> def has_crashed(self):
</span><span class="cx"> if not self._crashed and self.poll():
</span><ins>+ _log.debug('This test marked as a crash because of failure to poll the server process.')
</ins><span class="cx"> self._crashed = True
</span><span class="cx"> self._handle_possible_interrupt()
</span><span class="cx"> return self._crashed
</span></span></pre>
</div>
</div>
</body>
</html>