<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204527] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204527">204527</a></dd>
<dt>Author</dt> <dd>aakash_jain@apple.com</dd>
<dt>Date</dt> <dd>2016-08-16 15:24:23 -0700 (Tue, 16 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>EWS logs file are rotated too quickly
https://bugs.webkit.org/show_bug.cgi?id=160724
Reviewed by Daniel Bates.
Currently we are rotating the log file after 10 iterations of queue. If the queue
doesn't have any pending patches, these iterations result in very small amount of
logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
This results in a lot of log files in a day. This patch ensures that we rotate the
log file when its file size is greater than or equal to 100 KB.
* EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsEWSToolsstartqueuemacsh">trunk/Tools/EWSTools/start-queue-mac.sh</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (204526 => 204527)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-08-16 22:20:05 UTC (rev 204526)
+++ trunk/Tools/ChangeLog 2016-08-16 22:24:23 UTC (rev 204527)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-08-16 Aakash Jain <aakash_jain@apple.com>
+
+ EWS logs file are rotated too quickly
+ https://bugs.webkit.org/show_bug.cgi?id=160724
+
+ Reviewed by Daniel Bates.
+
+ Currently we are rotating the log file after 10 iterations of queue. If the queue
+ doesn't have any pending patches, these iterations result in very small amount of
+ logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
+ This results in a lot of log files in a day. This patch ensures that we rotate the
+ log file when its file size is greater than or equal to 100 KB.
+
+ * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
+
</ins><span class="cx"> 2016-08-16 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> WKSI static library should be named by major iOS revision, not individual updates
</span></span></pre></div>
<a id="trunkToolsEWSToolsstartqueuemacsh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/EWSTools/start-queue-mac.sh (204526 => 204527)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/EWSTools/start-queue-mac.sh 2016-08-16 22:20:05 UTC (rev 204526)
+++ trunk/Tools/EWSTools/start-queue-mac.sh 2016-08-16 22:24:23 UTC (rev 204527)
</span><span class="lines">@@ -55,7 +55,10 @@
</span><span class="cx"> cd $EWS_HOME/$QUEUE_NAME-logs
</span><span class="cx"> find . -mtime +30 -delete
</span><span class="cx"> if [ -s $QUEUE_NAME.log ]; then
</span><del>- mv -f $QUEUE_NAME.log ${QUEUE_NAME}_$(date +%Y-%m-%d_%H-%m).log
</del><ins>+ filesize=$(stat -f%z "$QUEUE_NAME.log") # filesize in bytes.
+ if [ $filesize -ge 100000 ]; then
+ mv -f $QUEUE_NAME.log ${QUEUE_NAME}_$(date +%Y-%m-%d_%H-%m).log
+ fi
</ins><span class="cx"> fi
</span><span class="cx"> cd $WEBKIT_HOME
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>