<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204554] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204554">204554</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-08-16 22:48:27 -0700 (Tue, 16 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS WK2] Don't throw touchMove events on the floor
https://bugs.webkit.org/show_bug.cgi?id=160935
Reviewed by Tim Horton.
Source/WebKit2:
EventDispatcher claimed to coalesce touchMove events, but actually threw away any
touchMove if there was one in the queue when the next non-move event came along.
Fix to strictly coalesce touchMove events, so a start/move/end stream always fires
a move event. This is necessary for move-based interaction to work in testing,
for example the added range slider test.
Test: fast/forms/ios/drag-range-thumb.html
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::touchEvent):
LayoutTests:
Test for range slider interaction with synthesized touch events.
* fast/forms/ios/drag-range-thumb-expected.txt: Added.
* fast/forms/ios/drag-range-thumb.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageEventDispatchercpp">trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastformsiosdragrangethumbexpectedtxt">trunk/LayoutTests/fast/forms/ios/drag-range-thumb-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastformsiosdragrangethumbhtml">trunk/LayoutTests/fast/forms/ios/drag-range-thumb.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204553 => 204554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-17 04:42:53 UTC (rev 204553)
+++ trunk/LayoutTests/ChangeLog 2016-08-17 05:48:27 UTC (rev 204554)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-08-16 Simon Fraser <simon.fraser@apple.com>
+
+ [iOS WK2] Don't throw touchMove events on the floor
+ https://bugs.webkit.org/show_bug.cgi?id=160935
+
+ Reviewed by Tim Horton.
+
+ Test for range slider interaction with synthesized touch events.
+
+ * fast/forms/ios/drag-range-thumb-expected.txt: Added.
+ * fast/forms/ios/drag-range-thumb.html: Added.
+
</ins><span class="cx"> 2016-08-16 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> customElements.define should retrieve lifecycle callbacks
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsiosdragrangethumbexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/ios/drag-range-thumb-expected.txt (0 => 204554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/ios/drag-range-thumb-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/ios/drag-range-thumb-expected.txt 2016-08-17 05:48:27 UTC (rev 204554)
</span><span class="lines">@@ -0,0 +1,4 @@
</span><ins>+Tests that a basic range slider works
+
+
+Successfully handled oninput, value is now "456"
</ins></span></pre></div>
<a id="trunkLayoutTestsfastformsiosdragrangethumbhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/ios/drag-range-thumb.html (0 => 204554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/ios/drag-range-thumb.html (rev 0)
+++ trunk/LayoutTests/fast/forms/ios/drag-range-thumb.html 2016-08-17 05:48:27 UTC (rev 204554)
</span><span class="lines">@@ -0,0 +1,71 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
+
+<html>
+<head>
+ <meta name="viewport" content="width=device-width">
+ <style>
+ input[type="range"] {
+ width: 300px;
+ }
+ </style>
+
+ <script src="resources/zooming-test-utils.js"></script>
+ <script>
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
+
+ var uiScriptHasCompleted = false;
+ var oninputHasBeenHandled = false;
+
+ function getUIScript(startX, startY, endX, endY, duration)
+ {
+ return `
+ (function() {
+ uiController.dragFromPointToPoint(${startX}, ${startY}, ${endX}, ${endY}, ${duration}, function() {
+ uiController.uiScriptComplete();
+ });
+ })();`
+ }
+
+ function checkDone()
+ {
+ if (oninputHasBeenHandled && uiScriptHasCompleted)
+ testRunner.notifyDone();
+ }
+
+ function handleValueChanged(value)
+ {
+ document.getElementById("console").textContent = "Successfully handled oninput, value is now \"" + value.toLowerCase() + "\"";
+ oninputHasBeenHandled = true;
+ checkDone();
+ }
+
+ function doTest()
+ {
+ if (!window.testRunner || !testRunner.runUIScript)
+ return;
+
+ var targetElement = document.getElementsByTagName('input')[0];
+ var point = getPointInsideElement(targetElement, 10, 10);
+
+ testRunner.runUIScript(getUIScript(point.x, point.y, point.x + 200, point.y, 0.05), function() {
+ uiScriptHasCompleted = true;
+ checkDone();
+ });
+ }
+
+ window.addEventListener('load', doTest, false);
+ </script>
+</head>
+<body>
+
+<p>Tests that a basic range slider works</p>
+
+<input type="range" min="100" max="600" value="100" oninput="handleValueChanged(this.value)">
+
+<div id="console">Failed to handle oninput<div>
+
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (204553 => 204554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-08-17 04:42:53 UTC (rev 204553)
+++ trunk/Source/WebKit2/ChangeLog 2016-08-17 05:48:27 UTC (rev 204554)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2016-08-16 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ [iOS WK2] Don't throw touchMove events on the floor
+ https://bugs.webkit.org/show_bug.cgi?id=160935
+
+ Reviewed by Tim Horton.
+
+ EventDispatcher claimed to coalesce touchMove events, but actually threw away any
+ touchMove if there was one in the queue when the next non-move event came along.
+
+ Fix to strictly coalesce touchMove events, so a start/move/end stream always fires
+ a move event. This is necessary for move-based interaction to work in testing,
+ for example the added range slider test.
+
+ Test: fast/forms/ios/drag-range-thumb.html
+
+ * WebProcess/WebPage/EventDispatcher.cpp:
+ (WebKit::EventDispatcher::touchEvent):
+
+2016-08-16 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> [iOS WK2] Clean up form select code
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160915
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageEventDispatchercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp (204553 => 204554)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp 2016-08-17 04:42:53 UTC (rev 204553)
+++ trunk/Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp 2016-08-17 05:48:27 UTC (rev 204554)
</span><span class="lines">@@ -180,8 +180,7 @@
</span><span class="cx"> const WebTouchEvent& lastTouchEvent = queuedEvents.last();
</span><span class="cx">
</span><span class="cx"> // Coalesce touch move events.
</span><del>- WebEvent::Type type = lastTouchEvent.type();
- if (type == WebEvent::TouchMove)
</del><ins>+ if (touchEvent.type() == WebEvent::TouchMove && lastTouchEvent.type() == WebEvent::TouchMove)
</ins><span class="cx"> queuedEvents.last() = touchEvent;
</span><span class="cx"> else
</span><span class="cx"> queuedEvents.append(touchEvent);
</span></span></pre>
</div>
</div>
</body>
</html>