<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204528] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204528">204528</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-08-16 15:26:40 -0700 (Tue, 16 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>DOM4: getElementsByClassName should include non StyledElements
https://bugs.webkit.org/show_bug.cgi?id=94718
Reviewed by Ryosuke Niwa.
Source/WebCore:
getElementsByClassName() now includes non StyledElements as per the latest
DOM specification:
- https://dom.spec.whatwg.org/#concept-getelementsbyclassname
The new behavior is consistent with Firefox and Chrome.
Test: fast/dom/getElementsByClassName/non-styled-element.html
* dom/ClassCollection.h:
(WebCore::ClassCollection::elementMatches):
LayoutTests:
* fast/dom/getElementsByClassName/011-expected.txt: Removed.
* fast/dom/getElementsByClassName/011.xml: Removed.
Drop outdated test. It is failing in Firefox and Chrome.
* fast/dom/getElementsByClassName/non-styled-element-expected.txt: Added.
* fast/dom/getElementsByClassName/non-styled-element.html: Added.
Add layout test coverage.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomClassCollectionh">trunk/Source/WebCore/dom/ClassCollection.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomgetElementsByClassNamenonstyledelementexpectedtxt">trunk/LayoutTests/fast/dom/getElementsByClassName/non-styled-element-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomgetElementsByClassNamenonstyledelementhtml">trunk/LayoutTests/fast/dom/getElementsByClassName/non-styled-element.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomgetElementsByClassName011expectedtxt">trunk/LayoutTests/fast/dom/getElementsByClassName/011-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomgetElementsByClassName011xml">trunk/LayoutTests/fast/dom/getElementsByClassName/011.xml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204527 => 204528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-16 22:24:23 UTC (rev 204527)
+++ trunk/LayoutTests/ChangeLog 2016-08-16 22:26:40 UTC (rev 204528)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-08-16 Chris Dumez <cdumez@apple.com>
+
+ DOM4: getElementsByClassName should include non StyledElements
+ https://bugs.webkit.org/show_bug.cgi?id=94718
+
+ Reviewed by Ryosuke Niwa.
+
+ * fast/dom/getElementsByClassName/011-expected.txt: Removed.
+ * fast/dom/getElementsByClassName/011.xml: Removed.
+ Drop outdated test. It is failing in Firefox and Chrome.
+
+ * fast/dom/getElementsByClassName/non-styled-element-expected.txt: Added.
+ * fast/dom/getElementsByClassName/non-styled-element.html: Added.
+ Add layout test coverage.
+
</ins><span class="cx"> 2016-08-16 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Make it possible to test iOS select elements, and add iPhone and iPad tests for them
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomgetElementsByClassName011expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/dom/getElementsByClassName/011-expected.txt (204527 => 204528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/getElementsByClassName/011-expected.txt 2016-08-16 22:24:23 UTC (rev 204527)
+++ trunk/LayoutTests/fast/dom/getElementsByClassName/011-expected.txt 2016-08-16 22:26:40 UTC (rev 204528)
</span><span class="lines">@@ -1,3 +0,0 @@
</span><del>-PASS
-
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastdomgetElementsByClassName011xml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/dom/getElementsByClassName/011.xml (204527 => 204528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/getElementsByClassName/011.xml 2016-08-16 22:24:23 UTC (rev 204527)
+++ trunk/LayoutTests/fast/dom/getElementsByClassName/011.xml 2016-08-16 22:26:40 UTC (rev 204528)
</span><span class="lines">@@ -1,19 +0,0 @@
</span><del>-<html xmlns="http://www.w3.org/1999/xhtml" xmlns:g="http://www.w3.org/2000/svg" xmlns:h="http://www.w3.org/1999/xhtml" xmlns:t="http://tc.labs.opera.com/#test">
- <head>
- <title>document.getElementsByClassName(): "tricky" compound</title>
- <script src="resources/common.js"></script>
- </head>
- <body>
- <p id="r">FAIL (script did not run)</p>
- <x class="a"/>
- <g:x class="a"/>
- <x t:class="a" h:class="a" g:class="a"/>
- <g:x t:class="a" h:class="a" g:class="a"/>
- <t:x class="a" t:class="a" h:class="a" g:class="a"/>
- <script>
- var collection = document.getElementsByClassName("a"),
- test = document.getElementsByTagNameNS("*", "x")
- t(collection, [test[0], test[1]])
- </script>
- </body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsfastdomgetElementsByClassNamenonstyledelementexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/getElementsByClassName/non-styled-element-expected.txt (0 => 204528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/getElementsByClassName/non-styled-element-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/getElementsByClassName/non-styled-element-expected.txt 2016-08-16 22:26:40 UTC (rev 204528)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+Tests that getElementsByClassName() is able to return non-styled elements
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS collection.length is 1
+PASS collection[0] is nonStyledElement
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomgetElementsByClassNamenonstyledelementhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/getElementsByClassName/non-styled-element.html (0 => 204528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/getElementsByClassName/non-styled-element.html (rev 0)
+++ trunk/LayoutTests/fast/dom/getElementsByClassName/non-styled-element.html 2016-08-16 22:26:40 UTC (rev 204528)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that getElementsByClassName() is able to return non-styled elements");
+
+var nonStyledElement = document.createElementNS(null, "test");
+nonStyledElement.classList = "myClass";
+document.body.appendChild(nonStyledElement);
+
+var collection = document.getElementsByClassName("myClass");
+shouldBe("collection.length", "1");
+shouldBe("collection[0]", "nonStyledElement");
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+<body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204527 => 204528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-16 22:24:23 UTC (rev 204527)
+++ trunk/Source/WebCore/ChangeLog 2016-08-16 22:26:40 UTC (rev 204528)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-08-16 Chris Dumez <cdumez@apple.com>
+
+ DOM4: getElementsByClassName should include non StyledElements
+ https://bugs.webkit.org/show_bug.cgi?id=94718
+
+ Reviewed by Ryosuke Niwa.
+
+ getElementsByClassName() now includes non StyledElements as per the latest
+ DOM specification:
+ - https://dom.spec.whatwg.org/#concept-getelementsbyclassname
+
+ The new behavior is consistent with Firefox and Chrome.
+
+ Test: fast/dom/getElementsByClassName/non-styled-element.html
+
+ * dom/ClassCollection.h:
+ (WebCore::ClassCollection::elementMatches):
+
</ins><span class="cx"> 2016-08-16 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Cleanup WK2 platform gamepad handling.
</span></span></pre></div>
<a id="trunkSourceWebCoredomClassCollectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ClassCollection.h (204527 => 204528)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ClassCollection.h 2016-08-16 22:24:23 UTC (rev 204527)
+++ trunk/Source/WebCore/dom/ClassCollection.h 2016-08-16 22:26:40 UTC (rev 204528)
</span><span class="lines">@@ -62,12 +62,8 @@
</span><span class="cx"> {
</span><span class="cx"> if (!element.hasClass())
</span><span class="cx"> return false;
</span><del>- if (!m_classNames.size())
</del><ins>+ if (m_classNames.isEmpty())
</ins><span class="cx"> return false;
</span><del>- // FIXME: DOM4 allows getElementsByClassName to return non StyledElement.
- // https://bugs.webkit.org/show_bug.cgi?id=94718
- if (!element.isStyledElement())
- return false;
</del><span class="cx"> return element.classNames().containsAll(m_classNames);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>