<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204490] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204490">204490</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-15 18:34:36 -0700 (Mon, 15 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Error/Warning icons are misplaced in the Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=160875
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-08-15
Reviewed by Matt Baker.
* UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder): Deleted.
Reworked to apply more generally to editors without titles.
* UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container.missing-dependency > .visual-style-property-editor-warning):
(.visual-style-property-container.invalid-value > .visual-style-property-editor-warning):
(.visual-style-property-container:matches(.missing-dependency, .invalid-value) > *:first-child:matches(.visual-style-property-value-container)):
(.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container) > .visual-style-special-property-placeholder):
(.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency): Deleted.
(.visual-style-property-container > .visual-style-property-editor-warning.invalid-value): Deleted.
Reworked class names to be on the element container instead of the icon.
* UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor.prototype.update):
(WebInspector.VisualStylePropertyEditor.prototype.updateEditorValues):
(WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleCommaSeparatedKeywordEditorcss">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStylePropertyEditorcss">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStylePropertyEditorjs">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (204489 => 204490)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-08-15 23:32:03 UTC (rev 204489)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-08-16 01:34:36 UTC (rev 204490)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-08-15 Devin Rousso <dcrousso+webkit@gmail.com>
+
+ Web Inspector: Error/Warning icons are misplaced in the Visual sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=160875
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
+ (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder): Deleted.
+ Reworked to apply more generally to editors without titles.
+
+ * UserInterface/Views/VisualStylePropertyEditor.css:
+ (.visual-style-property-container.missing-dependency > .visual-style-property-editor-warning):
+ (.visual-style-property-container.invalid-value > .visual-style-property-editor-warning):
+ (.visual-style-property-container:matches(.missing-dependency, .invalid-value) > *:first-child:matches(.visual-style-property-value-container)):
+ (.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container) > .visual-style-special-property-placeholder):
+ (.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency): Deleted.
+ (.visual-style-property-container > .visual-style-property-editor-warning.invalid-value): Deleted.
+ Reworked class names to be on the element container instead of the icon.
+
+ * UserInterface/Views/VisualStylePropertyEditor.js:
+ (WebInspector.VisualStylePropertyEditor.prototype.update):
+ (WebInspector.VisualStylePropertyEditor.prototype.updateEditorValues):
+ (WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
+ (WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):
+
</ins><span class="cx"> 2016-08-15 Saam Barati <sbarati@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Introduce a method to enable code coverage profiler without enabling type profiler
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleCommaSeparatedKeywordEditorcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css (204489 => 204490)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2016-08-15 23:32:03 UTC (rev 204489)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2016-08-16 01:34:36 UTC (rev 204490)
</span><span class="lines">@@ -32,10 +32,6 @@
</span><span class="cx"> overflow: auto;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder {
- display: none;
-}
-
</del><span class="cx"> .visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list {
</span><span class="cx"> min-height: 51px;
</span><span class="cx"> max-height: 94px;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStylePropertyEditorcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css (204489 => 204490)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css 2016-08-15 23:32:03 UTC (rev 204489)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.css 2016-08-16 01:34:36 UTC (rev 204490)
</span><span class="lines">@@ -67,12 +67,12 @@
</span><span class="cx"> margin-left: 4px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency {
</del><ins>+.visual-style-property-container.missing-dependency > .visual-style-property-editor-warning {
</ins><span class="cx"> display: block;
</span><span class="cx"> content: url(../Images/Warning.svg);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.visual-style-property-container > .visual-style-property-editor-warning.invalid-value {
</del><ins>+.visual-style-property-container.invalid-value > .visual-style-property-editor-warning {
</ins><span class="cx"> display: block;
</span><span class="cx"> content: url(../Images/Error.svg);
</span><span class="cx"> }
</span><span class="lines">@@ -92,6 +92,10 @@
</span><span class="cx"> opacity: 0.4;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.visual-style-property-container:matches(.missing-dependency, .invalid-value) > *:first-child:matches(.visual-style-property-value-container) {
+ margin-left: 2px;
+}
+
</ins><span class="cx"> .visual-style-property-container > .visual-style-property-value-container select {
</span><span class="cx"> width: 100%;
</span><span class="cx"> margin: 1px 0;
</span><span class="lines">@@ -124,6 +128,10 @@
</span><span class="cx"> z-index: 1;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container) > .visual-style-special-property-placeholder {
+ display: none;
+}
+
</ins><span class="cx"> .visual-style-property-info-popover {
</span><span class="cx"> width: 190px;
</span><span class="cx"> margin: 0 5px 3px;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStylePropertyEditorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.js (204489 => 204490)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.js 2016-08-15 23:32:03 UTC (rev 204489)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.js 2016-08-16 01:34:36 UTC (rev 204490)
</span><span class="lines">@@ -291,7 +291,7 @@
</span><span class="cx"> this._representedProperty = property;
</span><span class="cx">
</span><span class="cx"> if (!propertyMissing && property && !property.valid) {
</span><del>- this._warningElement.classList.add("invalid-value");
</del><ins>+ this._element.classList.add("invalid-value");
</ins><span class="cx"> this._warningElement.title = WebInspector.UIString("The value “%s” is not supported for this property.").format(propertyText);
</span><span class="cx"> this.specialPropertyPlaceholderElementText = propertyText;
</span><span class="cx"> return;
</span><span class="lines">@@ -326,7 +326,7 @@
</span><span class="cx"> this._lastValue = this.synthesizedValue;
</span><span class="cx"> this.disabled = false;
</span><span class="cx">
</span><del>- this._warningElement.classList.remove("invalid-value");
</del><ins>+ this._element.classList.remove("invalid-value");
</ins><span class="cx"> this._checkDependencies();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -501,7 +501,7 @@
</span><span class="cx"> this._specialPropertyPlaceholderElement.hidden = true;
</span><span class="cx">
</span><span class="cx"> this._checkDependencies();
</span><del>- this._warningElement.classList.remove("invalid-value");
</del><ins>+ this._element.classList.remove("invalid-value");
</ins><span class="cx">
</span><span class="cx"> this.dispatchEventToListeners(WebInspector.VisualStylePropertyEditor.Event.ValueDidChange);
</span><span class="cx"> return true;
</span><span class="lines">@@ -532,7 +532,7 @@
</span><span class="cx"> _checkDependencies()
</span><span class="cx"> {
</span><span class="cx"> if (!this._dependencies.size || !this._style || !this.synthesizedValue) {
</span><del>- this._warningElement.classList.remove("missing-dependency");
</del><ins>+ this._element.classList.remove("missing-dependency");
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -548,7 +548,7 @@
</span><span class="cx"> title += "\n " + property.name + ": " + dependencyValues.join("/");
</span><span class="cx"> }
</span><span class="cx">
</span><del>- this._warningElement.classList.toggle("missing-dependency", !!title.length);
</del><ins>+ this._element.classList.toggle("missing-dependency", !!title.length);
</ins><span class="cx"> this._warningElement.title = !!title.length ? WebInspector.UIString("Missing Dependencies:%s").format(title) : null;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>