<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204496] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204496">204496</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-15 22:14:17 -0700 (Mon, 15 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Large class lists are not easily discoverable with "Classes" quick-toggle
https://bugs.webkit.org/show_bug.cgi?id=160856
Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-08-15
Reviewed by Joseph Pecoraro.
* UserInterface/Base/DOMUtilities.js:
(WebInspector.linkifyNodeReference):
Add option to truncate the text of the linkified node.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
Increase the max-height to partially show additional classes if many are set.
* UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
Trucate the name of inherited nodes so they don't take up as much space in the sidebar.
* UserInterface/Views/VisualStyleSelectorSection.css:
(.details-section.visual-style-selector-section > .header > .current-selector): Deleted.
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles): Deleted.
Removed since they are already inherited.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseDOMUtilitiesjs">trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDetailsSidebarPanelcss">trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsRulesStyleDetailsPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleSelectorSectioncss">trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (204495 => 204496)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-08-16 04:17:36 UTC (rev 204495)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-08-16 05:14:17 UTC (rev 204496)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2016-08-15 Devin Rousso <dcrousso+webkit@gmail.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Large class lists are not easily discoverable with "Classes" quick-toggle
+ https://bugs.webkit.org/show_bug.cgi?id=160856
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Base/DOMUtilities.js:
+ (WebInspector.linkifyNodeReference):
+ Add option to truncate the text of the linkified node.
+
+ * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
+ (.sidebar > .panel.details.css-style > .content ~ .class-list-container):
+ Increase the max-height to partially show additional classes if many are set.
+
+ * UserInterface/Views/RulesStyleDetailsPanel.js:
+ (WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
+ Trucate the name of inherited nodes so they don't take up as much space in the sidebar.
+
+ * UserInterface/Views/VisualStyleSelectorSection.css:
+ (.details-section.visual-style-selector-section > .header > .current-selector): Deleted.
+ (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles): Deleted.
+ Removed since they are already inherited.
+
+2016-08-15 Devin Rousso <dcrousso+webkit@gmail.com>
+
</ins><span class="cx"> Web Inspector: Close button on selected item in Network tab is misaligned
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160884
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseDOMUtilitiesjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js (204495 => 204496)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js 2016-08-16 04:17:36 UTC (rev 204495)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js 2016-08-16 05:14:17 UTC (rev 204496)
</span><span class="lines">@@ -87,11 +87,13 @@
</span><span class="cx"> return link;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-WebInspector.linkifyNodeReference = function(node)
</del><ins>+WebInspector.linkifyNodeReference = function(node, maxLength)
</ins><span class="cx"> {
</span><del>- var displayName = WebInspector.displayNameForNode(node);
</del><ins>+ let displayName = WebInspector.displayNameForNode(node);
+ if (!isNaN(maxLength))
+ displayName = displayName.truncate(maxLength);
</ins><span class="cx">
</span><del>- var link = document.createElement("span");
</del><ins>+ let link = document.createElement("span");
</ins><span class="cx"> link.append(displayName);
</span><span class="cx"> link.setAttribute("role", "link");
</span><span class="cx"> link.className = "node-link";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDetailsSidebarPanelcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css (204495 => 204496)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2016-08-16 04:17:36 UTC (rev 204495)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2016-08-16 05:14:17 UTC (rev 204496)
</span><span class="lines">@@ -125,7 +125,7 @@
</span><span class="cx"> .sidebar > .panel.details.css-style > .content ~ .class-list-container {
</span><span class="cx"> flex-wrap: wrap;
</span><span class="cx"> bottom: var(--console-prompt-min-height);
</span><del>- max-height: 65px;
</del><ins>+ max-height: 75px;
</ins><span class="cx"> padding: 3px 2px;
</span><span class="cx"> overflow-y: scroll;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsRulesStyleDetailsPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js (204495 => 204496)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js 2016-08-16 04:17:36 UTC (rev 204495)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js 2016-08-16 05:14:17 UTC (rev 204496)
</span><span class="lines">@@ -180,7 +180,7 @@
</span><span class="cx"> var inheritedLabel = document.createElement("div");
</span><span class="cx"> inheritedLabel.className = "label";
</span><span class="cx"> inheritedLabel.appendChild(prefixElement);
</span><del>- inheritedLabel.appendChild(WebInspector.linkifyNodeReference(style.node));
</del><ins>+ inheritedLabel.appendChild(WebInspector.linkifyNodeReference(style.node, 100));
</ins><span class="cx"> newDOMFragment.appendChild(inheritedLabel);
</span><span class="cx">
</span><span class="cx"> hasMediaOrInherited.push(inheritedLabel);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsVisualStyleSelectorSectioncss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.css (204495 => 204496)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.css 2016-08-16 04:17:36 UTC (rev 204495)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.css 2016-08-16 05:14:17 UTC (rev 204496)
</span><span class="lines">@@ -42,9 +42,6 @@
</span><span class="cx"> width: calc(100% - 95px);
</span><span class="cx"> margin-left: 10px;
</span><span class="cx"> font-weight: normal;
</span><del>- white-space: nowrap;
- overflow: hidden;
- text-overflow: ellipsis;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .visual-style-selector-section.details-section:not(.collapsed) > .header > .current-selector {
</span><span class="lines">@@ -114,12 +111,6 @@
</span><span class="cx"> display: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles {
- overflow: hidden;
- white-space: nowrap;
- text-overflow: ellipsis;
-}
-
</del><span class="cx"> .details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider ~ .visual-style-selector-item:nth-child(even) {
</span><span class="cx"> background-color: hsl(0, 100%, 100%);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>