<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204440] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204440">204440</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-12 20:05:34 -0700 (Fri, 12 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove always true JSC::Debugger::needPauseHandling virtual method
https://bugs.webkit.org/show_bug.cgi?id=160822
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-08-12
Reviewed by Mark Lam.
Source/JavaScriptCore:
All subclasses return true for this method. Just remove the method.
* debugger/Debugger.cpp:
(JSC::Debugger::pauseIfNeeded):
* inspector/ScriptDebugServer.h:
Source/WebKit/mac:
* WebView/WebScriptDebugger.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredebuggerDebuggercpp">trunk/Source/JavaScriptCore/debugger/Debugger.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredebuggerDebuggerh">trunk/Source/JavaScriptCore/debugger/Debugger.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorScriptDebugServerh">trunk/Source/JavaScriptCore/inspector/ScriptDebugServer.h</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebScriptDebuggerh">trunk/Source/WebKit/mac/WebView/WebScriptDebugger.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (204439 => 204440)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-08-13 02:14:42 UTC (rev 204439)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-08-13 03:05:34 UTC (rev 204440)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-08-12 Joseph Pecoraro <pecoraro@apple.com>
+
+ Remove always true JSC::Debugger::needPauseHandling virtual method
+ https://bugs.webkit.org/show_bug.cgi?id=160822
+
+ Reviewed by Mark Lam.
+
+ All subclasses return true for this method. Just remove the method.
+
+ * debugger/Debugger.cpp:
+ (JSC::Debugger::pauseIfNeeded):
+ * inspector/ScriptDebugServer.h:
+
</ins><span class="cx"> 2016-08-12 Saam Barati <sbarati@apple.com>
</span><span class="cx">
</span><span class="cx"> Inline store loop for CopyRest in DFG and FTL for certain array modes
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredebuggerDebuggercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/debugger/Debugger.cpp (204439 => 204440)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/debugger/Debugger.cpp 2016-08-13 02:14:42 UTC (rev 204439)
+++ trunk/Source/JavaScriptCore/debugger/Debugger.cpp 2016-08-13 03:05:34 UTC (rev 204440)
</span><span class="lines">@@ -629,10 +629,6 @@
</span><span class="cx"> if (m_suppressAllPauses)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- JSGlobalObject* vmEntryGlobalObject = callFrame->vmEntryGlobalObject();
- if (!needPauseHandling(vmEntryGlobalObject))
- return;
-
</del><span class="cx"> Breakpoint breakpoint;
</span><span class="cx"> bool didHitBreakpoint = false;
</span><span class="cx"> bool pauseNow = m_pauseOnNextStatement;
</span><span class="lines">@@ -650,8 +646,9 @@
</span><span class="cx"> // Make sure we are not going to pause again on breakpoint actions by
</span><span class="cx"> // reseting the pause state before executing any breakpoint actions.
</span><span class="cx"> TemporaryPausedState pausedState(*this);
</span><del>- m_pauseOnCallFrame = 0;
</del><ins>+ m_pauseOnCallFrame = nullptr;
</ins><span class="cx"> m_pauseOnNextStatement = false;
</span><ins>+ JSGlobalObject* vmEntryGlobalObject = callFrame->vmEntryGlobalObject();
</ins><span class="cx">
</span><span class="cx"> if (didHitBreakpoint) {
</span><span class="cx"> handleBreakpointHit(vmEntryGlobalObject, breakpoint);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredebuggerDebuggerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/debugger/Debugger.h (204439 => 204440)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/debugger/Debugger.h 2016-08-13 02:14:42 UTC (rev 204439)
+++ trunk/Source/JavaScriptCore/debugger/Debugger.h 2016-08-13 03:05:34 UTC (rev 204440)
</span><span class="lines">@@ -144,7 +144,6 @@
</span><span class="cx"> void didEvaluateScript(double startTime, ProfilingReason);
</span><span class="cx">
</span><span class="cx"> protected:
</span><del>- virtual bool needPauseHandling(JSGlobalObject*) { return false; }
</del><span class="cx"> virtual void handleBreakpointHit(JSGlobalObject*, const Breakpoint&) { }
</span><span class="cx"> virtual void handleExceptionInBreakpointCondition(ExecState*, Exception*) const { }
</span><span class="cx"> virtual void handlePause(JSGlobalObject*, ReasonForPause) { }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorScriptDebugServerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/ScriptDebugServer.h (204439 => 204440)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/ScriptDebugServer.h 2016-08-13 02:14:42 UTC (rev 204439)
+++ trunk/Source/JavaScriptCore/inspector/ScriptDebugServer.h 2016-08-13 03:05:34 UTC (rev 204440)
</span><span class="lines">@@ -93,7 +93,6 @@
</span><span class="cx"> typedef HashMap<JSC::BreakpointID, BreakpointActions> BreakpointIDToActionsMap;
</span><span class="cx">
</span><span class="cx"> void sourceParsed(JSC::ExecState*, JSC::SourceProvider*, int errorLine, const String& errorMsg) final;
</span><del>- bool needPauseHandling(JSC::JSGlobalObject*) final { return true; }
</del><span class="cx"> void handleBreakpointHit(JSC::JSGlobalObject*, const JSC::Breakpoint&) final;
</span><span class="cx"> void handleExceptionInBreakpointCondition(JSC::ExecState*, JSC::Exception*) const final;
</span><span class="cx"> void handlePause(JSC::JSGlobalObject*, JSC::Debugger::ReasonForPause) final;
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (204439 => 204440)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-08-13 02:14:42 UTC (rev 204439)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-08-13 03:05:34 UTC (rev 204440)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-08-12 Joseph Pecoraro <pecoraro@apple.com>
+
+ Remove always true JSC::Debugger::needPauseHandling virtual method
+ https://bugs.webkit.org/show_bug.cgi?id=160822
+
+ Reviewed by Mark Lam.
+
+ * WebView/WebScriptDebugger.h:
+
</ins><span class="cx"> 2016-08-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Regression(r204268): Mail crashes when trying to compose an email
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebScriptDebuggerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebScriptDebugger.h (204439 => 204440)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebScriptDebugger.h 2016-08-13 02:14:42 UTC (rev 204439)
+++ trunk/Source/WebKit/mac/WebView/WebScriptDebugger.h 2016-08-13 03:05:34 UTC (rev 204440)
</span><span class="lines">@@ -57,7 +57,6 @@
</span><span class="cx"> private:
</span><span class="cx"> void sourceParsed(JSC::ExecState*, JSC::SourceProvider*, int errorLine, const WTF::String& errorMsg) override;
</span><span class="cx"> void handlePause(JSC::JSGlobalObject*, JSC::Debugger::ReasonForPause) override;
</span><del>- bool needPauseHandling(JSC::JSGlobalObject*) override { return true; }
</del><span class="cx">
</span><span class="cx"> bool m_callingDelegate;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>