<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204371] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204371">204371</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-11 03:22:06 -0700 (Thu, 11 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=160689
<rdar://problem/24025664>
Patch by Antoine Quint <graouts@apple.com> on 2016-08-11
Reviewed by Dean Jackson.
When the test samples 25th pixel it expect the value to be exactly 25% interpolation of the color values.
However, the sampling location is the center of the pixel, i.e. it should correspond to 25.5% interpolation,
which would expect the color of (189.975, 189.75, 65.25, 65.25). The new values are a rounded values of
interpolation “by hand” at steps of 25.5%, 50.5% and 75.5%.
LayoutTests/imported/w3c:
* canvas/2d.gradient.interpolate.colouralpha.html:
LayoutTests:
* canvas/philip/tests/2d.gradient.interpolate.colouralpha.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestscanvasphiliptests2dgradientinterpolatecolouralphahtml">trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3ccanvas2dgradientinterpolatecolouralphahtml">trunk/LayoutTests/imported/w3c/canvas/2d.gradient.interpolate.colouralpha.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204370 => 204371)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-11 03:35:01 UTC (rev 204370)
+++ trunk/LayoutTests/ChangeLog 2016-08-11 10:22:06 UTC (rev 204371)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-08-11 Antoine Quint <graouts@apple.com>
+
+ Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
+ https://bugs.webkit.org/show_bug.cgi?id=160689
+ <rdar://problem/24025664>
+
+ Reviewed by Dean Jackson.
+
+ When the test samples 25th pixel it expect the value to be exactly 25% interpolation of the color values.
+ However, the sampling location is the center of the pixel, i.e. it should correspond to 25.5% interpolation,
+ which would expect the color of (189.975, 189.75, 65.25, 65.25). The new values are a rounded values of
+ interpolation “by hand” at steps of 25.5%, 50.5% and 75.5%.
+
+ * canvas/philip/tests/2d.gradient.interpolate.colouralpha.html:
+
</ins><span class="cx"> 2016-08-10 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Should be able to Edit Node Attributes and Styles for non-UserAgent Shadow DOM nodes
</span></span></pre></div>
<a id="trunkLayoutTestscanvasphiliptests2dgradientinterpolatecolouralphahtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html (204370 => 204371)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html 2016-08-11 03:35:01 UTC (rev 204370)
+++ trunk/LayoutTests/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html 2016-08-11 10:22:06 UTC (rev 204371)
</span><span class="lines">@@ -17,9 +17,9 @@
</span><span class="cx"> g.addColorStop(1, 'rgba(0,0,255, 1)');
</span><span class="cx"> ctx.fillStyle = g;
</span><span class="cx"> ctx.fillRect(0, 0, 100, 50);
</span><del>-_assertPixelApprox(canvas, 25,25, 191,191,63,63, "25,25", "191,191,63,63", 3);
-_assertPixelApprox(canvas, 50,25, 127,127,127,127, "50,25", "127,127,127,127", 3);
-_assertPixelApprox(canvas, 75,25, 63,63,191,191, "75,25", "63,63,191,191", 3);
</del><ins>+_assertPixelApprox(canvas, 25,25, 190,190,65,65, "25,25", "190,190,65,65", 3);
+_assertPixelApprox(canvas, 50,25, 126,126,128,128, "50,25", "126,126,128,128", 3);
+_assertPixelApprox(canvas, 75,25, 62,62,192,192, "75,25", "62,62,192,192", 3);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> });
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204370 => 204371)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-11 03:35:01 UTC (rev 204370)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-11 10:22:06 UTC (rev 204371)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-08-11 Antoine Quint <graouts@apple.com>
+
+ Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
+ https://bugs.webkit.org/show_bug.cgi?id=160689
+ <rdar://problem/24025664>
+
+ Reviewed by Dean Jackson.
+
+ When the test samples 25th pixel it expect the value to be exactly 25% interpolation of the color values.
+ However, the sampling location is the center of the pixel, i.e. it should correspond to 25.5% interpolation,
+ which would expect the color of (189.975, 189.75, 65.25, 65.25). The new values are a rounded values of
+ interpolation “by hand” at steps of 25.5%, 50.5% and 75.5%.
+
+ * canvas/2d.gradient.interpolate.colouralpha.html:
+
</ins><span class="cx"> 2016-08-10 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Pull in recent upstream web-platform-tests changes for dom/ and html/
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3ccanvas2dgradientinterpolatecolouralphahtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/canvas/2d.gradient.interpolate.colouralpha.html (204370 => 204371)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/canvas/2d.gradient.interpolate.colouralpha.html 2016-08-11 03:35:01 UTC (rev 204370)
+++ trunk/LayoutTests/imported/w3c/canvas/2d.gradient.interpolate.colouralpha.html 2016-08-11 10:22:06 UTC (rev 204371)
</span><span class="lines">@@ -26,9 +26,9 @@
</span><span class="cx"> g.addColorStop(1, 'rgba(0,0,255, 1)');
</span><span class="cx"> ctx.fillStyle = g;
</span><span class="cx"> ctx.fillRect(0, 0, 100, 50);
</span><del>-_assertPixelApprox(canvas, 25,25, 191,191,63,63, "25,25", "191,191,63,63", 3);
-_assertPixelApprox(canvas, 50,25, 127,127,127,127, "50,25", "127,127,127,127", 3);
-_assertPixelApprox(canvas, 75,25, 63,63,191,191, "75,25", "63,63,191,191", 3);
</del><ins>+_assertPixelApprox(canvas, 25,25, 190,190,65,65, "25,25", "190,190,65,65", 3);
+_assertPixelApprox(canvas, 50,25, 126,126,128,128, "50,25", "126,126,128,128", 3);
+_assertPixelApprox(canvas, 75,25, 62,62,192,192, "75,25", "62,62,192,192", 3);
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> });
</span></span></pre>
</div>
</div>
</body>
</html>