<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204378] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204378">204378</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-08-11 11:14:05 -0700 (Thu, 11 Aug 2016)</dd>
</dl>

<h3>Log Message</h3>
<pre>[iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
https://bugs.webkit.org/show_bug.cgi?id=160761

Reviewed by Tim Horton.

Give iOS DRT a Launch storyboard.

Have it use a UIViewController so future forms testing works correctly.

Add TARGETED_DEVICE_FAMILY = &quot;1,2&quot; to the build settings for the .app, so that it
can run in iPad mode.

Remove empty InfoPlist.strings files.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/ios/Info.plist:
* DumpRenderTree/ios/Launch.storyboard: Added.
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreeDumpRenderTreexcodeprojprojectpbxproj">trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkToolsDumpRenderTreeiosInfoplist">trunk/Tools/DumpRenderTree/ios/Info.plist</a></li>
<li><a href="#trunkToolsDumpRenderTreemacConfigurationsDumpRenderTreeAppxcconfig">trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig</a></li>
<li><a href="#trunkToolsDumpRenderTreemacDumpRenderTreemm">trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
<li><a href="#trunkToolsWebKitTestRunnerWebKitTestRunnerxcodeprojprojectpbxproj">trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkToolsWebKitTestRunneriosPlatformWebViewIOSmm">trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkToolsDumpRenderTreeiosLaunchstoryboard">trunk/Tools/DumpRenderTree/ios/Launch.storyboard</a></li>
</ul>

<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkToolsWebKitTestRunnerWebKitTestRunnerAppenlprojInfoPliststrings">trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (204377 => 204378)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2016-08-11 17:48:57 UTC (rev 204377)
+++ trunk/Tools/ChangeLog        2016-08-11 18:14:05 UTC (rev 204378)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-08-10  Simon Fraser  &lt;simon.fraser@apple.com&gt;
+
+        [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
+        https://bugs.webkit.org/show_bug.cgi?id=160761
+
+        Reviewed by Tim Horton.
+
+        Give iOS DRT a Launch storyboard.
+
+        Have it use a UIViewController so future forms testing works correctly.
+
+        Add TARGETED_DEVICE_FAMILY = &quot;1,2&quot; to the build settings for the .app, so that it
+        can run in iPad mode.
+
+        Remove empty InfoPlist.strings files.
+
+        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+        * DumpRenderTree/ios/Info.plist:
+        * DumpRenderTree/ios/Launch.storyboard: Added.
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (createWebViewAndOffscreenWindow):
+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+        * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
+        * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
+        (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
+
</ins><span class="cx"> 2016-08-11  Per Arne Vollan  &lt;pvollan@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [Win] Unable to reliably run tests in parallel
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeDumpRenderTreexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (204377 => 204378)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj        2016-08-11 17:48:57 UTC (rev 204377)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj        2016-08-11 18:14:05 UTC (rev 204378)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx">                 00F048541A0C3C9A000244DB /* URLRedirect.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 00F048531A0C3C9A000244DB /* URLRedirect.cpp */; };
</span><span class="cx">                 0F37A4A711E6628700275F54 /* PluginObjectMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 0F37A4A611E6628700275F54 /* PluginObjectMac.mm */; };
</span><span class="cx">                 0F37A4AA11E6629100275F54 /* QuartzCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = B5A752A108AF5D1F00138E45 /* QuartzCore.framework */; };
</span><ins>+                0F4E43E31D5C2BAF008EBA5C /* Launch.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 0F4E43E11D5C037A008EBA5C /* Launch.storyboard */; };
</ins><span class="cx">                 141BF435096A455900E0753C /* WebKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 9335435F03D75502008635CE /* WebKit.framework */; };
</span><span class="cx">                 141BF436096A455900E0753C /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = A84F608908B136DA00E9745F /* Cocoa.framework */; };
</span><span class="cx">                 141BF438096A455900E0753C /* JavaScriptCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = A817090308B164D300CCB9FB /* JavaScriptCore.framework */; };
</span><span class="lines">@@ -214,6 +215,7 @@
</span><span class="cx"> /* Begin PBXFileReference section */
</span><span class="cx">                 00F048531A0C3C9A000244DB /* URLRedirect.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = URLRedirect.cpp; sourceTree = &quot;&lt;group&gt;&quot;; };
</span><span class="cx">                 0F37A4A611E6628700275F54 /* PluginObjectMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = PluginObjectMac.mm; sourceTree = &quot;&lt;group&gt;&quot;; };
</span><ins>+                0F4E43E11D5C037A008EBA5C /* Launch.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; name = Launch.storyboard; path = ios/Launch.storyboard; sourceTree = &quot;&lt;group&gt;&quot;; };
</ins><span class="cx">                 141BF233096A44CF00E0753C /* TestNetscapePlugIn.plugin */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = TestNetscapePlugIn.plugin; sourceTree = BUILT_PRODUCTS_DIR; };
</span><span class="cx">                 141BF447096A45C800E0753C /* PluginObject.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = PluginObject.h; sourceTree = &quot;&lt;group&gt;&quot;; };
</span><span class="cx">                 141BF448096A45C800E0753C /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = text.plist.xml; name = Info.plist; path = mac/Info.plist; sourceTree = &quot;&lt;group&gt;&quot;; };
</span><span class="lines">@@ -645,6 +647,7 @@
</span><span class="cx">                 A1158D6A18927CE10088C17B /* ios */ = {
</span><span class="cx">                         isa = PBXGroup;
</span><span class="cx">                         children = (
</span><ins>+                                0F4E43E11D5C037A008EBA5C /* Launch.storyboard */,
</ins><span class="cx">                                 4464CABD1C20A07000E5BB55 /* DumpRenderTreeAppMain.mm */,
</span><span class="cx">                                 A1158D55189273EB0088C17B /* DumpRenderTreeBrowserView.h */,
</span><span class="cx">                                 A1158D56189273EB0088C17B /* DumpRenderTreeBrowserView.mm */,
</span><span class="lines">@@ -902,6 +905,7 @@
</span><span class="cx">                         isa = PBXResourcesBuildPhase;
</span><span class="cx">                         buildActionMask = 2147483647;
</span><span class="cx">                         files = (
</span><ins>+                                0F4E43E31D5C2BAF008EBA5C /* Launch.storyboard in Resources */,
</ins><span class="cx">                         );
</span><span class="cx">                         runOnlyForDeploymentPostprocessing = 0;
</span><span class="cx">                 };
</span><span class="lines">@@ -1198,6 +1202,7 @@
</span><span class="cx">                         baseConfigurationReference = A19317FD18928738001C52B1 /* DumpRenderTreeApp.xcconfig */;
</span><span class="cx">                         buildSettings = {
</span><span class="cx">                                 INFOPLIST_FILE = &quot;$(SRCROOT)/ios/Info.plist&quot;;
</span><ins>+                                TARGETED_DEVICE_FAMILY = &quot;1,2&quot;;
</ins><span class="cx">                         };
</span><span class="cx">                         name = Debug;
</span><span class="cx">                 };
</span><span class="lines">@@ -1206,6 +1211,7 @@
</span><span class="cx">                         baseConfigurationReference = A19317FD18928738001C52B1 /* DumpRenderTreeApp.xcconfig */;
</span><span class="cx">                         buildSettings = {
</span><span class="cx">                                 INFOPLIST_FILE = &quot;$(SRCROOT)/ios/Info.plist&quot;;
</span><ins>+                                TARGETED_DEVICE_FAMILY = &quot;1,2&quot;;
</ins><span class="cx">                         };
</span><span class="cx">                         name = Release;
</span><span class="cx">                 };
</span><span class="lines">@@ -1214,6 +1220,7 @@
</span><span class="cx">                         baseConfigurationReference = A19317FD18928738001C52B1 /* DumpRenderTreeApp.xcconfig */;
</span><span class="cx">                         buildSettings = {
</span><span class="cx">                                 INFOPLIST_FILE = &quot;$(SRCROOT)/ios/Info.plist&quot;;
</span><ins>+                                TARGETED_DEVICE_FAMILY = &quot;1,2&quot;;
</ins><span class="cx">                         };
</span><span class="cx">                         name = Production;
</span><span class="cx">                 };
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeiosInfoplist"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/ios/Info.plist (204377 => 204378)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/ios/Info.plist        2016-08-11 17:48:57 UTC (rev 204377)
+++ trunk/Tools/DumpRenderTree/ios/Info.plist        2016-08-11 18:14:05 UTC (rev 204378)
</span><span class="lines">@@ -27,5 +27,24 @@
</span><span class="cx">                 &lt;key&gt;NSAllowsArbitraryLoads&lt;/key&gt;
</span><span class="cx">                 &lt;true/&gt;
</span><span class="cx">         &lt;/dict&gt;
</span><ins>+        &lt;key&gt;UILaunchStoryboardName&lt;/key&gt;
+        &lt;string&gt;Launch&lt;/string&gt;
+        &lt;key&gt;UIRequiredDeviceCapabilities&lt;/key&gt;
+        &lt;array&gt;
+                &lt;string&gt;armv7&lt;/string&gt;
+        &lt;/array&gt;
+        &lt;key&gt;UISupportedInterfaceOrientations&lt;/key&gt;
+        &lt;array&gt;
+                &lt;string&gt;UIInterfaceOrientationPortrait&lt;/string&gt;
+                &lt;string&gt;UIInterfaceOrientationLandscapeLeft&lt;/string&gt;
+                &lt;string&gt;UIInterfaceOrientationLandscapeRight&lt;/string&gt;
+        &lt;/array&gt;
+        &lt;key&gt;UISupportedInterfaceOrientations~ipad&lt;/key&gt;
+        &lt;array&gt;
+                &lt;string&gt;UIInterfaceOrientationPortrait&lt;/string&gt;
+                &lt;string&gt;UIInterfaceOrientationPortraitUpsideDown&lt;/string&gt;
+                &lt;string&gt;UIInterfaceOrientationLandscapeLeft&lt;/string&gt;
+                &lt;string&gt;UIInterfaceOrientationLandscapeRight&lt;/string&gt;
+        &lt;/array&gt;
</ins><span class="cx"> &lt;/dict&gt;
</span><span class="cx"> &lt;/plist&gt;
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreeiosLaunchstoryboard"></a>
<div class="addfile"><h4>Added: trunk/Tools/DumpRenderTree/ios/Launch.storyboard (0 => 204378)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/ios/Launch.storyboard                                (rev 0)
+++ trunk/Tools/DumpRenderTree/ios/Launch.storyboard        2016-08-11 18:14:05 UTC (rev 204378)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+&lt;?xml version=&quot;1.0&quot; encoding=&quot;UTF-8&quot; standalone=&quot;no&quot;?&gt;
+&lt;document type=&quot;com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB&quot; version=&quot;3.0&quot; toolsVersion=&quot;11134&quot; systemVersion=&quot;15F34&quot; targetRuntime=&quot;iOS.CocoaTouch&quot; propertyAccessControl=&quot;none&quot; useAutolayout=&quot;YES&quot; useTraitCollections=&quot;YES&quot; colorMatched=&quot;YES&quot;&gt;
+    &lt;dependencies&gt;
+        &lt;plugIn identifier=&quot;com.apple.InterfaceBuilder.IBCocoaTouchPlugin&quot; version=&quot;11106&quot;/&gt;
+    &lt;/dependencies&gt;
+    &lt;scenes/&gt;
+&lt;/document&gt;
</ins></span></pre></div>
<a id="trunkToolsDumpRenderTreemacConfigurationsDumpRenderTreeAppxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig (204377 => 204378)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig        2016-08-11 17:48:57 UTC (rev 204377)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig        2016-08-11 18:14:05 UTC (rev 204378)
</span><span class="lines">@@ -30,5 +30,10 @@
</span><span class="cx"> OTHER_LDFLAGS = $(PLATFORM_OTHER_LDFLAGS) $(ASAN_OTHER_LDFLAGS);
</span><span class="cx"> PLATFORM_OTHER_LDFLAGS[sdk=iphone*] = -l$(WEBKIT_SYSTEM_INTERFACE_LIBRARY) -lWebCoreTestSupport -force_load $(BUILT_PRODUCTS_DIR)/libDumpRenderTree.a -framework QuartzCore -framework CFNetwork -framework CoreFoundation -framework CoreGraphics -framework Foundation -framework GraphicsServices -framework ImageIO -framework MobileCoreServices -framework UIKit -framework WebCore -framework JavaScriptCore -framework WebKit $(OTHER_LDFLAGS_FONTS);
</span><span class="cx"> PLATFORM_OTHER_LDFLAGS[sdk=macosx*] = -framework JavaScriptCore;
</span><ins>+
</ins><span class="cx"> LD_RUNPATH_SEARCH_PATHS = &quot;@loader_path/.&quot;;
</span><ins>+
+EXCLUDED_SOURCE_FILE_NAMES[sdk=macosx*] = ios/*;
+
</ins><span class="cx"> PRODUCT_NAME = DumpRenderTree;
</span><ins>+
</ins></span></pre></div>
<a id="trunkToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (204377 => 204378)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm        2016-08-11 17:48:57 UTC (rev 204377)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm        2016-08-11 18:14:05 UTC (rev 204378)
</span><span class="lines">@@ -820,6 +820,10 @@
</span><span class="cx">     uiWindowRect.origin.y += [UIApp statusBarHeight];
</span><span class="cx">     UIWindow *uiWindow = [[[UIWindow alloc] initWithFrame:uiWindowRect] autorelease];
</span><span class="cx"> 
</span><ins>+    UIViewController *viewController = [[UIViewController alloc] init];
+    [uiWindow setRootViewController:viewController];
+    [viewController release];
+
</ins><span class="cx">     // The UIWindow and UIWebBrowserView are released when the DumpRenderTreeWindow is closed.
</span><span class="cx">     drtWindow.uiWindow = uiWindow;
</span><span class="cx">     drtWindow.browserView = webBrowserView;
</span><span class="lines">@@ -827,7 +831,7 @@
</span><span class="cx">     UIWebScrollView *scrollView = [[UIWebScrollView alloc] initWithFrame:layoutTestViewportRect];
</span><span class="cx">     [scrollView addSubview:webBrowserView];
</span><span class="cx"> 
</span><del>-    [uiWindow addSubview:scrollView];
</del><ins>+    [viewController.view addSubview:scrollView];
</ins><span class="cx">     [scrollView release];
</span><span class="cx"> 
</span><span class="cx">     adjustWebDocumentForStandardViewport(webBrowserView, scrollView);
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerWebKitTestRunnerxcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj (204377 => 204378)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj        2016-08-11 17:48:57 UTC (rev 204377)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj        2016-08-11 18:14:05 UTC (rev 204378)
</span><span class="lines">@@ -74,7 +74,6 @@
</span><span class="cx">                 2E63EDA11891B291002A7AFC /* AccessibilityUIElementIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2E63ED781891ACE9002A7AFC /* AccessibilityUIElementIOS.mm */; };
</span><span class="cx">                 2E63EDA61891BDC0002A7AFC /* TestRunner.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCC9981711D3F51E0017BCA2 /* TestRunner.cpp */; };
</span><span class="cx">                 2E749BF21891EBFA007FC175 /* EventSenderProxyIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2E63ED7A1891ACE9002A7AFC /* EventSenderProxyIOS.mm */; };
</span><del>-                2EE52CED1890A9A80010ED21 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 2EE52CEB1890A9A80010ED21 /* InfoPlist.strings */; };
</del><span class="cx">                 5641E2D014335E95008307E5 /* JSTextInputController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5641E2CE14335E95008307E5 /* JSTextInputController.cpp */; };
</span><span class="cx">                 5664A49A14326384008881BE /* TextInputController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5664A49814326384008881BE /* TextInputController.cpp */; };
</span><span class="cx">                 5670B8281386FCA5002EB355 /* EventSenderProxy.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5670B8271386FCA5002EB355 /* EventSenderProxy.mm */; };
</span><span class="lines">@@ -247,7 +246,6 @@
</span><span class="cx">                 2EE52CE21890A9A80010ED21 /* Foundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Foundation.framework; path = System/Library/Frameworks/Foundation.framework; sourceTree = SDKROOT; };
</span><span class="cx">                 2EE52CE41890A9A80010ED21 /* CoreGraphics.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreGraphics.framework; path = System/Library/Frameworks/CoreGraphics.framework; sourceTree = SDKROOT; };
</span><span class="cx">                 2EE52CEA1890A9A80010ED21 /* WebKitTestRunnerApp-Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; name = &quot;WebKitTestRunnerApp-Info.plist&quot;; path = &quot;WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist&quot;; sourceTree = &quot;&lt;group&gt;&quot;; };
</span><del>-                2EE52CEC1890A9A80010ED21 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = &quot;&lt;group&gt;&quot;; };
</del><span class="cx">                 2EE52CF11890A9A80010ED21 /* AppDelegate.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AppDelegate.h; sourceTree = &quot;&lt;group&gt;&quot;; };
</span><span class="cx">                 2EE52CF21890A9A80010ED21 /* AppDelegate.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = AppDelegate.m; sourceTree = &quot;&lt;group&gt;&quot;; };
</span><span class="cx">                 2EE52D131890A9FB0010ED21 /* PlatformWebViewIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = PlatformWebViewIOS.mm; sourceTree = &quot;&lt;group&gt;&quot;; };
</span><span class="lines">@@ -562,7 +560,6 @@
</span><span class="cx">                         children = (
</span><span class="cx">                                 2EE52CF11890A9A80010ED21 /* AppDelegate.h */,
</span><span class="cx">                                 2EE52CF21890A9A80010ED21 /* AppDelegate.m */,
</span><del>-                                2EE52CEB1890A9A80010ED21 /* InfoPlist.strings */,
</del><span class="cx">                                 0F4B08721D5BE88D00EC1B78 /* Launch.storyboard */,
</span><span class="cx">                                 2EE52D161890A9FB0010ED21 /* mainIOS.mm */,
</span><span class="cx">                         );
</span><span class="lines">@@ -889,7 +886,6 @@
</span><span class="cx">                         isa = PBXResourcesBuildPhase;
</span><span class="cx">                         buildActionMask = 2147483647;
</span><span class="cx">                         files = (
</span><del>-                                2EE52CED1890A9A80010ED21 /* InfoPlist.strings in Resources */,
</del><span class="cx">                                 0F4B08731D5BE88D00EC1B78 /* Launch.storyboard in Resources */,
</span><span class="cx">                         );
</span><span class="cx">                         runOnlyForDeploymentPostprocessing = 0;
</span><span class="lines">@@ -1068,17 +1064,6 @@
</span><span class="cx">                 };
</span><span class="cx"> /* End PBXTargetDependency section */
</span><span class="cx"> 
</span><del>-/* Begin PBXVariantGroup section */
-                2EE52CEB1890A9A80010ED21 /* InfoPlist.strings */ = {
-                        isa = PBXVariantGroup;
-                        children = (
-                                2EE52CEC1890A9A80010ED21 /* en */,
-                        );
-                        name = InfoPlist.strings;
-                        sourceTree = &quot;&lt;group&gt;&quot;;
-                };
-/* End PBXVariantGroup section */
-
</del><span class="cx"> /* Begin XCBuildConfiguration section */
</span><span class="cx">                 1DEB927508733DD40010E9CD /* Debug */ = {
</span><span class="cx">                         isa = XCBuildConfiguration;
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerWebKitTestRunnerAppenlprojInfoPliststrings"></a>
<div class="delfile"><h4>Deleted: trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings (204377 => 204378)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings        2016-08-11 17:48:57 UTC (rev 204377)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings        2016-08-11 18:14:05 UTC (rev 204378)
</span><span class="lines">@@ -1,2 +0,0 @@
</span><del>-/* Localized versions of Info.plist keys */
-
</del></span></pre></div>
<a id="trunkToolsWebKitTestRunneriosPlatformWebViewIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm (204377 => 204378)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm        2016-08-11 17:48:57 UTC (rev 204377)
+++ trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm        2016-08-11 18:14:05 UTC (rev 204378)
</span><span class="lines">@@ -116,6 +116,7 @@
</span><span class="cx"> 
</span><span class="cx">     UIViewController *viewController = [[UIViewController alloc] init];
</span><span class="cx">     [m_window setRootViewController:viewController];
</span><ins>+    [viewController release];
</ins><span class="cx"> 
</span><span class="cx">     m_view = [[TestRunnerWKWebView alloc] initWithFrame:viewRectForWindowRect(rect) configuration:configuration];
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>