<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204337] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204337">204337</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-08-10 10:37:49 -0700 (Wed, 10 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>child-transform-with-anchor-point-expected.html renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=160616
Reviewed by Zalan Bujtas.
Source/WebCore:
If a layer has perspective, we need to ensure that its bounds don't collapse to 0x0 when clipped out,
otherwise the sublayerTransform geometry gets messed up.
Test: compositing/geometry/clipped-out-perspective.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
LayoutTests:
* compositing/geometry/clipped-out-perspective-expected.html: Added.
* compositing/geometry/clipped-out-perspective.html: Added.
* compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Rebaseline.
* platform/mac-wk1/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestscompositinglayercreationoverlaptransformedpreserved3dexpectedtxt">trunk/LayoutTests/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk1TestExpectations">trunk/LayoutTests/platform/mac-wk1/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingcpp">trunk/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscompositinggeometryclippedoutperspectiveexpectedhtml">trunk/LayoutTests/compositing/geometry/clipped-out-perspective-expected.html</a></li>
<li><a href="#trunkLayoutTestscompositinggeometryclippedoutperspectivehtml">trunk/LayoutTests/compositing/geometry/clipped-out-perspective.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204336 => 204337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-10 17:32:15 UTC (rev 204336)
+++ trunk/LayoutTests/ChangeLog 2016-08-10 17:37:49 UTC (rev 204337)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-08-08 Simon Fraser <simon.fraser@apple.com>
+
+ child-transform-with-anchor-point-expected.html renders incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=160616
+
+ Reviewed by Zalan Bujtas.
+
+ * compositing/geometry/clipped-out-perspective-expected.html: Added.
+ * compositing/geometry/clipped-out-perspective.html: Added.
+ * compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Rebaseline.
+ * platform/mac-wk1/TestExpectations:
+
</ins><span class="cx"> 2016-08-10 Saam Barati <sbarati@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed. Skip a JSC test that's timing out and an inspector test that needs to be rebased after r204321
</span></span></pre></div>
<a id="trunkLayoutTestscompositinggeometryclippedoutperspectiveexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/geometry/clipped-out-perspective-expected.html (0 => 204337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/geometry/clipped-out-perspective-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/geometry/clipped-out-perspective-expected.html 2016-08-10 17:37:49 UTC (rev 204337)
</span><span class="lines">@@ -0,0 +1,43 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <style>
+ body {
+ overflow: hidden;
+ }
+
+ #perspective {
+ perspective: 600px;
+ position: absolute;
+ width: 400px;
+ left: -400px;
+ outline: 10px solid black;
+ }
+
+ #transformed {
+ transform: rotateY(90deg);
+ transform-origin: right;
+ background: green;
+ height: 600px;
+ }
+
+ #container {
+ position: relative;
+ margin: 100px;
+ overflow: hidden;
+ width: 600px;
+ height: 400px;
+ border: 1px solid black;
+ }
+ </style>
+ </style>
+ </head>
+ <body>
+ <div id="container">
+ <div id="perspective">
+ <div id="transformed"></div>
+ </div>
+ </div>
+ </body>
+</html>
+
</ins></span></pre></div>
<a id="trunkLayoutTestscompositinggeometryclippedoutperspectivehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/geometry/clipped-out-perspective.html (0 => 204337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/geometry/clipped-out-perspective.html (rev 0)
+++ trunk/LayoutTests/compositing/geometry/clipped-out-perspective.html 2016-08-10 17:37:49 UTC (rev 204337)
</span><span class="lines">@@ -0,0 +1,42 @@
</span><ins>+<!DOCTYPE html>
+<html>
+ <head>
+ <style>
+ body {
+ overflow: hidden;
+ }
+
+ #perspective {
+ perspective: 600px;
+ position: absolute;
+ width: 400px;
+ left: -400px;
+ }
+
+ #transformed {
+ transform: rotateY(90deg);
+ transform-origin: right;
+ background: green;
+ height: 600px;
+ }
+
+ #container {
+ position: relative;
+ margin: 100px;
+ overflow: hidden;
+ width: 600px;
+ height: 400px;
+ border: 1px solid black;
+ }
+ </style>
+ </style>
+ </head>
+ <body>
+ <div id="container">
+ <div id="perspective">
+ <div id="transformed"></div>
+ </div>
+ </div>
+ </body>
+</html>
+
</ins></span></pre></div>
<a id="trunkLayoutTestscompositinglayercreationoverlaptransformedpreserved3dexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt (204336 => 204337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt 2016-08-10 17:32:15 UTC (rev 204336)
+++ trunk/LayoutTests/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt 2016-08-10 17:37:49 UTC (rev 204337)
</span><span class="lines">@@ -9,6 +9,8 @@
</span><span class="cx"> (children 1
</span><span class="cx"> (GraphicsLayer
</span><span class="cx"> (position 108.00 108.00)
</span><ins>+ (anchor 0.00 0.00)
+ (bounds 1.00 1.00)
</ins><span class="cx"> (childrenTransform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [-0.25 -0.25 1.00 -0.01] [0.00 0.00 0.00 1.00])
</span><span class="cx"> (children 1
</span><span class="cx"> (GraphicsLayer
</span><span class="lines">@@ -67,6 +69,8 @@
</span><span class="cx"> (children 5
</span><span class="cx"> (GraphicsLayer
</span><span class="cx"> (position 108.00 108.00)
</span><ins>+ (anchor 0.00 0.00)
+ (bounds 1.00 1.00)
</ins><span class="cx"> (childrenTransform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [-0.25 -0.25 1.00 -0.01] [0.00 0.00 0.00 1.00])
</span><span class="cx"> (children 1
</span><span class="cx"> (GraphicsLayer
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk1TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (204336 => 204337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2016-08-10 17:32:15 UTC (rev 204336)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2016-08-10 17:37:49 UTC (rev 204337)
</span><span class="lines">@@ -233,9 +233,6 @@
</span><span class="cx"> # rdar://problem/26478296
</span><span class="cx"> [ Sierra+ ] svg/hixie/text/003.html [ Failure ]
</span><span class="cx">
</span><del>-# rdar://problem/26422407
-[ Sierra+ ] imported/blink/compositing/child-transform-with-anchor-point.html [ ImageOnlyFailure ]
-
</del><span class="cx"> [ Yosemite ] http/tests/media/hls/video-controller-getStartDate.html [ Pass Timeout ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/159893 [ Debug ] imported/w3c/web-platform-tests/XMLHttpRequest/event-readystatechange-loaded.htm [ Pass Failure ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204336 => 204337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-10 17:32:15 UTC (rev 204336)
+++ trunk/Source/WebCore/ChangeLog 2016-08-10 17:37:49 UTC (rev 204337)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-08-08 Simon Fraser <simon.fraser@apple.com>
+
+ child-transform-with-anchor-point-expected.html renders incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=160616
+
+ Reviewed by Zalan Bujtas.
+
+ If a layer has perspective, we need to ensure that its bounds don't collapse to 0x0 when clipped out,
+ otherwise the sublayerTransform geometry gets messed up.
+
+ Test: compositing/geometry/clipped-out-perspective.html
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateCompositedBounds):
+
</ins><span class="cx"> 2016-08-09 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Remove support for array types in IDLs
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (204336 => 204337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2016-08-10 17:32:15 UTC (rev 204336)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2016-08-10 17:37:49 UTC (rev 204337)
</span><span class="lines">@@ -536,7 +536,7 @@
</span><span class="cx"> // If the element has a transform-origin that has fixed lengths, and the renderer has zero size,
</span><span class="cx"> // then we need to ensure that the compositing layer has non-zero size so that we can apply
</span><span class="cx"> // the transform-origin via the GraphicsLayer anchorPoint (which is expressed as a fractional value).
</span><del>- if (layerBounds.isEmpty() && hasNonZeroTransformOrigin(renderer())) {
</del><ins>+ if (layerBounds.isEmpty() && (hasNonZeroTransformOrigin(renderer()) || renderer().style().hasPerspective())) {
</ins><span class="cx"> layerBounds.setWidth(1);
</span><span class="cx"> layerBounds.setHeight(1);
</span><span class="cx"> m_artificiallyInflatedBounds = true;
</span></span></pre>
</div>
</div>
</body>
</html>