<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204254] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204254">204254</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-08-08 09:35:30 -0700 (Mon, 08 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>It should be possible to re-initialize an Event after it's been dispatched
https://bugs.webkit.org/show_bug.cgi?id=160651
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
* web-platform-tests/dom/events/Event-propagation-expected.txt:
Source/WebCore:
Allow re-initialization of an Event that's already been dispatched, as
per the latest DOM specification:
- https://dom.spec.whatwg.org/#dom-event-initevent
Firefox already follows the specification here.
No new tests, rebaselined existing test.
Test: fast/events/initEvent-after-dispatch.html
* dom/Event.cpp:
(WebCore::Event::initEvent):
- Replace dispatched() check with isBeingDispatched() in order to
allow initialization of an already dispatched event but prevent
initialization of an event that is currently being dispatched
as per:
https://dom.spec.whatwg.org/#dom-event-initevent (step 1)
- Reset target to null as per:
https://dom.spec.whatwg.org/#concept-event-initialize (step 4)
LayoutTests:
Add layout test coverage.
* fast/events/initEvent-after-dispatch-expected.txt: Added.
* fast/events/initEvent-after-dispatch.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomeventsEventpropagationexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-propagation-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomEventcpp">trunk/Source/WebCore/dom/Event.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasteventsinitEventafterdispatchexpectedtxt">trunk/LayoutTests/fast/events/initEvent-after-dispatch-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsinitEventafterdispatchhtml">trunk/LayoutTests/fast/events/initEvent-after-dispatch.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204253 => 204254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-08 16:18:33 UTC (rev 204253)
+++ trunk/LayoutTests/ChangeLog 2016-08-08 16:35:30 UTC (rev 204254)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-08-08 Chris Dumez <cdumez@apple.com>
+
+ It should be possible to re-initialize an Event after it's been dispatched
+ https://bugs.webkit.org/show_bug.cgi?id=160651
+
+ Reviewed by Darin Adler.
+
+ Add layout test coverage.
+
+ * fast/events/initEvent-after-dispatch-expected.txt: Added.
+ * fast/events/initEvent-after-dispatch.html: Added.
+
</ins><span class="cx"> 2016-08-07 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Node.baseURI should not be nullable
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsinitEventafterdispatchexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/initEvent-after-dispatch-expected.txt (0 => 204254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/initEvent-after-dispatch-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/initEvent-after-dispatch-expected.txt 2016-08-08 16:35:30 UTC (rev 204254)
</span><span class="lines">@@ -0,0 +1,49 @@
</span><ins>+Tests calling initEvent() on an event while it is being dispatched and after.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS testEvent.initEvent("foo", true, false) did not throw exception.
+PASS testEvent.type is "foo"
+PASS testEvent.bubbles is true
+PASS testEvent.cancelable is false
+PASS testEvent.target is null
+PASS testEvent.currentTarget is null
+PASS testEvent.eventPhase is Event.NONE
+
+* In event handler
+PASS event.type is "foo"
+PASS event.bubbles is true
+PASS event.cancelable is false
+PASS event.target is document.body
+PASS event.currentTarget is document.body
+PASS event.eventPhase is Event.AT_TARGET
+
+PASS testEvent.initEvent("bar", false, true) did not throw exception.
+PASS event.type is "foo"
+PASS event.bubbles is true
+PASS event.cancelable is false
+PASS event.target is document.body
+PASS event.currentTarget is document.body
+PASS event.eventPhase is Event.AT_TARGET
+PASS document.body.dispatchEvent(testEvent) did not throw exception.
+
+* After event has been dispatched
+PASS testEvent.type is "foo"
+PASS testEvent.bubbles is true
+PASS testEvent.cancelable is false
+PASS testEvent.target is document.body
+PASS testEvent.currentTarget is null
+PASS testEvent.eventPhase is Event.NONE
+
+PASS testEvent.initEvent("bar", false, true) did not throw exception.
+PASS event.type is "bar"
+PASS event.bubbles is false
+PASS event.cancelable is true
+PASS event.target is null
+PASS event.currentTarget is null
+PASS event.eventPhase is Event.NONE
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventsinitEventafterdispatchhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/initEvent-after-dispatch.html (0 => 204254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/initEvent-after-dispatch.html (rev 0)
+++ trunk/LayoutTests/fast/events/initEvent-after-dispatch.html 2016-08-08 16:35:30 UTC (rev 204254)
</span><span class="lines">@@ -0,0 +1,63 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests calling initEvent() on an event while it is being dispatched and after.");
+
+function eventHandler(ev) {
+ event = ev;
+ debug("");
+ debug("* In event handler");
+ shouldBeEqualToString("event.type", "foo");
+ shouldBeTrue("event.bubbles");
+ shouldBeFalse("event.cancelable");
+ shouldBe("event.target", "document.body");
+ shouldBe("event.currentTarget", "document.body");
+ shouldBe("event.eventPhase", "Event.AT_TARGET");
+
+ debug("");
+ // It should not be possible to re-initialize an event being dispatched.
+ shouldNotThrow('testEvent.initEvent("bar", false, true)');
+ shouldBeEqualToString("event.type", "foo");
+ shouldBeTrue("event.bubbles");
+ shouldBeFalse("event.cancelable");
+ shouldBe("event.target", "document.body");
+ shouldBe("event.currentTarget", "document.body");
+ shouldBe("event.eventPhase", "Event.AT_TARGET");
+}
+
+var testEvent = document.createEvent("Event");
+shouldNotThrow('testEvent.initEvent("foo", true, false)');
+shouldBeEqualToString("testEvent.type", "foo");
+shouldBeTrue("testEvent.bubbles");
+shouldBeFalse("testEvent.cancelable");
+shouldBeNull("testEvent.target");
+shouldBeNull("testEvent.currentTarget");
+shouldBe("testEvent.eventPhase", "Event.NONE");
+
+document.body.addEventListener("foo", eventHandler);
+shouldNotThrow('document.body.dispatchEvent(testEvent)');
+
+debug("");
+debug("* After event has been dispatched");
+shouldBeEqualToString("testEvent.type", "foo");
+shouldBeTrue("testEvent.bubbles");
+shouldBeFalse("testEvent.cancelable");
+shouldBe("testEvent.target", "document.body");
+shouldBeNull("testEvent.currentTarget");
+shouldBe("testEvent.eventPhase", "Event.NONE");
+
+// It should now be possible to re-initialize the event.
+debug("");
+shouldNotThrow('testEvent.initEvent("bar", false, true)');
+shouldBeEqualToString("event.type", "bar");
+shouldBeFalse("event.bubbles");
+shouldBeTrue("event.cancelable");
+shouldBeNull("event.target");
+shouldBeNull("event.currentTarget");
+shouldBe("event.eventPhase", "Event.NONE");
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204253 => 204254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-08 16:18:33 UTC (rev 204253)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-08 16:35:30 UTC (rev 204254)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-08-08 Chris Dumez <cdumez@apple.com>
+
+ It should be possible to re-initialize an Event after it's been dispatched
+ https://bugs.webkit.org/show_bug.cgi?id=160651
+
+ Reviewed by Darin Adler.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/dom/events/Event-propagation-expected.txt:
+
</ins><span class="cx"> 2016-08-07 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Node.baseURI should not be nullable
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomeventsEventpropagationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-propagation-expected.txt (204253 => 204254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-propagation-expected.txt 2016-08-08 16:18:33 UTC (rev 204253)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/Event-propagation-expected.txt 2016-08-08 16:35:30 UTC (rev 204254)
</span><span class="lines">@@ -1,7 +1,7 @@
</span><span class="cx">
</span><span class="cx"> PASS Newly-created Event
</span><span class="cx"> PASS After stopPropagation()
</span><del>-FAIL Reinitialized after stopPropagation() assert_equals: Propagation flag expected true but got false
</del><ins>+PASS Reinitialized after stopPropagation()
</ins><span class="cx"> PASS After stopImmediatePropagation()
</span><del>-FAIL Reinitialized after stopImmediatePropagation() assert_equals: Propagation flag expected true but got false
</del><ins>+PASS Reinitialized after stopImmediatePropagation()
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204253 => 204254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-08 16:18:33 UTC (rev 204253)
+++ trunk/Source/WebCore/ChangeLog 2016-08-08 16:35:30 UTC (rev 204254)
</span><span class="lines">@@ -1,3 +1,30 @@
</span><ins>+2016-08-08 Chris Dumez <cdumez@apple.com>
+
+ It should be possible to re-initialize an Event after it's been dispatched
+ https://bugs.webkit.org/show_bug.cgi?id=160651
+
+ Reviewed by Darin Adler.
+
+ Allow re-initialization of an Event that's already been dispatched, as
+ per the latest DOM specification:
+ - https://dom.spec.whatwg.org/#dom-event-initevent
+
+ Firefox already follows the specification here.
+
+ No new tests, rebaselined existing test.
+
+ Test: fast/events/initEvent-after-dispatch.html
+
+ * dom/Event.cpp:
+ (WebCore::Event::initEvent):
+ - Replace dispatched() check with isBeingDispatched() in order to
+ allow initialization of an already dispatched event but prevent
+ initialization of an event that is currently being dispatched
+ as per:
+ https://dom.spec.whatwg.org/#dom-event-initevent (step 1)
+ - Reset target to null as per:
+ https://dom.spec.whatwg.org/#concept-event-initialize (step 4)
+
</ins><span class="cx"> 2016-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed. Fix GObject DOM bindings API break after r204236.
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Event.cpp (204253 => 204254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Event.cpp 2016-08-08 16:18:33 UTC (rev 204253)
+++ trunk/Source/WebCore/dom/Event.cpp 2016-08-08 16:35:30 UTC (rev 204254)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx">
</span><span class="cx"> void Event::initEvent(const AtomicString& eventTypeArg, bool canBubbleArg, bool cancelableArg)
</span><span class="cx"> {
</span><del>- if (dispatched())
</del><ins>+ if (isBeingDispatched())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> m_isInitialized = true;
</span><span class="lines">@@ -80,6 +80,7 @@
</span><span class="cx"> m_immediatePropagationStopped = false;
</span><span class="cx"> m_defaultPrevented = false;
</span><span class="cx"> m_isTrusted = false;
</span><ins>+ m_target = nullptr;
</ins><span class="cx">
</span><span class="cx"> m_type = eventTypeArg;
</span><span class="cx"> m_canBubble = canBubbleArg;
</span></span></pre>
</div>
</div>
</body>
</html>