<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204223] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204223">204223</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-06 01:48:31 -0700 (Sat, 06 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>LayoutTest http/tests/fetch/fetch-in-worker-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=160510
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-06
Reviewed by Sam Weinig.
* http/tests/fetch/fetch-in-worker-crash.html:
* http/tests/fetch/fetch-in-worker.js:
Adding a new test based on a ReadableStream that is not closed and therefore Response.text promise cannot resolve.
Removing the blob resolve message as there is no guarantee that blob load will finish after the test is done.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestsfetchfetchinworkercrashhtml">trunk/LayoutTests/http/tests/fetch/fetch-in-worker-crash.html</a></li>
<li><a href="#trunkLayoutTestshttptestsfetchfetchinworkerjs">trunk/LayoutTests/http/tests/fetch/fetch-in-worker.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204222 => 204223)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-06 08:00:20 UTC (rev 204222)
+++ trunk/LayoutTests/ChangeLog 2016-08-06 08:48:31 UTC (rev 204223)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-08-06 Youenn Fablet <youenn@apple.com>
+
+ LayoutTest http/tests/fetch/fetch-in-worker-crash.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=160510
+
+ Reviewed by Sam Weinig.
+
+ * http/tests/fetch/fetch-in-worker-crash.html:
+ * http/tests/fetch/fetch-in-worker.js:
+ Adding a new test based on a ReadableStream that is not closed and therefore Response.text promise cannot resolve.
+ Removing the blob resolve message as there is no guarantee that blob load will finish after the test is done.
+
</ins><span class="cx"> 2016-08-05 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> [Web IDL] Add support for USVString type
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsfetchfetchinworkercrashhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/fetch/fetch-in-worker-crash.html (204222 => 204223)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/fetch/fetch-in-worker-crash.html 2016-08-06 08:00:20 UTC (rev 204222)
+++ trunk/LayoutTests/http/tests/fetch/fetch-in-worker-crash.html 2016-08-06 08:48:31 UTC (rev 204223)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> <body>
</span><span class="cx"> <p>Test that terminating an ongoing fetch in a worker does not cause a crash.</p> <script>
</span><del>- if (testRunner) {
</del><ins>+ if (window.testRunner) {
</ins><span class="cx"> testRunner.dumpAsText();
</span><span class="cx"> testRunner.waitUntilDone();
</span><span class="cx"> }
</span><span class="lines">@@ -15,7 +15,7 @@
</span><span class="cx"> worker.terminate();
</span><span class="cx"> setTimeout(() => {
</span><span class="cx"> document.body.innerHTML += "<p>PASS: No crash.</p>";
</span><del>- if (testRunner)
</del><ins>+ if (window.testRunner)
</ins><span class="cx"> testRunner.notifyDone();
</span><span class="cx"> }, 100);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsfetchfetchinworkerjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/fetch/fetch-in-worker.js (204222 => 204223)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/fetch/fetch-in-worker.js 2016-08-06 08:00:20 UTC (rev 204222)
+++ trunk/LayoutTests/http/tests/fetch/fetch-in-worker.js 2016-08-06 08:48:31 UTC (rev 204223)
</span><span class="lines">@@ -9,11 +9,20 @@
</span><span class="cx"> postMessage("FAIL: promise 1 rejected");
</span><span class="cx"> });
</span><span class="cx">
</span><del>- var promise2 = new Request("test", {method: "POST", body: new Blob(["ab"])}).text().then(() => {
</del><ins>+ var stream = new ReadableStream({"start": function(controller) {
+ controller.enqueue("starting but not closing");
+ }});
+ var promise2 = new Response(stream).text().then(() => {
</ins><span class="cx"> postMessage("FAIL: promise 2 resolved");
</span><span class="cx"> }, () => {
</span><span class="cx"> postMessage("FAIL: promise 2 rejected");
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+ var promise3 = new Request("test", {method: "POST", body: new Blob(["ab"])}).text().then(() => {
+ // Not posting message as it could make the test flaky since we are not sure the test will end before the blob load finishes.
+ }, () => {
+ postMessage("FAIL: promise 3 rejected");
+ });
+
</ins><span class="cx"> postMessage(counter++);
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>