<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204191] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204191">204191</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-05 13:27:33 -0700 (Fri, 05 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove testRunner.handleErrorPages()
https://bugs.webkit.org/show_bug.cgi?id=160552
Patch by Jonathan Bedard <jbedard@apple.com> on 2016-08-05
Reviewed by Daniel Bates.
handleErrorPages() was implemented by the Qt WebKit port, per
https://bugs.webkit.org/show_bug.cgi?id=31509#c0, but never implemented
on other ports. Per https://bugs.webkit.org/show_bug.cgi?id=31555, this
feature was never implemented on Mac.
* fast/history/back-forward-reset-after-error-handling-expected.txt: Removed test expectations.
* fast/history/back-forward-reset-after-error-handling.html: Removed test.
* platform/efl/TestExpectations: Remove reference to back-forward-reset-after-error-handling.
* platform/gtk/TestExpectations: Ditto.
* platform/ios-simulator/TestExpectations: Ditto.
* platform/mac/TestExpectations: Ditto.
* platform/win/TestExpectations: Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorTestExpectations">trunk/LayoutTests/platform/ios-simulator/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasthistorybackforwardresetaftererrorhandlingexpectedtxt">trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasthistorybackforwardresetaftererrorhandlinghtml">trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204190 => 204191)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/ChangeLog 2016-08-05 20:27:33 UTC (rev 204191)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-08-05 Jonathan Bedard <jbedard@apple.com>
+
+ Remove testRunner.handleErrorPages()
+ https://bugs.webkit.org/show_bug.cgi?id=160552
+
+ Reviewed by Daniel Bates.
+
+ handleErrorPages() was implemented by the Qt WebKit port, per
+ https://bugs.webkit.org/show_bug.cgi?id=31509#c0, but never implemented
+ on other ports. Per https://bugs.webkit.org/show_bug.cgi?id=31555, this
+ feature was never implemented on Mac.
+
+ * fast/history/back-forward-reset-after-error-handling-expected.txt: Removed test expectations.
+ * fast/history/back-forward-reset-after-error-handling.html: Removed test.
+ * platform/efl/TestExpectations: Remove reference to back-forward-reset-after-error-handling.
+ * platform/gtk/TestExpectations: Ditto.
+ * platform/ios-simulator/TestExpectations: Ditto.
+ * platform/mac/TestExpectations: Ditto.
+ * platform/win/TestExpectations: Ditto.
+
</ins><span class="cx"> 2016-08-05 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> validity assertion fails after removing a child of an <optgroup> element
</span></span></pre></div>
<a id="trunkLayoutTestsfasthistorybackforwardresetaftererrorhandlingexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt (204190 => 204191)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt 2016-08-05 20:27:33 UTC (rev 204191)
</span><span class="lines">@@ -1,6 +0,0 @@
</span><del>-SUCCESS
-
-============== Back Forward List ==============
-curr-> (file test):fast/history/back-forward-reset-after-error-handling.html **nav target**
- (file test):fast/history/non-existent.html **nav target**
-===============================================
</del></span></pre></div>
<a id="trunkLayoutTestsfasthistorybackforwardresetaftererrorhandlinghtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling.html (204190 => 204191)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling.html 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/fast/history/back-forward-reset-after-error-handling.html 2016-08-05 20:27:33 UTC (rev 204191)
</span><span class="lines">@@ -1,48 +0,0 @@
</span><del>-<html>
- <script>
- // Pre-conditions
- // - Error page handling is supported on DRT.
-
- // Navigation steps:
- // 1- loads this page.
- // 2- loads a non-existent page (an error page is loaded).
- // 4- executes a back, forward and back navigations.
-
- // Expected results:
- // - forward-list should comprise the non-existent loaded page(2).
-
- var isOkToContinue = " "+
- "{ "+
- " var console = document.getElementById('console'); "+
- " if (console != null) "+
- " console.innerHTML = 'SUCCESS'; "+
- " else "+
- " console.innerHTML = 'FAIL'; "+
- "}";
-
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
- testRunner.handleErrorPages();
- testRunner.dumpBackForwardList();
- }
-
- function onPageShow(evt)
- {
- if (!evt.persisted) {
- // this is the first time the page has been loaded, then setup the
- // to-be-tested scenario.
- testRunner.queueLoad("./non-existent.html");
- testRunner.queueBackNavigation(1);
- testRunner.queueForwardNavigation(1);
- testRunner.queueBackNavigation(1);
- testRunner.queueNonLoadingScript("eval(\"" + isOkToContinue + "\")");
- }
- }
-
- window.onpageshow = onPageShow;
- </script>
- <body>
- <h1 id='console'/>
- </body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (204190 => 204191)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
</span><span class="lines">@@ -49,9 +49,6 @@
</span><span class="cx"> # EFL's LayoutTestController does not implement shadowPseudoId
</span><span class="cx"> media/video-volume-slider.html
</span><span class="cx">
</span><del>-# Need to add functionality to DumpRenderTree to handle error pages
-fast/history/back-forward-reset-after-error-handling.html
-
</del><span class="cx"> # BUG: Captions support needed in the media engine (via GTK+)
</span><span class="cx"> media/media-captions.html
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (204190 => 204191)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
</span><span class="lines">@@ -1959,9 +1959,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/53986 svg/text/caret-in-svg-text.xhtml [ Failure ]
</span><span class="cx">
</span><del>-# Need to add functionality to DumpRenderTree to handle error pages
-Bug(GTK) fast/history/back-forward-reset-after-error-handling.html [ Failure ]
-
</del><span class="cx"> # Paged continuousMouseScrollBy() events are not supported in GTK.
</span><span class="cx"> Bug(GTK) fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html [ Failure Timeout ]
</span><span class="cx"> Bug(GTK) fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (204190 => 204191)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
</span><span class="lines">@@ -1856,7 +1856,6 @@
</span><span class="cx"> fast/frames/valid.html [ Failure ]
</span><span class="cx"> fast/gradients/background-clipped.html [ Failure ]
</span><span class="cx"> fast/hidpi/image-srcset-data-srcset.html [ Failure ]
</span><del>-fast/history/back-forward-reset-after-error-handling.html [ Failure ]
</del><span class="cx"> fast/images/gif-large-checkerboard.html [ Failure ]
</span><span class="cx"> fast/images/gray-scale-jpeg-with-color-profile.html [ Failure ]
</span><span class="cx"> fast/images/icon-decoding.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (204190 => 204191)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
</span><span class="lines">@@ -53,9 +53,6 @@
</span><span class="cx"> accessibility/menu-list-sends-change-notification.html
</span><span class="cx"> accessibility/multiselect-list-reports-active-option.html
</span><span class="cx">
</span><del>-# Need to add functionality to DumpRenderTree to handle error pages
-fast/history/back-forward-reset-after-error-handling.html
-
</del><span class="cx"> # Need to implement this in plugins code in WebKit
</span><span class="cx"> plugins/reloadplugins-and-pages.html
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (204190 => 204191)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2016-08-05 20:22:52 UTC (rev 204190)
+++ trunk/LayoutTests/platform/win/TestExpectations 2016-08-05 20:27:33 UTC (rev 204191)
</span><span class="lines">@@ -200,9 +200,6 @@
</span><span class="cx"> fast/dom/Window/slow-unload-handler.html [ Skip ]
</span><span class="cx"> fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html [ Skip ]
</span><span class="cx">
</span><del>-# Need to add functionality to DumpRenderTree to handle error pages (mac as well)
-fast/history/back-forward-reset-after-error-handling.html [ Skip ]
-
</del><span class="cx"> # These tests require touch support
</span><span class="cx"> fast/events/touch/ [ Skip ]
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>