<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204184] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204184">204184</a></dd>
<dt>Author</dt> <dd>ryanhaddad@apple.com</dd>
<dt>Date</dt> <dd>2016-08-05 12:16:55 -0700 (Fri, 05 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/204174">r204174</a>.
The test for this change is failing on WK1
Reverted changeset:
"Popups opened from a sandboxed iframe should themselves be
sandboxed"
https://bugs.webkit.org/show_bug.cgi?id=134850
http://trac.webkit.org/changeset/204174</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageChromecpp">trunk/Source/WebCore/page/Chrome.cpp</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestshttptestssecurityresourcesanchortagwithblanktargethtml">trunk/LayoutTests/http/tests/security/resources/anchor-tag-with-blank-target.html</a></li>
<li><a href="#trunkLayoutTestshttptestssecurityresourcespageexecutingjavascripthtml">trunk/LayoutTests/http/tests/security/resources/page-executing-javascript.html</a></li>
<li><a href="#trunkLayoutTestshttptestssecuritywindowopenedfromsandboxediframeshouldinheritsandboxexpectedtxt">trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestssecuritywindowopenedfromsandboxediframeshouldinheritsandboxhtml">trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204183 => 204184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-05 19:16:34 UTC (rev 204183)
+++ trunk/LayoutTests/ChangeLog 2016-08-05 19:16:55 UTC (rev 204184)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-08-05 Ryan Haddad <ryanhaddad@apple.com>
+
+ Unreviewed, rolling out r204174.
+
+ The test for this change is failing on WK1
+
+ Reverted changeset:
+
+ "Popups opened from a sandboxed iframe should themselves be
+ sandboxed"
+ https://bugs.webkit.org/show_bug.cgi?id=134850
+ http://trac.webkit.org/changeset/204174
+
</ins><span class="cx"> 2016-08-05 John Wilander <wilander@apple.com>
</span><span class="cx">
</span><span class="cx"> Don't set document.domain to an IP address fragment
</span></span></pre></div>
<a id="trunkLayoutTestshttptestssecurityresourcesanchortagwithblanktargethtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/http/tests/security/resources/anchor-tag-with-blank-target.html (204183 => 204184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/resources/anchor-tag-with-blank-target.html 2016-08-05 19:16:34 UTC (rev 204183)
+++ trunk/LayoutTests/http/tests/security/resources/anchor-tag-with-blank-target.html 2016-08-05 19:16:55 UTC (rev 204184)
</span><span class="lines">@@ -1,8 +0,0 @@
</span><del>-<!DOCTYPE html>
-<html>
-<head>
-</head>
-<body>
- <a id="theLink" target="_blank" href="./page-executing-javascript.html">_blank page that executes JavaScript</a>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestshttptestssecurityresourcespageexecutingjavascripthtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/http/tests/security/resources/page-executing-javascript.html (204183 => 204184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/resources/page-executing-javascript.html 2016-08-05 19:16:34 UTC (rev 204183)
+++ trunk/LayoutTests/http/tests/security/resources/page-executing-javascript.html 2016-08-05 19:16:55 UTC (rev 204184)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-<!DOCTYPE html>
-<html>
-<body>
-<noscript>Pass: JavaScript was not allowed to execute.</noscript>
-<p id="output"></p>
-<script>
- document.getElementById("output").innerHTML = "Fail: JavaScript was allowed to execute.";
-</script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestshttptestssecuritywindowopenedfromsandboxediframeshouldinheritsandboxexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt (204183 => 204184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt 2016-08-05 19:16:34 UTC (rev 204183)
+++ trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt 2016-08-05 19:16:55 UTC (rev 204184)
</span><span class="lines">@@ -1,2 +0,0 @@
</span><del>-CONSOLE MESSAGE: Blocked script execution in 'http://127.0.0.1:8000/security/resources/page-executing-javascript.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
-
</del></span></pre></div>
<a id="trunkLayoutTestshttptestssecuritywindowopenedfromsandboxediframeshouldinheritsandboxhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html (204183 => 204184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html 2016-08-05 19:16:34 UTC (rev 204183)
+++ trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html 2016-08-05 19:16:55 UTC (rev 204184)
</span><span class="lines">@@ -1,48 +0,0 @@
</span><del>-<!DOCTYPE html>
-<html>
-<head>
- <meta charset="UTF-8">
- <title>Tests that windows created from a sandboxed context inherit the same sandbox</title>
- <script src="../resources/js-test-pre.js"></script>
-</head>
-<body>
-<script>
- if (window.testRunner) {
- testRunner.setCanOpenWindows();
- testRunner.waitUntilDone();
- testRunner.setPopupBlockingEnabled(false);
- testRunner.dumpAsText();
- }
-
- function wrapUp () {
- finishJSTest();
- if (window.testRunner) {
- testRunner.notifyDone();
- }
- }
-
- function run() {
- var iframeContentDocument = document.getElementById("theIframe").contentDocument;
- if (!iframeContentDocument) {
- testFailed("Can't get iframeElement.contentDocument");
- finishJSTest();
- testRunner.notifyDone();
- } else {
- var theLink = iframeContentDocument.getElementById("theLink");
- if (!theLink) {
- testFailed("Can't get iframeElement.contentDocument.getElementById('theLink')");
- finishJSTest();
- testRunner.notifyDone();
- } else {
- var clickEvent = document.createEvent("HTMLEvents");
- clickEvent.initEvent("click", true, true);
- theLink.dispatchEvent(clickEvent);
-
- setTimeout(wrapUp, 500);
- }
- }
- }
-</script>
-<iframe onload="run()" id="theIframe" sandbox="allow-same-origin allow-popups" src="resources/anchor-tag-with-blank-target.html"></iframe>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204183 => 204184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-05 19:16:34 UTC (rev 204183)
+++ trunk/Source/WebCore/ChangeLog 2016-08-05 19:16:55 UTC (rev 204184)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-08-05 Ryan Haddad <ryanhaddad@apple.com>
+
+ Unreviewed, rolling out r204174.
+
+ The test for this change is failing on WK1
+
+ Reverted changeset:
+
+ "Popups opened from a sandboxed iframe should themselves be
+ sandboxed"
+ https://bugs.webkit.org/show_bug.cgi?id=134850
+ http://trac.webkit.org/changeset/204174
+
</ins><span class="cx"> 2016-08-05 John Wilander <wilander@apple.com>
</span><span class="cx">
</span><span class="cx"> Don't set document.domain to an IP address fragment
</span></span></pre></div>
<a id="trunkSourceWebCorepageChromecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Chrome.cpp (204183 => 204184)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Chrome.cpp 2016-08-05 19:16:34 UTC (rev 204183)
+++ trunk/Source/WebCore/page/Chrome.cpp 2016-08-05 19:16:55 UTC (rev 204184)
</span><span class="lines">@@ -195,13 +195,10 @@
</span><span class="cx">
</span><span class="cx"> Page* Chrome::createWindow(Frame* frame, const FrameLoadRequest& request, const WindowFeatures& features, const NavigationAction& action) const
</span><span class="cx"> {
</span><del>- ASSERT(frame);
</del><span class="cx"> Page* newPage = m_client.createWindow(frame, request, features, action);
</span><span class="cx"> if (!newPage)
</span><span class="cx"> return 0;
</span><span class="cx">
</span><del>- newPage->mainFrame().loader().forceSandboxFlags(frame->loader().effectiveSandboxFlags());
-
</del><span class="cx"> if (StorageNamespace* oldSessionStorage = m_page.sessionStorage(false))
</span><span class="cx"> newPage->setSessionStorage(oldSessionStorage->copy(newPage));
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>