<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204187] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204187">204187</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-05 13:19:27 -0700 (Fri, 05 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>MeasurementCluster's addToSeries is slow
https://bugs.webkit.org/show_bug.cgi?id=160581
Rubber-stamped by Chris Dumez.
The bulk of time was spent in MeasurementAdaptor.prototype.applyTo where we computed the interval.
Since some of data points are filtered out by TimeSeriesChart component before intervals are used,
we can significantly reduce the CPU time by lazily compute them. This patch reduces the runtime of
applyTo from ~60ms to ~30ms on my machine.
* public/v3/models/measurement-adaptor.js:
(MeasurementAdaptor.prototype.applyTo): Lazily compute and cache the interval. Also cache the build
object instead of always creating a new object.
* public/v3/models/measurement-cluster.js:
(MeasurementCluster.prototype.addToSeries): Call applyTo first before checking whether the point is
an outlier or its id to avoid extracting those values twice since they show up in the profiler. Also
use "of" instead "forEach" since "of" seems to be faster here.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsmeasurementadaptorjs">trunk/Websites/perf.webkit.org/public/v3/models/measurement-adaptor.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsmeasurementclusterjs">trunk/Websites/perf.webkit.org/public/v3/models/measurement-cluster.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (204186 => 204187)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2016-08-05 19:38:18 UTC (rev 204186)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-08-05 20:19:27 UTC (rev 204187)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2016-08-04 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ MeasurementCluster's addToSeries is slow
+ https://bugs.webkit.org/show_bug.cgi?id=160581
+
+ Rubber-stamped by Chris Dumez.
+
+ The bulk of time was spent in MeasurementAdaptor.prototype.applyTo where we computed the interval.
+
+ Since some of data points are filtered out by TimeSeriesChart component before intervals are used,
+ we can significantly reduce the CPU time by lazily compute them. This patch reduces the runtime of
+ applyTo from ~60ms to ~30ms on my machine.
+
+ * public/v3/models/measurement-adaptor.js:
+ (MeasurementAdaptor.prototype.applyTo): Lazily compute and cache the interval. Also cache the build
+ object instead of always creating a new object.
+ * public/v3/models/measurement-cluster.js:
+ (MeasurementCluster.prototype.addToSeries): Call applyTo first before checking whether the point is
+ an outlier or its id to avoid extracting those values twice since they show up in the profiler. Also
+ use "of" instead "forEach" since "of" seems to be faster here.
+
+2016-08-04 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Syncing script's configuration duplicates a lot of boilerplate
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160574
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsmeasurementadaptorjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/measurement-adaptor.js (204186 => 204187)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/measurement-adaptor.js 2016-08-05 19:38:18 UTC (rev 204186)
+++ trunk/Websites/perf.webkit.org/public/v3/models/measurement-adaptor.js 2016-08-05 20:19:27 UTC (rev 204187)
</span><span class="lines">@@ -47,11 +47,11 @@
</span><span class="cx"> var mean = row[this._meanIndex];
</span><span class="cx"> var sum = row[this._sumIndex];
</span><span class="cx"> var squareSum = row[this._squareSumIndex];
</span><del>- var revisionList = row[this._revisionsIndex];
</del><span class="cx"> var buildId = row[this._buildIndex];
</span><span class="cx"> var builderId = row[this._builderIndex];
</span><del>- var buildNumber = row[this._buildNumberIndex];
- var buildTime = row[this._buildTimeIndex];
</del><ins>+ var cachedBuild = null;
+ var cachedInterval = null;
+
</ins><span class="cx"> var self = this;
</span><span class="cx"> return {
</span><span class="cx"> id: id,
</span><span class="lines">@@ -59,14 +59,22 @@
</span><span class="cx"> buildId: buildId,
</span><span class="cx"> metricId: null,
</span><span class="cx"> configType: null,
</span><del>- rootSet: function () { return MeasurementRootSet.ensureSingleton(id, revisionList); },
- build: function () { return new Build(buildId, Builder.findById(builderId), buildNumber, buildTime); },
</del><ins>+ rootSet: function () { return MeasurementRootSet.ensureSingleton(id, row[self._revisionsIndex]); },
+ build: function () {
+ if (cachedBuild == null)
+ cachedBuild = new Build(buildId, Builder.findById(builderId), row[self._buildNumberIndex], row[self._buildTimeIndex]);
+ return cachedBuild;
+ },
</ins><span class="cx"> time: row[this._commitTimeIndex],
</span><span class="cx"> value: mean,
</span><span class="cx"> sum: sum,
</span><span class="cx"> squareSum: squareSum,
</span><span class="cx"> iterationCount: row[this._countIndex],
</span><del>- interval: MeasurementAdaptor.computeConfidenceInterval(row[this._countIndex], mean, sum, squareSum)
</del><ins>+ interval: function () {
+ if (cachedInterval == null)
+ cachedInterval = MeasurementAdaptor.computeConfidenceInterval(row[self._countIndex], mean, sum, squareSum);
+ return cachedInterval;
+ }
</ins><span class="cx"> };
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsmeasurementclusterjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/measurement-cluster.js (204186 => 204187)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/measurement-cluster.js 2016-08-05 19:38:18 UTC (rev 204186)
+++ trunk/Websites/perf.webkit.org/public/v3/models/measurement-cluster.js 2016-08-05 20:19:27 UTC (rev 204187)
</span><span class="lines">@@ -17,17 +17,14 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> var self = this;
</span><del>- rawMeasurements.forEach(function (row) {
- var id = self._adaptor.extractId(row);
- if (id in idMap)
- return;
- if (self._adaptor.isOutlier(row) && !includeOutliers)
- return;
-
- idMap[id] = true;
-
- series.append(self._adaptor.applyTo(row));
- });
</del><ins>+ for (var row of rawMeasurements) {
+ var point = this._adaptor.applyTo(row);
+ if (point.id in idMap || (!includeOutliers && point.isOutlier))
+ continue;
+ idMap[point.id] = true;
+ point.cluster = this;
+ series.append(point);
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>