<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204197] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204197">204197</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-08-05 15:34:12 -0700 (Fri, 05 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>marquee with "truespeed" animates at > 60fps, hogging CPU
https://bugs.webkit.org/show_bug.cgi?id=160609
Reviewed by David Hyatt.
Source/WebCore:
A <marquee truespeed="" scrollDelay="0"> would fire a zero-delay timer and also
fail to animate, hogging CPU.
Fix to cap the timer at 16ms intervals. We don't believe it's necessary to
maintain web compatibility here.
Tested by existing tests.
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::minimumDelay):
* html/HTMLMarqueeElement.h:
LayoutTests:
Convert marquee tests into ref tests, removing all the platform expectations.
* fast/html/marquee-scroll-expected.html: Copied from LayoutTests/fast/html/marquee-scroll.html.
* fast/html/marquee-scroll.html:
* fast/html/marquee-scrollamount-expected.html: Added.
* fast/html/marquee-set-truespeed.html:
* platform/efl/fast/html/marquee-scroll-expected.png: Removed.
* platform/efl/fast/html/marquee-scroll-expected.txt: Removed.
* platform/efl/fast/html/marquee-scrollamount-expected.png: Removed.
* platform/efl/fast/html/marquee-scrollamount-expected.txt: Removed.
* platform/gtk/fast/html/marquee-scroll-expected.png: Removed.
* platform/gtk/fast/html/marquee-scroll-expected.txt: Removed.
* platform/gtk/fast/html/marquee-scrollamount-expected.png: Removed.
* platform/gtk/fast/html/marquee-scrollamount-expected.txt: Removed.
* platform/ios-simulator-wk1/TestExpectations:
* platform/ios-simulator-wk2/TestExpectations:
* platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt: Removed.
* platform/ios-simulator/fast/html/marquee-scroll-expected.txt: Removed.
* platform/ios-simulator/fast/html/marquee-scrollamount-expected.txt: Removed.
* platform/mac-wk1/TestExpectations:
* platform/mac/fast/html/marquee-scroll-expected.png: Removed.
* platform/mac/fast/html/marquee-scroll-expected.txt: Removed.
* platform/mac/fast/html/marquee-scrollamount-expected.png: Removed.
* platform/mac/fast/html/marquee-scrollamount-expected.txt: Removed.
* platform/win/TestExpectations:
* platform/win/fast/html/marquee-scroll-expected.txt: Removed.
* platform/win/fast/html/marquee-scrollamount-expected.txt: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasthtmlmarqueescrollhtml">trunk/LayoutTests/fast/html/marquee-scroll.html</a></li>
<li><a href="#trunkLayoutTestsfasthtmlmarqueesettruespeedhtml">trunk/LayoutTests/fast/html/marquee-set-truespeed.html</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorwk1TestExpectations">trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorwk2TestExpectations">trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk1TestExpectations">trunk/LayoutTests/platform/mac-wk1/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMarqueeElementcpp">trunk/Source/WebCore/html/HTMLMarqueeElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMarqueeElementh">trunk/Source/WebCore/html/HTMLMarqueeElement.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasthtmlmarqueescrollexpectedhtml">trunk/LayoutTests/fast/html/marquee-scroll-expected.html</a></li>
<li><a href="#trunkLayoutTestsfasthtmlmarqueescrollamountexpectedhtml">trunk/LayoutTests/fast/html/marquee-scrollamount-expected.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformeflfasthtmlmarqueescrollexpectedpng">trunk/LayoutTests/platform/efl/fast/html/marquee-scroll-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformeflfasthtmlmarqueescrollexpectedtxt">trunk/LayoutTests/platform/efl/fast/html/marquee-scroll-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformeflfasthtmlmarqueescrollamountexpectedpng">trunk/LayoutTests/platform/efl/fast/html/marquee-scrollamount-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformeflfasthtmlmarqueescrollamountexpectedtxt">trunk/LayoutTests/platform/efl/fast/html/marquee-scrollamount-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfasthtmlmarqueescrollexpectedpng">trunk/LayoutTests/platform/gtk/fast/html/marquee-scroll-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfasthtmlmarqueescrollexpectedtxt">trunk/LayoutTests/platform/gtk/fast/html/marquee-scroll-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfasthtmlmarqueescrollamountexpectedpng">trunk/LayoutTests/platform/gtk/fast/html/marquee-scrollamount-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfasthtmlmarqueescrollamountexpectedtxt">trunk/LayoutTests/platform/gtk/fast/html/marquee-scrollamount-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorfasthtmlmarqueescrollexpectedtxt">trunk/LayoutTests/platform/ios-simulator/fast/html/marquee-scroll-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorfasthtmlmarqueescrollamountexpectedtxt">trunk/LayoutTests/platform/ios-simulator/fast/html/marquee-scrollamount-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorwk2fasthtmlmarqueescrollamountexpectedtxt">trunk/LayoutTests/platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacfasthtmlmarqueescrollexpectedpng">trunk/LayoutTests/platform/mac/fast/html/marquee-scroll-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformmacfasthtmlmarqueescrollexpectedtxt">trunk/LayoutTests/platform/mac/fast/html/marquee-scroll-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacfasthtmlmarqueescrollamountexpectedpng">trunk/LayoutTests/platform/mac/fast/html/marquee-scrollamount-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformmacfasthtmlmarqueescrollamountexpectedtxt">trunk/LayoutTests/platform/mac/fast/html/marquee-scrollamount-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwinfasthtmlmarqueescrollexpectedtxt">trunk/LayoutTests/platform/win/fast/html/marquee-scroll-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformwinfasthtmlmarqueescrollamountexpectedtxt">trunk/LayoutTests/platform/win/fast/html/marquee-scrollamount-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/ChangeLog 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2016-08-05 Simon Fraser <simon.fraser@apple.com>
+
+ marquee with "truespeed" animates at > 60fps, hogging CPU
+ https://bugs.webkit.org/show_bug.cgi?id=160609
+
+ Reviewed by David Hyatt.
+
+ Convert marquee tests into ref tests, removing all the platform expectations.
+
+ * fast/html/marquee-scroll-expected.html: Copied from LayoutTests/fast/html/marquee-scroll.html.
+ * fast/html/marquee-scroll.html:
+ * fast/html/marquee-scrollamount-expected.html: Added.
+ * fast/html/marquee-set-truespeed.html:
+ * platform/efl/fast/html/marquee-scroll-expected.png: Removed.
+ * platform/efl/fast/html/marquee-scroll-expected.txt: Removed.
+ * platform/efl/fast/html/marquee-scrollamount-expected.png: Removed.
+ * platform/efl/fast/html/marquee-scrollamount-expected.txt: Removed.
+ * platform/gtk/fast/html/marquee-scroll-expected.png: Removed.
+ * platform/gtk/fast/html/marquee-scroll-expected.txt: Removed.
+ * platform/gtk/fast/html/marquee-scrollamount-expected.png: Removed.
+ * platform/gtk/fast/html/marquee-scrollamount-expected.txt: Removed.
+ * platform/ios-simulator-wk1/TestExpectations:
+ * platform/ios-simulator-wk2/TestExpectations:
+ * platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt: Removed.
+ * platform/ios-simulator/fast/html/marquee-scroll-expected.txt: Removed.
+ * platform/ios-simulator/fast/html/marquee-scrollamount-expected.txt: Removed.
+ * platform/mac-wk1/TestExpectations:
+ * platform/mac/fast/html/marquee-scroll-expected.png: Removed.
+ * platform/mac/fast/html/marquee-scroll-expected.txt: Removed.
+ * platform/mac/fast/html/marquee-scrollamount-expected.png: Removed.
+ * platform/mac/fast/html/marquee-scrollamount-expected.txt: Removed.
+ * platform/win/TestExpectations:
+ * platform/win/fast/html/marquee-scroll-expected.txt: Removed.
+ * platform/win/fast/html/marquee-scrollamount-expected.txt: Removed.
+
</ins><span class="cx"> 2016-08-05 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r204181.
</span></span></pre></div>
<a id="trunkLayoutTestsfasthtmlmarqueescrollexpectedhtmlfromrev204196trunkLayoutTestsfasthtmlmarqueescrollhtml"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/fast/html/marquee-scroll-expected.html (from rev 204196, trunk/LayoutTests/fast/html/marquee-scroll.html) (0 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/html/marquee-scroll-expected.html (rev 0)
+++ trunk/LayoutTests/fast/html/marquee-scroll-expected.html 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+<html>
+<title>Test for marquee scrolling behavior</title>
+<body>
+
+<p>Test for <a href="http://bugs.webkit.org/show_bug.cgi?id=15263">bug 15263</a>:
+REGRESSION: scrolldelay=0 causes marquee not to display</p>
+
+<p>The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty string. It should scroll until the text, &quot;The marquee scroll test passed&quot; is visible and left justified.</p>
+
+<div id="marquee" style="width: 300px; background-color:cyan;">
+The marquee scroll test passed
+</div>
+
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasthtmlmarqueescrollhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/html/marquee-scroll.html (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/html/marquee-scroll.html 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/fast/html/marquee-scroll.html 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,15 +1,35 @@
</span><span class="cx"> <html>
</span><span class="cx"> <title>Test for marquee scrolling behavior</title>
</span><ins>+<script>
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function waitForMarquee()
+ {
+ var counter = 0;
+ var marqueeWidth = document.getElementById('marquee').offsetWidth;
+ var numSteps = 1 + marqueeWidth / 6; // Default scrollAmount is 6px
+
+ var interval = window.setInterval(function() {
+ if (++counter >= numSteps) {
+ window.clearInterval(interval);
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }
+ }, 16);
+ }
+ window.addEventListener('load', waitForMarquee, false);
+</script>
</ins><span class="cx"> <body>
</span><span class="cx">
</span><span class="cx"> <p>Test for <a href="http://bugs.webkit.org/show_bug.cgi?id=15263">bug 15263</a>:
</span><span class="cx"> REGRESSION: scrolldelay=0 causes marquee not to display</p>
</span><span class="cx">
</span><del>-<p>The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty string. It should scroll until the text, &quot;The marquee scroll test passed&quot is visible and left justified.</p>
</del><ins>+<p>The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty string. It should scroll until the text, &quot;The marquee scroll test passed&quot; is visible and left justified.</p>
</ins><span class="cx">
</span><del>-<marquee width="50%" behavior="slide" bgcolor="cyan" truespeed="" scrollDelay="0">
</del><ins>+<marquee id="marquee" width="300px" behavior="slide" bgcolor="cyan" truespeed="" scrollDelay="0">
</ins><span class="cx"> The marquee scroll test passed
</span><span class="cx"> </marquee>
</span><span class="cx">
</span><span class="cx"> </body>
</span><del>-</html>
</del><span class="cx">\ No newline at end of file
</span><ins>+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasthtmlmarqueescrollamountexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/html/marquee-scrollamount-expected.html (0 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/html/marquee-scrollamount-expected.html (rev 0)
+++ trunk/LayoutTests/fast/html/marquee-scrollamount-expected.html 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+<body>
+<p>This is a regression test for https://bugs.webkit.org/show_bug.cgi?id=50434. It verifies that a marquee does not animate when scrollAmount is set to 0 by script.</p>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasthtmlmarqueesettruespeedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/html/marquee-set-truespeed.html (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/html/marquee-set-truespeed.html 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/fast/html/marquee-set-truespeed.html 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -18,6 +18,6 @@
</span><span class="cx"> setTimeout(function() {
</span><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.notifyDone();
</span><del>- }, 10);
</del><ins>+ }, 20);
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflfasthtmlmarqueescrollexpectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/platform/efl/fast/html/marquee-scroll-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflfasthtmlmarqueescrollexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/efl/fast/html/marquee-scroll-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/fast/html/marquee-scroll-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/efl/fast/html/marquee-scroll-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,23 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x18
- RenderText {#text} at (0,0) size 53x17
- text run at (0,0) width 53: "Test for "
- RenderInline {A} at (0,0) size 68x17 [color=#0000EE]
- RenderText {#text} at (53,0) size 68x17
- text run at (53,0) width 68: "bug 15263"
- RenderText {#text} at (121,0) size 394x17
- text run at (121,0) width 394: ": REGRESSION: scrolldelay=0 causes marquee not to display"
- RenderBlock {P} at (0,34) size 784x36
- RenderText {#text} at (0,0) size 776x35
- text run at (0,0) width 776: "The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty string."
- text run at (0,18) width 557: "It should scroll until the text, \"The marquee scroll test passed\" is visible and left justified."
- RenderBlock (anonymous) at (0,86) size 784x18
- RenderText {#text} at (0,0) size 0x0
-layer at (8,94) size 392x18 scrollX -392
- RenderBlock {MARQUEE} at (0,0) size 392x18 [bgcolor=#00FFFF]
- RenderText {#text} at (0,0) size 192x17
- text run at (0,0) width 192: "The marquee scroll test passed"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformeflfasthtmlmarqueescrollamountexpectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/platform/efl/fast/html/marquee-scrollamount-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflfasthtmlmarqueescrollamountexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/efl/fast/html/marquee-scrollamount-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/efl/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,14 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x36
- RenderText {#text} at (0,0) size 750x35
- text run at (0,0) width 750: "This is a regression test for https://bugs.webkit.org/show_bug.cgi?id=50434. It verifies that a marquee does not animate"
- text run at (0,18) width 250: "when scrollAmount is set to 0 by script."
- RenderBlock (anonymous) at (0,52) size 784x18
-layer at (8,60) size 100x18 scrollX -100
- RenderBlock {MARQUEE} at (0,0) size 100x18
- RenderText {#text} at (0,0) size 27x17
- text run at (0,0) width 27: "Test"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfasthtmlmarqueescrollexpectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/platform/gtk/fast/html/marquee-scroll-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfasthtmlmarqueescrollexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/gtk/fast/html/marquee-scroll-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/html/marquee-scroll-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/gtk/fast/html/marquee-scroll-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,23 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x17
- RenderText {#text} at (0,0) size 53x17
- text run at (0,0) width 53: "Test for "
- RenderInline {A} at (0,0) size 68x17 [color=#0000EE]
- RenderText {#text} at (53,0) size 68x17
- text run at (53,0) width 68: "bug 15263"
- RenderText {#text} at (121,0) size 394x17
- text run at (121,0) width 394: ": REGRESSION: scrolldelay=0 causes marquee not to display"
- RenderBlock {P} at (0,33) size 784x34
- RenderText {#text} at (0,0) size 776x34
- text run at (0,0) width 776: "The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty string."
- text run at (0,17) width 557: "It should scroll until the text, \"The marquee scroll test passed\" is visible and left justified."
- RenderBlock (anonymous) at (0,83) size 784x17
- RenderText {#text} at (0,0) size 0x0
-layer at (8,91) size 392x17 scrollX -392
- RenderBlock {MARQUEE} at (0,0) size 392x17 [bgcolor=#00FFFF]
- RenderText {#text} at (0,0) size 192x17
- text run at (0,0) width 192: "The marquee scroll test passed"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfasthtmlmarqueescrollamountexpectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/platform/gtk/fast/html/marquee-scrollamount-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfasthtmlmarqueescrollamountexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/gtk/fast/html/marquee-scrollamount-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/gtk/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,14 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x34
- RenderText {#text} at (0,0) size 750x34
- text run at (0,0) width 750: "This is a regression test for https://bugs.webkit.org/show_bug.cgi?id=50434. It verifies that a marquee does not animate"
- text run at (0,17) width 250: "when scrollAmount is set to 0 by script."
- RenderBlock (anonymous) at (0,50) size 784x17
-layer at (8,58) size 100x17 scrollX -100
- RenderBlock {MARQUEE} at (0,0) size 100x17
- RenderText {#text} at (0,0) size 27x17
- text run at (0,0) width 27: "Test"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorfasthtmlmarqueescrollexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/ios-simulator/fast/html/marquee-scroll-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/fast/html/marquee-scroll-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/ios-simulator/fast/html/marquee-scroll-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,24 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x20
- RenderText {#text} at (0,0) size 54x19
- text run at (0,0) width 54: "Test for "
- RenderInline {A} at (0,0) size 69x19 [color=#0000EE]
- RenderText {#text} at (53,0) size 69x19
- text run at (53,0) width 69: "bug 15263"
- RenderText {#text} at (121,0) size 399x19
- text run at (121,0) width 399: ": REGRESSION: scrolldelay=0 causes marquee not to display"
- RenderBlock {P} at (0,36) size 784x40
- RenderText {#text} at (0,0) size 747x39
- text run at (0,0) width 747: "The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty"
- text run at (0,20) width 45: "string. "
- text run at (44,20) width 573: "It should scroll until the text, \"The marquee scroll test passed\" is visible and left justified."
- RenderBlock (anonymous) at (0,92) size 784x20
- RenderText {#text} at (0,0) size 0x0
-layer at (8,100) size 392x20 scrollX -392
- RenderBlock {MARQUEE} at (0,0) size 392x20 [bgcolor=#00FFFF]
- RenderText {#text} at (0,0) size 197x19
- text run at (0,0) width 197: "The marquee scroll test passed"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorfasthtmlmarqueescrollamountexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/ios-simulator/fast/html/marquee-scrollamount-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/ios-simulator/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,15 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x40
- RenderText {#text} at (0,0) size 767x39
- text run at (0,0) width 767: "This is a regression test for https://bugs.webkit.org/show_bug.cgi?id=50434. It verifies that a marquee does not animate"
- text run at (0,20) width 256: "when scrollAmount is set to 0 by script."
- RenderBlock (anonymous) at (0,56) size 784x20
- RenderText {#text} at (0,0) size 0x0
-layer at (8,64) size 100x20 scrollX -100
- RenderBlock {MARQUEE} at (0,0) size 100x20
- RenderText {#text} at (0,0) size 27x19
- text run at (0,0) width 27: "Test"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorwk1TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -419,7 +419,6 @@
</span><span class="cx"> editing/unsupported-content/list-delete-003.html [ Failure ]
</span><span class="cx"> editing/unsupported-content/table-delete-002.html [ Failure ]
</span><span class="cx"> fast/forms/textfield-outline.html [ Failure ]
</span><del>-fast/html/marquee-scrollamount.html [ Failure ]
</del><span class="cx"> platform/ios-simulator/ios/fast/coordinates/document-elementFromPoint.html [ Failure ]
</span><span class="cx"> platform/ios-simulator/ios/fast/coordinates/element-client-rects.html [ Failure ]
</span><span class="cx"> platform/ios-simulator/ios/fast/coordinates/mouse-event-zoomed.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1464,7 +1464,6 @@
</span><span class="cx"> fast/dom/Geolocation/disconnected-frame-permission-denied.html
</span><span class="cx"> fast/dom/Geolocation/error.html
</span><span class="cx"> fast/events/mouse-cursor-multiframecur.html
</span><del>-fast/html/marquee-scrollamount.html [ Failure ]
</del><span class="cx"> fast/loader/frames-with-unload-handlers-in-page-cache.html
</span><span class="cx"> http/tests/cache/cache-redirections.html
</span><span class="cx"> js/promises-tests/promises-tests-2-2-6.html
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorwk2fasthtmlmarqueescrollamountexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,14 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x40
- RenderText {#text} at (0,0) size 767x39
- text run at (0,0) width 767: "This is a regression test for https://bugs.webkit.org/show_bug.cgi?id=50434. It verifies that a marquee does not animate"
- text run at (0,20) width 256: "when scrollAmount is set to 0 by script."
- RenderBlock (anonymous) at (0,56) size 784x20
-layer at (8,64) size 100x20 scrollX -10
- RenderBlock {MARQUEE} at (0,0) size 100x20
- RenderText {#text} at (0,0) size 27x19
- text run at (0,0) width 27: "Test"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmacfasthtmlmarqueescrollexpectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/platform/mac/fast/html/marquee-scroll-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacfasthtmlmarqueescrollexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/mac/fast/html/marquee-scroll-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/html/marquee-scroll-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/mac/fast/html/marquee-scroll-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,24 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x18
- RenderText {#text} at (0,0) size 54x18
- text run at (0,0) width 54: "Test for "
- RenderInline {A} at (0,0) size 69x18 [color=#0000EE]
- RenderText {#text} at (53,0) size 69x18
- text run at (53,0) width 69: "bug 15263"
- RenderText {#text} at (121,0) size 399x18
- text run at (121,0) width 399: ": REGRESSION: scrolldelay=0 causes marquee not to display"
- RenderBlock {P} at (0,34) size 784x36
- RenderText {#text} at (0,0) size 746x36
- text run at (0,0) width 746: "The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty"
- text run at (0,18) width 45: "string. "
- text run at (44,18) width 573: "It should scroll until the text, \"The marquee scroll test passed\" is visible and left justified."
- RenderBlock (anonymous) at (0,86) size 784x18
- RenderText {#text} at (0,0) size 0x0
-layer at (8,94) size 392x18 scrollX -392
- RenderBlock {MARQUEE} at (0,0) size 392x18 [bgcolor=#00FFFF]
- RenderText {#text} at (0,0) size 197x18
- text run at (0,0) width 197: "The marquee scroll test passed"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmacfasthtmlmarqueescrollamountexpectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/platform/mac/fast/html/marquee-scrollamount-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacfasthtmlmarqueescrollamountexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/mac/fast/html/marquee-scrollamount-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/mac/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,14 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x36
- RenderText {#text} at (0,0) size 766x36
- text run at (0,0) width 766: "This is a regression test for https://bugs.webkit.org/show_bug.cgi?id=50434. It verifies that a marquee does not animate"
- text run at (0,18) width 256: "when scrollAmount is set to 0 by script."
- RenderBlock (anonymous) at (0,52) size 784x18
-layer at (8,60) size 100x18 scrollX -100
- RenderBlock {MARQUEE} at (0,0) size 100x18
- RenderText {#text} at (0,0) size 27x18
- text run at (0,0) width 27: "Test"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk1TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -228,7 +228,6 @@
</span><span class="cx"> [ Sierra+ ] accessibility/parent-delete.html [ Failure ]
</span><span class="cx">
</span><span class="cx"> # rdar://problem/26422051
</span><del>-[ Sierra+ ] fast/html/marquee-scroll.html [ Failure ]
</del><span class="cx"> [ Sierra+ ] fast/inline-block/003.html [ Failure ]
</span><span class="cx">
</span><span class="cx"> # rdar://problem/26478296
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/win/TestExpectations 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -2769,8 +2769,6 @@
</span><span class="cx"> fast/history/location-replace-hash.html [ Skip ]
</span><span class="cx"> fast/history/saves-state-after-fragment-nav.html [ Skip ]
</span><span class="cx">
</span><del>-fast/html/marquee-scrollamount.html [ Failure ]
-
</del><span class="cx"> fast/images/image-controls-basic.html [ Failure ]
</span><span class="cx"> fast/images/exif-orientation-composited.html [ Failure ]
</span><span class="cx"> webkit.org/b/140516 [ Debug ] fast/images/large-size-image-crash.html [ Skip ] # Crashing
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinfasthtmlmarqueescrollexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/win/fast/html/marquee-scroll-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/fast/html/marquee-scroll-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/win/fast/html/marquee-scroll-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,23 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x18
- RenderText {#text} at (0,0) size 53x18
- text run at (0,0) width 53: "Test for "
- RenderInline {A} at (0,0) size 68x18 [color=#0000EE]
- RenderText {#text} at (53,0) size 68x18
- text run at (53,0) width 68: "bug 15263"
- RenderText {#text} at (121,0) size 394x18
- text run at (121,0) width 394: ": REGRESSION: scrolldelay=0 causes marquee not to display"
- RenderBlock {P} at (0,34) size 784x36
- RenderText {#text} at (0,0) size 776x36
- text run at (0,0) width 776: "The marquee below is defined with a scrollDelay value of zero and with the truespeed attribute assigned to an empty string."
- text run at (0,18) width 557: "It should scroll until the text, \"The marquee scroll test passed\" is visible and left justified."
- RenderBlock (anonymous) at (0,86) size 784x18
- RenderText {#text} at (0,0) size 0x0
-layer at (8,94) size 392x18 scrollX -392
- RenderBlock {MARQUEE} at (0,0) size 392x18 [bgcolor=#00FFFF]
- RenderText {#text} at (0,0) size 192x18
- text run at (0,0) width 192: "The marquee scroll test passed"
</del></span></pre></div>
<a id="trunkLayoutTestsplatformwinfasthtmlmarqueescrollamountexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/win/fast/html/marquee-scrollamount-expected.txt (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/LayoutTests/platform/win/fast/html/marquee-scrollamount-expected.txt 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,14 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x36
- RenderText {#text} at (0,0) size 750x36
- text run at (0,0) width 750: "This is a regression test for https://bugs.webkit.org/show_bug.cgi?id=50434. It verifies that a marquee does not animate"
- text run at (0,18) width 250: "when scrollAmount is set to 0 by script."
- RenderBlock (anonymous) at (0,52) size 784x18
-layer at (8,60) size 100x18 scrollX -100
- RenderBlock {MARQUEE} at (0,0) size 100x18
- RenderText {#text} at (0,0) size 27x18
- text run at (0,0) width 27: "Test"
</del><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/Source/WebCore/ChangeLog 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-08-05 Simon Fraser <simon.fraser@apple.com>
+
+ marquee with "truespeed" animates at > 60fps, hogging CPU
+ https://bugs.webkit.org/show_bug.cgi?id=160609
+
+ Reviewed by David Hyatt.
+
+ A <marquee truespeed="" scrollDelay="0"> would fire a zero-delay timer and also
+ fail to animate, hogging CPU.
+
+ Fix to cap the timer at 16ms intervals. We don't believe it's necessary to
+ maintain web compatibility here.
+
+ Tested by existing tests.
+
+ * html/HTMLMarqueeElement.cpp:
+ (WebCore::HTMLMarqueeElement::minimumDelay):
+ * html/HTMLMarqueeElement.h:
+
</ins><span class="cx"> 2016-08-05 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r204181.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMarqueeElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMarqueeElement.cpp (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMarqueeElement.cpp 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/Source/WebCore/html/HTMLMarqueeElement.cpp 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> // WinIE uses 60ms as the minimum delay by default.
</span><span class="cx"> return 60;
</span><span class="cx"> }
</span><del>- return 0;
</del><ins>+ return 16; // Don't allow timers at < 16ms intervals to avoid CPU hogging: webkit.org/b/160609
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool HTMLMarqueeElement::isPresentationAttribute(const QualifiedName& name) const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMarqueeElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMarqueeElement.h (204196 => 204197)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMarqueeElement.h 2016-08-05 22:26:01 UTC (rev 204196)
+++ trunk/Source/WebCore/html/HTMLMarqueeElement.h 2016-08-05 22:34:12 UTC (rev 204197)
</span><span class="lines">@@ -41,12 +41,15 @@
</span><span class="cx"> void start();
</span><span class="cx"> void stop() final;
</span><span class="cx">
</span><ins>+ // Number of pixels to move on each scroll movement. Defaults to 6.
</ins><span class="cx"> unsigned scrollAmount() const;
</span><span class="cx"> void setScrollAmount(unsigned);
</span><span class="cx">
</span><ins>+ // Interval between each scroll movement, in milliseconds. Defaults to 60.
</ins><span class="cx"> unsigned scrollDelay() const;
</span><span class="cx"> void setScrollDelay(unsigned);
</span><span class="cx">
</span><ins>+ // Loop count. -1 means loop indefinitely.
</ins><span class="cx"> int loop() const;
</span><span class="cx"> void setLoop(int, ExceptionCode&);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>