<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204156] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204156">204156</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-04 17:46:05 -0700 (Thu, 04 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>UI improvements to Flakiness Dashboard.
https://bugs.webkit.org/show_bug.cgi?id=153295
Patch by Dean Johnson <dean_johnson@apple.com> on 2016-08-04
Reviewed by Alexey Proskuryakov.
* TestResultServer/static-dashboards/flakiness_dashboard.css:
(td.options-container): Center text in most fields.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(createBugHTML): Text/Grammar updates.
(tableHeaders): Ditto.
(htmlForSingleTestRow): Ditto.
(headerForTestTableHtml): Ditto.
* TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
(ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsflakiness_dashboardcss">trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsflakiness_dashboardjs">trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsuijs">trunk/Tools/TestResultServer/static-dashboards/ui.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (204155 => 204156)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-08-05 00:23:12 UTC (rev 204155)
+++ trunk/Tools/ChangeLog 2016-08-05 00:46:05 UTC (rev 204156)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-08-04 Dean Johnson <dean_johnson@apple.com>
+
+ UI improvements to Flakiness Dashboard.
+ https://bugs.webkit.org/show_bug.cgi?id=153295
+
+ Reviewed by Alexey Proskuryakov.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.css:
+ (td.options-container): Center text in most fields.
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ (createBugHTML): Text/Grammar updates.
+ (tableHeaders): Ditto.
+ (htmlForSingleTestRow): Ditto.
+ (headerForTestTableHtml): Ditto.
+ * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
+ (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
+
</ins><span class="cx"> 2016-08-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsflakiness_dashboardcss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css (204155 => 204156)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css 2016-08-05 00:23:12 UTC (rev 204155)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css 2016-08-05 00:46:05 UTC (rev 204156)
</span><span class="lines">@@ -47,6 +47,9 @@
</span><span class="cx"> padding-left: 2em;
</span><span class="cx"> white-space: nowrap;
</span><span class="cx"> }
</span><ins>+td.options-container {
+ text-align: center;
+}
</ins><span class="cx"> .forms {
</span><span class="cx"> display: -webkit-box;
</span><span class="cx"> -webkit-box-align: baseline;
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsflakiness_dashboardjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (204155 => 204156)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2016-08-05 00:23:12 UTC (rev 204155)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2016-08-05 00:46:05 UTC (rev 204156)
</span><span class="lines">@@ -1328,7 +1328,7 @@
</span><span class="cx">
</span><span class="cx"> var component = encodeURIComponent('Tools / Tests');
</span><span class="cx"> url = 'https://bugs.webkit.org/enter_bug.cgi?assigned_to=webkit-unassigned%40lists.webkit.org&product=WebKit&form_name=enter_bug&component=' + component + '&short_desc=' + title + '&comment=' + description;
</span><del>- return '<a href="' + url + '" class="file-bug">FILE BUG</a>';
</del><ins>+ return '<a href="' + url + '" class="file-bug">File</a>';
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function isCrossBuilderView()
</span><span class="lines">@@ -1340,15 +1340,15 @@
</span><span class="cx"> {
</span><span class="cx"> var headers = [];
</span><span class="cx"> if (isCrossBuilderView() || opt_getAll)
</span><del>- headers.push('builder');
</del><ins>+ headers.push('Builder');
</ins><span class="cx">
</span><span class="cx"> if (!isCrossBuilderView() || opt_getAll)
</span><del>- headers.push('test');
</del><ins>+ headers.push('Test');
</ins><span class="cx">
</span><span class="cx"> if (g_history.isLayoutTestResults() || opt_getAll)
</span><del>- headers.push('bugs', 'modifiers', 'expectations');
</del><ins>+ headers.push('Bug(s)', 'Modifiers', 'Expectation(s)');
</ins><span class="cx">
</span><del>- headers.push('slowest run', 'flakiness (numbers are runtimes in seconds)');
</del><ins>+ headers.push('Slowest Run', 'Flakiness (Numbers are runtimes in seconds)');
</ins><span class="cx"> return headers;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1366,7 +1366,7 @@
</span><span class="cx"> var html = '';
</span><span class="cx"> for (var i = 0; i < headers.length; i++) {
</span><span class="cx"> var header = headers[i];
</span><del>- if (string.startsWith(header, 'test') || string.startsWith(header, 'builder')) {
</del><ins>+ if (string.startsWith(header, 'Test') || string.startsWith(header, 'Builder')) {
</ins><span class="cx"> // If isCrossBuilderView() is true, we're just viewing a single test
</span><span class="cx"> // with results for many builders, so the first column is builder names
</span><span class="cx"> // instead of test paths.
</span><span class="lines">@@ -1374,15 +1374,15 @@
</span><span class="cx"> var testCellHTML = isCrossBuilderView() ? test.builder : '<span class="link" onclick="g_history.setQueryParameter(\'tests\',\'' + test.test +'\');">' + test.test + '</span>';
</span><span class="cx">
</span><span class="cx"> html += '<tr><td class="' + testCellClassName + '">' + testCellHTML;
</span><del>- } else if (string.startsWith(header, 'bugs'))
- html += '<td class=options-container>' + (test.bugs ? htmlForBugs(test.bugs) : createBugHTML(test));
- else if (string.startsWith(header, 'modifiers'))
</del><ins>+ } else if (string.startsWith(header, 'Bug(s)'))
+ html += '<td class=options-container bugs>' + (test.bugs ? htmlForBugs(test.bugs) : createBugHTML(test));
+ else if (string.startsWith(header, 'Modifiers'))
</ins><span class="cx"> html += '<td class=options-container>' + test.modifiers;
</span><del>- else if (string.startsWith(header, 'expectations'))
- html += '<td class=options-container>' + test.expectations;
- else if (string.startsWith(header, 'slowest'))
- html += '<td>' + (test.slowestTime ? test.slowestTime + 's' : '');
- else if (string.startsWith(header, 'flakiness'))
</del><ins>+ else if (string.startsWith(header, 'Expectation(s)'))
+ html += '<td class=options-container>' + test.expectations.split(' ').join(' | ');
+ else if (string.startsWith(header, 'Slowest'))
+ html += '<td class=options-container>' + (test.slowestTime ? test.slowestTime + 's' : '');
+ else if (string.startsWith(header, 'Flakiness'))
</ins><span class="cx"> html += htmlForTestResults(test);
</span><span class="cx"> }
</span><span class="cx"> return html;
</span><span class="lines">@@ -2177,12 +2177,12 @@
</span><span class="cx">
</span><span class="cx"> function headerForTestTableHtml()
</span><span class="cx"> {
</span><del>- return '<h2 style="display:inline-block">Failing tests</h2>' +
- checkBoxToToggleState('showWontFixSkip', 'WONTFIX/SKIP') +
- checkBoxToToggleState('showCorrectExpectations', 'tests with correct expectations') +
- checkBoxToToggleState('showWrongExpectations', 'tests with wrong expectations') +
- checkBoxToToggleState('showFlaky', 'flaky') +
- checkBoxToToggleState('showSlow', 'slow');
</del><ins>+ return '<h2 style="display:inline-block">Show Tests Flagged As/With: </h2>' +
+ checkBoxToToggleState('showWontFixSkip', "Won't Fix/Skip") +
+ checkBoxToToggleState('showCorrectExpectations', 'Correct Expectations') +
+ checkBoxToToggleState('showWrongExpectations', 'Incorrect Expectations') +
+ checkBoxToToggleState('showFlaky', 'Flaky') +
+ checkBoxToToggleState('showSlow', 'Slow');
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function generatePageForBuilder(builderName)
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsuijs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/ui.js (204155 => 204156)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/ui.js 2016-08-05 00:23:12 UTC (rev 204155)
+++ trunk/Tools/TestResultServer/static-dashboards/ui.js 2016-08-05 00:46:05 UTC (rev 204156)
</span><span class="lines">@@ -110,8 +110,6 @@
</span><span class="cx"> ui.html._dashboardLink('Results', 'flakiness_dashboard.html') +
</span><span class="cx"> ui.html._dashboardLink('Treemap', 'treemap.html');
</span><span class="cx">
</span><del>- html += ui.html.select('Test type', 'testType', TEST_TYPES);
-
</del><span class="cx"> if (!opt_noBuilderMenu) {
</span><span class="cx"> var buildersForMenu = Object.keys(currentBuilders());
</span><span class="cx"> if (opt_includeNoneBuilder)
</span><span class="lines">@@ -119,9 +117,6 @@
</span><span class="cx"> html += ui.html.select('Builder', 'builder', buildersForMenu);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- html += ui.html.select('Group', 'group',
- Object.keys(currentBuilderGroupCategory()));
-
</del><span class="cx"> if (!history.isTreeMap())
</span><span class="cx"> html += ui.html.checkbox('showAllRuns', 'Show all runs', g_history.crossDashboardState.showAllRuns);
</span><span class="cx">
</span><span class="lines">@@ -212,4 +207,4 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-})();
</del><span class="cx">\ No newline at end of file
</span><ins>+})();
</ins></span></pre>
</div>
</div>
</body>
</html>