<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204148] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204148">204148</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-04 15:37:14 -0700 (Thu, 04 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add some extra test coverage for active touch event handler on subdocuments
https://bugs.webkit.org/show_bug.cgi?id=160276
Reviewed by Alex Christensen.
I wrote some tests while chasing a bug.
Documents are handled differently than other EventTarget. We had no test coverage
for that.
* fast/events/touch/ios/touch-event-listeners-on-detached-document-expected.txt: Added.
* fast/events/touch/ios/touch-event-listeners-on-detached-document.html: Added.
* fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame-expected.txt: Added.
* fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame.html: Added.
* fast/events/touch/ios/touch-event-listeners-on-subdocuments-expected.txt: Added.
* fast/events/touch/ios/touch-event-listeners-on-subdocuments.html: Added.
* fast/events/touch/ios/touch-event-listeners-on-template-document-expected.txt: Added.
* fast/events/touch/ios/touch-event-listeners-on-template-document.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasteventstouchiostoucheventlistenersondetacheddocumentexpectedtxt">trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-detached-document-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiostoucheventlistenersondetacheddocumenthtml">trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-detached-document.html</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiostoucheventlistenersonsubdocumentthendetachfromframeexpectedtxt">trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiostoucheventlistenersonsubdocumentthendetachfromframehtml">trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame.html</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiostoucheventlistenersonsubdocumentsexpectedtxt">trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocuments-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiostoucheventlistenersonsubdocumentshtml">trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocuments.html</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiostoucheventlistenersontemplatedocumentexpectedtxt">trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-template-document-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchiostoucheventlistenersontemplatedocumenthtml">trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-template-document.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204147 => 204148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-04 22:34:26 UTC (rev 204147)
+++ trunk/LayoutTests/ChangeLog 2016-08-04 22:37:14 UTC (rev 204148)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-08-04 Benjamin Poulain <benjamin@webkit.org>
+
+ Add some extra test coverage for active touch event handler on subdocuments
+ https://bugs.webkit.org/show_bug.cgi?id=160276
+
+ Reviewed by Alex Christensen.
+
+ I wrote some tests while chasing a bug.
+ Documents are handled differently than other EventTarget. We had no test coverage
+ for that.
+
+ * fast/events/touch/ios/touch-event-listeners-on-detached-document-expected.txt: Added.
+ * fast/events/touch/ios/touch-event-listeners-on-detached-document.html: Added.
+ * fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame-expected.txt: Added.
+ * fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame.html: Added.
+ * fast/events/touch/ios/touch-event-listeners-on-subdocuments-expected.txt: Added.
+ * fast/events/touch/ios/touch-event-listeners-on-subdocuments.html: Added.
+ * fast/events/touch/ios/touch-event-listeners-on-template-document-expected.txt: Added.
+ * fast/events/touch/ios/touch-event-listeners-on-template-document.html: Added.
+
</ins><span class="cx"> 2016-08-04 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Rebaseline http/tests/security/cross-frame-access-put.html after r204126.
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostoucheventlistenersondetacheddocumentexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-detached-document-expected.txt (0 => 204148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-detached-document-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-detached-document-expected.txt 2016-08-04 22:37:14 UTC (rev 204148)
</span><span class="lines">@@ -0,0 +1,9 @@
</span><ins>+Check the lifecycle of a touch event handler of a document detached from the top document
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostoucheventlistenersondetacheddocumenthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-detached-document.html (0 => 204148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-detached-document.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-detached-document.html 2016-08-04 22:37:14 UTC (rev 204148)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <script src="../../../../resources/js-test-pre.js"></script>
+ <style>
+ body {
+ margin: 0;
+ }
+ </style>
+ <meta name="viewport" content="initial-scale=1">
+</head>
+<body>
+ <script>
+ description("Check the lifecycle of a touch event handler of a document detached from the top document");
+
+ var detachedDocument = document.implementation.createHTMLDocument();
+ detachedDocument.addEventListener('touchstart', (event) => { debug("FAIL, this should not be called"); });
+ detachedDocument = undefined;
+ gc();
+ </script>
+ <script src="../../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostoucheventlistenersonsubdocumentthendetachfromframeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame-expected.txt (0 => 204148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame-expected.txt 2016-08-04 22:37:14 UTC (rev 204148)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+
+Check touch event listeners on sub-documents are correctly cleaned when the document is removed from the document.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+
+ Tapped (50, 50)
+PASS eventList is ['SecondLeveltouchstart']
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostoucheventlistenersonsubdocumentthendetachfromframehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame.html (0 => 204148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame.html 2016-08-04 22:37:14 UTC (rev 204148)
</span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <script src="../../../../resources/js-test-pre.js"></script>
+ <style>
+ body {
+ margin: 0;
+ }
+ </style>
+ <meta name="viewport" content="initial-scale=1">
+</head>
+<body>
+ <iframe id="first-level-iframe" src="about:blank" width="300" height="300" frameBorder="0"></iframe>
+ <p id="description"></p>
+ <div id="console">
+ </div>
+ <script>
+ description("Check touch event listeners on sub-documents are correctly cleaned when the document is removed from the document.");
+ window.jsTestIsAsync = true;
+
+ function getTapScript(x, y)
+ {
+ return `
+ (function() {
+ uiController.singleTapAtPoint(${x}, ${y}, function() {
+ uiController.uiScriptComplete("Tapped (" + ${x} + ", " + ${y} + ")");
+ });
+ })();`
+ }
+
+ function runTest()
+ {
+ var firstLevelIframe = document.getElementById("first-level-iframe");
+ firstLevelIframe.contentDocument.write('<iframe id="second-level-iframe" src="about:blank" width="300" height="300" frameBorder="0"></iframe>');
+ var secondLevelIframe = firstLevelIframe.contentDocument.getElementById("second-level-iframe");
+
+ window.eventList = [];
+ firstLevelIframe.contentDocument.addEventListener('touchstart', (event) => { eventList.push("FirstLevel" + event.type); });
+ secondLevelIframe.contentDocument.addEventListener('touchstart', (event) => { eventList.push("SecondLevel" + event.type); });
+
+ testRunner.runUIScript(getTapScript(50, 50), function(result) {
+ debug(result);
+ shouldBe("eventList", "['SecondLeveltouchstart']");
+
+ var nestedDocument = secondLevelIframe.contentDocument;
+ // Navigate the iframe.
+ secondLevelIframe.addEventListener("load", () => {
+ nestedDocument = undefined;
+ gc();
+ setTimeout(finishJSTest, 0);
+ });
+ secondLevelIframe.src="";
+ secondLevelIframe = undefined;
+ gc();
+ });
+ }
+ window.addEventListener('load', runTest, false);
+ </script>
+ <script src="../../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostoucheventlistenersonsubdocumentsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocuments-expected.txt (0 => 204148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocuments-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocuments-expected.txt 2016-08-04 22:37:14 UTC (rev 204148)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+Check touch event listeners on sub-documents are correctly cleaned when the document is removed from the document.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+
+ Tapped (50, 50)
+PASS eventList is ['SecondLeveltouchstart']
+Tapped (50, 50)
+PASS eventList is ['SecondLeveltouchstart', 'FirstLeveltouchstart']
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostoucheventlistenersonsubdocumentshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocuments.html (0 => 204148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocuments.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-subdocuments.html 2016-08-04 22:37:14 UTC (rev 204148)
</span><span class="lines">@@ -0,0 +1,66 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <script src="../../../../resources/js-test-pre.js"></script>
+ <style>
+ body {
+ margin: 0;
+ }
+ </style>
+ <meta name="viewport" content="initial-scale=1">
+</head>
+<body>
+ <iframe id="first-level-iframe" src="about:blank" width="300" height="300" frameBorder="0"></iframe>
+ <p id="description"></p>
+ <div id="console">
+ </div>
+ <script>
+ description("Check touch event listeners on sub-documents are correctly cleaned when the document is removed from the document.");
+ window.jsTestIsAsync = true;
+
+ function getTapScript(x, y)
+ {
+ return `
+ (function() {
+ uiController.singleTapAtPoint(${x}, ${y}, function() {
+ uiController.uiScriptComplete("Tapped (" + ${x} + ", " + ${y} + ")");
+ });
+ })();`
+ }
+
+ function runTest()
+ {
+ var firstLevelIframe = document.getElementById("first-level-iframe");
+ firstLevelIframe.contentDocument.write('<iframe id="second-level-iframe" src="about:blank" width="300" height="300" frameBorder="0"></iframe>');
+ var secondLevelIframe = firstLevelIframe.contentDocument.getElementById("second-level-iframe");
+
+ window.eventList = [];
+ firstLevelIframe.contentDocument.addEventListener('touchstart', (event) => { eventList.push("FirstLevel" + event.type); });
+ secondLevelIframe.contentDocument.addEventListener('touchstart', (event) => { eventList.push("SecondLevel" + event.type); });
+
+ testRunner.runUIScript(getTapScript(50, 50), function(result) {
+ debug(result);
+ shouldBe("eventList", "['SecondLeveltouchstart']");
+
+ secondLevelIframe.parentElement.removeChild(secondLevelIframe);
+ secondLevelIframe = undefined;
+ gc();
+
+ testRunner.runUIScript(getTapScript(50, 50), function(result) {
+ debug(result);
+ shouldBe("eventList", "['SecondLeveltouchstart', 'FirstLeveltouchstart']");
+
+ firstLevelIframe.parentElement.removeChild(firstLevelIframe);
+ firstLevelIframe = undefined;
+ gc();
+
+ finishJSTest();
+ });
+ });
+ }
+ window.addEventListener('load', runTest, false);
+ </script>
+ <script src="../../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostoucheventlistenersontemplatedocumentexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-template-document-expected.txt (0 => 204148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-template-document-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-template-document-expected.txt 2016-08-04 22:37:14 UTC (rev 204148)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+Check touch event listener on the document of a template. This should not crash or make ASAN mad.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS I am making a note here: huge success
+Tapped (50, 50)
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchiostoucheventlistenersontemplatedocumenthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-template-document.html (0 => 204148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-template-document.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/touch-event-listeners-on-template-document.html 2016-08-04 22:37:14 UTC (rev 204148)
</span><span class="lines">@@ -0,0 +1,58 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <script src="../../../../resources/js-test-pre.js"></script>
+ <style>
+ body {
+ margin: 0;
+ }
+ </style>
+ <meta name="viewport" content="initial-scale=1">
+</head>
+<body>
+ <div id="wrapper">
+ <template>
+ <div>FAIL: this should not be visible!</div>
+ </template>
+ </div>
+ <script>
+ description("Check touch event listener on the document of a template. This should not crash or make ASAN mad.");
+ window.jsTestIsAsync = true;
+
+
+ function getTapScript(x, y)
+ {
+ return `
+ (function() {
+ uiController.singleTapAtPoint(${x}, ${y}, function() {
+ uiController.uiScriptComplete("Tapped (" + ${x} + ", " + ${y} + ")");
+ });
+ })();`
+ }
+
+ function setup()
+ {
+ let template = document.getElementsByTagName("template")[0];
+ let templateDocument = template.content.firstChild.ownerDocument;
+ document.addEventListener('touchstart', () => { debug("PASS I am making a note here: huge success"); });
+ templateDocument.addEventListener('touchstart', () => { debug("FAIL this should not be called"); });
+ }
+
+ function runTest()
+ {
+ setup();
+ gc();
+
+ testRunner.runUIScript(getTapScript(50, 50), function(result) {
+ debug(result);
+ document.getElementById("wrapper").innerHTML = "";
+ gc();
+ finishJSTest();
+ });
+ }
+ window.addEventListener('load', runTest, false);
+ </script>
+ <script src="../../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre>
</div>
</div>
</body>
</html>