<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204152] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204152">204152</a></dd>
<dt>Author</dt> <dd>mattbaker@apple.com</dd>
<dt>Date</dt> <dd>2016-08-04 16:46:07 -0700 (Thu, 04 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: UI polish for Edit Breakpoint dialog
https://bugs.webkit.org/show_bug.cgi?id=160566
<rdar://problem/27706378>
Reviewed by Timothy Hatcher.
* UserInterface/Images/BreakpointActionAdd.svg: Removed.
* UserInterface/Images/BreakpointActionRemove.svg: Removed.
Use Plus13.svg and Minus.svg instead.
* UserInterface/Views/BreakpointActionView.css:
(.breakpoint-action-button-container):
(.breakpoint-action-append-button,):
(.breakpoint-action-append-button):
(.breakpoint-action-remove-button):
Button styles should match Xcode.
(.breakpoint-action-append-button:active,): Deleted.
Brightness on activation no longer needed.
* UserInterface/Views/BreakpointActionView.js:
(WebInspector.BreakpointActionView):
Add a button container so buttons can float together.
* UserInterface/Views/BreakpointPopoverController.css:
(.wide .edit-breakpoint-popover-condition > .CodeMirror):
Increase condition field width by the same amount as the popover.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsBreakpointActionViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsBreakpointActionViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsBreakpointPopoverControllercss">trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceImagesBreakpointActionAddsvg">trunk/Source/WebInspectorUI/UserInterface/Images/BreakpointActionAdd.svg</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceImagesBreakpointActionRemovesvg">trunk/Source/WebInspectorUI/UserInterface/Images/BreakpointActionRemove.svg</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (204151 => 204152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-08-04 23:24:14 UTC (rev 204151)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-08-04 23:46:07 UTC (rev 204152)
</span><span class="lines">@@ -1,5 +1,34 @@
</span><span class="cx"> 2016-08-04 Matt Baker <mattbaker@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: UI polish for Edit Breakpoint dialog
+ https://bugs.webkit.org/show_bug.cgi?id=160566
+ <rdar://problem/27706378>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Images/BreakpointActionAdd.svg: Removed.
+ * UserInterface/Images/BreakpointActionRemove.svg: Removed.
+ Use Plus13.svg and Minus.svg instead.
+
+ * UserInterface/Views/BreakpointActionView.css:
+ (.breakpoint-action-button-container):
+ (.breakpoint-action-append-button,):
+ (.breakpoint-action-append-button):
+ (.breakpoint-action-remove-button):
+ Button styles should match Xcode.
+ (.breakpoint-action-append-button:active,): Deleted.
+ Brightness on activation no longer needed.
+
+ * UserInterface/Views/BreakpointActionView.js:
+ (WebInspector.BreakpointActionView):
+ Add a button container so buttons can float together.
+
+ * UserInterface/Views/BreakpointPopoverController.css:
+ (.wide .edit-breakpoint-popover-condition > .CodeMirror):
+ Increase condition field width by the same amount as the popover.
+
+2016-08-04 Matt Baker <mattbaker@apple.com>
+
</ins><span class="cx"> Web Inspector: Popover's arrow is misplaced
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=151236
</span><span class="cx"> <rdar://problem/23527296>
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceImagesBreakpointActionAddsvg"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebInspectorUI/UserInterface/Images/BreakpointActionAdd.svg (204151 => 204152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Images/BreakpointActionAdd.svg 2016-08-04 23:24:14 UTC (rev 204151)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/BreakpointActionAdd.svg 2016-08-04 23:46:07 UTC (rev 204152)
</span><span class="lines">@@ -1,6 +0,0 @@
</span><del>-<?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright © 2013 Apple Inc. All rights reserved. -->
-<svg xmlns="http://www.w3.org/2000/svg" id="root" version="1.1" viewBox="0 0 16 16">
- <path stroke="rgb(241, 242, 243)" stroke-width="2" d="M 4 9 L 12 9 M 8 5 L 8 13"/>
- <path stroke="rgb(129, 129, 129)" stroke-width="2" d="M 4 8 L 12 8 M 8 4 L 8 12"/>
-</svg>
</del></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceImagesBreakpointActionRemovesvg"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebInspectorUI/UserInterface/Images/BreakpointActionRemove.svg (204151 => 204152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Images/BreakpointActionRemove.svg 2016-08-04 23:24:14 UTC (rev 204151)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/BreakpointActionRemove.svg 2016-08-04 23:46:07 UTC (rev 204152)
</span><span class="lines">@@ -1,6 +0,0 @@
</span><del>-<?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright © 2013 Apple Inc. All rights reserved. -->
-<svg xmlns="http://www.w3.org/2000/svg" id="root" version="1.1" viewBox="0 0 16 16">
- <path stroke="rgb(241, 242, 243)" stroke-width="2" d="M 12 9 L 4 9"/>
- <path stroke="rgb(129, 129, 129)" stroke-width="2" d="M 12 8 L 4 8"/>
-</svg>
</del></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsBreakpointActionViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css (204151 => 204152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css 2016-08-04 23:24:14 UTC (rev 204151)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css 2016-08-04 23:46:07 UTC (rev 204152)
</span><span class="lines">@@ -27,30 +27,28 @@
</span><span class="cx"> margin-bottom: 3px;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.breakpoint-action-button-container {
+ float: right;
+}
+
</ins><span class="cx"> .breakpoint-action-append-button,
</span><span class="cx"> .breakpoint-action-remove-button {
</span><del>- border: 1px solid hsl(0, 0%, 66%);
- border-radius: 10px;
- background-size: 16px 16px;
</del><span class="cx"> background-origin: border-box;
</span><del>- width: 16px;
- height: 16px;
- float: right;
- margin-left: 2px;
</del><ins>+ width: 13px;
+ height: 13px;
+ margin-left: 5px;
</ins><span class="cx"> margin-top: 2px;
</span><ins>+ background-color: transparent;
+ border: none;
+ opacity: 0.6;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.breakpoint-action-append-button:active,
-.breakpoint-action-remove-button:active {
- filter: brightness(50%);
-}
-
</del><span class="cx"> .breakpoint-action-append-button {
</span><del>- background-image: url(../Images/BreakpointActionAdd.svg), linear-gradient(to bottom, hsl(0, 0%, 98%), hsl(0, 0%, 78%));
</del><ins>+ background-image: url(../Images/Plus13.svg);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .breakpoint-action-remove-button {
</span><del>- background-image: url(../Images/BreakpointActionRemove.svg), linear-gradient(to bottom, hsl(0, 0%, 98%), hsl(0, 0%, 78%));
</del><ins>+ background-image: url(../Images/Minus.svg);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .breakpoint-action-block-body {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsBreakpointActionViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js (204151 => 204152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js 2016-08-04 23:24:14 UTC (rev 204151)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js 2016-08-04 23:46:07 UTC (rev 204152)
</span><span class="lines">@@ -54,12 +54,15 @@
</span><span class="cx"> picker.add(option);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- var appendActionButton = header.appendChild(document.createElement("button"));
</del><ins>+ let buttonContainerElement = header.appendChild(document.createElement("div"));
+ buttonContainerElement.classList.add("breakpoint-action-button-container");
+
+ let appendActionButton = buttonContainerElement.appendChild(document.createElement("button"));
</ins><span class="cx"> appendActionButton.className = "breakpoint-action-append-button";
</span><span class="cx"> appendActionButton.addEventListener("click", this._appendActionButtonClicked.bind(this));
</span><span class="cx"> appendActionButton.title = WebInspector.UIString("Add new breakpoint action after this action");
</span><span class="cx">
</span><del>- var removeActionButton = header.appendChild(document.createElement("button"));
</del><ins>+ let removeActionButton = buttonContainerElement.appendChild(document.createElement("button"));
</ins><span class="cx"> removeActionButton.className = "breakpoint-action-remove-button";
</span><span class="cx"> removeActionButton.addEventListener("click", this._removeAction.bind(this));
</span><span class="cx"> removeActionButton.title = WebInspector.UIString("Remove this breakpoint action");
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsBreakpointPopoverControllercss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css (204151 => 204152)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css 2016-08-04 23:24:14 UTC (rev 204151)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css 2016-08-04 23:46:07 UTC (rev 204152)
</span><span class="lines">@@ -70,6 +70,10 @@
</span><span class="cx"> height: auto;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.wide .edit-breakpoint-popover-condition > .CodeMirror {
+ width: 360px; /* NOTE: Fixed value, manually tuned to .edit-breakpoint-popover-content width. */
+}
+
</ins><span class="cx"> #edit-breakpoint-popover-ignore {
</span><span class="cx"> width: 40px;
</span><span class="cx"> margin-right: 4px;
</span></span></pre>
</div>
</div>
</body>
</html>