<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204030] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204030">204030</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-08-02 10:27:37 -0700 (Tue, 02 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[MathML] Use more auto for local variables
https://bugs.webkit.org/show_bug.cgi?id=160453
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.
No new tests, behavior is unchanged.
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::colSpan):
(WebCore::MathMLElement::rowSpan):
(WebCore::MathMLElement::childShouldCreateRenderer):
(WebCore::MathMLElement::defaultEventHandler):
* mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::getSelectedSemanticsChild):
* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoremathmlMathMLElementcpp">trunk/Source/WebCore/mathml/MathMLElement.cpp</a></li>
<li><a href="#trunkSourceWebCoremathmlMathMLSelectElementcpp">trunk/Source/WebCore/mathml/MathMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingmathmlRenderMathMLFencedcpp">trunk/Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204029 => 204030)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-02 17:03:40 UTC (rev 204029)
+++ trunk/Source/WebCore/ChangeLog 2016-08-02 17:27:37 UTC (rev 204030)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-08-02 Frederic Wang <fwang@igalia.com>
+
+ [MathML] Use more auto for local variables
+ https://bugs.webkit.org/show_bug.cgi?id=160453
+
+ Reviewed by Darin Adler.
+
+ No new tests, behavior is unchanged.
+
+ * mathml/MathMLElement.cpp:
+ (WebCore::MathMLElement::colSpan):
+ (WebCore::MathMLElement::rowSpan):
+ (WebCore::MathMLElement::childShouldCreateRenderer):
+ (WebCore::MathMLElement::defaultEventHandler):
+ * mathml/MathMLSelectElement.cpp:
+ (WebCore::MathMLSelectElement::getSelectedActionChild):
+ (WebCore::MathMLSelectElement::getSelectedSemanticsChild):
+ * rendering/mathml/RenderMathMLFenced.cpp:
+ (WebCore::RenderMathMLFenced::updateFromElement):
+
</ins><span class="cx"> 2016-08-02 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Attempt to fix build after r204014.
</span></span></pre></div>
<a id="trunkSourceWebCoremathmlMathMLElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/mathml/MathMLElement.cpp (204029 => 204030)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/MathMLElement.cpp 2016-08-02 17:03:40 UTC (rev 204029)
+++ trunk/Source/WebCore/mathml/MathMLElement.cpp 2016-08-02 17:27:37 UTC (rev 204030)
</span><span class="lines">@@ -207,7 +207,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!hasTagName(mtdTag))
</span><span class="cx"> return 1u;
</span><del>- const AtomicString& colSpanValue = attributeWithoutSynchronization(columnspanAttr);
</del><ins>+ auto& colSpanValue = attributeWithoutSynchronization(columnspanAttr);
</ins><span class="cx"> return std::max(1u, limitToOnlyHTMLNonNegative(colSpanValue, 1u));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -215,7 +215,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!hasTagName(mtdTag))
</span><span class="cx"> return 1u;
</span><del>- const AtomicString& rowSpanValue = attributeWithoutSynchronization(rowspanAttr);
</del><ins>+ auto& rowSpanValue = attributeWithoutSynchronization(rowspanAttr);
</ins><span class="cx"> static const unsigned maxRowspan = 8190; // This constant comes from HTMLTableCellElement.
</span><span class="cx"> return std::max(1u, std::min(limitToOnlyHTMLNonNegative(rowSpanValue, 1u), maxRowspan));
</span><span class="cx"> }
</span><span class="lines">@@ -280,7 +280,7 @@
</span><span class="cx"> bool MathMLElement::childShouldCreateRenderer(const Node& child) const
</span><span class="cx"> {
</span><span class="cx"> if (hasTagName(annotation_xmlTag)) {
</span><del>- const AtomicString& value = attributeWithoutSynchronization(MathMLNames::encodingAttr);
</del><ins>+ auto& value = attributeWithoutSynchronization(MathMLNames::encodingAttr);
</ins><span class="cx">
</span><span class="cx"> // See annotation-xml.model.mathml, annotation-xml.model.svg and annotation-xml.model.xhtml in the HTML5 RelaxNG schema.
</span><span class="cx">
</span><span class="lines">@@ -330,10 +330,10 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> if (MouseEvent::canTriggerActivationBehavior(*event)) {
</span><del>- const AtomicString& href = attributeWithoutSynchronization(hrefAttr);
- String url = stripLeadingAndTrailingHTMLSpaces(href);
</del><ins>+ auto& href = attributeWithoutSynchronization(hrefAttr);
+ const auto& url = stripLeadingAndTrailingHTMLSpaces(href);
</ins><span class="cx"> event->setDefaultHandled();
</span><del>- if (Frame* frame = document().frame())
</del><ins>+ if (auto* frame = document().frame())
</ins><span class="cx"> frame->loader().urlSelected(document().completeURL(url), "_self", event, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate());
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoremathmlMathMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/mathml/MathMLSelectElement.cpp (204029 => 204030)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/MathMLSelectElement.cpp 2016-08-02 17:03:40 UTC (rev 204029)
+++ trunk/Source/WebCore/mathml/MathMLSelectElement.cpp 2016-08-02 17:27:37 UTC (rev 204030)
</span><span class="lines">@@ -136,7 +136,7 @@
</span><span class="cx"> return child;
</span><span class="cx">
</span><span class="cx"> // The value of the actiontype attribute is case-sensitive.
</span><del>- const AtomicString& actiontype = attributeWithoutSynchronization(MathMLNames::actiontypeAttr);
</del><ins>+ auto& actiontype = attributeWithoutSynchronization(MathMLNames::actiontypeAttr);
</ins><span class="cx"> if (actiontype == "statusline")
</span><span class="cx"> // FIXME: implement user interaction for the "statusline" action type (http://wkbug/124922).
</span><span class="cx"> { }
</span><span class="lines">@@ -185,7 +185,7 @@
</span><span class="cx"> if (child->hasAttributeWithoutSynchronization(MathMLNames::srcAttr))
</span><span class="cx"> continue;
</span><span class="cx"> // If the <annotation-xml> element has an encoding attribute describing presentation MathML, SVG or HTML we assume the content can be displayed and we stop here.
</span><del>- const AtomicString& value = child->attributeWithoutSynchronization(MathMLNames::encodingAttr);
</del><ins>+ auto& value = child->attributeWithoutSynchronization(MathMLNames::encodingAttr);
</ins><span class="cx"> if (isMathMLEncoding(value) || isSVGEncoding(value) || isHTMLEncoding(value))
</span><span class="cx"> return child;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingmathmlRenderMathMLFencedcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp (204029 => 204030)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp 2016-08-02 17:03:40 UTC (rev 204029)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp 2016-08-02 17:27:37 UTC (rev 204030)
</span><span class="lines">@@ -54,14 +54,14 @@
</span><span class="cx"> const auto& fenced = element();
</span><span class="cx">
</span><span class="cx"> // The open operator defaults to a left parenthesis.
</span><del>- AtomicString open = fenced.attributeWithoutSynchronization(MathMLNames::openAttr);
</del><ins>+ auto& open = fenced.attributeWithoutSynchronization(MathMLNames::openAttr);
</ins><span class="cx"> m_open = open.isNull() ? gOpeningBraceChar : open;
</span><span class="cx">
</span><span class="cx"> // The close operator defaults to a right parenthesis.
</span><del>- AtomicString close = fenced.attributeWithoutSynchronization(MathMLNames::closeAttr);
</del><ins>+ auto& close = fenced.attributeWithoutSynchronization(MathMLNames::closeAttr);
</ins><span class="cx"> m_close = close.isNull() ? gClosingBraceChar : close;
</span><span class="cx">
</span><del>- AtomicString separators = fenced.attributeWithoutSynchronization(MathMLNames::separatorsAttr);
</del><ins>+ auto& separators = fenced.attributeWithoutSynchronization(MathMLNames::separatorsAttr);
</ins><span class="cx"> if (!separators.isNull()) {
</span><span class="cx"> StringBuilder characters;
</span><span class="cx"> for (unsigned int i = 0; i < separators.length(); i++) {
</span></span></pre>
</div>
</div>
</body>
</html>