<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204033] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204033">204033</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-08-02 12:11:27 -0700 (Tue, 02 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Kill [StrictTypeChecking] IDL extended attribute
https://bugs.webkit.org/show_bug.cgi?id=160382
Reviewed by Darin Adler.
Kill [StrictTypeChecking] IDL extended attribute. Its only remaining
use was on DOMString parameters for a few CanvasRenderingContext2D
operations in order to work around a bug in our overload resolution.
However, as of <a href="http://trac.webkit.org/projects/webkit/changeset/204028">r204028</a>, we implement the Web IDL overload resolution
algorithm and [StrictTypeChecking] is now a no-op and is no longer
needed.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestTypedefs.idl:
* html/canvas/CanvasRenderingContext2D.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsIDLAttributestxt">trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestTestObjidl">trunk/Source/WebCore/bindings/scripts/test/TestObj.idl</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestTestTypedefsidl">trunk/Source/WebCore/bindings/scripts/test/TestTypedefs.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Didl">trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204032 => 204033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-02 18:47:14 UTC (rev 204032)
+++ trunk/Source/WebCore/ChangeLog 2016-08-02 19:11:27 UTC (rev 204033)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-08-02 Chris Dumez <cdumez@apple.com>
+
+ Kill [StrictTypeChecking] IDL extended attribute
+ https://bugs.webkit.org/show_bug.cgi?id=160382
+
+ Reviewed by Darin Adler.
+
+ Kill [StrictTypeChecking] IDL extended attribute. Its only remaining
+ use was on DOMString parameters for a few CanvasRenderingContext2D
+ operations in order to work around a bug in our overload resolution.
+
+ However, as of r204028, we implement the Web IDL overload resolution
+ algorithm and [StrictTypeChecking] is now a no-op and is no longer
+ needed.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateParametersCheckExpression):
+ * bindings/scripts/IDLAttributes.txt:
+ * bindings/scripts/test/TestObj.idl:
+ * bindings/scripts/test/TestTypedefs.idl:
+ * html/canvas/CanvasRenderingContext2D.idl:
+
</ins><span class="cx"> 2016-08-02 Frederic Wang <fwang@igalia.com>
</span><span class="cx">
</span><span class="cx"> Move parsing of boolean operator properties into MathMLOperatorElement
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (204032 => 204033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-08-02 18:47:14 UTC (rev 204032)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-08-02 19:11:27 UTC (rev 204033)
</span><span class="lines">@@ -1956,16 +1956,7 @@
</span><span class="cx"> my $value = "arg$parameterIndex";
</span><span class="cx"> my $type = $parameter->type;
</span><span class="cx">
</span><del>- # For DOMString with StrictTypeChecking only Null, Undefined and Object
- # are accepted for compatibility. Otherwise, no restrictions are made to
- # match the non-overloaded behavior.
- # FIXME: Implement WebIDL overload resolution algorithm.
- if ($type eq "DOMString" || $codeGenerator->IsEnumType($type)) {
- if ($parameter->extendedAttributes->{"StrictTypeChecking"}) {
- push(@andExpression, "(${value}.isUndefinedOrNull() || ${value}.isString() || ${value}.isObject())");
- $usedArguments{$parameterIndex} = 1;
- }
- } elsif ($codeGenerator->IsCallbackInterface($parameter->type)) {
</del><ins>+ if ($codeGenerator->IsCallbackInterface($parameter->type)) {
</ins><span class="cx"> # For Callbacks only checks if the value is null or object.
</span><span class="cx"> if ($codeGenerator->IsFunctionOnlyCallbackInterface($parameter->type)) {
</span><span class="cx"> push(@andExpression, "(${value}.isNull() || ${value}.isFunction())");
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsIDLAttributestxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (204032 => 204033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2016-08-02 18:47:14 UTC (rev 204032)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2016-08-02 19:11:27 UTC (rev 204033)
</span><span class="lines">@@ -120,7 +120,6 @@
</span><span class="cx"> SetterRaisesExceptionWithMessage
</span><span class="cx"> SetterCallWith=ScriptExecutionContext|ScriptState|ScriptArguments|CallStack|ActiveWindow|FirstWindow
</span><span class="cx"> SkipVTableValidation
</span><del>-StrictTypeChecking
</del><span class="cx"> SuppressToJSObject
</span><span class="cx"> TreatNullAs=EmptyString
</span><span class="cx"> TreatReturnedNaNDateAs=Null|NaN
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestTestObjidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/TestObj.idl (204032 => 204033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2016-08-02 18:47:14 UTC (rev 204032)
+++ trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2016-08-02 19:11:27 UTC (rev 204033)
</span><span class="lines">@@ -251,9 +251,9 @@
</span><span class="cx">
</span><span class="cx"> #if defined(TESTING_JS)
</span><span class="cx"> // Overloads
</span><del>- void overloadedMethod(TestObj? objArg, [StrictTypeChecking] DOMString strArg);
</del><ins>+ void overloadedMethod(TestObj? objArg, DOMString strArg);
</ins><span class="cx"> void overloadedMethod(TestObj? objArg, optional long longArg);
</span><del>- void overloadedMethod([StrictTypeChecking] DOMString strArg);
</del><ins>+ void overloadedMethod(DOMString strArg);
</ins><span class="cx"> void overloadedMethod(long longArg);
</span><span class="cx"> void overloadedMethod(TestCallback callback);
</span><span class="cx"> void overloadedMethod(DOMStringList? listArg);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestTestTypedefsidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/TestTypedefs.idl (204032 => 204033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/TestTypedefs.idl 2016-08-02 18:47:14 UTC (rev 204032)
+++ trunk/Source/WebCore/bindings/scripts/test/TestTypedefs.idl 2016-08-02 19:11:27 UTC (rev 204033)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx">
</span><span class="cx"> void func(optional ARRAY_OF_LONGS x = []);
</span><span class="cx">
</span><del>- void setShadow(DOUBLE width, DOUBLE height, unrestricted float blur, [StrictTypeChecking] optional STRING color, optional DOUBLE alpha);
</del><ins>+ void setShadow(DOUBLE width, DOUBLE height, unrestricted float blur, optional STRING color, optional DOUBLE alpha);
</ins><span class="cx">
</span><span class="cx"> ULONGLONG methodWithSequenceArg(sequence<SCRIPT_VALUE> sequenceArg);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasCanvasRenderingContext2Didl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl (204032 => 204033)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl 2016-08-02 18:47:14 UTC (rev 204032)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl 2016-08-02 19:11:27 UTC (rev 204033)
</span><span class="lines">@@ -126,12 +126,12 @@
</span><span class="cx"> void fillText(DOMString text, unrestricted float x, unrestricted float y, optional unrestricted float maxWidth);
</span><span class="cx"> void strokeText(DOMString text, unrestricted float x, unrestricted float y, optional unrestricted float maxWidth);
</span><span class="cx">
</span><del>- void setStrokeColor([StrictTypeChecking] DOMString color, optional unrestricted float alpha);
</del><ins>+ void setStrokeColor(DOMString color, optional unrestricted float alpha);
</ins><span class="cx"> void setStrokeColor(unrestricted float grayLevel, optional float alpha = 1);
</span><span class="cx"> void setStrokeColor(unrestricted float r, unrestricted float g, unrestricted float b, unrestricted float a);
</span><span class="cx"> void setStrokeColor(unrestricted float c, unrestricted float m, unrestricted float y, unrestricted float k, unrestricted float a);
</span><span class="cx">
</span><del>- void setFillColor([StrictTypeChecking] DOMString color, optional unrestricted float alpha);
</del><ins>+ void setFillColor(DOMString color, optional unrestricted float alpha);
</ins><span class="cx"> void setFillColor(unrestricted float grayLevel, optional unrestricted float alpha = 1);
</span><span class="cx"> void setFillColor(unrestricted float r, unrestricted float g, unrestricted float b, unrestricted float a);
</span><span class="cx"> void setFillColor(unrestricted float c, unrestricted float m, unrestricted float y, unrestricted float k, unrestricted float a);
</span><span class="lines">@@ -160,7 +160,7 @@
</span><span class="cx"> optional DOMString compositeOperation = "");
</span><span class="cx">
</span><span class="cx"> void setShadow(unrestricted float width, unrestricted float height, unrestricted float blur,
</span><del>- [StrictTypeChecking] optional DOMString color, optional unrestricted float alpha);
</del><ins>+ optional DOMString color, optional unrestricted float alpha);
</ins><span class="cx"> void setShadow(unrestricted float width, unrestricted float height, unrestricted float blur, unrestricted float grayLevel,
</span><span class="cx"> optional unrestricted float alpha = 1);
</span><span class="cx"> void setShadow(unrestricted float width, unrestricted float height, unrestricted float blur, unrestricted float r,
</span></span></pre>
</div>
</div>
</body>
</html>