<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[204045] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/204045">204045</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-08-02 15:23:22 -0700 (Tue, 02 Aug 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Named / Indexed properties should be configurable
https://bugs.webkit.org/show_bug.cgi?id=160457
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
* web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
* web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
Source/WebCore:
Report Named / Indexed properties as being configurable to comply with
the Web IDL specification:
- http://heycam.github.io/webidl/#getownproperty-guts (step 1. and 2.)
Firefox and Chrome also report them as being configurable.
No new tests, rebaselined existing tests.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
LayoutTests:
Update / rebaseline existing tests to reflect behavior change.
* fast/dom/NodeList/nodelist-name-getter-properties-expected.txt:
* fast/dom/NodeList/nodelist-name-getter-properties.html:
* js/dom/getOwnPropertyDescriptor-expected.txt:
* js/resources/getOwnPropertyDescriptor.js:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomNodeListnodelistnamegetterpropertiesexpectedtxt">trunk/LayoutTests/fast/dom/NodeList/nodelist-name-getter-properties-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomNodeListnodelistnamegetterpropertieshtml">trunk/LayoutTests/fast/dom/NodeList/nodelist-name-getter-properties.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentgetElementsByTagNameexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsdomnodesElementgetElementsByTagNameexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomgetOwnPropertyDescriptorexpectedtxt">trunk/LayoutTests/js/dom/getOwnPropertyDescriptor-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsresourcesgetOwnPropertyDescriptorjs">trunk/LayoutTests/js/resources/getOwnPropertyDescriptor.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestCustomNamedGettercpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestEventTargetcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestOverrideBuiltinscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/LayoutTests/ChangeLog 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-08-02 Chris Dumez <cdumez@apple.com>
+
+ Named / Indexed properties should be configurable
+ https://bugs.webkit.org/show_bug.cgi?id=160457
+
+ Reviewed by Darin Adler.
+
+ Update / rebaseline existing tests to reflect behavior change.
+
+ * fast/dom/NodeList/nodelist-name-getter-properties-expected.txt:
+ * fast/dom/NodeList/nodelist-name-getter-properties.html:
+ * js/dom/getOwnPropertyDescriptor-expected.txt:
+ * js/resources/getOwnPropertyDescriptor.js:
+
</ins><span class="cx"> 2016-08-02 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove more unused/uninstalled Objective-C DOM bindings
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomNodeListnodelistnamegetterpropertiesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/NodeList/nodelist-name-getter-properties-expected.txt (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/NodeList/nodelist-name-getter-properties-expected.txt 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/LayoutTests/fast/dom/NodeList/nodelist-name-getter-properties-expected.txt 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-PASS Object.getOwnPropertyDescriptor(NodeList, 'aWildId').configurable is false
</del><ins>+PASS Object.getOwnPropertyDescriptor(NodeList, 'aWildId').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(NodeList, 'aWildId').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(NodeList, 'aWildId').writable is false
</span><span class="cx"> PASS successfullyParsed is true
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomNodeListnodelistnamegetterpropertieshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/NodeList/nodelist-name-getter-properties.html (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/NodeList/nodelist-name-getter-properties.html 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/LayoutTests/fast/dom/NodeList/nodelist-name-getter-properties.html 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -10,9 +10,9 @@
</span><span class="cx">
</span><span class="cx"> var NodeList = document.getElementsByTagName('div');
</span><span class="cx">
</span><del>-shouldBe("Object.getOwnPropertyDescriptor(NodeList, 'aWildId').configurable", 'false');
-shouldBe("Object.getOwnPropertyDescriptor(NodeList, 'aWildId').enumerable", 'false');
-shouldBe("Object.getOwnPropertyDescriptor(NodeList, 'aWildId').writable", 'false');
</del><ins>+shouldBeTrue("Object.getOwnPropertyDescriptor(NodeList, 'aWildId').configurable");
+shouldBeFalse("Object.getOwnPropertyDescriptor(NodeList, 'aWildId').enumerable");
+shouldBeFalse("Object.getOwnPropertyDescriptor(NodeList, 'aWildId').writable");
</ins><span class="cx"> </script>
</span><span class="cx"> <script src="../../../resources/js-test-post.js"></script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-08-02 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Named / Indexed properties should be configurable
+ https://bugs.webkit.org/show_bug.cgi?id=160457
+
+ Reviewed by Darin Adler.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
+ * web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
+
+2016-08-02 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> HTMLCollection's named getter should only do 'name' attribute matching for HTMLElements
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160456
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesDocumentgetElementsByTagNameexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Should be able to set expando shadowing a proto prop (item)
</span><span class="cx"> PASS Should be able to set expando shadowing a proto prop (namedItem)
</span><del>-FAIL hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames assert_true: desc.configurable expected true got false
</del><ins>+PASS hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames
</ins><span class="cx"> PASS HTML element with uppercase tagName never matches in HTML Documents
</span><span class="cx"> PASS Element in non-HTML namespace, no prefix, lowercase name
</span><span class="cx"> PASS Element in non-HTML namespace, no prefix, uppercase name
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsdomnodesElementgetElementsByTagNameexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> }" did not throw
</span><span class="cx"> PASS Should be able to set expando shadowing a proto prop (item)
</span><span class="cx"> PASS Should be able to set expando shadowing a proto prop (namedItem)
</span><del>-FAIL hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames assert_true: desc.configurable expected true got false
</del><ins>+PASS hasOwnProperty, getOwnPropertyDescriptor, getOwnPropertyNames
</ins><span class="cx"> PASS HTML element with uppercase tagName never matches in HTML Documents
</span><span class="cx"> PASS Element in non-HTML namespace, no prefix, lowercase name
</span><span class="cx"> PASS Element in non-HTML namespace, no prefix, uppercase name
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomgetOwnPropertyDescriptorexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/getOwnPropertyDescriptor-expected.txt (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/getOwnPropertyDescriptor-expected.txt 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/LayoutTests/js/dom/getOwnPropertyDescriptor-expected.txt 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -134,12 +134,12 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).enumerable is true
</span><del>-PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).configurable is false
</del><ins>+PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).value is document.getElementsByClassName('pass')[0]
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).enumerable is true
</span><del>-PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).configurable is false
</del><ins>+PASS Object.getOwnPropertyDescriptor(document.getElementsByClassName('pass'), 0).configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(canvasPixelArray, 0).value is canvasPixelArray[0]
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(canvasPixelArray, 0).hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(canvasPixelArray, 0).hasOwnProperty('set') is false
</span><span class="lines">@@ -149,7 +149,7 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(select, 0).hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(select, 0).hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(select, 0).enumerable is true
</span><del>-PASS Object.getOwnPropertyDescriptor(select, 0).configurable is false
</del><ins>+PASS Object.getOwnPropertyDescriptor(select, 0).configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(objectWithGetter, 'getter').get is getterFunc
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(objectWithGetter, 'getter').set is undefined
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(objectWithGetter, 'getter').hasOwnProperty('value') is false
</span></span></pre></div>
<a id="trunkLayoutTestsjsresourcesgetOwnPropertyDescriptorjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/resources/getOwnPropertyDescriptor.js (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/resources/getOwnPropertyDescriptor.js 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/LayoutTests/js/resources/getOwnPropertyDescriptor.js 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -45,14 +45,14 @@
</span><span class="cx"> descriptorShouldBe("global", "'window'", {get: 'globalWindowGetter', set: undefined, enumerable: true, configurable: false});
</span><span class="cx"> descriptorShouldBe("global", "'XMLHttpRequest'", {writable: true, enumerable: false, configurable: true, value:"XMLHttpRequest"});
</span><span class="cx"> descriptorShouldBe("global", "0", {writable: true, enumerable: false, configurable: false, value:"global[0]"});
</span><del>-descriptorShouldBe("document.getElementsByTagName('div')", "0", {writable: false, enumerable: true, configurable: false, value:"document.getElementsByTagName('div')[0]"});
-descriptorShouldBe("document.getElementsByClassName('pass')", "0", {writable: false, enumerable: true, configurable: false, value:"document.getElementsByClassName('pass')[0]"});
</del><ins>+descriptorShouldBe("document.getElementsByTagName('div')", "0", {writable: false, enumerable: true, configurable: true, value:"document.getElementsByTagName('div')[0]"});
+descriptorShouldBe("document.getElementsByClassName('pass')", "0", {writable: false, enumerable: true, configurable: true, value:"document.getElementsByClassName('pass')[0]"});
</ins><span class="cx"> var canvas = document.createElement("canvas");
</span><span class="cx"> var canvasPixelArray = canvas.getContext("2d").createImageData(10,10).data;
</span><span class="cx"> descriptorShouldBe("canvasPixelArray", "0", {writable: true, enumerable: true, configurable: false, value:"canvasPixelArray[0]"});
</span><span class="cx"> var select = document.createElement("select");
</span><span class="cx"> select.innerHTML = "<option>foo</option>";
</span><del>-descriptorShouldBe("select", "0", {writable: true, enumerable: true, configurable: false, value:"select[0]"});
</del><ins>+descriptorShouldBe("select", "0", {writable: true, enumerable: true, configurable: true, value:"select[0]"});
</ins><span class="cx">
</span><span class="cx"> var objectWithGetter = {};
</span><span class="cx"> function getterFunc(){};
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/Source/WebCore/ChangeLog 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-08-02 Chris Dumez <cdumez@apple.com>
+
+ Named / Indexed properties should be configurable
+ https://bugs.webkit.org/show_bug.cgi?id=160457
+
+ Reviewed by Darin Adler.
+
+ Report Named / Indexed properties as being configurable to comply with
+ the Web IDL specification:
+ - http://heycam.github.io/webidl/#getownproperty-guts (step 1. and 2.)
+
+ Firefox and Chrome also report them as being configurable.
+
+ No new tests, rebaselined existing tests.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateGetOwnPropertySlotBody):
+
</ins><span class="cx"> 2016-08-02 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove more unused/uninstalled Objective-C DOM bindings
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -317,9 +317,9 @@
</span><span class="cx"> push(@getOwnPropertySlotImpl, " unsigned index = optionalIndex.value();\n");
</span><span class="cx"> # Assume that if there's a setter, the index will be writable
</span><span class="cx"> if ($interface->extendedAttributes->{"CustomIndexedSetter"}) {
</span><del>- push(@getOwnPropertySlotImpl, " unsigned attributes = ${namespaceMaybe}DontDelete;\n");
</del><ins>+ push(@getOwnPropertySlotImpl, " unsigned attributes = 0;\n");
</ins><span class="cx"> } else {
</span><del>- push(@getOwnPropertySlotImpl, " unsigned attributes = ${namespaceMaybe}DontDelete | ${namespaceMaybe}ReadOnly;\n");
</del><ins>+ push(@getOwnPropertySlotImpl, " unsigned attributes = ${namespaceMaybe}ReadOnly;\n");
</ins><span class="cx"> }
</span><span class="cx"> push(@getOwnPropertySlotImpl, " slot.setValue(thisObject, attributes, " . GetIndexedGetterExpression($indexedGetterFunction) . ");\n");
</span><span class="cx"> push(@getOwnPropertySlotImpl, " return true;\n");
</span><span class="lines">@@ -344,7 +344,7 @@
</span><span class="cx"> }
</span><span class="cx"> push(@getOwnPropertySlotImpl, " JSValue value;\n");
</span><span class="cx"> push(@getOwnPropertySlotImpl, " if (thisObject->nameGetter(state, propertyName, value)) {\n");
</span><del>- push(@getOwnPropertySlotImpl, " slot.setValue(thisObject, ReadOnly | DontDelete | DontEnum, value);\n");
</del><ins>+ push(@getOwnPropertySlotImpl, " slot.setValue(thisObject, ReadOnly | DontEnum, value);\n");
</ins><span class="cx"> push(@getOwnPropertySlotImpl, " return true;\n");
</span><span class="cx"> push(@getOwnPropertySlotImpl, " }\n");
</span><span class="cx"> push(@getOwnPropertySlotImpl, " }\n");
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestCustomNamedGettercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -136,7 +136,7 @@
</span><span class="cx"> if (thisObject->classInfo() == info()) {
</span><span class="cx"> JSValue value;
</span><span class="cx"> if (thisObject->nameGetter(state, propertyName, value)) {
</span><del>- slot.setValue(thisObject, ReadOnly | DontDelete | DontEnum, value);
</del><ins>+ slot.setValue(thisObject, ReadOnly | DontEnum, value);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestEventTargetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx"> Optional<uint32_t> optionalIndex = parseIndex(propertyName);
</span><span class="cx"> if (optionalIndex && optionalIndex.value() < thisObject->wrapped().length()) {
</span><span class="cx"> unsigned index = optionalIndex.value();
</span><del>- unsigned attributes = DontDelete | ReadOnly;
</del><ins>+ unsigned attributes = ReadOnly;
</ins><span class="cx"> slot.setValue(thisObject, attributes, toJS(state, thisObject->globalObject(), thisObject->wrapped().item(index)));
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -139,7 +139,7 @@
</span><span class="cx"> if (!optionalIndex && thisObject->classInfo() == info()) {
</span><span class="cx"> JSValue value;
</span><span class="cx"> if (thisObject->nameGetter(state, propertyName, value)) {
</span><del>- slot.setValue(thisObject, ReadOnly | DontDelete | DontEnum, value);
</del><ins>+ slot.setValue(thisObject, ReadOnly | DontEnum, value);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -1350,7 +1350,7 @@
</span><span class="cx"> Optional<uint32_t> optionalIndex = parseIndex(propertyName);
</span><span class="cx"> if (optionalIndex) {
</span><span class="cx"> unsigned index = optionalIndex.value();
</span><del>- unsigned attributes = DontDelete | ReadOnly;
</del><ins>+ unsigned attributes = ReadOnly;
</ins><span class="cx"> slot.setValue(thisObject, attributes, jsStringOrUndefined(state, thisObject->wrapped().item(index)));
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestOverrideBuiltinscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp (204044 => 204045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp 2016-08-02 22:16:15 UTC (rev 204044)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp 2016-08-02 22:23:22 UTC (rev 204045)
</span><span class="lines">@@ -132,7 +132,7 @@
</span><span class="cx"> if (thisObject->classInfo() == info()) {
</span><span class="cx"> JSValue value;
</span><span class="cx"> if (thisObject->nameGetter(state, propertyName, value)) {
</span><del>- slot.setValue(thisObject, ReadOnly | DontDelete | DontEnum, value);
</del><ins>+ slot.setValue(thisObject, ReadOnly | DontEnum, value);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>