<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203849] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203849">203849</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-28 16:29:37 -0700 (Thu, 28 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>window.open.length should be 0
https://bugs.webkit.org/show_bug.cgi?id=160323
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
window.open.length should be 0 as all its parameters are optional:
- https://html.spec.whatwg.org/multipage/browsers.html#the-window-object
It is 2 in WebKit. Firefox and Chrome agree with the specification and return 0.
No new tests, rebaselined existing test.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::open):
Minor code optimization.
* page/DOMWindow.idl:
Update IDL to match the specification and our custom implementation.
This makes us return the right "length" value.
LayoutTests:
Update existing test to reflect behavior change.
* js/dom/function-length-expected.txt:
* js/dom/function-length.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomfunctionlengthexpectedtxt">trunk/LayoutTests/js/dom/function-length-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsdomfunctionlengthhtml">trunk/LayoutTests/js/dom/function-length.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp">trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowidl">trunk/Source/WebCore/page/DOMWindow.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203848 => 203849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-28 23:15:07 UTC (rev 203848)
+++ trunk/LayoutTests/ChangeLog 2016-07-28 23:29:37 UTC (rev 203849)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-07-28 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ window.open.length should be 0
+ https://bugs.webkit.org/show_bug.cgi?id=160323
+
+ Reviewed by Darin Adler.
+
+ Update existing test to reflect behavior change.
+
+ * js/dom/function-length-expected.txt:
+ * js/dom/function-length.html:
+
+2016-07-28 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameters to Event.initEvent() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160320
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203848 => 203849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-28 23:15:07 UTC (rev 203848)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-28 23:29:37 UTC (rev 203849)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-07-28 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ window.open.length should be 0
+ https://bugs.webkit.org/show_bug.cgi?id=160323
+
+ Reviewed by Darin Adler.
+
+ Rebaseline W3C test now that one more check is passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-07-28 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameters to Event.initEvent() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160320
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (203848 => 203849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-28 23:15:07 UTC (rev 203848)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-28 23:29:37 UTC (rev 203849)
</span><span class="lines">@@ -5181,7 +5181,7 @@
</span><span class="cx"> PASS Window interface: attribute opener
</span><span class="cx"> PASS Window interface: attribute parent
</span><span class="cx"> PASS Window interface: attribute frameElement
</span><del>-FAIL Window interface: operation open(DOMString,DOMString,DOMString,boolean) assert_equals: property has wrong .length expected 0 but got 2
</del><ins>+PASS Window interface: operation open(DOMString,DOMString,DOMString,boolean)
</ins><span class="cx"> PASS Window interface: attribute navigator
</span><span class="cx"> FAIL Window interface: attribute external assert_own_property: The global object must have a property "external" expected property "external" missing
</span><span class="cx"> PASS Window interface: attribute applicationCache
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomfunctionlengthexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/function-length-expected.txt (203848 => 203849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/function-length-expected.txt 2016-07-28 23:15:07 UTC (rev 203848)
+++ trunk/LayoutTests/js/dom/function-length-expected.txt 2016-07-28 23:29:37 UTC (rev 203849)
</span><span class="lines">@@ -4,7 +4,7 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> PASS window.confirm.length is 0
</span><del>-PASS window.open.length is 2
</del><ins>+PASS window.open.length is 0
</ins><span class="cx"> PASS window.showModalDialog.length is 1
</span><span class="cx"> PASS window.setTimeout.length is 1
</span><span class="cx"> PASS window.clearTimeout.length is 0
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomfunctionlengthhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/function-length.html (203848 => 203849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/function-length.html 2016-07-28 23:15:07 UTC (rev 203848)
+++ trunk/LayoutTests/js/dom/function-length.html 2016-07-28 23:29:37 UTC (rev 203849)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> description("This tests the length property of functions.");
</span><span class="cx">
</span><span class="cx"> shouldBe('window.confirm.length', '0');
</span><del>-shouldBe('window.open.length', '2');
</del><ins>+shouldBe('window.open.length', '0');
</ins><span class="cx"> shouldBe('window.showModalDialog.length', '1');
</span><span class="cx"> shouldBe('window.setTimeout.length', '1');
</span><span class="cx"> shouldBe('window.clearTimeout.length', '0');
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203848 => 203849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-28 23:15:07 UTC (rev 203848)
+++ trunk/Source/WebCore/ChangeLog 2016-07-28 23:29:37 UTC (rev 203849)
</span><span class="lines">@@ -1,5 +1,27 @@
</span><span class="cx"> 2016-07-28 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ window.open.length should be 0
+ https://bugs.webkit.org/show_bug.cgi?id=160323
+
+ Reviewed by Darin Adler.
+
+ window.open.length should be 0 as all its parameters are optional:
+ - https://html.spec.whatwg.org/multipage/browsers.html#the-window-object
+
+ It is 2 in WebKit. Firefox and Chrome agree with the specification and return 0.
+
+ No new tests, rebaselined existing test.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::open):
+ Minor code optimization.
+
+ * page/DOMWindow.idl:
+ Update IDL to match the specification and our custom implementation.
+ This makes us return the right "length" value.
+
+2016-07-28 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameters to Event.initEvent() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160320
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (203848 => 203849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2016-07-28 23:15:07 UTC (rev 203848)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2016-07-28 23:29:37 UTC (rev 203849)
</span><span class="lines">@@ -444,7 +444,8 @@
</span><span class="cx"> String urlString = valueToStringWithUndefinedOrNullCheck(&state, state.argument(0));
</span><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><del>- AtomicString frameName = state.argument(1).isUndefinedOrNull() ? "_blank" : state.argument(1).toString(&state)->value(&state);
</del><ins>+ JSValue targetValue = state.argument(1);
+ AtomicString target = targetValue.isUndefinedOrNull() ? AtomicString("_blank", AtomicString::ConstructFromLiteral) : targetValue.toString(&state)->toAtomicString(&state);
</ins><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><span class="cx"> String windowFeaturesString = valueToStringWithUndefinedOrNullCheck(&state, state.argument(2));
</span><span class="lines">@@ -451,7 +452,7 @@
</span><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><span class="cx">
</span><del>- RefPtr<DOMWindow> openedWindow = wrapped().open(urlString, frameName, windowFeaturesString, activeDOMWindow(&state), firstDOMWindow(&state));
</del><ins>+ RefPtr<DOMWindow> openedWindow = wrapped().open(urlString, target, windowFeaturesString, activeDOMWindow(&state), firstDOMWindow(&state));
</ins><span class="cx"> if (!openedWindow)
</span><span class="cx"> return jsUndefined();
</span><span class="cx"> return toJS(&state, openedWindow.get());
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.idl (203848 => 203849)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.idl 2016-07-28 23:15:07 UTC (rev 203848)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2016-07-28 23:29:37 UTC (rev 203849)
</span><span class="lines">@@ -65,9 +65,7 @@
</span><span class="cx"> void print();
</span><span class="cx"> void stop();
</span><span class="cx">
</span><del>- [Custom] DOMWindow open(DOMString url,
- DOMString name,
- optional DOMString options);
</del><ins>+ [Custom] DOMWindow open(optional DOMString url = "about:blank", optional DOMString target = "_blank", [TreatNullAs=EmptyString] optional DOMString features = "");
</ins><span class="cx">
</span><span class="cx"> [Custom] any showModalDialog(DOMString url,
</span><span class="cx"> optional any dialogArgs,
</span></span></pre>
</div>
</div>
</body>
</html>