<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203845] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203845">203845</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-28 15:05:49 -0700 (Thu, 28 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>First parameter to canvas.getContext() / probablySupportsContext() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160312
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.arguments.missing-expected.txt:
Source/WebCore:
First parameter to canvas.getContext() / probablySupportsContext()
should be mandatory:
- http://w3c.github.io/html/semantics-scripting.html#the-canvas-element
Firefox and Chrome agree with the specification for getContext().
Neither of them supports probablySupportsContext().
No new tests, rebaselined existing tests.
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
(WebCore::JSHTMLCanvasElement::probablySupportsContext):
* html/HTMLCanvasElement.idl:
Source/WebInspectorUI:
Update WebInspector accordingly.
* UserInterface/Models/NativeFunctionParameters.js:
LayoutTests:
Update existing test to reflect behavior change.
* fast/canvas/webgl/canvas-supports-context-expected.txt:
* fast/canvas/webgl/canvas-supports-context.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcanvaswebglcanvassupportscontextexpectedtxt">trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcanvaswebglcanvassupportscontexthtml">trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context.html</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsembeddedcontentthecanvaselementcontextargumentsmissingexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.arguments.missing-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSHTMLCanvasElementCustomcpp">trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCanvasElementidl">trunk/Source/WebCore/html/HTMLCanvasElement.idl</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs">trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/LayoutTests/ChangeLog 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-07-28 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ First parameter to canvas.getContext() / probablySupportsContext() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160312
+
+ Reviewed by Darin Adler.
+
+ Update existing test to reflect behavior change.
+
+ * fast/canvas/webgl/canvas-supports-context-expected.txt:
+ * fast/canvas/webgl/canvas-supports-context.html:
+
+2016-07-28 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameter to table.deleteRow() / body.deleteRow() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160307
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastcanvaswebglcanvassupportscontextexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context-expected.txt 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -112,7 +112,7 @@
</span><span class="cx"> FAIL getContext('webkit-3d' ,{ get preserveDrawingBUffer() { throw 'Test preserveDrawingBuffer Error'; } }) returns false (context does not exist)
</span><span class="cx">
</span><span class="cx"> Testing how probablySupportsContext handles no parameters
</span><del>-PASS document.createElement('canvas').probablySupportsContext() is false
</del><ins>+PASS document.createElement('canvas').probablySupportsContext() threw exception TypeError: Not enough arguments.
</ins><span class="cx">
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx"> Some tests failed.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcanvaswebglcanvassupportscontexthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context.html (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context.html 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/LayoutTests/fast/canvas/webgl/canvas-supports-context.html 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -158,7 +158,7 @@
</span><span class="cx">
</span><span class="cx"> debug("");
</span><span class="cx"> debug("Testing how probablySupportsContext handles no parameters");
</span><del>- shouldBeFalse("document.createElement('canvas').probablySupportsContext()");
</del><ins>+ shouldThrow("document.createElement('canvas').probablySupportsContext()");
</ins><span class="cx">
</span><span class="cx"> debug("");
</span><span class="cx"> }
</span><span class="lines">@@ -166,4 +166,4 @@
</span><span class="cx"> run_tests();
</span><span class="cx"> </script>
</span><span class="cx"> </body>
</span><del>-</html>
</del><span class="cx">\ No newline at end of file
</span><ins>+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-07-28 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ First parameter to canvas.getContext() / probablySupportsContext() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160312
+
+ Reviewed by Darin Adler.
+
+ Rebaseline several W3C tests now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+ * web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.arguments.missing-expected.txt:
+
+2016-07-28 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameter to table.deleteRow() / body.deleteRow() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160307
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -4803,8 +4803,8 @@
</span><span class="cx"> PASS HTMLCanvasElement interface: existence and properties of interface prototype object's "constructor" property
</span><span class="cx"> PASS HTMLCanvasElement interface: attribute width
</span><span class="cx"> PASS HTMLCanvasElement interface: attribute height
</span><del>-FAIL HTMLCanvasElement interface: operation getContext(DOMString,any) assert_equals: property has wrong .length expected 1 but got 0
-FAIL HTMLCanvasElement interface: operation probablySupportsContext(DOMString,any) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS HTMLCanvasElement interface: operation getContext(DOMString,any)
+PASS HTMLCanvasElement interface: operation probablySupportsContext(DOMString,any)
</ins><span class="cx"> FAIL HTMLCanvasElement interface: operation setContext(RenderingContext) assert_own_property: interface prototype object missing non-static operation expected property "setContext" missing
</span><span class="cx"> FAIL HTMLCanvasElement interface: operation transferControlToProxy() assert_own_property: interface prototype object missing non-static operation expected property "transferControlToProxy" missing
</span><span class="cx"> PASS HTMLCanvasElement interface: operation toDataURL(DOMString,any)
</span><span class="lines">@@ -4814,13 +4814,9 @@
</span><span class="cx"> PASS HTMLCanvasElement interface: document.createElement("canvas") must inherit property "width" with the proper type (0)
</span><span class="cx"> PASS HTMLCanvasElement interface: document.createElement("canvas") must inherit property "height" with the proper type (1)
</span><span class="cx"> PASS HTMLCanvasElement interface: document.createElement("canvas") must inherit property "getContext" with the proper type (2)
</span><del>-FAIL HTMLCanvasElement interface: calling getContext(DOMString,any) on document.createElement("canvas") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS HTMLCanvasElement interface: calling getContext(DOMString,any) on document.createElement("canvas") with too few arguments must throw TypeError
</ins><span class="cx"> PASS HTMLCanvasElement interface: document.createElement("canvas") must inherit property "probablySupportsContext" with the proper type (3)
</span><del>-FAIL HTMLCanvasElement interface: calling probablySupportsContext(DOMString,any) on document.createElement("canvas") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS HTMLCanvasElement interface: calling probablySupportsContext(DOMString,any) on document.createElement("canvas") with too few arguments must throw TypeError
</ins><span class="cx"> FAIL HTMLCanvasElement interface: document.createElement("canvas") must inherit property "setContext" with the proper type (4) assert_inherits: property "setContext" not found in prototype chain
</span><span class="cx"> FAIL HTMLCanvasElement interface: calling setContext(RenderingContext) on document.createElement("canvas") with too few arguments must throw TypeError assert_inherits: property "setContext" not found in prototype chain
</span><span class="cx"> FAIL HTMLCanvasElement interface: document.createElement("canvas") must inherit property "transferControlToProxy" with the proper type (5) assert_inherits: property "transferControlToProxy" not found in prototype chain
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmlsemanticsembeddedcontentthecanvaselementcontextargumentsmissingexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.arguments.missing-expected.txt (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.arguments.missing-expected.txt 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.arguments.missing-expected.txt 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -2,5 +2,5 @@
</span><span class="cx"> Defined in "Web IDL" (draft)
</span><span class="cx"> Actual output:
</span><span class="cx">
</span><del>-FAIL Canvas test: context.arguments.missing assert_throws: function "function () { canvas.getContext(); }" did not throw
</del><ins>+PASS Canvas test: context.arguments.missing
</ins><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/Source/WebCore/ChangeLog 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2016-07-28 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ First parameter to canvas.getContext() / probablySupportsContext() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160312
+
+ Reviewed by Darin Adler.
+
+ First parameter to canvas.getContext() / probablySupportsContext()
+ should be mandatory:
+ - http://w3c.github.io/html/semantics-scripting.html#the-canvas-element
+
+ Firefox and Chrome agree with the specification for getContext().
+ Neither of them supports probablySupportsContext().
+
+ No new tests, rebaselined existing tests.
+
+ * bindings/js/JSHTMLCanvasElementCustom.cpp:
+ (WebCore::JSHTMLCanvasElement::getContext):
+ (WebCore::JSHTMLCanvasElement::probablySupportsContext):
+ * html/HTMLCanvasElement.idl:
+
+2016-07-28 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> Parameter to table.deleteRow() / body.deleteRow() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160307
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSHTMLCanvasElementCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -69,8 +69,11 @@
</span><span class="cx">
</span><span class="cx"> JSValue JSHTMLCanvasElement::getContext(ExecState& state)
</span><span class="cx"> {
</span><ins>+ if (UNLIKELY(state.argumentCount() < 1))
+ return state.vm().throwException(&state, createNotEnoughArgumentsError(&state));
+
</ins><span class="cx"> HTMLCanvasElement& canvas = wrapped();
</span><del>- const String& contextId = state.argument(0).toString(&state)->value(&state);
</del><ins>+ const String& contextId = state.uncheckedArgument(0).toWTFString(&state);
</ins><span class="cx">
</span><span class="cx"> RefPtr<CanvasContextAttributes> attrs;
</span><span class="cx"> #if ENABLE(WEBGL)
</span><span class="lines">@@ -89,10 +92,11 @@
</span><span class="cx">
</span><span class="cx"> JSValue JSHTMLCanvasElement::probablySupportsContext(ExecState& state)
</span><span class="cx"> {
</span><ins>+ if (UNLIKELY(state.argumentCount() < 1))
+ return state.vm().throwException(&state, createNotEnoughArgumentsError(&state));
+
</ins><span class="cx"> HTMLCanvasElement& canvas = wrapped();
</span><del>- if (!state.argumentCount())
- return jsBoolean(false);
- const String& contextId = state.uncheckedArgument(0).toString(&state)->value(&state);
</del><ins>+ const String& contextId = state.uncheckedArgument(0).toWTFString(&state);
</ins><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCanvasElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCanvasElement.idl (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCanvasElement.idl 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.idl 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -41,8 +41,8 @@
</span><span class="cx">
</span><span class="cx"> #if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
</span><span class="cx"> // The custom binding is needed to handle context creation attributes.
</span><del>- [Custom] any getContext(optional DOMString contextId);
- [Custom] any probablySupportsContext(optional DOMString contextId);
</del><ins>+ [Custom] any getContext(DOMString contextId, any... arguments);
+ [Custom] boolean probablySupportsContext(DOMString contextId, any... arguments);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-07-28 Chris Dumez <cdumez@apple.com>
+
+ First parameter to canvas.getContext() / probablySupportsContext() should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160312
+
+ Reviewed by Darin Adler.
+
+ Update WebInspector accordingly.
+
+ * UserInterface/Models/NativeFunctionParameters.js:
+
</ins><span class="cx"> 2016-07-28 Matt Baker <mattbaker@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (203844 => 203845)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-07-28 21:51:50 UTC (rev 203844)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-07-28 22:05:49 UTC (rev 203845)
</span><span class="lines">@@ -871,8 +871,8 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> HTMLCanvasElement: {
</span><del>- getContext: "[contextId]",
- probablySupportsContext: "[contextId]",
</del><ins>+ getContext: "contextId",
+ probablySupportsContext: "contextId",
</ins><span class="cx"> toDataURL: "[type]",
</span><span class="cx"> __proto__: null,
</span><span class="cx"> },
</span></span></pre>
</div>
</div>
</body>
</html>