<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203777] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203777">203777</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-07-27 09:00:16 -0700 (Wed, 27 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Fix some video/canvas tests that should be passing
https://bugs.webkit.org/show_bug.cgi?id=160023
Patch by Miguel Gomez <magomez@igalia.com> on 2016-07-27
Reviewed by Carlos Garcia Campos.
Tools:
Add a platform identifier to the TestRunner's page user agent when the tests are run on the
EFL or GTK platforms.
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::platformConfigureViewForTest):
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::platformConfigureViewForTest):
LayoutTests:
Modify the tests to use a tolerance of 6 when running on the GTK or EFL platforms. Also,
added new expectations for the tests that need them.
* fast/canvas/canvas-createPattern-video-loading.html:
* fast/canvas/canvas-createPattern-video-modify.html:
* media/video-canvas-createPattern.html:
* platform/efl/fast/canvas/canvas-createPattern-video-loading-expected.txt: Added.
* platform/efl/fast/canvas/canvas-createPattern-video-modify-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-createPattern-video-loading-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-createPattern-video-modify-expected.txt: Added.
* resources/platform-helper.js: Added.
(isGtk):
(isEfl):
(videoCanvasPixelComparisonTolerance):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcanvascanvascreatePatternvideoloadinghtml">trunk/LayoutTests/fast/canvas/canvas-createPattern-video-loading.html</a></li>
<li><a href="#trunkLayoutTestsfastcanvascanvascreatePatternvideomodifyhtml">trunk/LayoutTests/fast/canvas/canvas-createPattern-video-modify.html</a></li>
<li><a href="#trunkLayoutTestsmediavideocanvascreatePatternhtml">trunk/LayoutTests/media/video-canvas-createPattern.html</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnereflTestControllerEflcpp">trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp</a></li>
<li><a href="#trunkToolsWebKitTestRunnergtkTestControllerGtkcpp">trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformeflfastcanvascanvascreatePatternvideoloadingexpectedtxt">trunk/LayoutTests/platform/efl/fast/canvas/canvas-createPattern-video-loading-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformeflfastcanvascanvascreatePatternvideomodifyexpectedtxt">trunk/LayoutTests/platform/efl/fast/canvas/canvas-createPattern-video-modify-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfastcanvascanvascreatePatternvideoloadingexpectedtxt">trunk/LayoutTests/platform/gtk/fast/canvas/canvas-createPattern-video-loading-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkfastcanvascanvascreatePatternvideomodifyexpectedtxt">trunk/LayoutTests/platform/gtk/fast/canvas/canvas-createPattern-video-modify-expected.txt</a></li>
<li><a href="#trunkLayoutTestsresourcesplatformhelperjs">trunk/LayoutTests/resources/platform-helper.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (203776 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-07-27 15:58:08 UTC (rev 203776)
+++ trunk/LayoutTests/ChangeLog 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-07-27 Miguel Gomez <magomez@igalia.com>
+
+ [GTK] Fix some video/canvas tests that should be passing
+ https://bugs.webkit.org/show_bug.cgi?id=160023
+
+ Reviewed by Carlos Garcia Campos.
+
+ Modify the tests to use a tolerance of 6 when running on the GTK or EFL platforms. Also,
+ added new expectations for the tests that need them.
+
+ * fast/canvas/canvas-createPattern-video-loading.html:
+ * fast/canvas/canvas-createPattern-video-modify.html:
+ * media/video-canvas-createPattern.html:
+ * platform/efl/fast/canvas/canvas-createPattern-video-loading-expected.txt: Added.
+ * platform/efl/fast/canvas/canvas-createPattern-video-modify-expected.txt: Added.
+ * platform/gtk/fast/canvas/canvas-createPattern-video-loading-expected.txt: Added.
+ * platform/gtk/fast/canvas/canvas-createPattern-video-modify-expected.txt: Added.
+ * resources/platform-helper.js: Added.
+ (isGtk):
+ (isEfl):
+ (videoCanvasPixelComparisonTolerance):
+
</ins><span class="cx"> 2016-07-27 Romain Bellessort <romain.bellessort@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> [Streams API] Replace ReadableStreamReader by ReadableStreamDefaultReader
</span></span></pre></div>
<a id="trunkLayoutTestsfastcanvascanvascreatePatternvideoloadinghtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/canvas/canvas-createPattern-video-loading.html (203776 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/canvas/canvas-createPattern-video-loading.html 2016-07-27 15:58:08 UTC (rev 203776)
+++ trunk/LayoutTests/fast/canvas/canvas-createPattern-video-loading.html 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -3,6 +3,7 @@
</span><span class="cx"> <head>
</span><span class="cx"> <script src="../../resources/js-test-pre.js"></script>
</span><span class="cx"> <script src="../../media/media-file.js"></script>
</span><ins>+ <script src="../../resources/platform-helper.js"></script>
</ins><span class="cx"> </head>
</span><span class="cx"> <body>
</span><span class="cx"> <script>
</span><span class="lines">@@ -58,7 +59,7 @@
</span><span class="cx"> context.fillRect(0, 0, canvas.width, canvas.height);
</span><span class="cx">
</span><span class="cx"> expectedResults.forEach(function(element) {
</span><del>- checkPixels(context, element[0], element[1], element[2], element[3], element[4], 2);
</del><ins>+ checkPixels(context, element[0], element[1], element[2], element[3], element[4], videoCanvasPixelComparisonTolerance());
</ins><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastcanvascanvascreatePatternvideomodifyhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/canvas/canvas-createPattern-video-modify.html (203776 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/canvas/canvas-createPattern-video-modify.html 2016-07-27 15:58:08 UTC (rev 203776)
+++ trunk/LayoutTests/fast/canvas/canvas-createPattern-video-modify.html 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -3,6 +3,7 @@
</span><span class="cx"> <head>
</span><span class="cx"> <script src="../../resources/js-test-pre.js"></script>
</span><span class="cx"> <script src="../../media/media-file.js"></script>
</span><ins>+ <script src="../../resources/platform-helper.js"></script>
</ins><span class="cx"> </head>
</span><span class="cx"> <body>
</span><span class="cx"> <script>
</span><span class="lines">@@ -40,7 +41,7 @@
</span><span class="cx"> context.fillRect(0, 0, canvas.width, canvas.height);
</span><span class="cx">
</span><span class="cx"> expectedResults.forEach(function(element) {
</span><del>- checkPixels(context, element[0], element[1], element[2], element[3], element[4], 2);
</del><ins>+ checkPixels(context, element[0], element[1], element[2], element[3], element[4], videoCanvasPixelComparisonTolerance());
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> finishJSTest();
</span></span></pre></div>
<a id="trunkLayoutTestsmediavideocanvascreatePatternhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/media/video-canvas-createPattern.html (203776 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/video-canvas-createPattern.html 2016-07-27 15:58:08 UTC (rev 203776)
+++ trunk/LayoutTests/media/video-canvas-createPattern.html 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -3,6 +3,7 @@
</span><span class="cx"> <title>Create patterns on canvas using video</title>
</span><span class="cx"> <script src="media-file.js"></script>
</span><span class="cx"> <script src="video-test.js"></script>
</span><ins>+ <script src="../resources/platform-helper.js"></script>
</ins><span class="cx"> <script>
</span><span class="cx"> var video;
</span><span class="cx"> var numberOfSeeks = 4;
</span><span class="lines">@@ -52,7 +53,7 @@
</span><span class="cx"> document.getElementById('canvases').appendChild(canvas);
</span><span class="cx">
</span><span class="cx"> expectedResults.forEach(function(element) {
</span><del>- checkColorAtLocation(ctx, element[0], element[1], element[2], element[3], element[4], 2);
</del><ins>+ checkColorAtLocation(ctx, element[0], element[1], element[2], element[3], element[4], videoCanvasPixelComparisonTolerance());
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> // Ensure that the test seeks a couple of times.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflfastcanvascanvascreatePatternvideoloadingexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/efl/fast/canvas/canvas-createPattern-video-loading-expected.txt (0 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/fast/canvas/canvas-createPattern-video-loading-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/canvas/canvas-createPattern-video-loading-expected.txt 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -0,0 +1,82 @@
</span><ins>+Test the behavior of 2d canvas createPattern as a video is loaded
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.createElement('canvas').getContext('2d').createPattern(video, 'repeat') is null
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformeflfastcanvascanvascreatePatternvideomodifyexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/efl/fast/canvas/canvas-createPattern-video-modify-expected.txt (0 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/fast/canvas/canvas-createPattern-video-modify-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/canvas/canvas-createPattern-video-modify-expected.txt 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+Tests that modifying the video used in createPattern does not affect the pattern rendered.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfastcanvascanvascreatePatternvideoloadingexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/gtk/fast/canvas/canvas-createPattern-video-loading-expected.txt (0 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/canvas/canvas-createPattern-video-loading-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/canvas/canvas-createPattern-video-loading-expected.txt 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -0,0 +1,82 @@
</span><ins>+Test the behavior of 2d canvas createPattern as a video is loaded
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.createElement('canvas').getContext('2d').createPattern(video, 'repeat') is null
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 17
+PASS buffer[1] is within 6 of 197
+PASS buffer[2] is within 6 of 195
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS buffer[0] is within 6 of 20
+PASS buffer[1] is within 6 of 200
+PASS buffer[2] is within 6 of 18
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformgtkfastcanvascanvascreatePatternvideomodifyexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/gtk/fast/canvas/canvas-createPattern-video-modify-expected.txt (0 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/fast/canvas/canvas-createPattern-video-modify-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/canvas/canvas-createPattern-video-modify-expected.txt 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+Tests that modifying the video used in createPattern does not affect the pattern rendered.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS buffer[0] is within 6 of 194
+PASS buffer[1] is within 6 of 193
+PASS buffer[2] is within 6 of 14
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsresourcesplatformhelperjs"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/resources/platform-helper.js (0 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/resources/platform-helper.js (rev 0)
+++ trunk/LayoutTests/resources/platform-helper.js 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+function isGtk()
+{
+ return navigator.userAgent.includes("WebKitTestRunnerGTK");
+}
+
+function isEfl()
+{
+ return navigator.userAgent.includes("WebKitTestRunnerEFL");
+}
+
+function videoCanvasPixelComparisonTolerance()
+{
+ if (isGtk() || isEfl())
+ return 6;
+
+ return 2;
+}
</ins></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (203776 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-07-27 15:58:08 UTC (rev 203776)
+++ trunk/Tools/ChangeLog 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-07-27 Miguel Gomez <magomez@igalia.com>
+
+ [GTK] Fix some video/canvas tests that should be passing
+ https://bugs.webkit.org/show_bug.cgi?id=160023
+
+ Reviewed by Carlos Garcia Campos.
+
+ Add a platform identifier to the TestRunner's page user agent when the tests are run on the
+ EFL or GTK platforms.
+
+ * WebKitTestRunner/efl/TestControllerEfl.cpp:
+ (WTR::TestController::platformConfigureViewForTest):
+ * WebKitTestRunner/gtk/TestControllerGtk.cpp:
+ (WTR::TestController::platformConfigureViewForTest):
+
</ins><span class="cx"> 2016-07-27 Carlos Alberto Lopez Perez <clopez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnereflTestControllerEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp (203776 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2016-07-27 15:58:08 UTC (rev 203776)
+++ trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -156,6 +156,7 @@
</span><span class="cx">
</span><span class="cx"> void TestController::platformConfigureViewForTest(const TestInvocation&)
</span><span class="cx"> {
</span><ins>+ WKPageSetApplicationNameForUserAgent(mainWebView()->page(), WKStringCreateWithUTF8CString("WebKitTestRunnerEFL"));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TestController::platformResetPreferencesToConsistentValues()
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnergtkTestControllerGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (203776 => 203777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2016-07-27 15:58:08 UTC (rev 203776)
+++ trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2016-07-27 16:00:16 UTC (rev 203777)
</span><span class="lines">@@ -140,6 +140,7 @@
</span><span class="cx">
</span><span class="cx"> void TestController::platformConfigureViewForTest(const TestInvocation&)
</span><span class="cx"> {
</span><ins>+ WKPageSetApplicationNameForUserAgent(mainWebView()->page(), WKStringCreateWithUTF8CString("WebKitTestRunnerGTK"));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void TestController::platformResetPreferencesToConsistentValues()
</span></span></pre>
</div>
</div>
</body>
</html>