<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[203797] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/203797">203797</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-07-27 14:51:49 -0700 (Wed, 27 Jul 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Parameter to named property getter should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160269
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Parameter to named property getter should be mandatory:
- https://heycam.github.io/webidl/#idl-named-properties
No new tests, rebaselined existing test.
* Modules/mediastream/RTCStatsResponse.idl:
* bindings/scripts/test/TestOverrideBuiltins.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLSelectElement.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCStatsResponseidl">trunk/Source/WebCore/Modules/mediastream/RTCStatsResponse.idl</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestOverrideBuiltinscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestTestOverrideBuiltinsidl">trunk/Source/WebCore/bindings/scripts/test/TestOverrideBuiltins.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionsCollectionidl">trunk/Source/WebCore/html/HTMLOptionsCollection.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementidl">trunk/Source/WebCore/html/HTMLSelectElement.idl</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMMimeTypeArrayidl">trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMPluginidl">trunk/Source/WebCore/plugins/DOMPlugin.idl</a></li>
<li><a href="#trunkSourceWebCorepluginsDOMPluginArrayidl">trunk/Source/WebCore/plugins/DOMPluginArray.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-07-27 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Parameter to named property getter should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160269
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-07-27 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> First parameter to Range.createContextualFragment() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160266
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldominterfacesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -4394,7 +4394,7 @@
</span><span class="cx"> PASS HTMLSelectElement interface: attribute options
</span><span class="cx"> PASS HTMLSelectElement interface: attribute length
</span><span class="cx"> PASS HTMLSelectElement interface: operation item(unsigned long)
</span><del>-FAIL HTMLSelectElement interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS HTMLSelectElement interface: operation namedItem(DOMString)
</ins><span class="cx"> PASS HTMLSelectElement interface: operation add([object Object],[object Object],[object Object],[object Object])
</span><span class="cx"> PASS HTMLSelectElement interface: operation remove()
</span><span class="cx"> PASS HTMLSelectElement interface: operation remove(long)
</span><span class="lines">@@ -4424,9 +4424,7 @@
</span><span class="cx"> PASS HTMLSelectElement interface: document.createElement("select") must inherit property "item" with the proper type (11)
</span><span class="cx"> PASS HTMLSelectElement interface: calling item(unsigned long) on document.createElement("select") with too few arguments must throw TypeError
</span><span class="cx"> PASS HTMLSelectElement interface: document.createElement("select") must inherit property "namedItem" with the proper type (12)
</span><del>-FAIL HTMLSelectElement interface: calling namedItem(DOMString) on document.createElement("select") with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
- fn.apply(obj, args);
- }" did not throw
</del><ins>+PASS HTMLSelectElement interface: calling namedItem(DOMString) on document.createElement("select") with too few arguments must throw TypeError
</ins><span class="cx"> PASS HTMLSelectElement interface: document.createElement("select") must inherit property "add" with the proper type (13)
</span><span class="cx"> PASS HTMLSelectElement interface: calling add([object Object],[object Object],[object Object],[object Object]) on document.createElement("select") with too few arguments must throw TypeError
</span><span class="cx"> PASS HTMLSelectElement interface: document.createElement("select") must inherit property "remove" with the proper type (14)
</span><span class="lines">@@ -5717,7 +5715,7 @@
</span><span class="cx"> PASS PluginArray interface: operation refresh(boolean)
</span><span class="cx"> PASS PluginArray interface: attribute length
</span><span class="cx"> PASS PluginArray interface: operation item(unsigned long)
</span><del>-FAIL PluginArray interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS PluginArray interface: operation namedItem(DOMString)
</ins><span class="cx"> PASS MimeTypeArray interface: existence and properties of interface object
</span><span class="cx"> PASS MimeTypeArray interface object length
</span><span class="cx"> PASS MimeTypeArray interface object name
</span><span class="lines">@@ -5725,7 +5723,7 @@
</span><span class="cx"> PASS MimeTypeArray interface: existence and properties of interface prototype object's "constructor" property
</span><span class="cx"> PASS MimeTypeArray interface: attribute length
</span><span class="cx"> PASS MimeTypeArray interface: operation item(unsigned long)
</span><del>-FAIL MimeTypeArray interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS MimeTypeArray interface: operation namedItem(DOMString)
</ins><span class="cx"> PASS Plugin interface: existence and properties of interface object
</span><span class="cx"> PASS Plugin interface object length
</span><span class="cx"> PASS Plugin interface object name
</span><span class="lines">@@ -5736,7 +5734,7 @@
</span><span class="cx"> PASS Plugin interface: attribute filename
</span><span class="cx"> PASS Plugin interface: attribute length
</span><span class="cx"> PASS Plugin interface: operation item(unsigned long)
</span><del>-FAIL Plugin interface: operation namedItem(DOMString) assert_equals: property has wrong .length expected 1 but got 0
</del><ins>+PASS Plugin interface: operation namedItem(DOMString)
</ins><span class="cx"> PASS MimeType interface: existence and properties of interface object
</span><span class="cx"> PASS MimeType interface object length
</span><span class="cx"> PASS MimeType interface object name
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/Source/WebCore/ChangeLog 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2016-07-27 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><ins>+ Parameter to named property getter should be mandatory
+ https://bugs.webkit.org/show_bug.cgi?id=160269
+
+ Reviewed by Ryosuke Niwa.
+
+ Parameter to named property getter should be mandatory:
+ - https://heycam.github.io/webidl/#idl-named-properties
+
+ No new tests, rebaselined existing test.
+
+ * Modules/mediastream/RTCStatsResponse.idl:
+ * bindings/scripts/test/TestOverrideBuiltins.idl:
+ * html/HTMLOptionsCollection.idl:
+ * html/HTMLSelectElement.idl:
+ * plugins/DOMMimeTypeArray.idl:
+ * plugins/DOMPlugin.idl:
+ * plugins/DOMPluginArray.idl:
+
+2016-07-27 Chris Dumez <cdumez@apple.com>
+
</ins><span class="cx"> First parameter to Range.createContextualFragment() should be mandatory
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=160266
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCStatsResponseidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCStatsResponse.idl (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCStatsResponse.idl 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/Source/WebCore/Modules/mediastream/RTCStatsResponse.idl 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -27,6 +27,5 @@
</span><span class="cx"> Conditional=WEB_RTC,
</span><span class="cx"> ] interface RTCStatsResponse {
</span><span class="cx"> sequence<RTCStatsReport> result();
</span><del>- // FIXME: The default parameter value is wrong.
- getter RTCStatsReport namedItem(optional DOMString name = "undefined");
</del><ins>+ getter RTCStatsReport namedItem(DOMString name);
</ins><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestOverrideBuiltinscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx"> static const HashTableValue JSTestOverrideBuiltinsPrototypeTableValues[] =
</span><span class="cx"> {
</span><span class="cx"> { "constructor", DontEnum, NoIntrinsic, { (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestOverrideBuiltinsConstructor), (intptr_t) static_cast<PutPropertySlot::PutValueFunc>(setJSTestOverrideBuiltinsConstructor) } },
</span><del>- { "namedItem", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestOverrideBuiltinsPrototypeFunctionNamedItem), (intptr_t) (0) } },
</del><ins>+ { "namedItem", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestOverrideBuiltinsPrototypeFunctionNamedItem), (intptr_t) (1) } },
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> const ClassInfo JSTestOverrideBuiltinsPrototype::s_info = { "TestOverrideBuiltinsPrototype", &Base::s_info, 0, CREATE_METHOD_TABLE(JSTestOverrideBuiltinsPrototype) };
</span><span class="lines">@@ -200,7 +200,9 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestOverrideBuiltins", "namedItem");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestOverrideBuiltins::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- auto name = state->argument(0).isUndefined() ? ASCIILiteral("test") : state->uncheckedArgument(0).toWTFString(state);
</del><ins>+ if (UNLIKELY(state->argumentCount() < 1))
+ return throwVMError(state, createNotEnoughArgumentsError(state));
+ auto name = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> JSValue result = toJS(state, castedThis->globalObject(), impl.namedItem(WTFMove(name)));
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestTestOverrideBuiltinsidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/TestOverrideBuiltins.idl (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/TestOverrideBuiltins.idl 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/Source/WebCore/bindings/scripts/test/TestOverrideBuiltins.idl 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -2,5 +2,5 @@
</span><span class="cx"> OverrideBuiltins
</span><span class="cx"> ] interface TestOverrideBuiltins
</span><span class="cx"> {
</span><del>- getter Node namedItem(optional DOMString name = "test");
</del><ins>+ getter Node namedItem(DOMString name);
</ins><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionsCollectionidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.idl (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionsCollection.idl 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.idl 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -27,7 +27,7 @@
</span><span class="cx"> [CustomSetter, SetterRaisesException] attribute unsigned long length;
</span><span class="cx">
</span><span class="cx"> #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C || defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT
</span><del>- getter Node namedItem(optional DOMString name);
</del><ins>+ getter Node namedItem(DOMString name);
</ins><span class="cx"> #else
</span><span class="cx"> getter HTMLOptionElement? item(unsigned long index);
</span><span class="cx"> getter HTMLOptionElement? namedItem(DOMString name);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.idl (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.idl 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/Source/WebCore/html/HTMLSelectElement.idl 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -47,12 +47,10 @@
</span><span class="cx">
</span><span class="cx"> #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C || defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT
</span><span class="cx"> getter Node item(unsigned long index);
</span><del>- Node namedItem(optional DOMString name);
</del><ins>+ Node namedItem(DOMString name);
</ins><span class="cx"> #else
</span><span class="cx"> getter HTMLOptionElement? item(unsigned long index);
</span><del>-
- // FIXME: Using "undefined" as default parameter value is wrong.
- HTMLOptionElement? namedItem(optional DOMString name = "undefined");
</del><ins>+ HTMLOptionElement? namedItem(DOMString name);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> [ObjCLegacyUnnamedParameters, RaisesException] void add(HTMLElement element, optional HTMLElement? before = null);
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMMimeTypeArrayidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -24,8 +24,6 @@
</span><span class="cx"> ] interface DOMMimeTypeArray {
</span><span class="cx"> readonly attribute unsigned long length;
</span><span class="cx"> getter DOMMimeType item(unsigned long index);
</span><del>-
- // FIXME: Using "undefined" as default parameter value is wrong.
- getter DOMMimeType namedItem(optional DOMString name = "undefined");
</del><ins>+ getter DOMMimeType namedItem(DOMString name);
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMPluginidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMPlugin.idl (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMPlugin.idl 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/Source/WebCore/plugins/DOMPlugin.idl 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -26,8 +26,6 @@
</span><span class="cx"> readonly attribute DOMString description;
</span><span class="cx"> readonly attribute unsigned long length;
</span><span class="cx"> getter DOMMimeType item(unsigned long index);
</span><del>-
- // FIXME: Using "undefined" as default parameter value is wrong.
- getter DOMMimeType namedItem(optional DOMString name = "undefined");
</del><ins>+ getter DOMMimeType namedItem(DOMString name);
</ins><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepluginsDOMPluginArrayidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMPluginArray.idl (203796 => 203797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/plugins/DOMPluginArray.idl 2016-07-27 21:36:11 UTC (rev 203796)
+++ trunk/Source/WebCore/plugins/DOMPluginArray.idl 2016-07-27 21:51:49 UTC (rev 203797)
</span><span class="lines">@@ -24,10 +24,8 @@
</span><span class="cx"> ] interface DOMPluginArray {
</span><span class="cx"> readonly attribute unsigned long length;
</span><span class="cx"> getter DOMPlugin item(unsigned long index);
</span><ins>+ getter DOMPlugin namedItem(DOMString name);
</ins><span class="cx">
</span><del>- // FIXME: Using "undefined" as default parameter value is wrong.
- getter DOMPlugin namedItem(optional DOMString name = "undefined");
-
</del><span class="cx"> void refresh(optional boolean reload = false);
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>